Subject: Re: bug#16922: df --si -h should emit a warning

From: Mateusz Jończyk <[email-masked]>
Date: Mon, 03 Mar 2014 16:19:59 +0100

W dniu 03.03.2014 04:02, Pádraig Brady pisze:
> On 03/02/2014 05:38 PM, Bernhard Voelker wrote: Very few read info pages, and
> anyway in this case we should be clear at the man page level.
> 
> Mateusz stated the issue was that on a quick glance, the --si option wasn't
> described well enough in isolation. Likewise, the description of -h requires
> reading that of -H to know the power used. So hopefully the attached patch fixes
> this and more.
> 
This patch fixes only the --help output, not the man page (which should be done
separately).

Seriously, wouldn't it be better to hardcode 1023M and 1.1G(B) into the code then
calculate them every time?
> thanks, Pádraig.

W dniu 03.03.2014 11:06, Bernhard Voelker pisze:
> On 03/03/2014 10:35 AM, Pádraig Brady wrote:
>> So SIZE here refers to the _input_ argument mentioned previously in the
>> --help. We might make this a bit more clear with BSIZE, but this same note is
>> refactored for use by df, du, ls, split, truncate. truncate(1) for example
>> uses it to refer to both a threshold and block size. Perhaps we should clarify
>> like:
>> 
>> The SIZE argument is an integer and optional unit (example: 10K is 10*1024). 
>> Units are K,M,G,T,P,E,Z,Y (powers of 1024) or KB,MB, ... (powers of 1000).
> 
> Good idea. Thanks.
> 
Maybe:
"The SIZE argument consists of an integer and an optional unit."

> Thanks for the link ... it seems that it's always only me who is confused, and
> coincidentally that post was also on a Monday. ;-) Therefore, I think we can go
> with the stuff you have in your local patch.

> 
> Thanks & have a nice day, Berny

- -- 
Pozdrawiam,
Mateusz Jończyk
AEI, Informatyka, Semestr 2 Magisterskich, BDiIS