GNU bug report logs - #16920
24.3; fix eldoc-message to clear own message only

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Liu <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16920: closed (24.3; fix eldoc-message to clear own message only)
Date: Mon, 10 Mar 2014 05:38:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 10 Mar 2014 13:37:13 +0800
with message-id <m17g82y5py.fsf <at> gmail.com>
and subject line Re: bug#16920: 24.3; fix eldoc-message to clear own message only
has caused the debbugs.gnu.org bug report #16920,
regarding 24.3; fix eldoc-message to clear own message only
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16920: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16920
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; fix eldoc-message to clear own message only
Date: Sun, 02 Mar 2014 15:18:10 +0800

I would like to fix eldoc-message for the upcoming release. Now that
eldoc can be used in the minibuffer there is one issue that can be
really annoying.

1. M-x eval-expression
2. type in (+ 1 1 |) ; | is the cursor
3. quickly pressing SPC repeatedly and then RET

The value 2 is shown and then cleared by eldoc (when eldoc-idle-delay is
short enough one may not see the value at all). The proposed fix is in
the following patch. Comments or objections?

=== modified file 'lisp/emacs-lisp/eldoc.el'
--- lisp/emacs-lisp/eldoc.el	2014-01-30 07:54:28 +0000
+++ lisp/emacs-lisp/eldoc.el	2014-03-02 07:14:45 +0000
@@ -255,7 +255,8 @@
     (let ((message-log-max nil))
       (cond (eldoc-last-message
 	     (funcall eldoc-message-function "%s" eldoc-last-message))
-	    (omessage (funcall eldoc-message-function nil)))))
+	    (omessage (and (equal omessage (current-message))
+			   (funcall eldoc-message-function nil))))))
   eldoc-last-message)
 
 (defun eldoc--message-command-p (command)

[Message part 3 (message/rfc822, inline)]

From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16920-done <at> debbugs.gnu.org
Subject: Re: bug#16920: 24.3; fix eldoc-message to clear own message only
Date: Mon, 10 Mar 2014 13:37:13 +0800

Fixed in 24.4

On 2014-03-10 10:44 +0800, Stefan Monnier wrote:
> Sounds good, thanks,
>
>
>         Stefan

OK, installed.

Leo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.