From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 02:18:50 2014 Received: (at submit) by debbugs.gnu.org; 2 Mar 2014 07:18:50 +0000 Received: from localhost ([127.0.0.1]:47317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK0fi-0006ZD-0U for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK0ff-0006Z3-Ka for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK0fW-0008C0-Rp for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:47 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fW-0008Bw-Oq for submit@debbugs.gnu.org; Sun, 02 Mar 2014 02:18:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38761) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fO-000873-6f for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK0fF-00088H-8V for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:30 -0500 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]:55110) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK0fF-00088C-12 for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 02:18:21 -0500 Received: by mail-pa0-f52.google.com with SMTP id rd3so987217pab.25 for ; Sat, 01 Mar 2014 23:18:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=hE9FpTBJcfh2qS8/xRJeCqV2rSESJ9SqKGmo8dYRoxg=; b=fyS+yY2GXYSESRICnCwClBA5D5pIsbnQbhCyPjUI7wFFltQS9eDvf0aNRj4WnRJT4H FJlawRjPnAR2vmd9xEcJXVZc8d/+ak510WnGnm88XT9gvH26UuyyLuugVTIiRi54B0DQ cS0r7gpmcD2QpSq9/+DP58c411dHm+rl/6FoUul2RW6BKnkUFoXs/ITAk1E5Eov0OINT xIvcbwyuP4Hvzx+VIncqIlc/VCnHpT9FQqdZUaoYnMFbhXz7Vb6I2KdqdY5etuKYwA9h TT0TW7zwEppHOS2QojlISf54FbmpJwYtH5rRL13/Ux1Bb4L9okufTgGLphC2350XL+Gh Z6aw== X-Received: by 10.68.138.227 with SMTP id qt3mr13179917pbb.6.1393744699295; Sat, 01 Mar 2014 23:18:19 -0800 (PST) Received: from Zeuss-MacBook.local ([222.130.182.111]) by mx.google.com with ESMTPSA id nv7sm22799402pbc.31.2014.03.01.23.18.16 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 01 Mar 2014 23:18:18 -0800 (PST) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; fix eldoc-message to clear own message only X-Debbugs-CC: Stefan Monnier Date: Sun, 02 Mar 2014 15:18:10 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) I would like to fix eldoc-message for the upcoming release. Now that eldoc can be used in the minibuffer there is one issue that can be really annoying. 1. M-x eval-expression 2. type in (+ 1 1 |) ; | is the cursor 3. quickly pressing SPC repeatedly and then RET The value 2 is shown and then cleared by eldoc (when eldoc-idle-delay is short enough one may not see the value at all). The proposed fix is in the following patch. Comments or objections? === modified file 'lisp/emacs-lisp/eldoc.el' --- lisp/emacs-lisp/eldoc.el 2014-01-30 07:54:28 +0000 +++ lisp/emacs-lisp/eldoc.el 2014-03-02 07:14:45 +0000 @@ -255,7 +255,8 @@ (let ((message-log-max nil)) (cond (eldoc-last-message (funcall eldoc-message-function "%s" eldoc-last-message)) - (omessage (funcall eldoc-message-function nil))))) + (omessage (and (equal omessage (current-message)) + (funcall eldoc-message-function nil)))))) eldoc-last-message) (defun eldoc--message-command-p (command) From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 07 17:54:56 2014 Received: (at 16920) by debbugs.gnu.org; 7 Mar 2014 22:54:56 +0000 Received: from localhost ([127.0.0.1]:55325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WM3fM-0007IM-0S for submit@debbugs.gnu.org; Fri, 07 Mar 2014 17:54:56 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:15446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WM3fJ-0007IB-98 for 16920@debbugs.gnu.org; Fri, 07 Mar 2014 17:54:53 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFFMCppy/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="50835532" Received: from 76-10-154-114.dsl.teksavvy.com (HELO ceviche.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Mar 2014 17:54:52 -0500 Received: by ceviche.home (Postfix, from userid 20848) id C6199660A5; Fri, 7 Mar 2014 17:54:53 -0500 (EST) From: Stefan Monnier To: Leo Liu Subject: Re: bug#16920: 24.3; fix eldoc-message to clear own message only Message-ID: References: Date: Fri, 07 Mar 2014 17:54:53 -0500 In-Reply-To: (Leo Liu's message of "Sun, 02 Mar 2014 15:18:10 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16920 Cc: 16920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > - (omessage (funcall eldoc-message-function nil))))) > + (omessage (and (equal omessage (current-message)) > + (funcall eldoc-message-function nil)))))) This can't be right when eldoc-message-function doesn't use `message'. So, we should probably move this test to the eldoc-message-function. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 08 02:32:39 2014 Received: (at 16920) by debbugs.gnu.org; 8 Mar 2014 07:32:39 +0000 Received: from localhost ([127.0.0.1]:55576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMBkM-0006lx-Fq for submit@debbugs.gnu.org; Sat, 08 Mar 2014 02:32:39 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:50555) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMBkI-0006lj-8D for 16920@debbugs.gnu.org; Sat, 08 Mar 2014 02:32:35 -0500 Received: by mail-pa0-f46.google.com with SMTP id kp14so5167131pab.33 for <16920@debbugs.gnu.org>; Fri, 07 Mar 2014 23:32:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=Ib8SGc5uDXEYfDPxL3rHFtamhgcfzEiWZrIux1psxwY=; b=S0nCxbSR2XyYMxpoTDjKbLPTPjnYutKGgqNoxpdZPh26J69NAaPSj9N3aPRlq/CemH JIN5qS6xGVk6YiY/00fHAWvokB6imG2MiT4aWI0bkHLoqx/cOfx459+vHMFEbad6nwWP pmO+L7PXXsln5LYprUdVKcCp46MEQChUYEFNQJGYENkbhakZ63IbMO2l0/hjJOU1tLqj XL/Y6PcVwsnkFH/SYHRqbTQDSRIz2bo3gif/939nKftnUDa/Dlq6ZEYb8gOw6fngbTuv kRMn16xxuYjxvhB7JzmkS8KoXmDc3GQC5k25u5jUIsqnGM5H93UfgpLsLeL7EvWSW9HS czLw== X-Received: by 10.66.119.136 with SMTP id ku8mr27056650pab.121.1394263953176; Fri, 07 Mar 2014 23:32:33 -0800 (PST) Received: from Zeuss-MacBook.local ([123.115.254.22]) by mx.google.com with ESMTPSA id ja8sm43714459pbd.3.2014.03.07.23.32.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Mar 2014 23:32:32 -0800 (PST) From: Leo Liu To: Stefan Monnier Subject: Re: bug#16920: 24.3; fix eldoc-message to clear own message only References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAElBMVEUAAAAAAP+LRRP0pGC+ vr7///+7mT1iAAAAAWJLR0QAiAUdSAAAAAlwSFlzAAALEwAACxMBAJqcGAAAAAd0SU1FB9cBBwMO DhglKe4AAAEsSURBVCjPbZNBboQwDEV/Cd4X9QJRThApmn0XYW+Jyf2v0m+HhqDBgiAe9rcTG7QH w/1Vn2Ar8gBb/ocywSN3qK9T3z4eFDB4eApocBpeBs1RSykoJd8gQcm8pGmHXFso3ajnmsqV0TnY DQkOfXUfN5NwaI7AWTVOyEhcu1aHmdWItHddUVUcUgUBCkitu8V6ditHVOVdqzl2EQ1ZVGTbdK0V 7cqn8vWzoU5Q/bF9Y/Y0cRU1xwkys5dJ+Dt6pBDWifcNQml8Gh2JVmPSoQzo7en0grswkxrUGYJ7 0hSxxAGr7ZMwYcHIzprpi7TENEE1xtiYxixRlCfPBsUUrwHD7uGIwATrbnODJcVrPpVn3hxiGloe m/S+z3CtuzUSMo83N4DPH+F0evwR3P4A2k+75838OKQAAAAASUVORK5CYII= Date: Sat, 08 Mar 2014 15:32:25 +0800 In-Reply-To: (Stefan Monnier's message of "Fri, 07 Mar 2014 17:54:53 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16920 Cc: 16920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 2014-03-08 06:54 +0800, Stefan Monnier wrote: > This can't be right when eldoc-message-function doesn't use `message'. > So, we should probably move this test to the eldoc-message-function. > > > Stefan The bug happens when exit minibuffer so we need to clear its state thoroughly at exit time. How about something like this: === modified file 'lisp/emacs-lisp/eldoc.el' --- lisp/emacs-lisp/eldoc.el 2014-01-30 07:54:28 +0000 +++ lisp/emacs-lisp/eldoc.el 2014-03-08 07:30:21 +0000 @@ -219,7 +219,9 @@ (if (minibufferp) (progn (add-hook 'minibuffer-exit-hook - (lambda () (setq eldoc-mode-line-string nil)) + (lambda () (setq eldoc-mode-line-string nil + ;; http://debbugs.gnu.org/16920 + eldoc-last-message nil)) nil t) (with-current-buffer (window-buffer From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 09 22:44:49 2014 Received: (at 16920) by debbugs.gnu.org; 10 Mar 2014 02:44:49 +0000 Received: from localhost ([127.0.0.1]:58558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMqCu-0000iY-MI for submit@debbugs.gnu.org; Sun, 09 Mar 2014 22:44:49 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:36387) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMqCs-0000iM-NJ for 16920@debbugs.gnu.org; Sun, 09 Mar 2014 22:44:47 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApEKABK/CFFMCppy/2dsb2JhbABEgxu7cxdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOXKYoggzGBXoMT X-IPAS-Result: ApEKABK/CFFMCppy/2dsb2JhbABEgxu7cxdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOXKYoggzGBXoMT X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="50960244" Received: from 76-10-154-114.dsl.teksavvy.com (HELO ceviche.home) ([76.10.154.114]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 09 Mar 2014 22:44:46 -0400 Received: by ceviche.home (Postfix, from userid 20848) id 0CDB8660A5; Sun, 9 Mar 2014 22:44:46 -0400 (EDT) From: Stefan Monnier To: Leo Liu Subject: Re: bug#16920: 24.3; fix eldoc-message to clear own message only Message-ID: References: Date: Sun, 09 Mar 2014 22:44:46 -0400 In-Reply-To: (Leo Liu's message of "Sat, 08 Mar 2014 15:32:25 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16920 Cc: 16920@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > The bug happens when exit minibuffer so we need to clear its state > thoroughly at exit time. How about something like this: [...] > - (lambda () (setq eldoc-mode-line-string nil)) > + (lambda () (setq eldoc-mode-line-string nil > + ;; http://debbugs.gnu.org/16920 > + eldoc-last-message nil)) Sounds good, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 10 01:37:26 2014 Received: (at 16920-done) by debbugs.gnu.org; 10 Mar 2014 05:37:26 +0000 Received: from localhost ([127.0.0.1]:58608 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMstx-0005se-NA for submit@debbugs.gnu.org; Mon, 10 Mar 2014 01:37:26 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:46998) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WMstv-0005sU-31 for 16920-done@debbugs.gnu.org; Mon, 10 Mar 2014 01:37:23 -0400 Received: by mail-pb0-f46.google.com with SMTP id rq2so6815634pbb.33 for <16920-done@debbugs.gnu.org>; Sun, 09 Mar 2014 22:37:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=CsoQf8iP8oh4gpwOJxt7o0VDkQQzl4Js1rv9uxw+O4M=; b=raa6WTeUDckoQ3rfVLB38WxRVDSySVlTceV2NOh3k8L4PGU15n1WQ3T/BgxPaewVPY Jmv3AOB8TUpwBVcYOEHgoepfqFRFP3EEpfHNKKrWS5IethNwVPPFBvO2LpxCBaMlsRZp wnLZgpOnpsqj+8b8PPSrePNQrIgw3osnMrprBT03HLU7TInWfMckwgGbS/baudcvaIzd TH3NgrfSvp+JD6Ynqr5syloImPolkW+Rt58K+hYzeynLTqUqEtm5FIAyNvdkd5maDoEr W98SPNN1Hn1sBhi3UFqgSpJIl7ilv5gu2Vm7j+Q78xOQpk0qwUnvbPbDFW/AIR0ZUmBZ KjnQ== X-Received: by 10.68.171.229 with SMTP id ax5mr37963431pbc.125.1394429842054; Sun, 09 Mar 2014 22:37:22 -0700 (PDT) Received: from Zeuss-MacBook.local ([221.220.235.57]) by mx.google.com with ESMTPSA id db3sm60827088pbb.10.2014.03.09.22.37.19 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 09 Mar 2014 22:37:21 -0700 (PDT) From: Leo Liu To: Stefan Monnier Subject: Re: bug#16920: 24.3; fix eldoc-message to clear own message only References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAG1BMVEUAAAA9Cgm3Hx1WWFWA gn+WmJWsrqv4+vcCAwCRl2MkAAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAAAYoA AAGKATOXMFgAAAAHdElNRQfXAQwDNR+ZJmElAAABIklEQVQoz22SPW+DQAyGWUq65qasd9PNUSX4 AZHK2C1rJy5jpDS4IwRVup9dn7GNafpKIPPgzztXFSujqq1eM2n8h22oMkvxI/i9C97kRfMRUN55 dS3BrsAwBXUtMLAO4lryh8kTjOxKpQNniNxAgZOEe4bZwsDTFhKdqZRLNII4OQNHhEuq/RMkm6Cj TnnEA/fk0BorcYn5qA3oaeAxbaBOLrX+9G48NZ2Fzc2tzDM8Q+tMypEOqYHh8mAWaaK3U/cDMOT5 aMZMABgPXc7zPMs1A8DXO756GFJ/4fMEq47hTsAdn5avoxZ4ywl0c2w4Flu2Ybeyb3S+EqxX2DYA H8veJGEDTnHnrXvRaPyt+2kSfK6rfBZ2tUtfP/mR+pR6sX8BUZ/cDV7tvkoAAAAASUVORK5CYII= Date: Mon, 10 Mar 2014 13:37:13 +0800 In-Reply-To: (Stefan Monnier's message of "Sun, 09 Mar 2014 22:44:46 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9.2) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16920-done Cc: 16920-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Fixed in 24.4 On 2014-03-10 10:44 +0800, Stefan Monnier wrote: > Sounds good, thanks, > > > Stefan OK, installed. Leo From unknown Fri Aug 15 04:03:43 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Apr 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator