From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 08:28:49 2014 Received: (at submit) by debbugs.gnu.org; 1 Mar 2014 13:28:49 +0000 Received: from localhost ([127.0.0.1]:45453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJjyC-000172-Ic for submit@debbugs.gnu.org; Sat, 01 Mar 2014 08:28:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45643) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJjy9-00016r-9Y for submit@debbugs.gnu.org; Sat, 01 Mar 2014 08:28:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJjxz-0007EM-Bc for submit@debbugs.gnu.org; Sat, 01 Mar 2014 08:28:44 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52155) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJjxz-0007Dq-8P for submit@debbugs.gnu.org; Sat, 01 Mar 2014 08:28:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJjxr-0003dy-RE for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 08:28:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WJjxk-0007BZ-FB for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 08:28:27 -0500 Received: from mail-ee0-f49.google.com ([74.125.83.49]:56185) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WJjxk-0007BV-6i for bug-gnu-emacs@gnu.org; Sat, 01 Mar 2014 08:28:20 -0500 Received: by mail-ee0-f49.google.com with SMTP id b57so2882892eek.36 for ; Sat, 01 Mar 2014 05:28:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=K7oRGQ9tiZP1Huws8CnZtQPlb9P/Wu5fimLtEV5FxHs=; b=E8H0KBWyds8sVbi9lfv3eKue4AqjT52I4NBkk72FezQQbm3SIC6lrLoo/fQgHSR3gv 9e93KcVPn4pySmztxyQwjmMapzLTXv8IMpXRC+69sz70v760MfTFx0QfIqQtJwBWPJU7 ZlUcF34GvGtspUz9yAoXCfPWmNBU7brKh9bfko+tPqeaMvD+o+t2TPtEtpYAYohUzM3h dFIWO4z21h4NQVEdU30bUkjqpge6Rj6um2RFbV9GBhaazdj0r+m2uXAn9dj6NBb/UAfG 4ogPPLaoL8yzInUrJb4/hisBgQDI6D0RTDYQp27WJoDerXKw1hBVJZlp/mKrdfMqzFby gYcQ== X-Gm-Message-State: ALoCoQmH2RoIa2PvVka1mvptAP8RBF7KvMLgjLTHI/5Tvc7MX5SvR8mZZiWImnq+fjo5i1v09tWW X-Received: by 10.14.29.6 with SMTP id h6mr84206eea.84.1393680499435; Sat, 01 Mar 2014 05:28:19 -0800 (PST) Received: from Bozhidars-MacBook-Pro.local ([95.87.231.111]) by mx.google.com with ESMTPSA id m1sm23549338een.7.2014.03.01.05.28.17 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Sat, 01 Mar 2014 05:28:18 -0800 (PST) Received: by Bozhidars-MacBook-Pro.local (Postfix, from userid 501) id A764883A1451; Sat, 1 Mar 2014 15:28:19 +0200 (EET) From: Bozhidar Batsov To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [ruby-mode] Regexp literal modifiers are not font-locked Date: Sat, 01 Mar 2014 15:28:19 +0200 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In a simple regexp like: /something/i %r{test}i the trailing 'i' is not font-locked. Most editor/IDEs font-lock the modifiers. I'd suggest the use of a different face than the string face used for the literal itself, but even it would be an improvement. I also think that only valid modifiers should be font-locked. In GNU Emacs 24.3.50.1 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00) of 2014-01-27 on Bozhidars-MacBook-Pro.local Windowing system distributor `Apple', version 10.3.1265 Configured using: `configure --prefix=/usr/local/Cellar/emacs/HEAD --without-dbus --enable-locallisppath=/usr/local/share/emacs/site-lisp --infodir=/usr/local/Cellar/emacs/HEAD/share/info/emacs --without-gnutls --with-ns --disable-ns-self-contained' Important settings: locale-coding-system: utf-8-unix Major mode: Ruby Minor modes in effect: ruby-tools-mode: t inf-ruby-minor-mode: t diff-auto-refine-mode: t subword-mode: t guru-mode: t erc-truncate-mode: t erc-spelling-mode: t erc-list-mode: t erc-menu-mode: t erc-autojoin-mode: t erc-ring-mode: t erc-networks-mode: t erc-pcomplete-mode: t erc-track-mode: t erc-match-mode: t erc-button-mode: t erc-fill-mode: t erc-stamp-mode: t erc-netsplit-mode: t erc-irccontrols-mode: t erc-noncommands-mode: t erc-move-to-prompt-mode: t erc-readonly-mode: t global-flycheck-mode: t flycheck-mode: t which-function-mode: t flx-ido-mode: t ido-ubiquitous-mode: t winner-mode: t global-undo-tree-mode: t undo-tree-mode: t whitespace-mode: t global-anzu-mode: t anzu-mode: t projectile-global-mode: t projectile-mode: t flyspell-mode: t volatile-highlights-mode: t global-hl-line-mode: t shell-dirtrack-mode: t recentf-mode: t savehist-mode: t show-smartparens-global-mode: t show-smartparens-mode: t smartparens-mode: t global-auto-revert-mode: t delete-selection-mode: t prelude-global-mode: t prelude-mode: t tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t size-indication-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: o i o s g e m C-x g C-n C-n C-n C-n C-n d q C-x o C-u S c c F i x SPC a SPC b u n c h SPC o f SPC c o m p i l a t i o n SPC w a r n i n g s C-c C-c P P C-x g C-n d q d q C-u S c c S i m p l i f y SPC s o m e SPC c o e e SPC d e SPC b y SPC u s i n g SPC m o r e SPC m o d e r n SPC c o n v e n t i o n s M-b M-b M-b M-d C-d C-e C-c C-c P P l l q C-x b t e s t . C-y C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-n C-p C-p C-f C-p x C-s C-g C-x C-s C-p C-p C-p C-p C-p C-p C-k C-x C-s C-n C-n C-n C-n C-n C-n C-e t o p SPC = SPC / s h i t / i C-p C-p C-p M-x Recent messages: 1 trailing blank lines detected. Quit Saving file /Users/bozhidar/projects/test.rb... Wrote /Users/bozhidar/projects/test.rb Useless assignment to variable - regexp [2 times] Saving file /Users/bozhidar/projects/test.rb... Wrote /Users/bozhidar/projects/test.rb Auto-saving...done Saving file /Users/bozhidar/projects/test.rb... Wrote /Users/bozhidar/projects/test.rb Load-path shadows: /Users/bozhidar/.emacs.d/elpa/tabulated-list-20120406.2251/tabulated-list hides /usr/local/Cellar/emacs/HEAD/share/emacs/24.3.50/lisp/emacs-lisp/tabulated-list Features: (shadow sort mail-extr emacsbug vc-annotate vc vc-dispatcher nxml-uchnm rng-xsd xsd-regexp rng-cmpct edebug crm ielm hippie-exp markdown-mode noutline outline gitignore-mode conf-mode yaml-mode ace-jump-mode ffap url-parse url-vars ruby-tools inf-ruby ruby-mode-expansions smartparens-ruby ruby-mode smie misearch multi-isearch jka-compr eieio-opt speedbar sb-image ezimage dframe mule-util find-dired magit-key-mode magit view epa derived epg epg-config diff-mode git-rebase-mode git-commit-mode server log-edit message sendmail rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log executable vc-git lisp-mnt network-stream starttls tls cider cider-mode cider-repl cider-eldoc clojure-test-mode cider-interaction arc-mode archive-mode cider-client nrepl-client cider-util ewoc superword subword clojure-mode-expansions clojure-mode inf-lisp rainbow-mode color rainbow-delimiters elisp-slime-nav guru-mode prelude-key-chord key-chord prelude-xml nxml-mode-expansions html-mode-expansions sgml-mode smartparens-html rng-nxml rng-valid rng-loc rng-uri rng-parse nxml-parse rng-match rng-dt rng-util rng-pttrn nxml-ns nxml-mode nxml-outln nxml-rap nxml-util nxml-glyph nxml-enc xmltok prelude-web prelude-scss prelude-scheme prelude-ruby prelude-perl prelude-org prelude-js prelude-erc erc-truncate erc-autoaway erc-spelling erc-notify erc-log erc-list erc-menu erc-join erc-ring erc-networks erc-pcomplete erc-track erc-match erc-button erc-fill erc-stamp erc-netsplit erc-goodies erc erc-backend erc-compat prelude-emacs-lisp prelude-css prelude-common-lisp slime-autoloads prelude-clojure prelude-lisp prelude-c prelude-programming flycheck help-mode rx f which-func imenu prelude-ido smex flx-ido flx ido-ubiquitous warnings ido prelude-osx exec-path-from-shell prelude-global-keybindings prelude-editor winner undo-tree diff esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg eldoc esh-groups eshell esh-module esh-mode esh-util re-builder whitespace browse-kill-ring midnight ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff dired-x dired anzu projectile pkg-info find-func grep compile s bookmark pp expand-region text-mode-expansions er-basic-expansions expand-region-core expand-region-custom flyspell ispell etags volatile-highlights hl-line windmove tramp-cache tramp-sh tramp tramp-compat auth-source gnus-util mm-util mail-prsvr password-cache tramp-loaddefs trampver shell pcomplete comint ansi-color ring format-spec recentf tree-widget wid-edit savehist saveplace diminish smartparens-config smartparens autorevert filenotify delsel prelude-mode easy-mmode edmacro kmacro prelude-core epl advice help-fns dash thingatpt prelude-ui zenburn-theme prelude-packages finder-inf ack-and-a-half-autoloads diminish-autoloads erlang-autoloads flx-ido-autoloads eieio byte-opt bytecomp byte-compile cconv eieio-core grizzl-autoloads key-chord-autoloads logito-autoloads info easymenu cl-macs gv move-text-autoloads pkg-info-autoloads puppet-mode-autoloads rainbow-delimiters-autoloads request-autoloads rubocop-autoloads volatile-highlights-autoloads yaml-mode-autoloads package cl cl-loaddefs cl-lib time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process cocoa ns multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 01 17:06:56 2014 Received: (at 16914-done) by debbugs.gnu.org; 1 Mar 2014 22:06:56 +0000 Received: from localhost ([127.0.0.1]:47045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJs3b-0008LO-AZ for submit@debbugs.gnu.org; Sat, 01 Mar 2014 17:06:55 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:54325) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJs3Z-0008LG-Al for 16914-done@debbugs.gnu.org; Sat, 01 Mar 2014 17:06:53 -0500 Received: by mail-ee0-f54.google.com with SMTP id c41so3061683eek.41 for <16914-done@debbugs.gnu.org>; Sat, 01 Mar 2014 14:06:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=J1+ccIN2CRdcVr1OyvNy1xXn/wc0Qw38it2VRMVMVOo=; b=J9uV12hUPCV5Ufj4Muc4V11xBCIrskb3sCLr7cqColHUsPoRLHtmVTq7EA8Eg6RXQx 9PkPyot1puHnfmZjldSiQDlHCo9ro119ulOSsG2vlwXyzMJVk0JIstrBc7T66iA6jyne jiEvke2NAw6nc/iFOlZAws691aG49n+DyyxZE8QKJJiWE6yIfARUNiEybecJm4CcHKOx EKuEo/iGdPWuQbgJObPWhsCsdjkUJ2mhcsOZ69Z1EHGTOocG3nzwoYEOvNvQoq+4jC61 Da7gDSKKM4IDxVdVCtX9fQq8sKFZDOEKhvQOVhGMvECHcUNLI6ujIOGhBNDODcIgpblZ lyaw== X-Received: by 10.14.176.195 with SMTP id b43mr1706350eem.99.1393711612622; Sat, 01 Mar 2014 14:06:52 -0800 (PST) Received: from axl ([93.109.195.252]) by mx.google.com with ESMTPSA id a2sm28604908eem.18.2014.03.01.14.06.50 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 01 Mar 2014 14:06:51 -0800 (PST) From: Dmitry Gutov To: Bozhidar Batsov Subject: Re: bug#16914: 24.3.50; [ruby-mode] Regexp literal modifiers are not font-locked References: Date: Sun, 02 Mar 2014 00:06:19 +0200 In-Reply-To: (Bozhidar Batsov's message of "Sat, 01 Mar 2014 15:28:19 +0200") Message-ID: <8738j1po9w.fsf@yandex.ru> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16914-done Cc: 16914-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Version: 24.4 Bozhidar Batsov writes: > In a simple regexp like: > > /something/i > %r{test}i > > the trailing 'i' is not font-locked. Most editor/IDEs font-lock the > modifiers. I'd suggest the use of a different face than the string face > used for the literal itself, but even it would be an improvement. I also > think > that only valid modifiers should be font-locked. Added in 116626. From unknown Sun Jun 15 08:44:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Mar 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator