GNU bug report logs - #16912
[PATCH] no longer use CSET for non-UTF8 locale in DFA engine

Previous Next

Full log

View this message in rfc822 format

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Norihiro Tanaka <noritnk <at> kcn.ne.jp>, 16912 <at> debbugs.gnu.org
Subject: bug#16912: [PATCH] no longer use CSET for non-UTF8 locale in DFA engine
Date: Sat, 01 Mar 2014 16:13:14 -0800

Thanks for looking into this.  Unfortunately the combination of the two 
patches causes "make check" to fail, because it reintroduces a titlecase 
bug.  I can draft a further patch for that, but in the meantime can you 
look at a few other things?

First, why does the first patch add those four using_utf8 calls to 
parse_bracket_exp?  Isn't that optimization valid regardless of whether 
the multibyte encoding is UTF-8?

Second, the comment "UTF-8 allows treating a simple, non-inverted MBCSET 
like a CSET." no longer seems to match the code, since addtok no longer 
invokes using_utf8.

Third, could you please draft a proper commit message?  The format is 
something like this:

grep: minor tuning for mb_case_map_apply

* src/kwsearch.c (mb_case_map_apply): Avoid unnecessary widening of
size_t to intmax_t.  Avoid unnecessary reinitialization of k.


That is, a first line of the form "program: short description".  Then an 
empty line.  Then a ChangeLog entry in standard GNU format.

I'll take a look at the second patch later.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.