GNU bug report logs - #16901
24.3.50; emacs_backtrace.txt

Previous Next

Full log

Message #96 received at 16901 <at> debbugs.gnu.org (full text, mbox):

From: Ken Brown <kbrown <at> cornell.edu>
To: Eli Zaretskii <eliz <at> gnu.org>, lekktu <at> gmail.com
Cc: 16901 <at> debbugs.gnu.org, dmantipov <at> yandex.ru
Subject: Re: bug#16901: 24.3.50; emacs_backtrace.txt
Date: Mon, 03 Mar 2014 18:20:09 -0500

On 3/3/2014 11:54 AM, Eli Zaretskii wrote:
> P.S. The bugs in gmalloc were so glaring that I'd appreciate if
> someone could eyeball my changes, in case I grossly misunderstood the
> code.  When I see such bugs in such veteran code, I usually question
> my own sanity.  TIA.

I may be misunderstanding the code too, but I don't think your fix to 
aligned_alloc is quite right.  If adj == 0 in line 1596, then we've 
allocated much more memory than we needed, and the next call to malloc 
(line 1602) allocates even more.  And if adj == 1 in line 1596, then 
we've allocated exactly as much memory as we needed, so there's no need 
to call malloc again in line 1602.

Ken

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.