GNU bug report logs - #16883
[PATCH] Fix emacsclient's handling of SIGCONT.

Previous Next

Package: emacs;

Reported by: Andreas Amann <a.amann <at> ucc.ie>

Date: Tue, 25 Feb 2014 18:47:01 UTC

Severity: normal

Tags: patch

Found in version 24.3

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16883: closed ([PATCH] Fix emacsclient's handling of SIGCONT.)
Date: Tue, 25 Feb 2014 19:08:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 25 Feb 2014 11:07:47 -0800
with message-id <530CEA03.30301 <at> cs.ucla.edu>
and subject line Re: [PATCH] Fix emacsclient's handling of SIGCONT.
has caused the debbugs.gnu.org bug report #16883,
regarding [PATCH] Fix emacsclient's handling of SIGCONT.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16883: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16883
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Andreas Amann <a.amann <at> ucc.ie>
To: quiet <at> debbugs.gnu.org
Subject: [PATCH] Fix emacsclient's handling of SIGCONT.
Date: Thu, 20 Feb 2014 00:05:30 +0000
Package: emacs
Version: 24.3

[ Resent from
http://lists.gnu.org/archive/html/emacs-devel/2014-02/msg00467.html ]

* emacsclient.c (handle_sigcont):  previously it was not possible
to run emacsclient in the background using "bg", because SIGCONT
was blocked in this case.  Now SIGCONT is only blocked if the
Emacs frame is opened on the current terminal.
---

There is an annoying problem with backgrounding of emacsclient
processes. 
To illustrate the problem, do the following:

>emacs -Q -f server-start &
[1] xxxPID1xxx
>emacsclient -c filename
Waiting for Emacs...^Z (press control-z)
[2]+  Stopped                 emacsclient -c filename
>bg
[2]+ emacsclient -c ~/.bashrc &

[2]+  Stopped                 emacsclient -c ~/.bashrc

At this point, emacsclient is stopped and not running in the background
as it should after receiving the SIGCONT signal through "bg". We can
still go to the second emacs frame showing "filename", finish editing
the file and leave the frame with C-x #.  After this, the emacsclient is
stalled in the "Stopped" state, and does not exit as it should.  

It will only exit after issuing
>fg

The attached patch fixes this by only stopping emacsclient, if the emacs
frame is opened in the current terminal. 


 lib-src/ChangeLog     | 8 ++++++++
 lib-src/emacsclient.c | 2 +-
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog
index 5005e1f..1c2862f 100644
--- a/lib-src/ChangeLog
+++ b/lib-src/ChangeLog
@@ -1,3 +1,11 @@
+2014-02-19  Andreas Amann  <a.amann <at> ucc.ie>
+
+	Fix emacsclient's handling of SIGCONT.
+	* emacsclient.c (handle_sigcont): previously it was not possible
+	to run emacsclient in the background using "bg", because SIGCONT
+	was blocked in this case.  Now SIGCONT is only blocked if the
+	Emacs frame is opened on the current terminal.
+
 2014-01-22  Eli Zaretskii  <eliz <at> gnu.org>
 
 	* update-game-score.c (write_scores) [WINDOWSNT]: Use chmod
diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c
index 6593b91..fd85a50 100644
--- a/lib-src/emacsclient.c
+++ b/lib-src/emacsclient.c
@@ -1111,7 +1111,7 @@ handle_sigcont (int signalnum)
       /* We are in the foreground. */
       send_to_emacs (emacs_socket, "-resume \n");
     }
-  else
+  else if (tty)
     {
       /* We are in the background; cancel the continue. */
       raise (SIGSTOP);
-- 
1.8.5.4


[Message part 3 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: a.amann <at> ucc.ie, 16883-done <at> debbugs.gnu.org
Subject: Re: [PATCH] Fix emacsclient's handling of SIGCONT.
Date: Tue, 25 Feb 2014 11:07:47 -0800
Thanks for the bug report.  I applied that change as part of Emacs trunk 
bzr 116558.


This bug report was last modified 11 years and 108 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.