GNU bug report logs - #16861
24.3; Eshell /.. eshell/pwd Bug

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16861 in the body.
You can then email your comments to 16861 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "R. Michael Weylandt" <michael.weylandt <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; Eshell /.. eshell/pwd Bug
Date: Sun, 23 Feb 2014 22:30:08 -0500

Confirmed with Emacs 24.3 & 22.1:

Enter eshell, change to / and then cd to ".." and eshell/pwd reports
"/.." instead of the canonical "/":

~ $ cd /
/ $ cd ..
/.. $ cd ..
/ $

It's pretty much a non-issue, but it may be an easy fix for someone.

I can submit a patch, but not sure if that's helpful without signing
FSF papers.

Michael

Message #8 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: "R. Michael Weylandt" <michael.weylandt <at> gmail.com>
Cc: 16861 <at> debbugs.gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 10:30:21 +0100

"R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:

> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
> "/.." instead of the canonical "/":

(expand-file-name ".." "/") -> "/.."

See its doc string.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 11:13:07 +0100

Andreas Schwab <schwab <at> suse.de> writes:

> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
>
>> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
>> "/.." instead of the canonical "/":
>
> (expand-file-name ".." "/") -> "/.."
>
> See its doc string.

We are speaking here of `eshell/pwd' which should return "/" like
`*pwd', `expand-filename' is unrelated to this.
The prompt of eshell is also showing "/.." which is not correct.

Try (setq eshell-pwd-convert-function 'file-truename)

Which fix the problem.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #14 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 16861 <at> debbugs.gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 11:23:14 +0100

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> Andreas Schwab <schwab <at> suse.de> writes:
>
>> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
>>
>>> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
>>> "/.." instead of the canonical "/":
>>
>> (expand-file-name ".." "/") -> "/.."
>>
>> See its doc string.
>
> We are speaking here of `eshell/pwd' which should return "/" like
> `*pwd', `expand-filename' is unrelated to this.

See eshell/cd, which uses cd which uses expand-filename.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #17 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 16861 <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 11:29:31 +0100

Andreas Schwab <schwab <at> suse.de> writes:

> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Andreas Schwab <schwab <at> suse.de> writes:
>>
>>> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
>>>
>>>> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
>>>> "/.." instead of the canonical "/":
>>>
>>> (expand-file-name ".." "/") -> "/.."
>>>
>>> See its doc string.
>>
>> We are speaking here of `eshell/pwd' which should return "/" like
>> `*pwd', `expand-filename' is unrelated to this.
>
> See eshell/cd, which uses cd which uses expand-filename.

Probably, but the problem is related to pwd.
See docstring of `eshell-pwd-convert-function'.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #20 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> suse.de>
To: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Cc: 16861 <at> debbugs.gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 11:34:22 +0100

Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:

> Probably, but the problem is related to pwd.

No, the problem already started with cd.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab <at> suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Message #23 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 16861 <at> debbugs.gnu.org, Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 12:13:31 +0100

Andreas Schwab <schwab <at> suse.de> writes:

> Thierry Volpiatto <thierry.volpiatto <at> gmail.com> writes:
>
>> Probably, but the problem is related to pwd.
>
> No, the problem already started with cd.

`eshell/cd' more exactly that use `eshell/pwd' internally.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #26 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: "R. Michael Weylandt <michael.weylandt <at> gmail.com>"
 <michael.weylandt <at> gmail.com>
To: Andreas Schwab <schwab <at> suse.de>
Cc: "16861 <at> debbugs.gnu.org" <16861 <at> debbugs.gnu.org>
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 24 Feb 2014 10:39:07 -0500

On Feb 24, 2014, at 4:30, Andreas Schwab <schwab <at> suse.de> wrote:

> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
> 
>> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
>> "/.." instead of the canonical "/":
> 
> (expand-file-name ".." "/") -> "/.."
> 
> See its doc string.

Ok -- I hadn't run across file systems with a 'superroot' before (cf. Emacs Manual 25.8.4). I'll special case it in my Eshell prompt function then. 

Thanks for the quick reply,

Michael

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Mon, 03 Mar 2014 07:57:13 +0100

"R. Michael Weylandt <michael.weylandt <at> gmail.com>"
<michael.weylandt <at> gmail.com> writes:

> On Feb 24, 2014, at 4:30, Andreas Schwab <schwab <at> suse.de> wrote:
>
>> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
>> 
>>> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
>>> "/.." instead of the canonical "/":
>> 
>> (expand-file-name ".." "/") -> "/.."
>> 
>> See its doc string.
>
> Ok -- I hadn't run across file systems with a 'superroot' before (cf. Emacs Manual 25.8.4). I'll special case it in my Eshell prompt function then. 

If one is interested to fix this bug, a fix for this could be something
like:

--8<---------------cut here---------------start------------->8---
(setq eshell-pwd-convert-function (lambda (f)
                                    (if (file-equal-p (file-truename f) "/")
                                        "/" f)))
--8<---------------cut here---------------end--------------->8---

instead of 'identity as default value.

-- 
Thierry
Get my Gnupg key:
gpg --keyserver pgp.mit.edu --recv-keys 59F29997 

Message #32 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "R. Michael Weylandt" <michael.weylandt <at> gmail.com>
Cc: 16861 <at> debbugs.gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Sat, 05 Feb 2022 23:57:59 +0100

"R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:

> Enter eshell, change to / and then cd to ".." and eshell/pwd reports
> "/.." instead of the canonical "/":
>
> ~ $ cd /
> / $ cd ..
> /.. $ cd ..
> / $
>
> It's pretty much a non-issue, but it may be an easy fix for someone.

(I'm going through old bug reports that unfortunately weren't resolved
at the time.)

I've now fixed this in Emacs 29.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 16861 <at> debbugs.gnu.org (full text, mbox):

From: Michael Weylandt <michael.weylandt <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16861 <at> debbugs.gnu.org
Subject: Re: bug#16861: 24.3; Eshell /.. eshell/pwd Bug
Date: Sun, 6 Feb 2022 10:30:56 -0600

Thanks!

Michael

On Sat, Feb 5, 2022 at 4:58 PM Lars Ingebrigtsen <larsi <at> gnus.org> wrote:
>
> "R. Michael Weylandt" <michael.weylandt <at> gmail.com> writes:
>
> > Enter eshell, change to / and then cd to ".." and eshell/pwd reports
> > "/.." instead of the canonical "/":
> >
> > ~ $ cd /
> > / $ cd ..
> > /.. $ cd ..
> > / $
> >
> > It's pretty much a non-issue, but it may be an easy fix for someone.
>
> (I'm going through old bug reports that unfortunately weren't resolved
> at the time.)
>
> I've now fixed this in Emacs 29.
>
> --
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.