GNU bug report logs - #16854
24.3.50; ert-run-tests-interactively t selector not working

Previous Next

Package: emacs;

Reported by: Helmut Eller <eller.helmut <at> gmail.com>

Date: Sun, 23 Feb 2014 14:58:02 UTC

Severity: normal

Found in version 24.3.50

Fixed in version 24.4

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Helmut Eller <eller.helmut <at> gmail.com>
To: 16854 <at> debbugs.gnu.org
Subject: bug#16854: 24.3.50; ert-run-tests-interactively t selector not working
Date: Sun, 23 Feb 2014 19:16:09 +0100
On Sun, Feb 23 2014, Dmitry Gutov wrote:

> Helmut Eller <eller.helmut <at> gmail.com> writes:
>
>> When I run this
>>
>> (require 'ert)
>> (ert-deftest infloop0 () (while t))
>>
>> with: emacs -Q -nw -l infloops.el -f ert
>>
>> Emacs starts up and asks: "Run tests (default t): "
>> If I enter: "t RET"
>> then ERT does not run anything and simply writes:
>> "Ran 0 tests, 0 results were as expected"
>>
>> The expected result is that all tests should be executed.
>
> Same here. Apparently, this is fallout from 114803 (bug#9756).
>
> The code before it used `read-from-minibuffer' with t READ argument, so
> "t" was converted to `t'. But now `ert-select-tests' receives SELECTOR
> as "t".
>
> The patch below fixes it for me.

Yes, with the patch t works.  But it's no longer possible to enter
regexps.  Not sure if that matters.  Maybe the default should be the
regexp ".*" instead of t.  Hmm, that would look odd.

Helmut





This bug report was last modified 11 years and 84 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.