Subject: bug#16854: 24.3.50; ert-run-tests-interactively t selector not working

From: Helmut Eller <[email-masked]>
Date: Sun, 23 Feb 2014 19:16:09 +0100

On Sun, Feb 23 2014, Dmitry Gutov wrote:

> Helmut Eller <[email-masked]> writes:
>
>> When I run this
>>
>> (require 'ert)
>> (ert-deftest infloop0 () (while t))
>>
>> with: emacs -Q -nw -l infloops.el -f ert
>>
>> Emacs starts up and asks: "Run tests (default t): "
>> If I enter: "t RET"
>> then ERT does not run anything and simply writes:
>> "Ran 0 tests, 0 results were as expected"
>>
>> The expected result is that all tests should be executed.
>
> Same here. Apparently, this is fallout from 114803 (bug#9756).
>
> The code before it used `read-from-minibuffer' with t READ argument, so
> "t" was converted to `t'. But now `ert-select-tests' receives SELECTOR
> as "t".
>
> The patch below fixes it for me.

Yes, with the patch t works.  But it's no longer possible to enter
regexps.  Not sure if that matters.  Maybe the default should be the
regexp ".*" instead of t.  Hmm, that would look odd.

Helmut