From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Feb 2014 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139316696328252 (code B ref -1); Sun, 23 Feb 2014 14:50:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Feb 2014 14:49:23 +0000 Received: from localhost ([127.0.0.1]:36393 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHaMs-0007LZ-7O for submit@debbugs.gnu.org; Sun, 23 Feb 2014 09:49:22 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57344) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHaMo-0007LI-ES for submit@debbugs.gnu.org; Sun, 23 Feb 2014 09:49:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHaMd-0003kh-4K for submit@debbugs.gnu.org; Sun, 23 Feb 2014 09:49:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58162) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHaMd-0003kc-0n for submit@debbugs.gnu.org; Sun, 23 Feb 2014 09:49:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59043) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHaMX-00041X-3e for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 09:49:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHaMR-0003jW-8I for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 09:49:00 -0500 Received: from mail-ee0-x229.google.com ([2a00:1450:4013:c00::229]:46091) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHaMR-0003jN-11 for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 09:48:55 -0500 Received: by mail-ee0-f41.google.com with SMTP id b15so441151eek.14 for ; Sun, 23 Feb 2014 06:48:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=n7X6rwSs/pj5pupqX3ytjsEAxRWLulAv9Q+7XntrZcE=; b=SGnDKzBR4e2VbiC8oyquub0TlxJy46EDjaGjQ0fck2HQ8DkuUELcxs6U1ChmUnEU9M yloDIdVRGa6S2n78QklxsmjJSz4yJyCUkyIWlEIIHPMwJDanRBkn4tcFgySugLu+U+Z7 svlShB/h1/SoSPeQeyLz065wSAgF/G95HiNWtHt/KtZhc01wvBWxyVfpWKI2bC/WeKk7 LoOWmWa6BsgzCdPU6rk+xcYhlEBXLb0AgrIaOJ2WPll9Zxg4Bbs3VIAW/3tXwo0dy1RE 8kvRz3gY5LV8wweG6BLmt5te/ydVP+snbmY4aDFjAVyokb/7tAgmWzoJAerhJIvYqI1J 3+3w== X-Received: by 10.15.111.130 with SMTP id cj2mr19449468eeb.102.1393166933495; Sun, 23 Feb 2014 06:48:53 -0800 (PST) Received: from ix (dial-187038.pool.broadband44.net. [212.46.187.38]) by mx.google.com with ESMTPSA id x2sm51891297eeo.8.2014.02.23.06.48.51 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 23 Feb 2014 06:48:52 -0800 (PST) Received: from helmut by ix with local (Exim 4.80) (envelope-from ) id 1WHaMM-0006Iv-LO for bug-gnu-emacs@gnu.org; Sun, 23 Feb 2014 15:48:50 +0100 From: Helmut Eller Date: Sun, 23 Feb 2014 15:48:50 +0100 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) When I run this file (require 'ert) (ert-deftest infloop0 () (while t)) (ert-deftest infloop1 () (while t)) (ert-deftest infloop2 () (while t)) (ert-deftest infloop3 () (while t)) (ert-deftest infloop4 () (while t)) with emacs -Q -nw -l infloops.el -eval "(ert t)" I need to press C-g five times before ERT finally stops. It would be much less annoying if ERT would quit after the first C-g. This is especially important for test suites with more than 100 tests. In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2014-02-23 on ix Windowing system distributor `The X.Org Foundation', version 11.0.11204000 System Description: Debian GNU/Linux 7.1 (wheezy) From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort In-Reply-To: Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Mar 2014 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139377457515676 (code B ref -1); Sun, 02 Mar 2014 15:37:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Mar 2014 15:36:15 +0000 Received: from localhost ([127.0.0.1]:48020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK8R5-00044m-9J for submit@debbugs.gnu.org; Sun, 02 Mar 2014 10:36:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:40237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK8R2-00044c-Is for submit@debbugs.gnu.org; Sun, 02 Mar 2014 10:36:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK8Qs-0005Jp-Rx for submit@debbugs.gnu.org; Sun, 02 Mar 2014 10:36:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK8Qs-0005Jl-Oh for submit@debbugs.gnu.org; Sun, 02 Mar 2014 10:36:02 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK8Ql-0005PG-E5 for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 10:36:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WK8Qe-0005IK-45 for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 10:35:55 -0500 Received: from plane.gmane.org ([80.91.229.3]:57681) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WK8Qd-0005I6-PL for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 10:35:48 -0500 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1WK8Qb-0002oc-KS for bug-gnu-emacs@gnu.org; Sun, 02 Mar 2014 16:35:45 +0100 Received: from dial-187038.pool.broadband44.net ([212.46.187.38]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 02 Mar 2014 16:35:45 +0100 Received: from eller.helmut by dial-187038.pool.broadband44.net with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 02 Mar 2014 16:35:45 +0100 X-Injected-Via-Gmane: http://gmane.org/ From: Helmut Eller Date: Sun, 02 Mar 2014 16:35:33 +0100 Lines: 82 Message-ID: References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: dial-187038.pool.broadband44.net User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Cancel-Lock: sha1:CSeMYByPtS2D4FbMo/w+r52KEVQ= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/plain On Sun, Feb 23 2014, Helmut Eller wrote: > I need to press C-g five times before ERT finally stops. > > It would be much less annoying if ERT would quit after the first C-g. > This is especially important for test suites with more than 100 tests. Here is a patch to fix this: Make it easier to abort a series of tests with C-g. * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If interactively is true and a test was aborted then ask if the remaining tests should be aborted too. (ert-run-tests-batch, ert-run-tests-interactively): Pass in interactively arg. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=x.patch diff --git lisp/emacs-lisp/ert.el lisp/emacs-lisp/ert.el index 34041aa..aa01c3f 100644 --- lisp/emacs-lisp/ert.el +++ lisp/emacs-lisp/ert.el @@ -1238,7 +1238,7 @@ SELECTOR is the selector that was used to select TESTS." (funcall listener 'test-ended stats test result)) (setf (ert--stats-current-test stats) nil)))) -(defun ert-run-tests (selector listener) +(defun ert-run-tests (selector listener interactively) "Run the tests specified by SELECTOR, sending progress updates to LISTENER." (let* ((tests (ert-select-tests selector t)) (stats (ert--make-stats tests selector))) @@ -1249,10 +1249,14 @@ SELECTOR is the selector that was used to select TESTS." (let ((ert--current-run-stats stats)) (force-mode-line-update) (unwind-protect - (progn - (cl-loop for test in tests do - (ert-run-or-rerun-test stats test listener)) - (setq abortedp nil)) + (cl-loop for test in tests do + (ert-run-or-rerun-test stats test listener) + (when (and interactively + (ert-test-quit-p + (ert-test-most-recent-result test)) + (y-or-n-p "Abort testing? ")) + (cl-return)) + finally (setq abortedp nil)) (setf (ert--stats-aborted-p stats) abortedp) (setf (ert--stats-end-time stats) (current-time)) (funcall listener 'run-ended stats abortedp))) @@ -1443,7 +1447,8 @@ Returns the stats object." (ert-test-result-expected-p test result)) (1+ (ert--stats-test-pos stats test)) - (ert-test-name test))))))))) + (ert-test-name test))))))) + nil)) ;;;###autoload (defun ert-run-tests-batch-and-exit (&optional selector) @@ -1952,9 +1957,8 @@ and how to display message." test result))) (ert--results-update-stats-display-maybe ewoc stats) (ewoc-invalidate ewoc node)))))))) - (ert-run-tests - selector - listener))) + (ert-run-tests selector listener t))) + ;;;###autoload (defalias 'ert 'ert-run-tests-interactively) --=-=-=-- From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort In-Reply-To: Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Sep 2014 10:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14100855133074 (code B ref -1); Sun, 07 Sep 2014 10:26:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Sep 2014 10:25:13 +0000 Received: from localhost ([127.0.0.1]:60876 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQZei-0000nV-Sk for submit@debbugs.gnu.org; Sun, 07 Sep 2014 06:25:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36927) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQZef-0000ma-KY for submit@debbugs.gnu.org; Sun, 07 Sep 2014 06:25:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQZeQ-0008Bj-M5 for submit@debbugs.gnu.org; Sun, 07 Sep 2014 06:25:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_NUMERIC_HELO,T_FSL_HELO_BARE_IP_2 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQZeQ-0008Bf-JW for submit@debbugs.gnu.org; Sun, 07 Sep 2014 06:24:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38641) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQZeJ-0004FE-3C for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 06:24:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQZeB-00085x-DT for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 06:24:46 -0400 Received: from plane.gmane.org ([80.91.229.3]:43441) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQZeB-00083I-6O for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 06:24:39 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XQZe7-0004Uk-FD for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 12:24:35 +0200 Received: from 212.46.176.18 ([212.46.176.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2014 12:24:35 +0200 Received: from eller.helmut by 212.46.176.18 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2014 12:24:35 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Helmut Eller Date: Sun, 07 Sep 2014 12:24:22 +0200 Lines: 10 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 212.46.176.18 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:cWNBywyW8QqbA3G5vwJN6nR5jeI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On Sun, Feb 23 2014, Helmut Eller wrote: [...] > It would be much less annoying if ERT would quit after the first C-g. > This is especially important for test suites with more than 100 tests. Has somebody time to look at this issue, please? This bug is quite a showstopper for me. Helmut From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Sep 2014 19:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141011969929755 (code B ref -1); Sun, 07 Sep 2014 19:55:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Sep 2014 19:54:59 +0000 Received: from localhost ([127.0.0.1]:33024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQiY6-0007jq-Ml for submit@debbugs.gnu.org; Sun, 07 Sep 2014 15:54:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38940) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQiY4-0007je-Is for submit@debbugs.gnu.org; Sun, 07 Sep 2014 15:54:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQiXp-0000Zw-HR for submit@debbugs.gnu.org; Sun, 07 Sep 2014 15:54:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50652) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQiXp-0000Zs-EG for submit@debbugs.gnu.org; Sun, 07 Sep 2014 15:54:41 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40661) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQiXh-0002xj-NK for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 15:54:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQiXa-0000Fb-7a for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 15:54:33 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:53644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQiXZ-0000FX-Ux for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 15:54:26 -0400 Received: from [192.168.178.32] (brln-4d0c3f47.pool.mediaWays.net [77.12.63.71]) by mrelayeu.kundenserver.de (node=mreue103) with ESMTP (Nemesis) id 0MB1l6-1XYNVM1Puu-009zxM; Sun, 07 Sep 2014 21:54:24 +0200 Message-ID: <540CB7F2.3060905@easy-emacs.de> Date: Sun, 07 Sep 2014 21:54:26 +0200 From: Andreas =?UTF-8?Q?R=C3=B6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:JKsD5TNHxxL7tdWWpYDBJ8CAi7aqCIoyYPnljU9RFAV q+cDStF5wbR2QipfbbIT9nTsdoG4ukeOafRocQ4cRE/QUih5z9 bUqYGr8pRg+BVnHvhDP1QhnT1tPiL+cOupsdtilMgW81/nSGNl 1QZp/JFeTIn0QAdZmi206SPXst/n7p1jefdhHeH48L4V4c1R45 TuK9Gl3r/yWwkkeOytmFzkRxVKFlnb13O40TMdxjR4K7BSAesj QBbTl4Njue3/Mj0kmsq17D7fZMKM6I39zLIVb+4I6gRq65wrM0 tfuFX/D94GJ+UkCiXrGgFdd56778ob9+Bp9amWkTtHHJrcBzF9 W3oG3vculLvesQEd/ExPbvQlf/iUdwMJfv+rIlS+p X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 07.09.2014 12:24, Helmut Eller wrote: > On Sun, Feb 23 2014, Helmut Eller wrote: > > [...] >> It would be much less annoying if ERT would quit after the first C-g. >> This is especially important for test suites with more than 100 tests. > > Has somebody time to look at this issue, please? This bug is quite a > showstopper for me. > > Helmut > Hi, just out of couriosity: why not run it from shell, which would not have that nuisance? Andreas From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort In-Reply-To: Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 07 Sep 2014 20:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14101223031532 (code B ref -1); Sun, 07 Sep 2014 20:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 7 Sep 2014 20:38:23 +0000 Received: from localhost ([127.0.0.1]:33040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQjE5-0000Od-A1 for submit@debbugs.gnu.org; Sun, 07 Sep 2014 16:38:21 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43287) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQjE0-0000OK-Bg for submit@debbugs.gnu.org; Sun, 07 Sep 2014 16:38:17 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQjDl-0002Ti-BF for submit@debbugs.gnu.org; Sun, 07 Sep 2014 16:38:11 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=5.0 tests=BAYES_20,FREEMAIL_FROM, RCVD_NUMERIC_HELO,T_FSL_HELO_BARE_IP_2 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQjDl-0002Te-8X for submit@debbugs.gnu.org; Sun, 07 Sep 2014 16:38:01 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44988) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQjDd-0007xU-PE for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 16:38:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQjDW-0002Nw-98 for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 16:37:53 -0400 Received: from plane.gmane.org ([80.91.229.3]:33927) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQjDW-0002Ns-2k for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 16:37:46 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XQjDP-0001HH-Gm for bug-gnu-emacs@gnu.org; Sun, 07 Sep 2014 22:37:39 +0200 Received: from 212.46.176.18 ([212.46.176.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2014 22:37:39 +0200 Received: from eller.helmut by 212.46.176.18 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 07 Sep 2014 22:37:39 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Helmut Eller Date: Sun, 07 Sep 2014 22:37:29 +0200 Lines: 10 Message-ID: References: <540CB7F2.3060905@easy-emacs.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 212.46.176.18 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:WNL4AMcgJm1q4yFT9hkvwVeHfJA= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On Sun, Sep 07 2014, Andreas Röhler wrote: > just out of couriosity: why not run it from shell, which would not > have that nuisance? I need to test display related code, like checking if the proper region is visible; that wouldn't work in batch mode. Also the *ert* buffer is easier to browse than log files. Helmut From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Sep 2014 09:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141016861818927 (code B ref -1); Mon, 08 Sep 2014 09:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2014 09:30:18 +0000 Received: from localhost ([127.0.0.1]:33219 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQvH5-0004vA-3a for submit@debbugs.gnu.org; Mon, 08 Sep 2014 05:30:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:49237) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQvGz-0004u7-HT for submit@debbugs.gnu.org; Mon, 08 Sep 2014 05:30:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQvGk-00088Z-EV for submit@debbugs.gnu.org; Mon, 08 Sep 2014 05:30:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57101) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQvGk-00088V-Ba for submit@debbugs.gnu.org; Mon, 08 Sep 2014 05:29:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50933) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQvGc-0007os-H9 for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 05:29:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQvGV-00087N-21 for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 05:29:46 -0400 Received: from mout.kundenserver.de ([212.227.17.10]:59129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQvGU-00087F-PO for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 05:29:39 -0400 Received: from [192.168.178.32] (brln-4d0c52ba.pool.mediaWays.net [77.12.82.186]) by mrelayeu.kundenserver.de (node=mreue101) with ESMTP (Nemesis) id 0LoHJh-1Y2Apc2vur-00gF6V; Mon, 08 Sep 2014 11:29:38 +0200 Message-ID: <540D76FB.7030708@easy-emacs.de> Date: Mon, 08 Sep 2014 11:29:31 +0200 From: Andreas =?UTF-8?Q?R=C3=B6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 References: <540CB7F2.3060905@easy-emacs.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:Kst7feHMeevEh861wObRyjfCYWWKT6PKh2OLZLlnk2g 64i2bLtcr5CvLydD5L0c4w1CZKWcVHnyJJIqSbdxTW48PhDFV4 vQUT4hpYH/bFwT9RaImuwosNcB/XpyL29Cbn+3dDdXJg7hlm32 ybRB+veD1tTUngRY23dUPVrXpfY9ofG9DxGW7ayluhUFHFSCzn DG6wRPUICzGlz5WBAIpGHpUoLcMqGKKqOmLaOBHQlAKFDStuli NkBGy253UPU1OdqN1gITjVz/sd7HiPfc4TElHr8NyRsD/fpN/S /dI0lZfydcqOZ5LqdV4hyfL7TfhsMDaSm4da2soX4g6x60D+4u 6nQk7RSUPRGT4/zmZecQ759Y8twQ+La9/UDedD2VR X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 07.09.2014 22:37, Helmut Eller wrote: > On Sun, Sep 07 2014, Andreas Röhler wrote: > >> just out of couriosity: why not run it from shell, which would not >> have that nuisance? > > I need to test display related code, like checking if the proper region > is visible; that wouldn't work in batch mode. Why not? But understand there might be some work left to write the related test, checks if being visible. Also the *ert* buffer is > easier to browse than log files. > Get nice output here should something fail. Run this manually then... Cheers, Andreas From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort In-Reply-To: Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Sep 2014 14:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.141018502716600 (code B ref -1); Mon, 08 Sep 2014 14:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2014 14:03:47 +0000 Received: from localhost ([127.0.0.1]:33932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQzXm-0004Jf-M5 for submit@debbugs.gnu.org; Mon, 08 Sep 2014 10:03:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47011) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XQzXk-0004JT-E8 for submit@debbugs.gnu.org; Mon, 08 Sep 2014 10:03:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQzXV-0005u8-EW for submit@debbugs.gnu.org; Mon, 08 Sep 2014 10:03:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_NUMERIC_HELO,T_FSL_HELO_BARE_IP_2 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42053) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQzXV-0005u4-Be for submit@debbugs.gnu.org; Mon, 08 Sep 2014 10:03:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQzXN-0005qD-Mz for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 10:03:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XQzXE-0005po-Ck for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 10:03:21 -0400 Received: from plane.gmane.org ([80.91.229.3]:54831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XQzXE-0005pk-79 for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 10:03:12 -0400 Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1XQzXA-0003Bd-1L for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 16:03:08 +0200 Received: from 212.46.171.153 ([212.46.171.153]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 08 Sep 2014 16:03:08 +0200 Received: from eller.helmut by 212.46.171.153 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 08 Sep 2014 16:03:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ From: Helmut Eller Date: Mon, 08 Sep 2014 16:02:53 +0200 Lines: 23 Message-ID: References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 212.46.171.153 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) Cancel-Lock: sha1:lU9k9tL11as/Gg0OEeJfuexfKl4= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.2 (---) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.2 (---) On Mon, Sep 08 2014, Andreas Röhler wrote: >> I need to test display related code, like checking if the proper region >> is visible; that wouldn't work in batch mode. > > Why not? But understand there might be some work left to write the > related test, checks if being visible. Try this: emacs -batch -eval '(message "%s" (pos-visible-in-window-p (window-start)))' It prints nil. Shouldn't window-start always be visible? > Also the *ert* buffer is >> easier to browse than log files. >> > > Get nice output here should something fail. Run this manually then... Sure, use what works best for a given problem. My log output is long and full of random calls to "message". Helmut From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Sep 2014 16:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16853@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.14101934556996 (code B ref -1); Mon, 08 Sep 2014 16:25:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Sep 2014 16:24:15 +0000 Received: from localhost ([127.0.0.1]:34024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XR1ji-0001ol-0w for submit@debbugs.gnu.org; Mon, 08 Sep 2014 12:24:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60651) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XR1jf-0001oX-Kz for submit@debbugs.gnu.org; Mon, 08 Sep 2014 12:24:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XR1jQ-0008Sr-O7 for submit@debbugs.gnu.org; Mon, 08 Sep 2014 12:24:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR1jQ-0008Sj-LH for submit@debbugs.gnu.org; Mon, 08 Sep 2014 12:23:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33998) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR1jJ-0004YG-5W for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 12:23:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XR1j7-0008Nq-VZ for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 12:23:49 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:55486) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XR1j7-0008NG-MC for bug-gnu-emacs@gnu.org; Mon, 08 Sep 2014 12:23:37 -0400 Received: from [192.168.178.32] (brln-4d0c52ba.pool.mediaWays.net [77.12.82.186]) by mrelayeu.kundenserver.de (node=mreue104) with ESMTP (Nemesis) id 0LdEZd-1Y8eDZ2ew5-00iT20; Mon, 08 Sep 2014 18:23:36 +0200 Message-ID: <540DD800.8030508@easy-emacs.de> Date: Mon, 08 Sep 2014 18:23:28 +0200 From: Andreas =?UTF-8?Q?R=C3=B6hler?= User-Agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Icedove/24.7.0 MIME-Version: 1.0 References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:dCJX28J5NpW5Z5jDviKeJMjGN5s5cEqYMkw3+1SYQBb 4INMmFMD0X3/XURpyMtOHb/4zQNRtI8bQZy/MoAwOfPbVyk1Lu YJvQfNzK7ySaW5RxVYSXqcJZXevy060YKrnpLkWVHjINlGq/Ms RhieW0hZdujT8D361kOTJMAQs3vuJfHhaHy/ffASqOZfcSIKZh KbZ3Suw4naVNYNgg3JhC57BsUimn/lHGX8l4VyldUZ2rYzvfmY Z08IY5LUhdiD9u12YQ9cMjl8wtsnFKzkRKMatQj7XI1H+mcCfH SxcC6eG2P7w8MsC32Kiw0KEcsOCR4p/mTOx4u3uWGoQgjubT+5 tmENuePYlbeepjGnlGxsFqv04BgCuJHL35OJYNc5R X-UI-Out-Filterresults: notjunk:1; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On 08.09.2014 16:02, Helmut Eller wrote: > On Mon, Sep 08 2014, Andreas Röhler wrote: > >>> I need to test display related code, like checking if the proper region >>> is visible; that wouldn't work in batch mode. >> >> Why not? But understand there might be some work left to write the >> related test, checks if being visible. > > Try this: > emacs -batch -eval '(message "%s" (pos-visible-in-window-p (window-start)))' > > It prints nil. Shouldn't window-start always be visible? I see, thanks. BTW it also refused to message (point). Andreas From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 13:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Helmut Eller Cc: 16853@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.14102694227973 (code B ref 16853); Tue, 09 Sep 2014 13:31:02 +0000 Received: (at 16853) by debbugs.gnu.org; 9 Sep 2014 13:30:22 +0000 Received: from localhost ([127.0.0.1]:34567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLUz-00024V-44 for submit@debbugs.gnu.org; Tue, 09 Sep 2014 09:30:22 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:48349) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLUs-000248-2S for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 09:30:16 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0NBM00L00YOHBB00@a-mtaout21.012.net.il> for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 16:30:07 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBM00L18YU7AK20@a-mtaout21.012.net.il>; Tue, 09 Sep 2014 16:30:07 +0300 (IDT) Date: Tue, 09 Sep 2014 16:30:17 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83fvg0c45y.fsf@gnu.org> References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Helmut Eller > Date: Mon, 08 Sep 2014 16:02:53 +0200 > > Try this: > emacs -batch -eval '(message "%s" (pos-visible-in-window-p (window-start)))' > > It prints nil. Shouldn't window-start always be visible? No, not when the window is not "live". From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 13:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 16853@debbugs.gnu.org Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.14102703429451 (code B ref 16853); Tue, 09 Sep 2014 13:46:01 +0000 Received: (at 16853) by debbugs.gnu.org; 9 Sep 2014 13:45:42 +0000 Received: from localhost ([127.0.0.1]:34571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLjp-0002SL-QO for submit@debbugs.gnu.org; Tue, 09 Sep 2014 09:45:42 -0400 Received: from mail-wi0-f174.google.com ([209.85.212.174]:62190) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLjj-0002Rv-22 for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 09:45:36 -0400 Received: by mail-wi0-f174.google.com with SMTP id n3so1087544wiv.13 for <16853@debbugs.gnu.org>; Tue, 09 Sep 2014 06:45:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=CBY2Yxy3EQRK4EbYZw6iENsiue0csynSqAqQjhqosPU=; b=KrH/zERaI/eDKALo1iyFsLjlqX/lag9DDibrr/3wGSSdYOg/4HVeoCg2qWKCyLO9+h Oaf6uO8REu9f+5Nb40x+2R8TfzoQsH4smSofdCTL+0xnNJpjKdmuzer8CQxq8ubrwOvT InJxc7aTKbCkejyoPQOswRkrx2dq6jCOAA8joop681L6acwlZ1ljOI+ef1M9F4YivaNW RAvbp93VynBP0NVnDluLLGvTKrafkjSoepoyEjyhTtvQBZum2rwJU3dc4rAZyR/TVW5g deV1vaOwBm04ZfKMDrftkFxhNZ8GURHs5HPx7eSe2BARXWNK8zSdxzCD9oP3eqVG/y8l OSBA== X-Received: by 10.181.13.116 with SMTP id ex20mr30861207wid.31.1410270329204; Tue, 09 Sep 2014 06:45:29 -0700 (PDT) Received: from ix ([212.46.171.153]) by mx.google.com with ESMTPSA id gk17sm15654049wic.16.2014.09.09.06.45.28 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 09 Sep 2014 06:45:28 -0700 (PDT) Received: from helmut by ix with local (Exim 4.80) (envelope-from ) id 1XRLjb-0005CX-4x; Tue, 09 Sep 2014 15:45:27 +0200 From: Helmut Eller References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> <83fvg0c45y.fsf@gnu.org> Date: Tue, 09 Sep 2014 15:45:27 +0200 In-Reply-To: <83fvg0c45y.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Sep 2014 16:30:17 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Sep 09 2014, Eli Zaretskii wrote: >> From: Helmut Eller >> Date: Mon, 08 Sep 2014 16:02:53 +0200 >> >> Try this: >> emacs -batch -eval '(message "%s" (pos-visible-in-window-p (window-start)))' >> >> It prints nil. Shouldn't window-start always be visible? > > No, not when the window is not "live". The window in the example is the selected window and it is live: emacs -batch -eval '(message "%s" (window-live-p (selected-window)))' => t Helmut From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 13:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Helmut Eller Cc: 16853@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.141027107411344 (code B ref 16853); Tue, 09 Sep 2014 13:58:02 +0000 Received: (at 16853) by debbugs.gnu.org; 9 Sep 2014 13:57:54 +0000 Received: from localhost ([127.0.0.1]:35439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLvd-0002wu-Fd for submit@debbugs.gnu.org; Tue, 09 Sep 2014 09:57:53 -0400 Received: from mtaout24.012.net.il ([80.179.55.180]:37184) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRLvY-0002wb-Pt for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 09:57:50 -0400 Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0NBM00A00ZSS9400@mtaout24.012.net.il> for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 16:52:39 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBM003JJZVRGB70@mtaout24.012.net.il>; Tue, 09 Sep 2014 16:52:39 +0300 (IDT) Date: Tue, 09 Sep 2014 16:57:52 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83a968c2vz.fsf@gnu.org> References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> <83fvg0c45y.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Helmut Eller > Cc: 16853@debbugs.gnu.org > Date: Tue, 09 Sep 2014 15:45:27 +0200 > > On Tue, Sep 09 2014, Eli Zaretskii wrote: > > >> From: Helmut Eller > >> Date: Mon, 08 Sep 2014 16:02:53 +0200 > >> > >> Try this: > >> emacs -batch -eval '(message "%s" (pos-visible-in-window-p (window-start)))' > >> > >> It prints nil. Shouldn't window-start always be visible? > > > > No, not when the window is not "live". > > The window in the example is the selected window and it is live: > emacs -batch -eval '(message "%s" (window-live-p (selected-window)))' > => t Not in batch mode, it isn't. From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Helmut Eller Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 14:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 16853@debbugs.gnu.org Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.141027205812962 (code B ref 16853); Tue, 09 Sep 2014 14:15:02 +0000 Received: (at 16853) by debbugs.gnu.org; 9 Sep 2014 14:14:18 +0000 Received: from localhost ([127.0.0.1]:35443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRMBV-0003Mz-AA for submit@debbugs.gnu.org; Tue, 09 Sep 2014 10:14:17 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:42068) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRMBR-0003Mi-Bg for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 10:14:14 -0400 Received: by mail-wi0-f178.google.com with SMTP id hi2so1271458wib.11 for <16853@debbugs.gnu.org>; Tue, 09 Sep 2014 07:14:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=N86ADdzIL11IMbzVKADYLzniBCnAG0oYYdRPP/v+iZU=; b=mwrq+TC38HiyA+Ba91if6xDdyXTf6Cmo+mDK/4uWO1l9R3NhV5LwdsUWA27tYd8G3W GLLYy8umpewdIwfhlCMP8faGKaRb33P0Cu+SOxGYK618iJnfNahlGE3FkiQA1rw1Pmb/ G1gnrNaw7UtEZbW2BtdNdmCLVKBMKkOQW2tq5HPLcWkIs0T6zUYmE8yHBt3mw4W2V9ZV dWVYPahMLDgvq27h/5vjnIN9NQbUtZojk5dycHOiKtllMVeO2CeNo6zls7+x29+jPAne tOPH/BG6UNcYKwp92MLKkBIjv6/Y15GOsUcy1WBf4YDxERH4RPtJFHxvsEH8uXKhvZBK j4Yg== X-Received: by 10.194.205.196 with SMTP id li4mr41981864wjc.46.1410272047577; Tue, 09 Sep 2014 07:14:07 -0700 (PDT) Received: from ix ([212.46.171.153]) by mx.google.com with ESMTPSA id fp19sm1986324wic.3.2014.09.09.07.14.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Tue, 09 Sep 2014 07:14:06 -0700 (PDT) Received: from helmut by ix with local (Exim 4.80) (envelope-from ) id 1XRMBJ-0005Dd-IP; Tue, 09 Sep 2014 16:14:05 +0200 From: Helmut Eller References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> <83fvg0c45y.fsf@gnu.org> <83a968c2vz.fsf@gnu.org> Date: Tue, 09 Sep 2014 16:14:05 +0200 In-Reply-To: <83a968c2vz.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 09 Sep 2014 16:57:52 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, Sep 09 2014, Eli Zaretskii wrote: >> From: Helmut Eller >> Cc: 16853@debbugs.gnu.org >> Date: Tue, 09 Sep 2014 15:45:27 +0200 >> >> On Tue, Sep 09 2014, Eli Zaretskii wrote: >> >> >> From: Helmut Eller >> >> Date: Mon, 08 Sep 2014 16:02:53 +0200 >> >> >> >> Try this: >> >> emacs -batch -eval '(message "%s" (pos-visible-in-window-p >> >> (window-start)))' >> >> >> >> It prints nil. Shouldn't window-start always be visible? >> > >> > No, not when the window is not "live". >> >> The window in the example is the selected window and it is live: >> emacs -batch -eval '(message "%s" (window-live-p (selected-window)))' >> => t > > Not in batch mode, it isn't. Are you wasting time on purpose or what is this? The point of the example was to show that pos-visible-in-window-p doesn't work normally in batch mode. Claiming that the window isn't live when window-live-p obviously returns t is IMO silly. Helmut From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 09 Sep 2014 14:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Helmut Eller Cc: 16853@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.141027370415990 (code B ref 16853); Tue, 09 Sep 2014 14:42:02 +0000 Received: (at 16853) by debbugs.gnu.org; 9 Sep 2014 14:41:44 +0000 Received: from localhost ([127.0.0.1]:35472 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRMc4-00049p-Fa for submit@debbugs.gnu.org; Tue, 09 Sep 2014 10:41:44 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:59400) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XRMc1-00049Z-Vt for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 10:41:42 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0NBN0000021YBC00@a-mtaout20.012.net.il> for 16853@debbugs.gnu.org; Tue, 09 Sep 2014 17:41:36 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NBN00MTU25BW770@a-mtaout20.012.net.il>; Tue, 09 Sep 2014 17:41:36 +0300 (IDT) Date: Tue, 09 Sep 2014 17:41:46 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83zje8amad.fsf@gnu.org> References: <540CB7F2.3060905@easy-emacs.de> <540D76FB.7030708@easy-emacs.de> <83fvg0c45y.fsf@gnu.org> <83a968c2vz.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Helmut Eller > Cc: 16853@debbugs.gnu.org > Date: Tue, 09 Sep 2014 16:14:05 +0200 > > Are you wasting time on purpose or what is this? I've just stopped. From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 24 Feb 2016 03:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Helmut Eller Cc: 16853@debbugs.gnu.org Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.145628330115489 (code B ref 16853); Wed, 24 Feb 2016 03:09:02 +0000 Received: (at 16853) by debbugs.gnu.org; 24 Feb 2016 03:08:21 +0000 Received: from localhost ([127.0.0.1]:41984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYPoL-00041k-2c for submit@debbugs.gnu.org; Tue, 23 Feb 2016 22:08:21 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:48665) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aYPoK-00041d-9q for 16853@debbugs.gnu.org; Tue, 23 Feb 2016 22:08:20 -0500 Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aYPnx-0006Zq-80; Wed, 24 Feb 2016 04:07:57 +0100 From: Lars Ingebrigtsen References: Date: Wed, 24 Feb 2016 14:07:53 +1100 In-Reply-To: (Helmut Eller's message of "Sun, 02 Mar 2014 16:35:33 +0100") Message-ID: <87k2lun6uu.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1aYPnx-0006Zq-80 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1456888078.1602@fglgHg8SB964bBQBiOPIgA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Helmut Eller writes: > Here is a patch to fix this: > > Make it easier to abort a series of tests with C-g. > > * emacs-lisp/ert.el (ert-run-tests): Add "interactively" arg. If > interactively is true and a test was aborted then ask if the > remaining tests should be aborted too. > (ert-run-tests-batch, ert-run-tests-interactively): Pass in > interactively arg. I think this makes sense, but the discussion seemed to go off on a tangent, and the patch wasn't applied. And I'm not familiar with the ert internals, but could somebody look at the patch and see whether it looks reasonable? > diff --git lisp/emacs-lisp/ert.el lisp/emacs-lisp/ert.el > index 34041aa..aa01c3f 100644 > --- lisp/emacs-lisp/ert.el > +++ lisp/emacs-lisp/ert.el > @@ -1238,7 +1238,7 @@ SELECTOR is the selector that was used to select TESTS." > (funcall listener 'test-ended stats test result)) > (setf (ert--stats-current-test stats) nil)))) > > -(defun ert-run-tests (selector listener) > +(defun ert-run-tests (selector listener interactively) > "Run the tests specified by SELECTOR, sending progress updates to LISTENER." > (let* ((tests (ert-select-tests selector t)) > (stats (ert--make-stats tests selector))) > @@ -1249,10 +1249,14 @@ SELECTOR is the selector that was used to select TESTS." > (let ((ert--current-run-stats stats)) > (force-mode-line-update) > (unwind-protect > - (progn > - (cl-loop for test in tests do > - (ert-run-or-rerun-test stats test listener)) > - (setq abortedp nil)) > + (cl-loop for test in tests do > + (ert-run-or-rerun-test stats test listener) > + (when (and interactively > + (ert-test-quit-p > + (ert-test-most-recent-result test)) > + (y-or-n-p "Abort testing? ")) > + (cl-return)) > + finally (setq abortedp nil)) > (setf (ert--stats-aborted-p stats) abortedp) > (setf (ert--stats-end-time stats) (current-time)) > (funcall listener 'run-ended stats abortedp))) > @@ -1443,7 +1447,8 @@ Returns the stats object." > (ert-test-result-expected-p > test result)) > (1+ (ert--stats-test-pos stats test)) > - (ert-test-name test))))))))) > + (ert-test-name test))))))) > + nil)) > > ;;;###autoload > (defun ert-run-tests-batch-and-exit (&optional selector) > @@ -1952,9 +1957,8 @@ and how to display message." > test result))) > (ert--results-update-stats-display-maybe ewoc stats) > (ewoc-invalidate ewoc node)))))))) > - (ert-run-tests > - selector > - listener))) > + (ert-run-tests selector listener t))) > + > ;;;###autoload > (defalias 'ert 'ert-run-tests-interactively) > > -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Mar 2017 02:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 16853@debbugs.gnu.org, Helmut Eller Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.148971869814677 (code B ref 16853); Fri, 17 Mar 2017 02:45:02 +0000 Received: (at 16853) by debbugs.gnu.org; 17 Mar 2017 02:44:58 +0000 Received: from localhost ([127.0.0.1]:59497 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cohss-0003oX-3V for submit@debbugs.gnu.org; Thu, 16 Mar 2017 22:44:57 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:36704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cohsi-0003o8-JN; Thu, 16 Mar 2017 22:44:48 -0400 Received: by mail-it0-f65.google.com with SMTP id u69so1702695ita.3; Thu, 16 Mar 2017 19:44:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=h9KVRAftBGQvVhDnqqtdd36RPlbajO6brtC0d7BCP1w=; b=A/OgsqoFbHwGLRV95cez4LLX+OFcHI+W6cp5Hbs+K2quZlTOaHERPyNpv6ZzK9bKaD HDGSHs5eKh8LB6RoHAaUX4jjIZOM7EyzXSVnlewlavdn8Z1nBs246uIGpWrQ4NR+khXW qC497xbWsVKjy/csRIEGT8UUd43cwBQlrFZEfpCY2UWX7SiodRt//GyV3AgLhKdMy4Nc qEYstBDuG/orrykLrqr+yrHArDZPvNBRTJcr5EPH3u36D8pBJhZMZrvfIGLQ5Ti8bm5n G6XJQg38A62+0Povzydl35iIif3koZpdE60Q/bI14dnIMkF7ByKQH7y25zqsiprnGf4r pX2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=h9KVRAftBGQvVhDnqqtdd36RPlbajO6brtC0d7BCP1w=; b=B9P2pEiwFSqcA92eOsGgXrb02q9vkrZrqVffyWVYz6tFpjN4UIzw8I2MTTDXbozrmN nTHx4MkAS2yp/8uAus7Y7lGsatqIRxvZzKwBrzEQXU6u3AR05gh2IeB44qSFliYsYoGn EJ6OFgMJ5WSBU11mSYPupzbO785Z15bqgvBANJEHAzUwAnewGWPF2dG2b4u+ODd4XQ2t LMCtpw7p9Fw2SzrcjoV6Iku95G3ROPgBDBlMvr3DcoSTrxqKHzyvlIQ1sqrx1z4pFX0O 69nGaKikqpN4YGZsYgXGdPvlYYqTMb2gu7on0v6Mbrlprd+jZwz3OGckfTd7J6YLt9aA kEAg== X-Gm-Message-State: AFeK/H2qq2CPwBgn5zZ984jP5f6HZ+OjpQEe8J/Ts5/he5GG5ABlLpuaW14IcvJklr4D7A== X-Received: by 10.107.8.215 with SMTP id h84mr15282931ioi.134.1489718679208; Thu, 16 Mar 2017 19:44:39 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id j14sm2153046itd.0.2017.03.16.19.44.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 16 Mar 2017 19:44:38 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87k2lun6uu.fsf@gnus.org> Date: Thu, 16 Mar 2017 22:45:57 -0400 In-Reply-To: <87k2lun6uu.fsf@gnus.org> (Lars Ingebrigtsen's message of "Wed, 24 Feb 2016 14:07:53 +1100") Message-ID: <87y3w44o4a.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) severity 16853 wishlist quit Lars Ingebrigtsen writes: > I think this makes sense, but the discussion seemed to go off on a > tangent, and the patch wasn't applied. > > And I'm not familiar with the ert internals, but could somebody look at > the patch and see whether it looks reasonable? Looks good to me. I'll push to master in week or so, if there are no objections. From unknown Sun Jun 15 10:55:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16853: 24.3.50; ert-run-tests-interactively difficult to abort Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2017 00:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16853 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Helmut Eller , 16853@debbugs.gnu.org Received: via spool by 16853-submit@debbugs.gnu.org id=B16853.149040087122164 (code B ref 16853); Sat, 25 Mar 2017 00:15:02 +0000 Received: (at 16853) by debbugs.gnu.org; 25 Mar 2017 00:14:31 +0000 Received: from localhost ([127.0.0.1]:42920 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crZLj-0005lK-4X for submit@debbugs.gnu.org; Fri, 24 Mar 2017 20:14:31 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:35257) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1crZLh-0005l1-NX; Fri, 24 Mar 2017 20:14:30 -0400 Received: by mail-it0-f66.google.com with SMTP id y18so1038959itc.2; Fri, 24 Mar 2017 17:14:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=WAeMnK+bxBfwO2P68m10QFgBQOYV4OV4ucWaDlGCK+0=; b=c1pJ7U+sz1rBjmCl1tExGG/5SqLs++uoFoA14STSFEvhp7NCkEPMv4G7Q9+UyGt4jF QHVGJqcEqWn+rSB0/SbHIbMl6fRwOgrOca5lT99HVnNA77Rb82ekOYdlqcRki1jpj9Dx yT+wLaIw1YRsmesFzkKkfIWTPbuA7SKu+AqqXzWfQhAK6Tz+RjFW7j9GzQGlEQTn2aNE Xt7T4jz6ykHNWjlXxFMmYhDj/+eCqyhrqs8XHwHuuEYOQ65M7UZWNM73xZBZjWTYCCgh u9EM8UfDKz2u/8zcgsA8LsCenUwrnoG38UeUGUE6kJ3k4I6SwaeKGR2l/KoUPcH0rZZk /8oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=WAeMnK+bxBfwO2P68m10QFgBQOYV4OV4ucWaDlGCK+0=; b=PkkpR9MmNklGgVARRsYb9pRMqfwCgEKT+69tdSqq7sluBG99Om5pb7SL53CLUEa5Na 2RaRMF7iU0q0XbZeEA6MaCuxnjdjb7QSAyJ+G7OXh85Tbf7h7Q2rfs/vMQtFOQLepYXb ngQ05rkQG3rVR6jhHAImlElD0pqzT9QEKZHBK5Cfb71gnVksfD6sfL4ngstAvtngmr/S +pYYaq3dgZUtEyXD4wiLybrzQlefmyOfcIOxaUqw+lU9jPNc2WjNA4PpCyxj31FJwSME G3Tsal5hjrTGFK+4EYdzxFMKlJ5b3u63HSSQFiBIc40yTwjLZ7/FXtfBcKgtYNzBkM7H Ex6w== X-Gm-Message-State: AFeK/H2wym5e03TWyVVLGS+5RylEqlghx17DPdqvTQYsNLCXdI6pkjwgHwi1zMH7PPLr5A== X-Received: by 10.107.50.206 with SMTP id y197mr11183707ioy.214.1490400864242; Fri, 24 Mar 2017 17:14:24 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id s194sm1736943ita.12.2017.03.24.17.14.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 24 Mar 2017 17:14:23 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87k2lun6uu.fsf@gnus.org> <87y3w44o4a.fsf@users.sourceforge.net> Date: Fri, 24 Mar 2017 20:15:47 -0400 In-Reply-To: <87y3w44o4a.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net's message of "Thu, 16 Mar 2017 22:45:57 -0400") Message-ID: <87k27e2ouk.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 16853 fixed close 16853 26.1 quit npostavs@users.sourceforge.net writes: > > Looks good to me. I'll push to master in week or so, if there are no > objections. Done [1: ef44346782]. 1: 2017-03-24 20:13:17 -0400 ef443467826dc33c6e58081e7af7c68905f6db26 Make it easier to abort a series of tests with C-g