From unknown Fri Jun 20 07:14:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16847 <16847@debbugs.gnu.org> To: bug#16847 <16847@debbugs.gnu.org> Subject: Status: parted 3.1 help texts are missing flag pmbr_boot Reply-To: bug#16847 <16847@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:14:51 +0000 retitle 16847 parted 3.1 help texts are missing flag pmbr_boot reassign 16847 parted submitter 16847 Peter Klotz severity 16847 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 22 15:20:21 2014 Received: (at submit) by debbugs.gnu.org; 22 Feb 2014 20:20:22 +0000 Received: from localhost ([127.0.0.1]:35950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHJ3d-0008AB-4x for submit@debbugs.gnu.org; Sat, 22 Feb 2014 15:20:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35533) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHIxY-0007yi-49 for submit@debbugs.gnu.org; Sat, 22 Feb 2014 15:14:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHIxK-0003zM-3q for submit@debbugs.gnu.org; Sat, 22 Feb 2014 15:13:58 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.1 required=5.0 tests=BAYES_50, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43548) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHIxK-0003zI-0o for submit@debbugs.gnu.org; Sat, 22 Feb 2014 15:13:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHIxB-00056r-JA for bug-parted@gnu.org; Sat, 22 Feb 2014 15:13:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WHIx3-0003vQ-5v for bug-parted@gnu.org; Sat, 22 Feb 2014 15:13:41 -0500 Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:36004) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WHIx2-0003vH-UJ for bug-parted@gnu.org; Sat, 22 Feb 2014 15:13:33 -0500 Received: by mail-ee0-f42.google.com with SMTP id e53so726781eek.15 for ; Sat, 22 Feb 2014 12:13:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=ghpEFcMw/nfjP0G5yxWJ/5JXnWwkJ6Q3uZWvkiMRkWE=; b=PdP8sza0tWiGnexrZXU1zFr2I/HetGTi+01wEX5tQ8BBglEeqAU906HbWLv5LE4OCS 12E81TEFscmsYtNzT8Xtzdko5BBCkReaIe/20SD9ZLQl5LU7B2mvXtRcd9Qe10vRmqTY qIOQVW3gWpn4GbbaKU7b1RggT6VkrGWKL/N0RRg+YhskH2qAHjp98ZwCL8BSY8bwZ72C b1Ba6MpFOQamJUEV5hBVzyVfiAprBE0nJ5ad3RU3LKRLlUFsinJm0bCJkY9JBhjRHk/B z4v6TtnKzb5h0K97GXohDhfYgya7f3aXOjKpEpI4SsSwEGGEBjKTCKSCZ6FkG7bFuBwp ruUQ== X-Received: by 10.14.103.134 with SMTP id f6mr16039946eeg.41.1393100011237; Sat, 22 Feb 2014 12:13:31 -0800 (PST) Received: from [192.168.17.122] (chello080109177091.tirol.surfer.at. [80.109.177.91]) by mx.google.com with ESMTPSA id j41sm42612963eey.15.2014.02.22.12.13.30 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sat, 22 Feb 2014 12:13:30 -0800 (PST) Message-ID: <530904E9.6030900@aon.at> Date: Sat, 22 Feb 2014 21:13:29 +0100 From: Peter Klotz User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: bug-parted@gnu.org Subject: parted 3.1 help texts are missing flag pmbr_boot Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 22 Feb 2014 15:20:19 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Neither "help disk_set" nor "help disk_toggle" in parted 3.1 mentions flag "pmbr_boot" to set the protective MBR's boot flag. However setting the flag using this options works fine. In my opinion it should be added since otherwise most users will not even realize the flag exists. Regards, Peter. From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 11:41:15 2014 Received: (at 16847) by debbugs.gnu.org; 24 Feb 2014 16:41:15 +0000 Received: from localhost ([127.0.0.1]:38021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHyag-0005cs-Vs for submit@debbugs.gnu.org; Mon, 24 Feb 2014 11:41:15 -0500 Received: from rrcs-67-78-168-186.se.biz.rr.com ([67.78.168.186]:57958 helo=iriserv.iradimed.com ident=hidden-user) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHyae-0005ch-Vp for 16847@debbugs.gnu.org; Mon, 24 Feb 2014 11:41:13 -0500 Received: by iriserv.iradimed.com (Postfix, from userid 1000) id 873B756B01; Mon, 24 Feb 2014 11:41:11 -0500 (EST) From: Phillip Susi To: 16847@debbugs.gnu.org Subject: [PATCH] Fix help text for disk_{set,toggle} Date: Mon, 24 Feb 2014 11:41:11 -0500 Message-Id: <1393260071-13860-2-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1393260071-13860-1-git-send-email-psusi@ubuntu.com> References: <1393260071-13860-1-git-send-email-psusi@ubuntu.com> In-Reply-To: <530904E9.6030900@aon.at> References: <530904E9.6030900@aon.at> X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16847 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) Fix the help text to show *disk* flags instead of partition flags. Signed-off-by: Phillip Susi --- NEWS | 4 ++++ parted/parted.c | 23 +++++++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 935fa33..40ce370 100644 --- a/NEWS +++ b/NEWS @@ -12,6 +12,10 @@ GNU parted NEWS -*- outline -*- boot partition type. ** Bug Fixes + + Fix help text for disk_{set,toggle} to show *disk* flags instead + of partition flags. + Fix gpt to correctly handle non ASCII charcters in partition names If a drive was 100 times an even multiple of two, sizes specified as diff --git a/parted/parted.c b/parted/parted.c index b20d432..a7d9363 100644 --- a/parted/parted.c +++ b/parted/parted.c @@ -144,6 +144,7 @@ static const char* number_msg = N_( static const char* label_type_msg_start = N_("LABEL-TYPE is one of: "); static const char* flag_msg_start = N_("FLAG is one of: "); +static const char* disk_flag_msg_start = N_("FLAG is one of: "); static const char* unit_msg_start = N_("UNIT is one of: "); static const char* min_or_opt_msg = N_("desired alignment: minimum or optimal"); static const char* part_type_msg = N_("PART-TYPE is one of: primary, logical, " @@ -167,6 +168,7 @@ static const char* copyright_msg = N_( static char* label_type_msg; static char* flag_msg; +static char* disk_flag_msg; static char* unit_msg; static char* mkpart_fs_type_msg; @@ -1710,6 +1712,7 @@ _init_messages () PedFileSystemAlias* fs_alias; PedDiskType* disk_type; PedPartitionFlag part_flag; + PedDiskFlag disk_flag; PedUnit unit; /* flags */ @@ -1728,6 +1731,22 @@ _init_messages () flag_msg = str_list_convert (list); str_list_destroy (list); +/* disk flags */ + first = 1; + list = str_list_create (_(disk_flag_msg_start), NULL); + for (disk_flag = ped_disk_flag_next (0); disk_flag; + disk_flag = ped_disk_flag_next (disk_flag)) { + if (first) + first = 0; + else + str_list_append (list, ", "); + str_list_append (list, + _(ped_disk_flag_get_name (disk_flag))); + } + str_list_append (list, "\n"); + + disk_flag_msg = str_list_convert (list); + str_list_destroy (list); /* units */ first = 1; @@ -1912,7 +1931,7 @@ command_register (commands, command_create ( str_list_create ( _("disk_set FLAG STATE change the FLAG on selected device"), NULL), - str_list_create (flag_msg, _(state_msg), NULL), 1)); + str_list_create (disk_flag_msg, _(state_msg), NULL), 1)); command_register (commands, command_create ( str_list_create_unique ("disk_toggle", _("disk_toggle"), NULL), @@ -1921,7 +1940,7 @@ command_register (commands, command_create ( _("disk_toggle [FLAG] toggle the state of FLAG on " "selected device"), NULL), - str_list_create (flag_msg, NULL), 1)); + str_list_create (disk_flag_msg, NULL), 1)); command_register (commands, command_create ( str_list_create_unique ("set", _("set"), NULL), -- 1.8.3.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 11:41:20 2014 Received: (at 16847) by debbugs.gnu.org; 24 Feb 2014 16:41:20 +0000 Received: from localhost ([127.0.0.1]:38024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHyal-0005dE-Nc for submit@debbugs.gnu.org; Mon, 24 Feb 2014 11:41:19 -0500 Received: from rrcs-67-78-168-186.se.biz.rr.com ([67.78.168.186]:57959 helo=iriserv.iradimed.com ident=hidden-user) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHyaj-0005cg-Ry for 16847@debbugs.gnu.org; Mon, 24 Feb 2014 11:41:18 -0500 Received: by iriserv.iradimed.com (Postfix, from userid 1000) id 63C4256AD3; Mon, 24 Feb 2014 11:41:11 -0500 (EST) From: Phillip Susi To: 16847@debbugs.gnu.org Subject: [PATCH] Fix help text Date: Mon, 24 Feb 2014 11:41:10 -0500 Message-Id: <1393260071-13860-1-git-send-email-psusi@ubuntu.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <530904E9.6030900@aon.at> References: <530904E9.6030900@aon.at> X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16847 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/) Thanks for the report. It was missing the flag because it was listing the wrong flags entirely. It was showing the partition flags instead of the disk flags. This patch fixes it. Phillip Susi (1): Fix help text for disk_{set,toggle} NEWS | 4 ++++ parted/parted.c | 23 +++++++++++++++++++++-- 2 files changed, 25 insertions(+), 2 deletions(-) -- 1.8.3.2 From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 02 23:19:08 2014 Received: (at 16847-done) by debbugs.gnu.org; 3 Mar 2014 04:19:08 +0000 Received: from localhost ([127.0.0.1]:48404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKKLL-0000jo-QZ for submit@debbugs.gnu.org; Sun, 02 Mar 2014 23:19:08 -0500 Received: from cdptpa-omtalb.mail.rr.com ([75.180.132.120]:62727) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WKKLJ-0000jg-TQ for 16847-done@debbugs.gnu.org; Sun, 02 Mar 2014 23:19:06 -0500 X-Authority-Analysis: v=2.0 cv=H69ZMpki c=1 sm=0 a=S/gQ7PeTrZbCJAhh99lbaw==:17 a=cs1xLa0W9aIA:10 a=qMNFktKpUkIA:10 a=S1A5HrydsesA:10 a=ossw24rp0ecA:10 a=8nJEP1OIZ-IA:10 a=fxJcL_dCAAAA:8 a=KGjhK52YXX0A:10 a=QfKxxUxMAAAA:8 a=cue9MDvHm-VqHLa50v4A:9 a=wPNLvfGTeEIA:10 a=2eKvNQJKnqYA:10 a=S/gQ7PeTrZbCJAhh99lbaw==:117 X-Cloudmark-Score: 0 X-Authenticated-User: X-Originating-IP: 72.238.67.160 Received: from [72.238.67.160] ([72.238.67.160:60150] helo=[192.168.1.101]) by cdptpa-oedge04.mail.rr.com (envelope-from ) (ecelerity 2.2.3.46 r()) with ESMTP id 18/A0-11872-8B204135; Mon, 03 Mar 2014 04:19:04 +0000 Message-ID: <531402B9.1010201@ubuntu.com> Date: Sun, 02 Mar 2014 23:19:05 -0500 From: Phillip Susi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: 16847-done@debbugs.gnu.org Subject: Re: bug#16847: [PATCH] Fix help text for disk_{set,toggle} References: <1393260071-13860-1-git-send-email-psusi@ubuntu.com> <1393260071-13860-2-git-send-email-psusi@ubuntu.com> In-Reply-To: <1393260071-13860-2-git-send-email-psusi@ubuntu.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16847-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 02/24/2014 11:41 AM, Phillip Susi wrote: > Fix the help text to show *disk* flags instead of partition flags. > > Signed-off-by: Phillip Susi --- NEWS > | 4 ++++ parted/parted.c | 23 +++++++++++++++++++++-- 2 files > changed, 25 insertions(+), 2 deletions(-) I've taken the liberty of pushing this patch without waiting for review, given how trivial it is. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.14 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCgAGBQJTFAK5AAoJEI5FoCIzSKrwklwIAJkzE+dJIObcNN3QNc8q4u9U TO3ao9zDv0Rbz/P1jIomcWqKCWFmlxKEdhxFlFF+CE+fll1BoIHs9oRDgp9z5tO+ TJtcDErgFnB49j1VNlD4gNzl7yxe+35e1MWfwfMtfQbXBgIRI4JsqX2KlL8Vn51t 7qSpMZsghQ5bZrLpw6CJIcEY0/P0AX6w6ZFnmthf0yw28k8+JxMQQngKZ5Tvr9SY nii4QYJLZCckMoZyEC0KU3SL+YUxTU/Vvf75WwSBhN+TiP7saEd0i8VyaFgcSVXd 0iiURYfnG6k+LG8H45j5LutQsHJ5qHxhhNbm4hDCsQlnEhOIH3Km8JXLnk0dCdI= =PLyL -----END PGP SIGNATURE----- From unknown Fri Jun 20 07:14:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 31 Mar 2014 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator