GNU bug report logs - #16847
parted 3.1 help texts are missing flag pmbr_boot

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16847 in the body.
You can then email your comments to 16847 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Peter Klotz <peter.klotz99 <at> gmail.com>
To: bug-parted <at> gnu.org
Subject: parted 3.1 help texts are missing flag pmbr_boot
Date: Sat, 22 Feb 2014 21:13:29 +0100

Neither "help disk_set" nor "help disk_toggle" in parted 3.1 mentions 
flag "pmbr_boot" to set the protective MBR's boot flag. However setting 
the flag using this options works fine.

In my opinion it should be added since otherwise most users will not 
even realize the flag exists.

Regards, Peter.

Message #8 received at 16847 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 16847 <at> debbugs.gnu.org
Subject: [PATCH] Fix help text for disk_{set,toggle}
Date: Mon, 24 Feb 2014 11:41:11 -0500

Fix the help text to show *disk* flags instead of partition flags.

Signed-off-by: Phillip Susi <psusi <at> ubuntu.com>
---
 NEWS            |  4 ++++
 parted/parted.c | 23 +++++++++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

diff --git a/NEWS b/NEWS
index 935fa33..40ce370 100644
--- a/NEWS
+++ b/NEWS
@@ -12,6 +12,10 @@ GNU parted NEWS                                    -*- outline -*-
   boot partition type.
 
 ** Bug Fixes
+
+  Fix help text for disk_{set,toggle} to show *disk* flags instead
+  of partition flags.
+
   Fix gpt to correctly handle non ASCII charcters in partition names
 
   If a drive was 100 times an even multiple of two, sizes specified as
diff --git a/parted/parted.c b/parted/parted.c
index b20d432..a7d9363 100644
--- a/parted/parted.c
+++ b/parted/parted.c
@@ -144,6 +144,7 @@ static const char* number_msg = N_(
 
 static const char* label_type_msg_start = N_("LABEL-TYPE is one of: ");
 static const char* flag_msg_start =   N_("FLAG is one of: ");
+static const char* disk_flag_msg_start =   N_("FLAG is one of: ");
 static const char* unit_msg_start =   N_("UNIT is one of: ");
 static const char* min_or_opt_msg = N_("desired alignment: minimum or optimal");
 static const char* part_type_msg =    N_("PART-TYPE is one of: primary, logical, "
@@ -167,6 +168,7 @@ static const char* copyright_msg = N_(
 
 static char* label_type_msg;
 static char* flag_msg;
+static char* disk_flag_msg;
 static char* unit_msg;
 
 static char* mkpart_fs_type_msg;
@@ -1710,6 +1712,7 @@ _init_messages ()
         PedFileSystemAlias*     fs_alias;
         PedDiskType*            disk_type;
         PedPartitionFlag        part_flag;
+        PedDiskFlag             disk_flag;
         PedUnit                 unit;
 
 /* flags */
@@ -1728,6 +1731,22 @@ _init_messages ()
 
         flag_msg = str_list_convert (list);
         str_list_destroy (list);
+/* disk flags */
+        first = 1;
+        list = str_list_create (_(disk_flag_msg_start), NULL);
+        for (disk_flag = ped_disk_flag_next (0); disk_flag;
+                        disk_flag = ped_disk_flag_next (disk_flag)) {
+                if (first)
+                        first = 0;
+                else
+                        str_list_append (list, ", ");
+                str_list_append (list,
+                                 _(ped_disk_flag_get_name (disk_flag)));
+        }
+        str_list_append (list, "\n");
+
+        disk_flag_msg = str_list_convert (list);
+        str_list_destroy (list);
 
 /* units */
         first = 1;
@@ -1912,7 +1931,7 @@ command_register (commands, command_create (
         str_list_create (
 _("disk_set FLAG STATE                      change the FLAG on selected device"),
 NULL),
-        str_list_create (flag_msg, _(state_msg), NULL), 1));
+        str_list_create (disk_flag_msg, _(state_msg), NULL), 1));
 
 command_register (commands, command_create (
         str_list_create_unique ("disk_toggle", _("disk_toggle"), NULL),
@@ -1921,7 +1940,7 @@ command_register (commands, command_create (
 _("disk_toggle [FLAG]                       toggle the state of FLAG on "
 "selected device"),
 NULL),
-        str_list_create (flag_msg, NULL), 1));
+        str_list_create (disk_flag_msg, NULL), 1));
 
 command_register (commands, command_create (
 		str_list_create_unique ("set", _("set"), NULL),
-- 
1.8.3.2

Message #11 received at 16847 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 16847 <at> debbugs.gnu.org
Subject: [PATCH] Fix help text
Date: Mon, 24 Feb 2014 11:41:10 -0500

Thanks for the report.  It was missing the flag because it was listing
the wrong flags entirely.  It was showing the partition flags instead
of the disk flags.  This patch fixes it.

Phillip Susi (1):
  Fix help text for disk_{set,toggle}

 NEWS            |  4 ++++
 parted/parted.c | 23 +++++++++++++++++++++--
 2 files changed, 25 insertions(+), 2 deletions(-)

-- 
1.8.3.2

Message #16 received at 16847-done <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 16847-done <at> debbugs.gnu.org
Subject: Re: bug#16847: [PATCH] Fix help text for disk_{set,toggle}
Date: Sun, 02 Mar 2014 23:19:05 -0500

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 02/24/2014 11:41 AM, Phillip Susi wrote:
> Fix the help text to show *disk* flags instead of partition flags.
> 
> Signed-off-by: Phillip Susi <psusi <at> ubuntu.com> --- NEWS
> |  4 ++++ parted/parted.c | 23 +++++++++++++++++++++-- 2 files
> changed, 25 insertions(+), 2 deletions(-)

I've taken the liberty of pushing this patch without waiting for
review, given how trivial it is.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJTFAK5AAoJEI5FoCIzSKrwklwIAJkzE+dJIObcNN3QNc8q4u9U
TO3ao9zDv0Rbz/P1jIomcWqKCWFmlxKEdhxFlFF+CE+fll1BoIHs9oRDgp9z5tO+
TJtcDErgFnB49j1VNlD4gNzl7yxe+35e1MWfwfMtfQbXBgIRI4JsqX2KlL8Vn51t
7qSpMZsghQ5bZrLpw6CJIcEY0/P0AX6w6ZFnmthf0yw28k8+JxMQQngKZ5Tvr9SY
nii4QYJLZCckMoZyEC0KU3SL+YUxTU/Vvf75WwSBhN+TiP7saEd0i8VyaFgcSVXd
0iiURYfnG6k+LG8H45j5LutQsHJ5qHxhhNbm4hDCsQlnEhOIH3Km8JXLnk0dCdI=
=PLyL
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.