From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Darshit Shah Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Sat, 22 Feb 2014 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: 16843@debbugs.gnu.org X-Debbugs-Original-To: bug-automake@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13930852022435 (code B ref -1); Sat, 22 Feb 2014 16:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Feb 2014 16:06:42 +0000 Received: from localhost ([127.0.0.1]:35837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHF69-0000dB-71 for submit@debbugs.gnu.org; Sat, 22 Feb 2014 11:06:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WH8TO-0003XK-Sk for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WH8TI-0003hA-0P for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID,WEIRD_PORT autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TH-0003gz-U8 for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TG-0001EM-IU for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WH8TD-0003fd-7f for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:06 -0500 Received: from mail-vc0-x235.google.com ([2607:f8b0:400c:c03::235]:37438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TD-0003fS-1k for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:03 -0500 Received: by mail-vc0-f181.google.com with SMTP id lg15so544581vcb.40 for ; Sat, 22 Feb 2014 01:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=sff5SJBbY1iTAc4kH48TsqjFV0Q/43s/Mhq6W1RKBG8=; b=KA+vJAM/0ydNptJoW5nxih8Ui6mkMC6baS9WYNg+9ABFHrIDb9/BRoYQeJX3I/QsvM 7R/vU/KAYrQUCqguVsHKDdEGr9WGlilI/HYlgCQIGIcxzvQRgEwEXfmt31RQE84K+p+o Sh6EIdphQfeZvOf46AfwZg1Olzv10ZE8yTRDuQk5c6I7RJkWPojg4emV+xn4ubLEJYOl YNvJ051EPi0tK3iWOQhKUGa8eYeYWXQgq+q+BgEDc4Dhf/hOyF12zV84RJpd1k9mJw4q qADcI3NeqSXH7WNz/VjP6+cuFTT0k5QBuxqFvYsUaAQrTq3SSXuJrR8ociGca8Qay183 wrSQ== X-Received: by 10.220.53.66 with SMTP id l2mr7418516vcg.33.1393059722383; Sat, 22 Feb 2014 01:02:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.186.167 with HTTP; Sat, 22 Feb 2014 01:01:21 -0800 (PST) From: Darshit Shah Date: Sat, 22 Feb 2014 10:01:21 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a11c2b8dae7564c04f2fafd38 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Mailman-Approved-At: Sat, 22 Feb 2014 11:06:37 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11c2b8dae7564c04f2fafd38 Content-Type: text/plain; charset=ISO-8859-1 automake --version: 1.14.1 autoconf --version: 2.69 The error occured when attempting to run the test suite GNU Wget's git source. `make` works correctly, but `make check` happens to fail with the following output: if test -d ./.git \ && git --version >/dev/null 2>&1; then \ cd . && \ git submodule --quiet foreach \ test '"$(git rev-parse "$sha1")"' \ = '"$(git merge-base origin "$sha1")"' \ || { echo 'maint.mk: found non-public submodule commit' >&2; \ exit 1; }; \ else \ : ; \ fi Stopping at 'gnulib'; script returned non-zero status. maint.mk: found non-public submodule commit maint.mk:1394: recipe for target 'public-submodule-commit' failed make: *** [public-submodule-commit] Error 1 In the repository, gnulib is used as a submodule. Running: $ git submodule foreach echo $name, $path, $sha1 returns an empty string which implies that git is unable to see the submodules correctly. I bisected the git source to find the commit causing the problems. The following is the commit message: commit 1c4fb136dbad762c9c4350ee79c3474ae8037587 Author: Anders Kaseorg Date: Fri Sep 27 06:23:55 2013 -0400 submodule foreach: skip eval for more than one argument 'eval "$@"' creates an extra layer of shell interpretation, which is probably not expected by a user who passes multiple arguments to git submodule foreach: $ git grep "'" [searches for single quotes] $ git submodule foreach git grep "'" Entering '[submodule]' /usr/lib/git-core/git-submodule: 1: eval: Syntax error: Unterminated quoted string Stopping at '[submodule]'; script returned non-zero status. To fix this, if the user passes more than one argument, execute "$@" directly instead of passing it to eval. Examples: * Typical usage when adding an extra level of quoting is to pass a single argument representing the entire command to be passed to the shell. This doesn't change that. * One can imagine someone feeding untrusted input as an argument: git submodule foreach git grep "$variable" That currently results in a nonobvious shell code injection vulnerability. Executing the command named by the arguments directly, as in this patch, fixes it. Signed-off-by: Anders Kaseorg Acked-by: Johan Herland Signed-off-by: Jonathan Nieder Hence, this seems to me as a feature, not a bug in Git. Maybe, automake needs to fix its scripts accordingly? Because the issue with `make check` was introduced through this specific commit. Do let me know if I can provide any more help. Also, I am not sunscribed to this mailing list, hence, please ensure to leave my email in the CC list. -- Thanking You, Darshit Shah --001a11c2b8dae7564c04f2fafd38 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
automake --version: 1.1= 4.1
autoconf --version: 2.69

The error occured when a= ttempting to run the test suite GNU Wget's git source.
`make` = works correctly, but `make check` happens to fail with the following output= :

if test -d ./.git=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0=A0=A0 && = git --version >/dev/null 2>&1; then=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
=A0 cd . &&=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0 git submodule --quiet foreach= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0 test '"$(git rev-parse "$sha1")"= 9;=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0 =3D= '"$(git merge-base origin "$sha1")"'=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0 || { echo &= #39;maint.mk: found non-public submodule co= mmit' >&2;=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0=A0=A0=A0 exit 1; };=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 \
else=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0 : ;=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
fi
Stopping at 'gnulib'; script retur= ned non-zero status.
maint.mk: found non-public submodule commit=
maint.mk:1394: recipe for target &= #39;public-submodule-commit' failed
make: *** [public-submodule-comm= it] Error 1


In the repository, gnulib is used as a submodule. Running:
$ git submodule foreach echo $name, $path, $sha1
returns an= empty string which implies that git is unable to see the submodules correc= tly.

I bisected the git source to find the commit causing the problems= . The following is the commit message:

commit 1c= 4fb136dbad762c9c4350ee79c3474ae8037587
Author: Anders Kaseorg <andersk@MIT.EDU>
Date:=A0=A0 Fri Sep 27 06:23:55 2013 -0400

=A0=A0=A0 submodule forea= ch: skip eval for more than one argument
=A0=A0=A0
=A0=A0=A0 'ev= al "$@"' creates an extra layer of shell interpretation, whic= h is
=A0=A0=A0 probably not expected by a user who passes multiple argum= ents to git
=A0=A0=A0 submodule foreach:
=A0=A0=A0
=A0=A0=A0=A0 $ git grep "= ;'"
=A0=A0=A0=A0 [searches for single quotes]
=A0=A0=A0=A0 $= git submodule foreach git grep "'"
=A0=A0=A0=A0 Entering = '[submodule]'
=A0=A0=A0=A0 /usr/lib/git-core/git-submodule: 1: e= val: Syntax error: Unterminated quoted string
=A0=A0=A0=A0 Stopping at '[submodule]'; script returned non-zero st= atus.
=A0=A0=A0
=A0=A0=A0 To fix this, if the user passes more than = one argument, execute "$@"
=A0=A0=A0 directly instead of passi= ng it to eval.
=A0=A0=A0
=A0=A0=A0 Examples:
=A0=A0=A0
=A0=A0=A0=A0 * Typical usage when addi= ng an extra level of quoting is to pass a
=A0=A0=A0=A0=A0=A0 single argu= ment representing the entire command to be passed to the
=A0=A0=A0=A0=A0= =A0 shell.=A0 This doesn't change that.
=A0=A0=A0
=A0=A0=A0=A0 * One can imagine someone feeding untrusted inpu= t as an argument:
=A0=A0=A0
=A0=A0=A0=A0=A0=A0=A0 git submodule fore= ach git grep "$variable"
=A0=A0=A0
=A0=A0=A0=A0=A0=A0 That= currently results in a nonobvious shell code injection
=A0=A0=A0=A0=A0=A0 vulnerability.=A0 Executing the command named by the arg= uments
=A0=A0=A0=A0=A0=A0 directly, as in this patch, fixes it.
=A0= =A0=A0
=A0=A0=A0 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
=A0=A0=A0 Acked-by: Johan Herland <= johan@herland.net>
=A0=A0=A0 Signed-off-by: Jonathan Nieder <<= a href=3D"mailto:jrnieder@gmail.com">jrnieder@gmail.com>


=
Hence, this seems to me as a feature, not a bug in Git. Maybe, automake nee= ds to fix its scripts accordingly? Because the issue with `make check` was = introduced through this specific commit.

Do let me know if I can provide any more help.
Also, I am not sunscribed to this mailing list, hence, please ensure to le= ave my email in the CC list.

--
Thanking You,
Darshit Shah

--001a11c2b8dae7564c04f2fafd38-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Darshit Shah , 16843@debbugs.gnu.org, Bug-gnulib Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.13932506733329 (code B ref 16843); Mon, 24 Feb 2014 14:05:02 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 14:04:33 +0000 Received: from localhost ([127.0.0.1]:37501 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHw93-0000rc-Eu for submit@debbugs.gnu.org; Mon, 24 Feb 2014 09:04:33 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61764) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHw90-0000rM-JX for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 09:04:32 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OE4MOc002201 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 09:04:23 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1OE4Jtd014588; Mon, 24 Feb 2014 09:04:20 -0500 Message-ID: <530B5163.7030507@redhat.com> Date: Mon, 24 Feb 2014 07:04:19 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <530B507E.7090902@redhat.com> In-Reply-To: <530B507E.7090902@redhat.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="8Mb8n0o8UhCh6qPpQUwoUq8ooBwDpm4DD" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8Mb8n0o8UhCh6qPpQUwoUq8ooBwDpm4DD Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/24/2014 07:00 AM, Eric Blake wrote: >=20 > Based on the test that is failing, can you please show the output of: >=20 > git submodule --quiet foreach echo 'a b' '"c d"' >=20 > On my version (1.8.5.3), I get 'a b c d' (that is, echo saw three > arguments rather than 2, where only my 'c d' argument survived because= > it was double-quoted). I'm guessing your version preserves extra > quotes, because it is not being passed through a layer of shell > interpretation? What about: git submodule --quiet foreach 'echo a b "c d" "$sha1"' That is, does presenting the entire command as a single argument to git still manage to interpolate the shell variable and preserve the double space between c and d while doing word splitting between a and b? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --8Mb8n0o8UhCh6qPpQUwoUq8ooBwDpm4DD Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC1FjAAoJEKeha0olJ0NqQEQH/R4xcAknzW9uwfipkbFSPfee RVn5b0uz2S/njIltqmFkniTbRDn5Xn8udBhjv+s9Stu/vT7QbvNldgOlboefvSIL tojwH5GC9++PPGzcEE2WveFO6Cw1SFkwQQTc7zkP8EYOkgI/j7BhtjiA94YDAHYs aux9ZmmVvu7dIgmWfzVezR2TypFYDHmbea5WmC34+Z3SnGGeTctfBbusoQqSw8PJ JW0nrIVD1Mrlu0scju7WsGsgu8QRDYTg2KDNUSbmSXaiCiA48KKE8Xv0g1ShJm0o UW3bddjF3cAy6o1rOMH40xrnhEPp+UZUS1aBZwQT1uIjUSdcCoOXEuSWSS86bM4= =nDHt -----END PGP SIGNATURE----- --8Mb8n0o8UhCh6qPpQUwoUq8ooBwDpm4DD-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 14:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Darshit Shah , 16843@debbugs.gnu.org, Bug-gnulib Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.13932508243634 (code B ref 16843); Mon, 24 Feb 2014 14:08:02 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 14:07:04 +0000 Received: from localhost ([127.0.0.1]:37506 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHwBQ-0000w8-1J for submit@debbugs.gnu.org; Mon, 24 Feb 2014 09:07:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50654) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHwBN-0000vy-KD for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 09:06:58 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OE6r5w000365 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 09:06:55 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1OE0Vr5017670; Mon, 24 Feb 2014 09:00:31 -0500 Message-ID: <530B507E.7090902@redhat.com> Date: Mon, 24 Feb 2014 07:00:30 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="geRhrBpVSSXeEN5hkiaCGGvfRc0rfniPI" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --geRhrBpVSSXeEN5hkiaCGGvfRc0rfniPI Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable thanks [adding gnulib] On 02/22/2014 02:01 AM, Darshit Shah wrote: > automake --version: 1.14.1 > autoconf --version: 2.69 >=20 > The error occured when attempting to run the test suite GNU Wget's git > source. > `make` works correctly, but `make check` happens to fail with the follo= wing > output: >=20 > if test -d ./.git \ > && git --version >/dev/null 2>&1; then \ > cd . && \ > git submodule --quiet foreach \ > test '"$(git rev-parse "$sha1")"' \ > =3D '"$(git merge-base origin "$sha1")"' \ > || { echo 'maint.mk: found non-public submodule commit' >&2; = \ > exit 1; }; \ > else \ > : ; \ > fi > Stopping at 'gnulib'; script returned non-zero status. > maint.mk: found non-public submodule commit > maint.mk:1394: recipe for target 'public-submodule-commit' failed > make: *** [public-submodule-commit] Error 1 This rule comes from upstream gnulib, so it will break on more than just automake as more people start upgrading to newer git. >=20 >=20 > In the repository, gnulib is used as a submodule. Running: > $ git submodule foreach echo $name, $path, $sha1 > returns an empty string which implies that git is unable to see the > submodules correctly. >=20 > I bisected the git source to find the commit causing the problems. The > following is the commit message: >=20 > commit 1c4fb136dbad762c9c4350ee79c3474ae8037587 >=20 > To fix this, if the user passes more than one argument, execute "$@= " > directly instead of passing it to eval. >=20 >=20 > Hence, this seems to me as a feature, not a bug in Git. Maybe, automake= > needs to fix its scripts accordingly? Because the issue with `make chec= k` > was introduced through this specific commit. Yes, we need to update the gnulib rule to behave nicely on both old and new versions of git. Based on the test that is failing, can you please show the output of: git submodule --quiet foreach echo 'a b' '"c d"' On my version (1.8.5.3), I get 'a b c d' (that is, echo saw three arguments rather than 2, where only my 'c d' argument survived because it was double-quoted). I'm guessing your version preserves extra quotes, because it is not being passed through a layer of shell interpretation? Have you reported this regression to the git folks? >=20 > Do let me know if I can provide any more help. > Also, I am not sunscribed to this mailing list, hence, please ensure to= > leave my email in the CC list. Yes, reply-to-all is list policy (both for automake and for gnulib). --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --geRhrBpVSSXeEN5hkiaCGGvfRc0rfniPI Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC1B/AAoJEKeha0olJ0NqXB0H/2DNN4PtZJKJJpyU/XbvHAP/ J/K2hx8YsRfxEOUswlRfrJ7rQFlblJB76BdJBMVL1UjbmCGjZ3X5BautvcYOrUVz KFhaReK9Biu9rnFkHN2izyD/C6F9uEzgDrZ37G8H0puemjMCVsQkRGGTFoBKMM9y M9CL/e/pJ9gMulGZw14gwzbg1ZjZ76XaguyBVrwhYrv07NL+ZoDGDCBTxCLsZpks wzTXULRjQuPuXluZbJ/m/T+nKhP6epmvA6wpOZMmflaGPp9BMrwj6WUp2miw7LYM LnSsxjuP2JWLBEgNWWfjyJrIMUZsEPqJOwWjF88HK+FnQq5Rm0Ukj+BQwsSb6gs= =7pYI -----END PGP SIGNATURE----- --geRhrBpVSSXeEN5hkiaCGGvfRc0rfniPI-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Darshit Shah Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 19:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Eric Blake Cc: Bug-gnulib , 16843@debbugs.gnu.org Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.13932707229262 (code B ref 16843); Mon, 24 Feb 2014 19:39:02 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 19:38:42 +0000 Received: from localhost ([127.0.0.1]:38172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1MP-0002PJ-AQ for submit@debbugs.gnu.org; Mon, 24 Feb 2014 14:38:41 -0500 Received: from mail-vc0-f180.google.com ([209.85.220.180]:42926) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1MG-0002Oo-PP for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 14:38:33 -0500 Received: by mail-vc0-f180.google.com with SMTP id ks9so6234732vcb.11 for <16843@debbugs.gnu.org>; Mon, 24 Feb 2014 11:38:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=yNuAQMoXORkrLE12bsSNBD472QKqMS3fHT2N8rHrE4Q=; b=z/rOOQBB/KjfUXcCpw9WtF/IK4x2nNm1mIG/ARpDVr/buQ4Gk1RdMITq8fjF1S8APJ jdLvVoid1JZgReMzKmDK8po08tnH29dbtxU4LvnyZ4V64AtlUcx0LzkaDozch4+LQzw3 8x7kJ05n/wp3J8abuepX7QQN4qNkrLIlrgRxEgRVWjCPOrX/ei6cbEb1xHZrVYLCpo6w cArzfqrE/a5QhhQpI+hoTHGq1RDGlvlG57AZT1q7ZnLvs/GH82ZeigCYiPMr6S8MmW0J iYeJ+JshrFZZflGtSjmXAugZTMXCCf5K3nW0+++NKUbqL4Lav+psj779f1k67o1RFTQl ustg== X-Received: by 10.52.230.105 with SMTP id sx9mr11735604vdc.10.1393270707068; Mon, 24 Feb 2014 11:38:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.186.167 with HTTP; Mon, 24 Feb 2014 11:37:46 -0800 (PST) In-Reply-To: <530B5163.7030507@redhat.com> References: <530B507E.7090902@redhat.com> <530B5163.7030507@redhat.com> From: Darshit Shah Date: Mon, 24 Feb 2014 20:37:46 +0100 Message-ID: Content-Type: multipart/alternative; boundary=089e0111da1e92266604f32c1da3 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --089e0111da1e92266604f32c1da3 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Feb 24, 2014 at 3:04 PM, Eric Blake wrote: > On 02/24/2014 07:00 AM, Eric Blake wrote: > > > > > Based on the test that is failing, can you please show the output of: > > > > git submodule --quiet foreach echo 'a b' '"c d"' > > > > On my version (1.8.5.3), I get 'a b c d' (that is, echo saw three > > arguments rather than 2, where only my 'c d' argument survived because > > it was double-quoted). I'm guessing your version preserves extra > > quotes, because it is not being passed through a layer of shell > > interpretation? > > What about: > > git submodule --quiet foreach 'echo a b "c d" "$sha1"' > > That is, does presenting the entire command as a single argument to git > still manage to interpolate the shell variable and preserve the double > space between c and d while doing word splitting between a and b? > The first command: git submodule --quiet foreach echo 'a b' '"c d"' gives the output: a b "c d" Where there is a double space between a and b while c and d still retain their quotes. The second command: git submodule --quiet foreach 'echo a b "c d" "$sha1"' Gives the output: a b c d 0ac90c5a98030c998f3e1db3a0d7f19d4630b6b6 So, it does seem to do word splitting between a and b, while retaining the double space between c and d. > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org > > -- Thanking You, Darshit Shah --089e0111da1e92266604f32c1da3 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable



On Mon, Feb 24, 2014 at 3:04 PM, Eric Blake <<= a href=3D"mailto:eblake@redhat.com" target=3D"_blank">eblake@redhat.com= > wrote:
On 02/24/= 2014 07:00 AM, Eric Blake wrote:

>
> Based on the test that is failing, can you please show the output of:<= br> >
> =A0 git submodule --quiet foreach echo 'a =A0b' '"c = =A0d"'
>
> On my version (1.8.5.3), I get 'a b c =A0d' (that is, echo saw= three
> arguments rather than 2, where only my 'c =A0d' argument survi= ved because
> it was double-quoted). =A0I'm guessing your version preserves extr= a
> quotes, because it is not being passed through a layer of shell
> interpretation?

What about:

=A0 git submodule --quiet foreach 'echo a =A0b "c =A0d" "= ;$sha1"'

That is, does presenting the entire command as a single argument to git
still manage to interpolate the shell variable and preserve the double
space between c and d while doing word splitting between a and b?

The first command:
git submodule --quiet fore= ach echo 'a =A0b' '"c =A0d"'
gives = the output: a=A0 b "c=A0 d"
Where there is a double space between a and b while c and d stil= l retain their quotes.

The second command:
git submodu= le --quiet foreach 'echo a =A0b "c =A0d" "$sha1"= 9;

Gives the output:
a b c=A0 d 0ac90c5a98030c998f3e1db3a0d7= f19d4630b6b6
So, it does seem to do word splitting between a = and b, while retaining the double space between c and d.
=A0<= br>
--
Eric Blake =A0 eblake redhat com =A0 =A0+1-919-301-3266
Libvirt virtualization library http://libvirt.org




--
Thanking Yo= u,
Darshit Shah

--089e0111da1e92266604f32c1da3-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 19:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Darshit Shah Cc: Bug-gnulib , 16843@debbugs.gnu.org Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.139327159110916 (code B ref 16843); Mon, 24 Feb 2014 19:54:01 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 19:53:11 +0000 Received: from localhost ([127.0.0.1]:38177 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1aR-0002py-92 for submit@debbugs.gnu.org; Mon, 24 Feb 2014 14:53:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8292) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1aO-0002pe-3G for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 14:53:10 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OJr1KG014664 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 14:53:02 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1OJr1A2028708; Mon, 24 Feb 2014 14:53:01 -0500 Message-ID: <530BA31D.5010800@redhat.com> Date: Mon, 24 Feb 2014 12:53:01 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <530B507E.7090902@redhat.com> <530B5163.7030507@redhat.com> In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AeIRNnmH21HwmE0LcdF0tl3INOQHTidQk" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --AeIRNnmH21HwmE0LcdF0tl3INOQHTidQk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/24/2014 12:37 PM, Darshit Shah wrote: >>> Based on the test that is failing, can you please show the output of:= >>> >>> git submodule --quiet foreach echo 'a b' '"c d"' >> What about: >> >> git submodule --quiet foreach 'echo a b "c d" "$sha1"' >> >=20 > The first command: > git submodule --quiet foreach echo 'a b' '"c d"' > gives the output: a b "c d" Good, I was right - newer git is doing one less round of shell interpolation, so the second layer of quotes that we were adding for older git now show up as literal arguments in newer git. > Where there is a double space between a and b while c and d still retai= n > their quotes. >=20 > The second command: > git submodule --quiet foreach 'echo a b "c d" "$sha1"' >=20 > Gives the output: > a b c d 0ac90c5a98030c998f3e1db3a0d7f19d4630b6b6 Yay - you confirmed that the solution that works for both versions of git is to ensure that we provide exactly one argument to the foreach command, where that argument gets passed through the shell with identical results. I'll patch maint.mk shortly. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --AeIRNnmH21HwmE0LcdF0tl3INOQHTidQk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC6MdAAoJEKeha0olJ0NqYA4H/i/sFoGOBnqkXrJHvZhXRu3N zJEHK5sNPAX9xEIxpjlRLyYR4yDC9NBoomoBDYRUjmbB4Qna3t+IkuWi6NUMuxim tuNHPSQRqkvhzyxbtlq5g1QNqt0wZozD+kLauS/RgKMXnS85UyecaK7xNvB8Ajy4 YbrKx5M8kl9gD7y5y3hjarO/LX9Ifx3nxHR5q9YcTVKZiE7bStOaQK0HseBLUCLO j+soLoIXOEl14DFUz+QUB169dMKYWSymXeqBCKOynuSX7QK8iEIBj4EZfBoXIhES XkJgMnsXektvjH+N5YKHp/6taYwH9HGi1ORa1Yw5udH7gNs4OI8GZ+U+i4GF5V0= =Hf8O -----END PGP SIGNATURE----- --AeIRNnmH21HwmE0LcdF0tl3INOQHTidQk-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Eric Blake Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 20:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Darshit Shah Cc: Bug-gnulib , 16843@debbugs.gnu.org Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.139327235812345 (code B ref 16843); Mon, 24 Feb 2014 20:06:01 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 20:05:58 +0000 Received: from localhost ([127.0.0.1]:38187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1mo-0003D2-Ax for submit@debbugs.gnu.org; Mon, 24 Feb 2014 15:05:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:14198) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1ml-0003Co-1g for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 15:05:56 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OK5qOg025702 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 15:05:53 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s1OK5p3K004777; Mon, 24 Feb 2014 15:05:51 -0500 Message-ID: <530BA61E.5000700@redhat.com> Date: Mon, 24 Feb 2014 13:05:50 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <530B507E.7090902@redhat.com> <530B5163.7030507@redhat.com> <530BA31D.5010800@redhat.com> In-Reply-To: <530BA31D.5010800@redhat.com> X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="kpoAe66WDrRNmWSi9GMbMK1XO8nWpm28A" X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --kpoAe66WDrRNmWSi9GMbMK1XO8nWpm28A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/24/2014 12:53 PM, Eric Blake wrote: > Yay - you confirmed that the solution that works for both versions of > git is to ensure that we provide exactly one argument to the foreach > command, where that argument gets passed through the shell with > identical results. I'll patch maint.mk shortly. Actually, it turns out that the problem has already been fixed upstream: commit 7a0c729aacc3716a665ce3b0c8cb34843bdecc75 Author: Jim Meyering Date: Wed Jan 1 20:25:44 2014 -0800 maint: fix public-submodule-commit to work with newer git * top/maint.mk (public-submodule-commit): Remove excess quoting. We were over-quoting the test arguments, and somewhere prior to version 1.8.5.2.229, git stopped removing those excess quotes, which made the test fail, since the unexpanded strings would always differ; using GIT_TRACE=3D1 confirmed that the git merge-base command wasn't even being run. So all that remains now is for the package you were complaining about to upgrade to a newer version of gnulib that plays nicely with git 1.9 and newer. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --kpoAe66WDrRNmWSi9GMbMK1XO8nWpm28A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC6YeAAoJEKeha0olJ0Nq6D0IAIRyTxljQ4F+RTMdXLZDtfy7 cZ/4CfDuKHOgw8UqBzkAgLO9c91cmqwt2Gdrz88ebzDYFLhJ/WSrgiV7UkqPhfBg j/kYgUe2YjNA8g3tdQppNrRJN6W8moHcgpPMT3xBqsI/6nnCKC9AUv/EnTWmWjnA W2F5Y53oFmKwNGYZ4tsBk1GKu8gOne5gBLfRK1AYuWd3tAR+zMb/1fAGYtoFfaz8 UcDT/FrNZjHccL6qOolSHAQyXue/uG8ztHoUOtRAowKY44ywSbCCvOIGFrZN8FT2 rLBw50e/8X2j/FHyUOocdoZUsKVyDdAds+vYwecrs9bdgC7B1uArHo0Z3/MipVo= =GkhO -----END PGP SIGNATURE----- --kpoAe66WDrRNmWSi9GMbMK1XO8nWpm28A-- From unknown Tue Jun 17 01:39:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16843: Error caused due to regression in git Resent-From: Darshit Shah Original-Sender: "Debbugs-submit" Resent-CC: bug-automake@gnu.org Resent-Date: Mon, 24 Feb 2014 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16843 X-GNU-PR-Package: automake X-GNU-PR-Keywords: To: Eric Blake Cc: bug-wget , Bug-gnulib , 16843@debbugs.gnu.org Received: via spool by 16843-submit@debbugs.gnu.org id=B16843.139327261012853 (code B ref 16843); Mon, 24 Feb 2014 20:11:02 +0000 Received: (at 16843) by debbugs.gnu.org; 24 Feb 2014 20:10:10 +0000 Received: from localhost ([127.0.0.1]:38195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1qr-0003LE-Nb for submit@debbugs.gnu.org; Mon, 24 Feb 2014 15:10:10 -0500 Received: from mail-ve0-f178.google.com ([209.85.128.178]:45680) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1ql-0003KR-Tf for 16843@debbugs.gnu.org; Mon, 24 Feb 2014 15:10:07 -0500 Received: by mail-ve0-f178.google.com with SMTP id jy13so2902345veb.9 for <16843@debbugs.gnu.org>; Mon, 24 Feb 2014 12:09:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=qbX2iL/RqL4aYkipOpZVL/H8A7Twkehc9omVpysJIMM=; b=JEJcVCEaMddfB3HNIE2XccQL7zHwHs7onxdI5JEojSOv8479UttuwZa0tQHEOdJnAP 5kVDy0TuzL16hriNgqS/h1nOiOMGqmubzRbKPbgbNPeD7VHuR3bBL1dV8SXVG8GyU39k 9mWtlqLil7Vo7SGAY0urXBZSWL+kBOKQXj/u9nVVioHT4Q1Yphrv6/GOAtsVgOtaNDmJ ZWkWZfKNT5UcSGzgdb2JFiXAhi9uO2lvSebeVfsfQmsJi0lXuCRVHIZjRZXin7JalfHE NzR9HSnu6EjeT+LFGhqa7uiDO7Zr+vMCWpeWXzKJYrxZowGxKWSW/9LeFV8ltfhWOdcZ qkCg== X-Received: by 10.52.247.231 with SMTP id yh7mr11573477vdc.34.1393272598241; Mon, 24 Feb 2014 12:09:58 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.186.167 with HTTP; Mon, 24 Feb 2014 12:09:18 -0800 (PST) In-Reply-To: <530BA61E.5000700@redhat.com> References: <530B507E.7090902@redhat.com> <530B5163.7030507@redhat.com> <530BA31D.5010800@redhat.com> <530BA61E.5000700@redhat.com> From: Darshit Shah Date: Mon, 24 Feb 2014 21:09:18 +0100 Message-ID: Content-Type: multipart/alternative; boundary=001a1133c9aa4b2a7f04f32c8e32 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --001a1133c9aa4b2a7f04f32c8e32 Content-Type: text/plain; charset=ISO-8859-1 On Mon, Feb 24, 2014 at 9:05 PM, Eric Blake wrote: > On 02/24/2014 12:53 PM, Eric Blake wrote: > > Yay - you confirmed that the solution that works for both versions of > > git is to ensure that we provide exactly one argument to the foreach > > command, where that argument gets passed through the shell with > > identical results. I'll patch maint.mk shortly. > > Actually, it turns out that the problem has already been fixed upstream: > > commit 7a0c729aacc3716a665ce3b0c8cb34843bdecc75 > Author: Jim Meyering > Date: Wed Jan 1 20:25:44 2014 -0800 > > maint: fix public-submodule-commit to work with newer git > > * top/maint.mk (public-submodule-commit): Remove excess quoting. > We were over-quoting the test arguments, and somewhere prior to > version 1.8.5.2.229, git stopped removing those excess quotes, > which made the test fail, since the unexpanded strings would > always differ; using GIT_TRACE=1 confirmed that the git merge-base > command wasn't even being run. > > So all that remains now is for the package you were complaining about to > upgrade to a newer version of gnulib that plays nicely with git 1.9 and > newer. > > Thanks Eric! I'll notify them of the fact. -- Thanking You, Darshit Shah --001a1133c9aa4b2a7f04f32c8e32 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable



On Mon, Feb 24, 2014 at 9:05 PM, Eric Blake <<= a href=3D"mailto:eblake@redhat.com" target=3D"_blank">eblake@redhat.com= > wrote:
On 02/24/2014 12:53 PM, Eric= Blake wrote:
> Yay - you confirmed that the solution that works for both versions of<= br> > git is to ensure that we provide exactly one argument to the foreach > command, where that argument gets passed through the shell with
> identical results. =A0I'll patch maint.mk shortly.

Actually, it turns out that the problem has already been fixed upstre= am:

commit 7a0c729aacc3716a665ce3b0c8cb34843bdecc75
Author: Jim Meyering <meyering@fb.com= >
Date: =A0 Wed Jan 1 20:25:44 2014 -0800

=A0 =A0 maint: fix public-submodule-commit to work with newer git

=A0 =A0 * top/maint.mk (p= ublic-submodule-commit): Remove excess quoting.
=A0 =A0 We were over-quoting the test arguments, and somewhere prior to
=A0 =A0 version 1.8.5.2.229, git stopped removing those excess quotes,
=A0 =A0 which made the test fail, since the unexpanded strings would
=A0 =A0 always differ; using GIT_TRACE=3D1 confirmed that the git merge-bas= e
=A0 =A0 command wasn't even being run.

So all that remains now is for the package you were complaining about to upgrade to a newer version of gnulib that plays nicely with git 1.9 and
newer.

T= hanks Eric!

I'll notify them of the fact.


--
Thanking You,
Darshit Shah

--001a1133c9aa4b2a7f04f32c8e32-- From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 24 15:11:40 2014 Received: (at control) by debbugs.gnu.org; 24 Feb 2014 20:11:41 +0000 Received: from localhost ([127.0.0.1]:38201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1sK-0003OI-Dy for submit@debbugs.gnu.org; Mon, 24 Feb 2014 15:11:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1sH-0003O4-21; Mon, 24 Feb 2014 15:11:37 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OKBYMa010373 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 15:11:35 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1OKBYqM003917; Mon, 24 Feb 2014 15:11:34 -0500 Message-ID: <530BA776.1060007@redhat.com> Date: Mon, 24 Feb 2014 13:11:34 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Darshit Shah , 16843-done@debbugs.gnu.org Subject: Re: bug#16843: Error caused due to regression in git References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable tag 16843 notabug thanks On 02/22/2014 02:01 AM, Darshit Shah wrote: > automake --version: 1.14.1 > autoconf --version: 2.69 >=20 > The error occured when attempting to run the test suite GNU Wget's git > source. Then this bug should be filed against wget, not automake. I'm closing this bug in the automake tracker, as the fix is for wget to upgrade to a newer version of gnulib, and automake has no bearing on it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC6d2AAoJEKeha0olJ0Nquh4H/2LJsn3nM51lIyqLOzaUM6Qh UiIDf5smEkPA5o6fdZnHkG5Cs04qFUwfgUWcKm+xqueRKg58FygXNf/J5N5ydm9d hMTEFgb9oo/sB6bw3PWInpFjjAC12qvid6ohjKqinrFwNzSSygKhH7vj0VNfUKQj KBNFTzbIWRBD8RZxyO/OYpawcbInTuArzTzt+tLbfBlPWFle4ltQf5L9fWSVkZC/ V0ZL/lCY3NAR8uN+uVr17PlZZMWPPDX2RO4ylo3HIAqs5vEOtkpHu8ubJn3yvBx/ 7pEYA7CgwKVgHixB0UpCF7PyvUy8ZT9xVlAqW8zt6twaXxNpaRPhrOmAAxuiUoY= =6RZY -----END PGP SIGNATURE----- --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX-- From unknown Tue Jun 17 01:39:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Darshit Shah Subject: bug#16843: closed (Re: bug#16843: Error caused due to regression in git) Message-ID: References: <530BA776.1060007@redhat.com> X-Gnu-PR-Message: they-closed 16843 X-Gnu-PR-Package: automake X-Gnu-PR-Keywords: notabug Reply-To: 16843@debbugs.gnu.org Date: Mon, 24 Feb 2014 20:12:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1393272724-13107-1" This is a multi-part message in MIME format... ------------=_1393272724-13107-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16843: Error caused due to regression in git which was filed against the automake package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16843@debbugs.gnu.org. --=20 16843: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16843 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1393272724-13107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16843-done) by debbugs.gnu.org; 24 Feb 2014 20:11:40 +0000 Received: from localhost ([127.0.0.1]:38199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1sJ-0003OG-S1 for submit@debbugs.gnu.org; Mon, 24 Feb 2014 15:11:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:29952) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WI1sH-0003O4-21; Mon, 24 Feb 2014 15:11:37 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s1OKBYMa010373 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 24 Feb 2014 15:11:35 -0500 Received: from [10.3.113.118] (ovpn-113-118.phx2.redhat.com [10.3.113.118]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id s1OKBYqM003917; Mon, 24 Feb 2014 15:11:34 -0500 Message-ID: <530BA776.1060007@redhat.com> Date: Mon, 24 Feb 2014 13:11:34 -0700 From: Eric Blake Organization: Red Hat, Inc. User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Darshit Shah , 16843-done@debbugs.gnu.org Subject: Re: bug#16843: Error caused due to regression in git References: In-Reply-To: X-Enigmail-Version: 1.6 OpenPGP: url=http://people.redhat.com/eblake/eblake.gpg Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX" X-Scanned-By: MIMEDefang 2.67 on 10.5.11.12 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16843-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable tag 16843 notabug thanks On 02/22/2014 02:01 AM, Darshit Shah wrote: > automake --version: 1.14.1 > autoconf --version: 2.69 >=20 > The error occured when attempting to run the test suite GNU Wget's git > source. Then this bug should be filed against wget, not automake. I'm closing this bug in the automake tracker, as the fix is for wget to upgrade to a newer version of gnulib, and automake has no bearing on it. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTC6d2AAoJEKeha0olJ0Nquh4H/2LJsn3nM51lIyqLOzaUM6Qh UiIDf5smEkPA5o6fdZnHkG5Cs04qFUwfgUWcKm+xqueRKg58FygXNf/J5N5ydm9d hMTEFgb9oo/sB6bw3PWInpFjjAC12qvid6ohjKqinrFwNzSSygKhH7vj0VNfUKQj KBNFTzbIWRBD8RZxyO/OYpawcbInTuArzTzt+tLbfBlPWFle4ltQf5L9fWSVkZC/ V0ZL/lCY3NAR8uN+uVr17PlZZMWPPDX2RO4ylo3HIAqs5vEOtkpHu8ubJn3yvBx/ 7pEYA7CgwKVgHixB0UpCF7PyvUy8ZT9xVlAqW8zt6twaXxNpaRPhrOmAAxuiUoY= =6RZY -----END PGP SIGNATURE----- --pDDBlSo7CmUr4Hmp17f8Dv60m85bQmdiX-- ------------=_1393272724-13107-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Feb 2014 16:06:42 +0000 Received: from localhost ([127.0.0.1]:35837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WHF69-0000dB-71 for submit@debbugs.gnu.org; Sat, 22 Feb 2014 11:06:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:48890) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WH8TO-0003XK-Sk for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WH8TI-0003hA-0P for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID,WEIRD_PORT autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TH-0003gz-U8 for submit@debbugs.gnu.org; Sat, 22 Feb 2014 04:02:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TG-0001EM-IU for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WH8TD-0003fd-7f for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:06 -0500 Received: from mail-vc0-x235.google.com ([2607:f8b0:400c:c03::235]:37438) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WH8TD-0003fS-1k for bug-automake@gnu.org; Sat, 22 Feb 2014 04:02:03 -0500 Received: by mail-vc0-f181.google.com with SMTP id lg15so544581vcb.40 for ; Sat, 22 Feb 2014 01:02:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:from:date:message-id:subject:to:content-type; bh=sff5SJBbY1iTAc4kH48TsqjFV0Q/43s/Mhq6W1RKBG8=; b=KA+vJAM/0ydNptJoW5nxih8Ui6mkMC6baS9WYNg+9ABFHrIDb9/BRoYQeJX3I/QsvM 7R/vU/KAYrQUCqguVsHKDdEGr9WGlilI/HYlgCQIGIcxzvQRgEwEXfmt31RQE84K+p+o Sh6EIdphQfeZvOf46AfwZg1Olzv10ZE8yTRDuQk5c6I7RJkWPojg4emV+xn4ubLEJYOl YNvJ051EPi0tK3iWOQhKUGa8eYeYWXQgq+q+BgEDc4Dhf/hOyF12zV84RJpd1k9mJw4q qADcI3NeqSXH7WNz/VjP6+cuFTT0k5QBuxqFvYsUaAQrTq3SSXuJrR8ociGca8Qay183 wrSQ== X-Received: by 10.220.53.66 with SMTP id l2mr7418516vcg.33.1393059722383; Sat, 22 Feb 2014 01:02:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.58.186.167 with HTTP; Sat, 22 Feb 2014 01:01:21 -0800 (PST) From: Darshit Shah Date: Sat, 22 Feb 2014 10:01:21 +0100 Message-ID: Subject: Error caused due to regression in git To: bug-automake@gnu.org Content-Type: multipart/alternative; boundary=001a11c2b8dae7564c04f2fafd38 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 22 Feb 2014 11:06:37 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --001a11c2b8dae7564c04f2fafd38 Content-Type: text/plain; charset=ISO-8859-1 automake --version: 1.14.1 autoconf --version: 2.69 The error occured when attempting to run the test suite GNU Wget's git source. `make` works correctly, but `make check` happens to fail with the following output: if test -d ./.git \ && git --version >/dev/null 2>&1; then \ cd . && \ git submodule --quiet foreach \ test '"$(git rev-parse "$sha1")"' \ = '"$(git merge-base origin "$sha1")"' \ || { echo 'maint.mk: found non-public submodule commit' >&2; \ exit 1; }; \ else \ : ; \ fi Stopping at 'gnulib'; script returned non-zero status. maint.mk: found non-public submodule commit maint.mk:1394: recipe for target 'public-submodule-commit' failed make: *** [public-submodule-commit] Error 1 In the repository, gnulib is used as a submodule. Running: $ git submodule foreach echo $name, $path, $sha1 returns an empty string which implies that git is unable to see the submodules correctly. I bisected the git source to find the commit causing the problems. The following is the commit message: commit 1c4fb136dbad762c9c4350ee79c3474ae8037587 Author: Anders Kaseorg Date: Fri Sep 27 06:23:55 2013 -0400 submodule foreach: skip eval for more than one argument 'eval "$@"' creates an extra layer of shell interpretation, which is probably not expected by a user who passes multiple arguments to git submodule foreach: $ git grep "'" [searches for single quotes] $ git submodule foreach git grep "'" Entering '[submodule]' /usr/lib/git-core/git-submodule: 1: eval: Syntax error: Unterminated quoted string Stopping at '[submodule]'; script returned non-zero status. To fix this, if the user passes more than one argument, execute "$@" directly instead of passing it to eval. Examples: * Typical usage when adding an extra level of quoting is to pass a single argument representing the entire command to be passed to the shell. This doesn't change that. * One can imagine someone feeding untrusted input as an argument: git submodule foreach git grep "$variable" That currently results in a nonobvious shell code injection vulnerability. Executing the command named by the arguments directly, as in this patch, fixes it. Signed-off-by: Anders Kaseorg Acked-by: Johan Herland Signed-off-by: Jonathan Nieder Hence, this seems to me as a feature, not a bug in Git. Maybe, automake needs to fix its scripts accordingly? Because the issue with `make check` was introduced through this specific commit. Do let me know if I can provide any more help. Also, I am not sunscribed to this mailing list, hence, please ensure to leave my email in the CC list. -- Thanking You, Darshit Shah --001a11c2b8dae7564c04f2fafd38 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
automake --version: 1.1= 4.1
autoconf --version: 2.69

The error occured when a= ttempting to run the test suite GNU Wget's git source.
`make` = works correctly, but `make check` happens to fail with the following output= :

if test -d ./.git=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0=A0=A0 && = git --version >/dev/null 2>&1; then=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
=A0 cd . &&=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0 git submodule --quiet foreach= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0 test '"$(git rev-parse "$sha1")"= 9;=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0 =3D= '"$(git merge-base origin "$sha1")"'=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0 || { echo &= #39;maint.mk: found non-public submodule co= mmit' >&2;=A0=A0=A0=A0=A0=A0=A0 \
=A0=A0=A0=A0=A0=A0=A0=A0 exit 1; };=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0 \
else=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 \
=A0 : ;=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0= =A0=A0=A0=A0=A0=A0=A0 \
fi
Stopping at 'gnulib'; script retur= ned non-zero status.
maint.mk: found non-public submodule commit=
maint.mk:1394: recipe for target &= #39;public-submodule-commit' failed
make: *** [public-submodule-comm= it] Error 1


In the repository, gnulib is used as a submodule. Running:
$ git submodule foreach echo $name, $path, $sha1
returns an= empty string which implies that git is unable to see the submodules correc= tly.

I bisected the git source to find the commit causing the problems= . The following is the commit message:

commit 1c= 4fb136dbad762c9c4350ee79c3474ae8037587
Author: Anders Kaseorg <andersk@MIT.EDU>
Date:=A0=A0 Fri Sep 27 06:23:55 2013 -0400

=A0=A0=A0 submodule forea= ch: skip eval for more than one argument
=A0=A0=A0
=A0=A0=A0 'ev= al "$@"' creates an extra layer of shell interpretation, whic= h is
=A0=A0=A0 probably not expected by a user who passes multiple argum= ents to git
=A0=A0=A0 submodule foreach:
=A0=A0=A0
=A0=A0=A0=A0 $ git grep "= ;'"
=A0=A0=A0=A0 [searches for single quotes]
=A0=A0=A0=A0 $= git submodule foreach git grep "'"
=A0=A0=A0=A0 Entering = '[submodule]'
=A0=A0=A0=A0 /usr/lib/git-core/git-submodule: 1: e= val: Syntax error: Unterminated quoted string
=A0=A0=A0=A0 Stopping at '[submodule]'; script returned non-zero st= atus.
=A0=A0=A0
=A0=A0=A0 To fix this, if the user passes more than = one argument, execute "$@"
=A0=A0=A0 directly instead of passi= ng it to eval.
=A0=A0=A0
=A0=A0=A0 Examples:
=A0=A0=A0
=A0=A0=A0=A0 * Typical usage when addi= ng an extra level of quoting is to pass a
=A0=A0=A0=A0=A0=A0 single argu= ment representing the entire command to be passed to the
=A0=A0=A0=A0=A0= =A0 shell.=A0 This doesn't change that.
=A0=A0=A0
=A0=A0=A0=A0 * One can imagine someone feeding untrusted inpu= t as an argument:
=A0=A0=A0
=A0=A0=A0=A0=A0=A0=A0 git submodule fore= ach git grep "$variable"
=A0=A0=A0
=A0=A0=A0=A0=A0=A0 That= currently results in a nonobvious shell code injection
=A0=A0=A0=A0=A0=A0 vulnerability.=A0 Executing the command named by the arg= uments
=A0=A0=A0=A0=A0=A0 directly, as in this patch, fixes it.
=A0= =A0=A0
=A0=A0=A0 Signed-off-by: Anders Kaseorg <andersk@mit.edu>
=A0=A0=A0 Acked-by: Johan Herland <= johan@herland.net>
=A0=A0=A0 Signed-off-by: Jonathan Nieder <<= a href=3D"mailto:jrnieder@gmail.com">jrnieder@gmail.com>


=
Hence, this seems to me as a feature, not a bug in Git. Maybe, automake nee= ds to fix its scripts accordingly? Because the issue with `make check` was = introduced through this specific commit.

Do let me know if I can provide any more help.
Also, I am not sunscribed to this mailing list, hence, please ensure to le= ave my email in the CC list.

--
Thanking You,
Darshit Shah

--001a11c2b8dae7564c04f2fafd38-- ------------=_1393272724-13107-1--