GNU bug report logs - #16842
[PATCH] Use mbrtowc_cache in DFA engine

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 22 Feb 2014 15:47:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #11 received at 16842 <at> debbugs.gnu.org (full text, mbox):

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 16842 <at> debbugs.gnu.org
Subject: bug#16842: [PATCH] Use mbrtowc_cache in DFA engine
Date: Sat, 29 Mar 2014 01:05:23 +0900

[Message part 1 (text/plain, inline)]
Paul,

Thanks very match.  I checked the patch, and I add fixes to it as
following.

 1. Fixed warning.

    dfa.c: In function 'build_mbrtowc_cache':
    dfa.c:448: warning: pointer targets in passing argument 1 of
    'mbrtowc' differ in signedness

 2. took mbrtowc_cache into new member of struct dfa.

    When struct dfa more than one are used at the same time, mbrtowc cache
    may be conflict.  So, take mbrtowc_cache into new member of struct dfa,
    and define each mbrtowc cache for them.

Norihiro

[patch.txt (text/plain, attachment)]
This bug report was last modified 11 years and 53 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.