From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 19 Feb 2014 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16816@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13928454044932 (code B ref -1); Wed, 19 Feb 2014 21:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 19 Feb 2014 21:30:04 +0000 Received: from localhost ([127.0.0.1]:60723 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGEiP-0001HE-UI for submit@debbugs.gnu.org; Wed, 19 Feb 2014 16:30:03 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37338) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGEiN-0001Gm-Je for submit@debbugs.gnu.org; Wed, 19 Feb 2014 16:30:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGEi8-0003n5-OA for submit@debbugs.gnu.org; Wed, 19 Feb 2014 16:29:54 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:60741) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGEi8-0003n1-LI for submit@debbugs.gnu.org; Wed, 19 Feb 2014 16:29:44 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGEi1-0003mv-B8 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 16:29:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGEht-0003jC-QG for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 16:29:37 -0500 Received: from mailrelay011.isp.belgacom.be ([195.238.6.178]:1296) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGEht-0003ff-Ki for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 16:29:29 -0500 X-Belgacom-Dynamic: yes Received: from 199.199-178-91.adsl-dyn.isp.belgacom.be (HELO LDLC-portable) ([91.178.199.199]) by relay.skynet.be with ESMTP; 19 Feb 2014 22:29:27 +0100 From: Nicolas Richard Date: Wed, 19 Feb 2014 22:29:27 +0100 Message-ID: <87sire4wqw.fsf@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The docstring of `with-temp-buffer-window' contains : It does not make the buffer current for BODY. (2nd sentence of 2nd paragraph). But I think that is wrong, because : (with-temp-buffer-window (get-buffer-create "foo") nil nil (message "curbuf: %s" (current-buffer))) outputs "curbuf: foo" If this is a docbug, here's a suggestion : --- a/lisp/window.el +++ b/lisp/window.el @@ -149,10 +149,9 @@ BUFFER-OR-NAME must specify either a live buffer, or the name of a buffer (if it does not exist, this macro creates it). This construct makes buffer BUFFER-OR-NAME empty before running BODY. -It does not make the buffer current for BODY. -Instead it binds `standard-output' to that buffer, so that output -generated with `prin1' and similar functions in BODY goes into -the buffer. +It makes the buffer current for BODY and binds `standard-output' to that +buffer, so that output generated with `prin1' and similar functions in +BODY goes into the buffer. At the end of BODY, this marks the specified buffer unmodified and read-only, and displays it in a window (but does not select it, or make -- Nico. From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 21 Feb 2014 13:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Richard Cc: 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139298813412047 (code B ref 16816); Fri, 21 Feb 2014 13:09:02 +0000 Received: (at 16816) by debbugs.gnu.org; 21 Feb 2014 13:08:54 +0000 Received: from localhost ([127.0.0.1]:34389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGpqY-00038E-5C for submit@debbugs.gnu.org; Fri, 21 Feb 2014 08:08:54 -0500 Received: from mout.gmx.net ([212.227.17.21]:62760) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGpqW-000380-2G for 16816@debbugs.gnu.org; Fri, 21 Feb 2014 08:08:52 -0500 Received: from [62.47.35.16] ([62.47.35.16]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MfzEP-1WbOxc3GTd-00NVTJ for <16816@debbugs.gnu.org>; Fri, 21 Feb 2014 14:08:45 +0100 Message-ID: <53074FDB.4040907@gmx.at> Date: Fri, 21 Feb 2014 14:08:43 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> In-Reply-To: <87sire4wqw.fsf@yahoo.fr> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:psN5QVLvjAMLI3tsyX0y89WAEeFhYp50IlhLNRSu3NbOyr5/Y+F c4T/dt7RK+MrmrT+ItbOsUWejiOvi54nt7AMzxw42BoeEyIiHKELFB9HlT0mgsCmtACsnTs p97hjBmg/FC36+/ZpAbfWvzvgvaf56yZaUF66KXlSkP51fnZRNtCv4Bdu7XnBaZKc7Ga6lu kPU+Mp/PWKiSgpyMfiHgg== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > The docstring of `with-temp-buffer-window' contains : > > It does not make the buffer current for BODY. > > (2nd sentence of 2nd paragraph). > > But I think that is wrong, because : > (with-temp-buffer-window > (get-buffer-create "foo") > nil > nil > (message "curbuf: %s" > (current-buffer))) > > outputs "curbuf: foo" > > If this is a docbug, here's a suggestion : > > --- a/lisp/window.el > +++ b/lisp/window.el > @@ -149,10 +149,9 @@ BUFFER-OR-NAME must specify either a live buffer, or the name of a > buffer (if it does not exist, this macro creates it). > > This construct makes buffer BUFFER-OR-NAME empty before running BODY. > -It does not make the buffer current for BODY. > -Instead it binds `standard-output' to that buffer, so that output > -generated with `prin1' and similar functions in BODY goes into > -the buffer. > +It makes the buffer current for BODY and binds `standard-output' to that > +buffer, so that output generated with `prin1' and similar functions in > +BODY goes into the buffer. > > At the end of BODY, this marks the specified buffer unmodified and > read-only, and displays it in a window (but does not select it, or make `with-temp-buffer-window' should behave as `with-output-to-temp-buffer' in this regard (at least I hope so). So in revision 116509 I moved the evaluation of BODY out of the scope of `with-current-buffer'. If this causes problems, I will revert and use your patch. Thanks, martin From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 21 13:40:22 2014 Received: (at control) by debbugs.gnu.org; 21 Feb 2014 18:40:22 +0000 Received: from localhost ([127.0.0.1]:35025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGv1K-0004i9-9X for submit@debbugs.gnu.org; Fri, 21 Feb 2014 13:40:22 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:47361 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGv1H-0004hy-Th for control@debbugs.gnu.org; Fri, 21 Feb 2014 13:40:20 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WGv1H-00054A-H5 for control@debbugs.gnu.org; Fri, 21 Feb 2014 13:40:19 -0500 Date: Fri, 21 Feb 2014 13:40:19 -0500 Message-Id: Subject: control message for bug 16816 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -6.0 (------) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.0 (------) close 16816 24.4 From debbugs-submit-bounces@debbugs.gnu.org Tue Feb 25 14:45:55 2014 Received: (at control) by debbugs.gnu.org; 25 Feb 2014 19:45:55 +0000 Received: from localhost ([127.0.0.1]:39885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WINww-0004Bu-U7 for submit@debbugs.gnu.org; Tue, 25 Feb 2014 14:45:55 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:53485 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WINwu-0004Bk-8m for control@debbugs.gnu.org; Tue, 25 Feb 2014 14:45:52 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WINwu-0007bR-1n for control@debbugs.gnu.org; Tue, 25 Feb 2014 14:45:52 -0500 Date: Tue, 25 Feb 2014 14:45:52 -0500 Message-Id: Subject: control message for bug 16882 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) forcemerge 16816 16882 From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 15:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139351517327180 (code B ref 16816); Thu, 27 Feb 2014 15:33:02 +0000 Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 15:32:53 +0000 Received: from localhost ([127.0.0.1]:42823 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ2xA-00074J-On for submit@debbugs.gnu.org; Thu, 27 Feb 2014 10:32:53 -0500 Received: from mail-yh0-f41.google.com ([209.85.213.41]:36641) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ2x8-00074A-8H for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 10:32:51 -0500 Received: by mail-yh0-f41.google.com with SMTP id f73so2822067yha.14 for <16816@debbugs.gnu.org>; Thu, 27 Feb 2014 07:32:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=LwL58avzLvUjMk9yq59H9r1qmGoafFmlFnWsKwOXjMU=; b=PSK1gH0XM6iGL6mh5utMz9XZipCVIoI2hTi8jd+OqAYVBCSyXtNhYxv4WYqXIyZ1PN ye6DtwE++xchJgTmt+XrXvHxufGB7O5VyiNf+ZR67lvVjHKfOR29996KZcqTB2Q0iL7s DyRFb278n/S0qkcKog2EJ4sE4ReGM5dwUdppwVYWcS1MSBzI5/mff2Eh62TdaZ9qcB1/ lgC9/MGVEqaoZyREefChOgtJ4u7e1t3ub0oinflSR0XOcT6pqlJ6RpizT3vqW5HbZcmb JgWLhaMPVEJNVehK7qMuJ1LPmrAqq+IbWfCa4gzRSSNZnLev7prKdtzFah2WJwfBOmGi zhSg== X-Received: by 10.236.122.99 with SMTP id s63mr15825407yhh.19.1393515169585; Thu, 27 Feb 2014 07:32:49 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.197.1 with HTTP; Thu, 27 Feb 2014 07:32:09 -0800 (PST) In-Reply-To: <53074FDB.4040907@gmx.at> References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> From: Juanma Barranquero Date: Thu, 27 Feb 2014 16:32:09 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) reopen 16816 quit On Fri, Feb 21, 2014 at 2:08 PM, martin rudalics wrote: > `with-temp-buffer-window' should behave as `with-output-to-temp-buffer' > in this regard (at least I hope so). So in revision 116509 I moved the > evaluation of BODY out of the scope of `with-current-buffer'. If this > causes problems, I will revert and use your patch. This breaks with-help-window. Try emacs -Q C-x C-h the help output is inserted in the current buffer (*scratch*, in this case). This patch fixes it. === modified file 'lisp/help.el' --- lisp/help.el 2014-02-10 01:34:22 +0000 +++ lisp/help.el 2014-02-27 15:29:05 +0000 @@ -1207,7 +1207,8 @@ (temp-buffer-window-show-hook (cons 'help-mode-finish temp-buffer-window-show-hook))) (with-temp-buffer-window - ,buffer-name nil 'help-window-setup (progn ,@body))))) + ,buffer-name nil 'help-window-setup + (with-current-buffer ,buffer-name ,@body))))) ;; Called from C, on encountering `help-char' when reading a char. ;; Don't print to *Help*; that would clobber Help history. From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139352671331191 (code B ref 16816); Thu, 27 Feb 2014 18:46:01 +0000 Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 18:45:13 +0000 Received: from localhost ([127.0.0.1]:42996 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ5xI-000871-PE for submit@debbugs.gnu.org; Thu, 27 Feb 2014 13:45:13 -0500 Received: from mout.gmx.net ([212.227.17.22]:52203) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ5xG-00086r-8V for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 13:45:10 -0500 Received: from [62.47.47.134] ([62.47.47.134]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0LoaCE-1WtpPc2fne-00gZ3V; Thu, 27 Feb 2014 19:45:06 +0100 Message-ID: <530F87A7.1080009@gmx.at> Date: Thu, 27 Feb 2014 19:44:55 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:PhWAXXrZ4xWSXCQiJn9WtxGgb80XJ7x9Vw+AWAv/iSuVn0rnx8a 93udYXfm1vpsuDqItGwfQb8fCCjaTmDmbnnkN7EiDS1omAXp+uDpqvFH+hBFCmZLaVUvA61 guyWcaBH33PF8pkUDiwErVkqigvrUMWhMl/QUW01xNZ/9eEmen8VUALrcNIiyGoCi+0lEBU aK/PBfF70dAkK80m9N+BQ== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > This breaks with-help-window. Try > > emacs -Q > C-x C-h > > the help output is inserted in the current buffer (*scratch*, in this case). Yes. A lousy bug. I introduced it last year relying on the misfeature that `with-temp-buffer-window' makes the help buffer current. Does the following patch fix it? === modified file 'lisp/help.el' --- lisp/help.el 2014-02-10 01:34:22 +0000 +++ lisp/help.el 2014-02-27 18:31:30 +0000 @@ -498,7 +498,8 @@ then we display only bindings that start with that prefix." (let ((buf (current-buffer))) (with-help-window (help-buffer) - (describe-buffer-bindings buf prefix menus)))) + (with-current-buffer (help-buffer) + (describe-buffer-bindings buf prefix menus))))) (defun where-is (definition &optional insert) "Print message listing key sequences that invoke the command DEFINITION. > This patch fixes it. > > === modified file 'lisp/help.el' > --- lisp/help.el 2014-02-10 01:34:22 +0000 > +++ lisp/help.el 2014-02-27 15:29:05 +0000 > @@ -1207,7 +1207,8 @@ > (temp-buffer-window-show-hook > (cons 'help-mode-finish temp-buffer-window-show-hook))) > (with-temp-buffer-window > - ,buffer-name nil 'help-window-setup (progn ,@body))))) > + ,buffer-name nil 'help-window-setup > + (with-current-buffer ,buffer-name ,@body))))) > > ;; Called from C, on encountering `help-char' when reading a char. > ;; Don't print to *Help*; that would clobber Help history. > This would restore what we had till now: BODY would get evaluated in the help buffer and not in the original buffer. I doubt this could have any serious consequences (Emacs 24.3 runs this already for quite some time) but it's inherently disturbing. martin From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 18:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139352737932415 (code B ref 16816); Thu, 27 Feb 2014 18:57:01 +0000 Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 18:56:19 +0000 Received: from localhost ([127.0.0.1]:43003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ682-0008Ql-Vn for submit@debbugs.gnu.org; Thu, 27 Feb 2014 13:56:19 -0500 Received: from mail-yh0-f43.google.com ([209.85.213.43]:54861) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ680-0008Qc-QO for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 13:56:17 -0500 Received: by mail-yh0-f43.google.com with SMTP id f10so822855yha.2 for <16816@debbugs.gnu.org>; Thu, 27 Feb 2014 10:56:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=70ZB+fa2KDnPJqp+C7oihwu0pL7Y3DDutzmJQ4/X5ng=; b=Y7L+hcoDHZPTNaxGqjb4tmnS5MpCqJFCzFu/g+I/QovjihLYC9zfj8JCJbgdO+97RX sMSsBWQMFmhB/Zc+96sDAcO0FFhs1tIzmk9IwOvIxzm1tqtFlVl7VPWlr5BoiAWz5P+y qho9HlOk8IMsmEs3IKC3DaaimU73vHtromWhtYUAZK8lvZdvzlo7BS/iKqTDW+T7IUip SBy0scKycuFLVeyowMP3dPBMvo8PX6lz169MEd8Em6NRh4fXuxzYw/JUfni2JA+8Oon2 iYVN4C24ZfvPsvb0ug1gmwVxfp2tc7igUl7ebqHZNvz8cOMJImjsU6lgcobBjxWbxQKI 0zOw== X-Received: by 10.236.96.201 with SMTP id r49mr16789807yhf.33.1393527375859; Thu, 27 Feb 2014 10:56:15 -0800 (PST) MIME-Version: 1.0 Received: by 10.170.197.1 with HTTP; Thu, 27 Feb 2014 10:55:35 -0800 (PST) In-Reply-To: <530F87A7.1080009@gmx.at> References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> <530F87A7.1080009@gmx.at> From: Juanma Barranquero Date: Thu, 27 Feb 2014 19:55:35 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Thu, Feb 27, 2014 at 7:44 PM, martin rudalics wrote: > Does the following patch fix it? Yes. > This would restore what we had till now: BODY would get evaluated in the > help buffer and not in the original buffer. I doubt this could have any > serious consequences (Emacs 24.3 runs this already for quite some time) > but it's inherently disturbing. You're right, I suppose. BTW, the docstring of with-help-window isn't exactly clear to me... Display buffer with name BUFFER-NAME in a help window evaluating BODY. Evaluating BODY in a help window? What does this mean? J From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 20:01:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.13935312527522 (code B ref 16816); Thu, 27 Feb 2014 20:01:03 +0000 Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 20:00:52 +0000 Received: from localhost ([127.0.0.1]:43067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ78V-0001xG-KD for submit@debbugs.gnu.org; Thu, 27 Feb 2014 15:00:51 -0500 Received: from mout.gmx.net ([212.227.15.18]:62182) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ78R-0001x6-MA for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 15:00:49 -0500 Received: from [62.47.47.134] ([62.47.47.134]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0MSuMn-1WiF9X3At3-00Rnwd; Thu, 27 Feb 2014 21:00:46 +0100 Message-ID: <530F9964.9030408@gmx.at> Date: Thu, 27 Feb 2014 21:00:36 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> <530F87A7.1080009@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:fm/g+ZYIlxIr9xzjDv6rpGGgCG+tf96gWrCsdxesdTcZJlmlOyA JsXYC3XgDqAPNt2FFhaYNDI/zwjBXRM+PASDasEzLNsbv35SuWBtEtdrxB+btMqNf75x+9/ 3DGAagLjJGXVPE2mO2CQTTLve1pBvc19DNFJCx+mTIoffuVgGXLOhm73b2Kn+Rr+Kq72qo7 Ez/XtxgbcdZlOvdW8X8OA== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > BTW, the docstring of with-help-window isn't exactly clear to me... > > Display buffer with name BUFFER-NAME in a help window evaluating BODY. > > Evaluating BODY in a help window? What does this mean? Drew's getting old. Such an awful doc-string and he apparently never complained ... I'll have to fix the info entry too. It doesn't even say that the buffer gets displayed. martin From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 21:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics , Juanma Barranquero Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139353506819458 (code B ref 16816); Thu, 27 Feb 2014 21:05:02 +0000 Received: (at 16816) by debbugs.gnu.org; 27 Feb 2014 21:04:28 +0000 Received: from localhost ([127.0.0.1]:43126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ883-00053l-Va for submit@debbugs.gnu.org; Thu, 27 Feb 2014 16:04:28 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:18964) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ881-00053d-IN for 16816@debbugs.gnu.org; Thu, 27 Feb 2014 16:04:26 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1RL4NRO025172 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 27 Feb 2014 21:04:23 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1RL4MCV025640 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 27 Feb 2014 21:04:22 GMT Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1RL4LB2023685; Thu, 27 Feb 2014 21:04:21 GMT MIME-Version: 1.0 Message-ID: Date: Thu, 27 Feb 2014 13:04:21 -0800 (PST) From: Drew Adams References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> <530F87A7.1080009@gmx.at> <530F9964.9030408@gmx.at> In-Reply-To: <530F9964.9030408@gmx.at> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > > BTW, the docstring of with-help-window isn't exactly clear to me... > > Display buffer with name BUFFER-NAME in a help window evaluating BOD= Y. > > Evaluating BODY in a help window? What does this mean? >=20 > Drew's getting old. Everyone's getting old, from Day Zero on. > Such an awful doc-string and he apparently never complained ... So many bugs, so little time. Fortunately, Juanma is there. From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Feb 2014 11:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.13935851543911 (code B ref 16816); Fri, 28 Feb 2014 11:00:02 +0000 Received: (at 16816) by debbugs.gnu.org; 28 Feb 2014 10:59:14 +0000 Received: from localhost ([127.0.0.1]:43640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJL9t-000110-Jt for submit@debbugs.gnu.org; Fri, 28 Feb 2014 05:59:13 -0500 Received: from mout.gmx.net ([212.227.15.18]:49228) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJL9q-00010m-LB for 16816@debbugs.gnu.org; Fri, 28 Feb 2014 05:59:11 -0500 Received: from [62.47.57.2] ([62.47.57.2]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M0cs6-1XE32n13BW-00uoZ0; Fri, 28 Feb 2014 11:59:04 +0100 Message-ID: <53106BF3.8020504@gmx.at> Date: Fri, 28 Feb 2014 11:58:59 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> <530F87A7.1080009@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:tq6TyvfUDtgmVXLiA94mSg0bPclqkyM4ksU5bbl2SyHOmRB/bpX 4KyaEFyzBJXi4JhMf1GZug/7Cz+PZ4dhDo2UIZo8mb7uMStpmTFv/aCVPwi2+APif/j6znB JCGb4/0kD98tCyu7KZG4wd6IaVJyPYmM8BXaZggWg9k56w6+6jeVggd8doxew9fleV+4YHF 9faAI6FuLCxJQ5TJRTQuA== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) >> This would restore what we had till now: BODY would get evaluated in the >> help buffer and not in the original buffer. I doubt this could have any >> serious consequences (Emacs 24.3 runs this already for quite some time) >> but it's inherently disturbing. > > You're right, I suppose. I reverted my previous change. It's too dangerous as the bug you reported demonstrates. > BTW, the docstring of with-help-window isn't exactly clear to me... > > Display buffer with name BUFFER-NAME in a help window evaluating BODY. > > Evaluating BODY in a help window? What does this mean? I rewrote the doc-strings of `with-temp-buffer-window' and `with-help-window'. Please have a look. martin From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 28 Feb 2014 11:00:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Richard Cc: 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.13935851613935 (code B ref 16816); Fri, 28 Feb 2014 11:00:05 +0000 Received: (at 16816) by debbugs.gnu.org; 28 Feb 2014 10:59:21 +0000 Received: from localhost ([127.0.0.1]:43643 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJLA1-00011O-1W for submit@debbugs.gnu.org; Fri, 28 Feb 2014 05:59:21 -0500 Received: from mout.gmx.net ([212.227.15.18]:52781) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJL9y-00011D-WE for 16816@debbugs.gnu.org; Fri, 28 Feb 2014 05:59:19 -0500 Received: from [62.47.57.2] ([62.47.57.2]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0LgqEs-1Wyhrp0aLG-00oDq8 for <16816@debbugs.gnu.org>; Fri, 28 Feb 2014 11:59:15 +0100 Message-ID: <53106BFF.6080801@gmx.at> Date: Fri, 28 Feb 2014 11:59:11 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> In-Reply-To: <87sire4wqw.fsf@yahoo.fr> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:Xu27pNSTUV3Yahxl1ugrBf9PJ1FNJTcjby6NuE8GzvOvwwRNBQY vvanGQQHltvpXhctWww7zUOs/LaQ3LZzP5Rgn8ujMsf6qTB7TV5ybCSnSFCwnHBYeUbSM7X TvTbmMj95Ta/Clz2R904dJsuqFcMGRDyo+UfEreZRNKerhN+tgoR+RdVQFxuCxBDpSeMH/V nYLsuCej5t6XA8T6m5A5g== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > If this is a docbug, here's a suggestion : I made it a docbug now and largely expanded the doc-string based on your suggestion. martin From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Mar 2014 10:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juanma Barranquero Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139496405130444 (code B ref 16816); Sun, 16 Mar 2014 10:01:02 +0000 Received: (at 16816) by debbugs.gnu.org; 16 Mar 2014 10:00:51 +0000 Received: from localhost ([127.0.0.1]:37938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WP7sA-0007uy-SE for submit@debbugs.gnu.org; Sun, 16 Mar 2014 06:00:51 -0400 Received: from mout.gmx.net ([212.227.17.21]:56561) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WP7s6-0007uj-Tm for 16816@debbugs.gnu.org; Sun, 16 Mar 2014 06:00:48 -0400 Received: from [62.46.211.76] ([62.46.211.76]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MaF8e-1Wirdz2vxg-00Jukn; Sun, 16 Mar 2014 11:00:43 +0100 Message-ID: <53257646.5050601@gmx.at> Date: Sun, 16 Mar 2014 11:00:38 +0100 From: martin rudalics MIME-Version: 1.0 References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:9p+ArgkliMyDYGcj6JcUqS484jDR/qHAzEHYtRmqwrqzUo4PnOo QSFP7S9uVk2MlRWZoofAGSpnsNCGjVLutqdBNo2xpbAM09qlZyn4nFQ304PfX9UUwuC/o+M UelCdVe4rcJn25yMrMjhA03eh1hHCH+MBtNtcdhwelNTcwMYwxObvucRzp3JY5ebBq7tc05 yw8gNtdd8ldQVm967kM0w== X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > This breaks with-help-window. Try > > emacs -Q > C-x C-h > > the help output is inserted in the current buffer (*scratch*, in this case). Should be now fixed in the way I proposed initially. Please check. Thanks, martin From unknown Mon Jun 23 00:36:14 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16816: 24.3.50; erroneous docstring in with-temp-buffer-window Resent-From: Juanma Barranquero Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Mar 2014 05:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16816 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: Nicolas Richard , 16816@debbugs.gnu.org Received: via spool by 16816-submit@debbugs.gnu.org id=B16816.139546560228517 (code B ref 16816); Sat, 22 Mar 2014 05:21:02 +0000 Received: (at 16816) by debbugs.gnu.org; 22 Mar 2014 05:20:02 +0000 Received: from localhost ([127.0.0.1]:44095 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRELh-0007Pi-Hu for submit@debbugs.gnu.org; Sat, 22 Mar 2014 01:20:02 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:60837) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WRELd-0007PO-O8 for 16816@debbugs.gnu.org; Sat, 22 Mar 2014 01:19:58 -0400 Received: by mail-yk0-f178.google.com with SMTP id 79so8708044ykr.9 for <16816@debbugs.gnu.org>; Fri, 21 Mar 2014 22:19:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=DOgpvb3luNw764nro57TxEYYmafjS6KAy8vDzOUPB38=; b=cp2SvQ+Sx+GpYnb+JslLlnFd0GfKL+Cmvtl8GIlycX69zT5CWJt/fts73U2/J4R7Vx QyLlw3CzxuYZZwJvfkSN0HF+1fUeZRd7tn6mOZKOsOlJUfccG9pWuqN1Z9NMIZI3YMcG Ubr7o0JqLornC5U33nT6RwZbiyqqermFd3IHAkqAXoL/UVEOHjbIi+vPQddfQ4/7gQsh 8bViTLFKsVNyqUkgO9hLMI0occ3V2eN6wIQAqeGlitNor9zjFDgbxGDWOk+MRLbbFZ6C h5gG7/2PwqWdKkujspZzTDvZv7FbXmhtk0d4EI1jc5NdCzPAl9IMadrT6bIXoYgtY6q2 dFNA== X-Received: by 10.236.16.161 with SMTP id h21mr72297204yhh.77.1395465596799; Fri, 21 Mar 2014 22:19:56 -0700 (PDT) MIME-Version: 1.0 Received: by 10.170.163.3 with HTTP; Fri, 21 Mar 2014 22:19:16 -0700 (PDT) In-Reply-To: <53257646.5050601@gmx.at> References: <87sire4wqw.fsf@yahoo.fr> <53074FDB.4040907@gmx.at> <53257646.5050601@gmx.at> From: Juanma Barranquero Date: Sat, 22 Mar 2014 06:19:16 +0100 Message-ID: Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, Mar 16, 2014 at 11:00 AM, martin rudalics wrote: > Should be now fixed in the way I proposed initially. Please check. Sorry, I forgot about this one. It works, of course. Thanks, J