From unknown Tue Jun 17 20:20:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16814 <16814@debbugs.gnu.org> To: bug#16814 <16814@debbugs.gnu.org> Subject: Status: `sql-interactive-mode' overwrites `comint' variables Reply-To: bug#16814 <16814@debbugs.gnu.org> Date: Wed, 18 Jun 2025 03:20:41 +0000 retitle 16814 `sql-interactive-mode' overwrites `comint' variables reassign 16814 emacs submitter 16814 Emilio C. Lopes severity 16814 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 19 15:03:47 2014 Received: (at submit) by debbugs.gnu.org; 19 Feb 2014 20:03:47 +0000 Received: from localhost ([127.0.0.1]:60655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGDMx-0007Dw-4y for submit@debbugs.gnu.org; Wed, 19 Feb 2014 15:03:47 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45924) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WGDMv-0007Di-Q8 for submit@debbugs.gnu.org; Wed, 19 Feb 2014 15:03:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGDMi-0005yk-57 for submit@debbugs.gnu.org; Wed, 19 Feb 2014 15:03:40 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58692) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGDMi-0005ye-23 for submit@debbugs.gnu.org; Wed, 19 Feb 2014 15:03:32 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47597) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGDMZ-0005pO-K4 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 15:03:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WGDMR-0005vA-6c for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 15:03:23 -0500 Received: from mail-wg0-x232.google.com ([2a00:1450:400c:c00::232]:52677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WGDMR-0005uu-02 for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 15:03:15 -0500 Received: by mail-wg0-f50.google.com with SMTP id z12so725615wgg.17 for ; Wed, 19 Feb 2014 12:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:subject:user-agent:date:message-id:mime-version :content-type; bh=igMpSgLZFp8B6kVSBeIX6xCmy2jrDWCuMawQDrzaLFE=; b=Pw57ywAD8/Vn+HGX5F6zlpVGWmrlzaKT35qfs/Lbirh7md2HfI7kRIMi7P0EAJRQx9 LsLRvwvfwOtxv6xOpDw+XXBK8gekE8BzW+QYQi2c+qKwaNsrfAVT+pc/87UqIqO4RcVY CA7EyhwiUJAmks0qW6Ab6yDPt0IQOd8mO71e+whlRhlFQ8tLE10phuNxKqi+PzJxPv7F bABbRXAECLgUkwljvbnOMFUV0Q7yOZcPpDJWSDx+iUE18Ue7f22q8nvds6fVmDLrKMiX Xyb7hzk4jvZw7W4N4UwS4SYoRKhtUk70QGKWrZlg5RPJt0dSmrX8yiw2MZk982YsyZLK E70w== X-Received: by 10.14.47.133 with SMTP id t5mr4109601eeb.96.1392840191754; Wed, 19 Feb 2014 12:03:11 -0800 (PST) Received: from bessa.local (p5B073DC5.dip0.t-ipconnect.de. [91.7.61.197]) by mx.google.com with ESMTPSA id 43sm2824428eeh.13.2014.02.19.12.03.09 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 19 Feb 2014 12:03:10 -0800 (PST) From: Emilio C. Lopes To: bug-gnu-emacs@gnu.org Subject: `sql-interactive-mode' overwrites `comint' variables User-agent: mu4e 0.9.9.5; emacs 24.3.1 Date: Wed, 19 Feb 2014 21:05:45 +0100 Message-ID: <87lhx6amw6.fsf@gmx.net> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) `sql-interactive-mode' sets the variables `comint-input-ring-separator' and `comint-input-ring-file-name' without making them buffer-local. When I use `sql-interactive-mode' and afterwards run `(comint-read-input-ring)' in `shell-mode' I get an empty `comint-input-ring'. Here is a patch: 2012-10-09 Emilio C. Lopes * progmodes/sql.el (sql-interactive-mode): make variables `comint-input-ring-separator' and `comint-input-ring-file-name' buffer-local before setting. diff --unified lisp/progmodes/sql.el.\~1\~ lisp/progmodes/sql.el --- lisp/progmodes/sql.el.~1~ 2014-02-19 14:31:34.000000000 +0100 +++ lisp/progmodes/sql.el 2014-02-19 14:45:36.000000000 +0100 @@ -3928,8 +3928,8 @@ ;; People wanting a different history file for each ;; buffer/process/client/whatever can change separator and file-name ;; on the sql-interactive-mode-hook. - (setq comint-input-ring-separator sql-input-ring-separator - comint-input-ring-file-name sql-input-ring-file-name) + (setq-local comint-input-ring-separator sql-input-ring-separator) + (setq-local comint-input-ring-file-name sql-input-ring-file-name) ;; Calling the hook before calling comint-read-input-ring allows users ;; to set comint-input-ring-file-name in sql-interactive-mode-hook. (comint-read-input-ring t)) Diff finished. Wed Feb 19 14:45:41 2014 From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 20:56:23 2014 Received: (at 16814-done) by debbugs.gnu.org; 28 Feb 2014 01:56:23 +0000 Received: from localhost ([127.0.0.1]:43286 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJCgY-0006L7-UK for submit@debbugs.gnu.org; Thu, 27 Feb 2014 20:56:23 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:49589) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJCgW-0006Ky-Cl for 16814-done@debbugs.gnu.org; Thu, 27 Feb 2014 20:56:21 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WJCgV-000859-DD; Thu, 27 Feb 2014 20:56:19 -0500 From: Glenn Morris To: 16814-done@debbugs.gnu.org Subject: Re: bug#16814: `sql-interactive-mode' overwrites `comint' variables References: <87lhx6amw6.fsf@gmx.net> X-Spook: Geraldton CDC MD4 2600 Magazine monarchist sniper X-Ran: "L-?~AjQ*pM)>pA}f,FtdOQyMZQ%V1&;Z`oGk&vxj@8-:gK-I(BnEMsaz{F$E!mwyPNL50 X-Hue: green X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 27 Feb 2014 20:56:19 -0500 In-Reply-To: <87lhx6amw6.fsf@gmx.net> (Emilio C. Lopes's message of "Wed, 19 Feb 2014 21:05:45 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16814-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 24.4 Emilio C. Lopes wrote: > `sql-interactive-mode' sets the variables `comint-input-ring-separator' > and `comint-input-ring-file-name' without making them buffer-local. You're right about comint-input-ring-separator, but sql-interactive-mode first calls comint-mode, which makes comint-input-ring-file-name buffer-local. > Here is a patch: Partially applied, thanks. From unknown Tue Jun 17 20:20:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Mar 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 01 16:57:03 2014 Received: (at control) by debbugs.gnu.org; 1 Nov 2014 20:57:03 +0000 Received: from localhost ([127.0.0.1]:44859 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkfjK-0006jt-Ov for submit@debbugs.gnu.org; Sat, 01 Nov 2014 16:57:03 -0400 Received: from nm20.bullet.mail.bf1.yahoo.com ([98.139.212.179]:39681) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XkfjI-0006jS-4R for control@debbugs.gnu.org; Sat, 01 Nov 2014 16:57:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1414875413; bh=WXfh/xOYWs4Xn5pYKjDrG+GinEKTgs/gb3p6HIzcXxo=; h=Date:From:Reply-To:To:Subject:From:Subject; b=hIzdlnnIrUiI1WuczvwJ+EGbCjQ1or94Plrg/lMuMytu60tj6DBZDxxcAONamhrF1kBL1P+kP9KdAeLXyKmuxwgVdR3zYqpvkNAkrHAPs/u5LRwafrIea1KzPkhQVOKDPFgmph4lJoVKoWsX1mE4tGnPnEHF8gYsouo9k5cG6NwrnwLwjOcaeDpJYMZG8o0MHFANk8gAO/AscIXKrmc9tA17mLg4L1EqOsz+TQOFtP7fTuTdmZA/c7UjohX6Rk0mweKbFbTqtE6n6AM75X+suGiFl/tRmoHxV4A71s5UnMcNM9sa1RCtVLLqOd4o4FqRFBIXAky8PTLyXWrI7A1I0w== DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s2048; d=yahoo.com; b=GP5OI1qP67dYfuOL6hxzUZLH1b/mB/FJTENR0+tuRgVbQtIe8tNf+6HVEbY4iQBqf69cbq0FRy9EGW69YgPfkcOHu3RrfisepEmxhPq7WsuFL5XM7a8ZpjqdXp02FzRhoou8iC4p4fRSMaRtZ7SWWa/IPX60h0D0N2KsfllyKm6r/TIR74scXzBMXrwmo3XWxFvvzmxNf4GG8/4y4MsR8pMV81OdLCDYYst6eDDCvueRhViPfk6vY5PNmuUkUkXMGHrPbp835+M6iJf0Q7WwzTOWBTYM8qUNXB93tuY1JsZiHV7g5STw5gDXE/7DjaAW4Pht3SDo4FRQKcW8nykXaw==; Received: from [66.196.81.171] by nm20.bullet.mail.bf1.yahoo.com with NNFMP; 01 Nov 2014 20:56:53 -0000 Received: from [98.139.212.217] by tm17.bullet.mail.bf1.yahoo.com with NNFMP; 01 Nov 2014 20:56:53 -0000 Received: from [127.0.0.1] by omp1026.mail.bf1.yahoo.com with NNFMP; 01 Nov 2014 20:56:53 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 250071.44399.bm@omp1026.mail.bf1.yahoo.com X-YMail-OSG: vFBxQd0VM1kz_tMX7sIzTyAy43uCMWcflNb95I_4KDSL120AMb.cdhyo5tKHMQN lovwxuA4cNspauDPDtk2cPjhUJjneqjCDXIDJxYjLcFrai6sIcaTOwcvy8YY5kJFCSFZQereOdM8 Ys56mPSr2bbIIR0kJA9nrUidVGG8S2mCf0_DH._APUQUT6QD9sl.Fm7vp0h.Pa15a9s3v7YmU6Pj Raq0zFtXQOlzA0HlCOvMAedgU7fsvHS0crdC.OcFhQPBRbINfa74WtO8Cv1b0zAuOIwFawfoyvD2 oBkxz6BOHcxFXm6fWIbNoIbzat_KCQrdiLJ7ZfGTmSkMp5.CIlnFRr5UNFY40kI85mTGxrIojIYP uf.bWuogNoJ.GFtaASN8NVPpIjNEyRMicReMsmuuNRxO2C50LBvt49S1tg28baknVnwpZspxAZbR aWI.HLq1sj7.OHaCqqzXHY6L1JBhmVGlSZaPVuXjhvpWWDFsTnRPGnyvFgyk- Received: by 76.13.26.107; Sat, 01 Nov 2014 20:56:52 +0000 Date: Sat, 1 Nov 2014 20:56:31 +0000 (UTC) From: Michael Mauger To: "control@debbugs.gnu.org" Message-ID: <665475530.94051.1414875391872.JavaMail.yahoo@jws106146.mail.bf1.yahoo.com> Subject: unarchive 16814 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Length: 15 X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Michael Mauger List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.6 (/) unarchive 16814 From unknown Tue Jun 17 20:20:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Nov 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator