From unknown Fri Aug 15 12:50:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16807 <16807@debbugs.gnu.org> To: bug#16807 <16807@debbugs.gnu.org> Subject: Status: 24.3.50; changes in advice.el break multi-term.el Reply-To: bug#16807 <16807@debbugs.gnu.org> Date: Fri, 15 Aug 2025 19:50:56 +0000 retitle 16807 24.3.50; changes in advice.el break multi-term.el reassign 16807 emacs submitter 16807 henry atting severity 16807 normal tag 16807 notabug wontfix thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Feb 19 02:32:21 2014 Received: (at submit) by debbugs.gnu.org; 19 Feb 2014 07:32:22 +0000 Received: from localhost ([127.0.0.1]:59402 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WG1dk-0000f2-Vi for submit@debbugs.gnu.org; Wed, 19 Feb 2014 02:32:21 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51072) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WG08o-0006JW-MU for submit@debbugs.gnu.org; Wed, 19 Feb 2014 00:56:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG08Z-0003oS-UT for submit@debbugs.gnu.org; Wed, 19 Feb 2014 00:56:13 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:59751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG08Z-0003oI-S9 for submit@debbugs.gnu.org; Wed, 19 Feb 2014 00:56:03 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG08N-00032I-Vy for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:56:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WG08G-0003hs-LK for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:55:51 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:56000) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WG08G-0003hl-BQ for bug-gnu-emacs@gnu.org; Wed, 19 Feb 2014 00:55:44 -0500 Received: from bye.fritz.box (dslb-188-103-194-231.pools.arcor-ip.net [188.103.194.231]) by mrelayeu.kundenserver.de (node=mreue005) with ESMTP (Nemesis) id 0M2HoW-1X5lL03JVE-00s9NN; Wed, 19 Feb 2014 06:55:43 +0100 From: henry atting To: bug-gnu-emacs@gnu.org Subject: 24.3.50; changes in advice.el break multi-term.el Organization: LiteraturLateNight Date: Wed, 19 Feb 2014 06:55:21 +0100 Message-ID: <87eh2zfxyu.fsf@bye.fritz.box> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V02:K0:mBEI3rnz5VSA34MOEcn8c1WyCxDK+Rxj4clM9SdJhPQ OV3LtGpQixei7e5/MeMekBhRcQajqXki6YWFglwEdsMkF8cygZ fKsCFO6ubzVWzu7qJvDucrGRAkzNKacH24Fjcfk6DR/9dkF9gB zytRwWlouJfJs4NOoF6vSk7xfMBuYMfbAcPVxP+mlXsf+aP3WM aFIKUFUtRCOGCtfwcGv18IuOhgsb94VhaVcgXW9ZClonz/4+MB s60n2WkC669RusuS1WZunjV0WwxKSLEPWv2aLzL785K2Fk/gIx Chr6LTEIbEfAv8sg53m6b/PNzYfUiU1kg5k01f9h3J7xYZ3taR J60WUHRiEPLqC0nmQs3k= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Wed, 19 Feb 2014 02:32:17 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In GNU Emacs 24.3.50.1 (i686-pc-linux-gnu, GTK+ Version 3.8.6) of 2014-02-08 on bye I know multi-term.el is not part of emacs and, what is more, isn't developed anymore as far as I can see. So take it much more as a brief remark than as a bug report. Following function and macro where removed from advice.el: (defmacro ad-macro-p (definition) ;;"non-nil if DEFINITION is a macro." (` (eq (car-safe (, definition)) 'macro))) (defun ad-advised-definition-p (definition) ;;"non-nil if DEFINITION was generated from advice information." (if (or (ad-lambda-p definition) (ad-macro-p definition) (ad-compiled-p definition)) (let ((docstring (ad-docstring definition))) (and (stringp docstring) (string-match ad-advised-definition-docstring-regexp docstring))))) But multi-term depends on it. Putting these lines somewhere at the beginning of ~/.emacs works for me as a workaround. From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 21:30:34 2014 Received: (at 16807) by debbugs.gnu.org; 28 Feb 2014 02:30:34 +0000 Received: from localhost ([127.0.0.1]:43309 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJDDd-0000D8-Hx for submit@debbugs.gnu.org; Thu, 27 Feb 2014 21:30:33 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:50016) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJDDb-0000D1-ME for 16807@debbugs.gnu.org; Thu, 27 Feb 2014 21:30:32 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WJDDa-0008RN-TA; Thu, 27 Feb 2014 21:30:30 -0500 From: Glenn Morris To: henry atting Subject: Re: bug#16807: 24.3.50; changes in advice.el break multi-term.el References: <87eh2zfxyu.fsf@bye.fritz.box> X-Spook: NASA Becker Mole Compsec asset SDI ASLET Armani X-Ran: ut0sd?o=xj!)V'=?C{Lj":n3c&uM6bYe5OSqEGc|W-0y/w^dATOIT*K`*PH^)?6Z8KW\eE X-Hue: white X-Attribution: GM Date: Thu, 27 Feb 2014 21:30:30 -0500 In-Reply-To: <87eh2zfxyu.fsf@bye.fritz.box> (henry atting's message of "Wed, 19 Feb 2014 06:55:21 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16807 Cc: 16807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) OK, thanks for the info. I don't think those definitions are coming back, so from the Emacs side there isn't really anything to do here. It seems pretty odd that multi-term would be using those, I doubt if it really needed to do so (but I've never looked at it). From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 27 21:30:48 2014 Received: (at control) by debbugs.gnu.org; 28 Feb 2014 02:30:48 +0000 Received: from localhost ([127.0.0.1]:43312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJDDs-0000Dk-An for submit@debbugs.gnu.org; Thu, 27 Feb 2014 21:30:48 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:50021) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJDDq-0000Dc-RE for control@debbugs.gnu.org; Thu, 27 Feb 2014 21:30:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WJDDq-0000Lc-B1 for control@debbugs.gnu.org; Thu, 27 Feb 2014 21:30:46 -0500 Date: Thu, 27 Feb 2014 21:30:46 -0500 Message-Id: Subject: control message for bug 16807 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) tag 16807 notabug wontfix close 16807 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 08:57:07 2014 Received: (at 16807) by debbugs.gnu.org; 28 Feb 2014 13:57:07 +0000 Received: from localhost ([127.0.0.1]:43792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJNw1-00007L-Fe for submit@debbugs.gnu.org; Fri, 28 Feb 2014 08:57:05 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:41668) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJNvy-000078-5q for 16807@debbugs.gnu.org; Fri, 28 Feb 2014 08:57:02 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFHO+KLz/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCQMwR0EkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFHO+KLz/2dsb2JhbABEvw4Xc4IfAQVWIxALNBIUGA0kiCQMwR0EkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="48975018" Received: from 206-248-162-243.dsl.teksavvy.com (HELO pastel.home) ([206.248.162.243]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 Feb 2014 08:56:59 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5858D6057F; Fri, 28 Feb 2014 08:56:59 -0500 (EST) From: Stefan Monnier To: henry atting Subject: Re: bug#16807: 24.3.50; changes in advice.el break multi-term.el Message-ID: References: <87eh2zfxyu.fsf@bye.fritz.box> Date: Fri, 28 Feb 2014 08:56:59 -0500 In-Reply-To: <87eh2zfxyu.fsf@bye.fritz.box> (henry atting's message of "Wed, 19 Feb 2014 06:55:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16807 Cc: 16807@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (defmacro ad-macro-p (definition) multi-term.el can use the new `macrop' instead. But I don't see any use of ad-macro-p in https://github.com/milkypostman/multi-term/blob/master/multi-term.el > (defun ad-advised-definition-p (definition) multi-term.el doesn't really need this anyway, it seems. I.e. you can just replace it with (defun ad-advised-definition-p (def) t)) Both of these were too internal to be worth providing (even as obsolete definitions). Stefan From unknown Fri Aug 15 12:50:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 29 Mar 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator