GNU bug report logs - #16793
window-state-put needs a live window

Previous Next

Full log

View this message in rfc822 format

From: Juanma Barranquero <lekktu <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 16793 <at> debbugs.gnu.org
Subject: bug#16793: window-state-put needs a live window
Date: Tue, 18 Feb 2014 22:18:22 +0100

On Tue, Feb 18, 2014 at 8:04 PM, martin rudalics <rudalics <at> gmx.at> wrote:

> I tend to agree with you.  But the obvious consequence is that the
> WINDOW argument of `window-state-put' could then specify an internal
> window that is not the root window of its frame.  In this case plain
> `delete-other-windows' would be the wrong action.

Yeah. In my workaround that wasn't important because I specifically
got the frame's root.

>  I attach a patch.

Was this:

> +       (setq window (catch 'live
> +                      (walk-window-subtree
> +                       (lambda (window)
> +                         (when (window-live-p window)))
> +                       root))))

intended to be

  (setq window (catch 'live
                 (walk-window-subtree
                  (lambda (window)
                    (when (window-live-p window)
                      (throw 'live window)))
                  root))))

I suppose?

   J

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.