GNU bug report logs - #16744
24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs'

Previous Next

Full log

Message #11 received at 16744 <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Drew Adams <drew.adams <at> oracle.com>, Michael
 Kifer <kifer <at> cs.stonybrook.edu>
Cc: 16744 <at> debbugs.gnu.org
Subject: RE: bug#16744: 24.3.50;	REGRESSION: C-h v does not show doc for
 `ediff-highlight-all-diffs'
Date: Thu, 13 Feb 2014 13:01:16 -0800 (PST)

> That's because of the ediff-defvar-local macro:
> 
>   (defcustom ediff-highlight-all-diffs t
>     "If nil, only the selected differences are highlighted.
>   Otherwise, all difference regions are highlighted, but the
> selected region is
>   shown in brighter colors."
>     :type 'boolean
>     :group 'ediff-highlighting)
>   (ediff-defvar-local ediff-highlight-all-diffs t "")
> 
> It is invoked (here and elsewhere) with an empty string as the doc,
> so that's what you get.

I see.  Seems like such a macro, if really needed, should at least
reuse the main doc string, in _addition_ to adding any local-binding
doc string.  Or perhaps allow for either adding or replacing.
But it should not require duplicating the literal string as an
argument, just to provide doc for the local var.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.