From unknown Sun Sep 07 18:03:29 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16744 <16744@debbugs.gnu.org> To: bug#16744 <16744@debbugs.gnu.org> Subject: Status: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' Reply-To: bug#16744 <16744@debbugs.gnu.org> Date: Mon, 08 Sep 2025 01:03:29 +0000 retitle 16744 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highl= ight-all-diffs' reassign 16744 emacs submitter 16744 Drew Adams severity 16744 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 14:32:38 2014 Received: (at submit) by debbugs.gnu.org; 13 Feb 2014 19:32:38 +0000 Received: from localhost ([127.0.0.1]:51174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE21V-0000yq-Gf for submit@debbugs.gnu.org; Thu, 13 Feb 2014 14:32:37 -0500 Received: from eggs.gnu.org ([208.118.235.92]:49583) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE21T-0000ya-LU for submit@debbugs.gnu.org; Thu, 13 Feb 2014 14:32:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE21E-00071h-8O for submit@debbugs.gnu.org; Thu, 13 Feb 2014 14:32:30 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([208.118.235.17]:39917) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE21E-00071c-5M for submit@debbugs.gnu.org; Thu, 13 Feb 2014 14:32:20 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE215-0001am-D7 for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2014 14:32:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WE20w-0006xG-RX for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2014 14:32:11 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:28137) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WE20w-0006x6-KG for bug-gnu-emacs@gnu.org; Thu, 13 Feb 2014 14:32:02 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1DJW04L002691 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Feb 2014 19:32:01 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1DJVxeO018138 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Thu, 13 Feb 2014 19:31:59 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1DJVxJb002854 for ; Thu, 13 Feb 2014 19:31:59 GMT MIME-Version: 1.0 Message-ID: <4d0cbf1a-914e-493c-bb2f-186229902418@default> Date: Thu, 13 Feb 2014 11:31:58 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.17 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -Q M-x load-library ediff C-h v ediff-highlight-all-diffs No doc shown, just an empty "Documentation:". This regression was introduced in Emacs 24.1. No problem for releases before that. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2014-02-11 on ODIEONE Bzr revision: 116410 lekktu@gmail.com-20140211204823-l9l2s6tktfitq266 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 15:29:48 2014 Received: (at 16744) by debbugs.gnu.org; 13 Feb 2014 20:29:48 +0000 Received: from localhost ([127.0.0.1]:51236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE2uq-0002eo-BZ for submit@debbugs.gnu.org; Thu, 13 Feb 2014 15:29:48 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:42384) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE2uo-0002eU-IO for 16744@debbugs.gnu.org; Thu, 13 Feb 2014 15:29:47 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N0Y00200BJ88E00@mtaout29.012.net.il> for 16744@debbugs.gnu.org; Thu, 13 Feb 2014 22:31:55 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0Y00L5DBP7A860@mtaout29.012.net.il>; Thu, 13 Feb 2014 22:31:55 +0200 (IST) Date: Thu, 13 Feb 2014 22:29:34 +0200 From: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' In-reply-to: <4d0cbf1a-914e-493c-bb2f-186229902418@default> X-012-Sender: halo1@inter.net.il To: Drew Adams , Michael Kifer Message-id: <83txc2dadt.fsf@gnu.org> References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16744 Cc: 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Thu, 13 Feb 2014 11:31:58 -0800 (PST) > From: Drew Adams > > emacs -Q > M-x load-library ediff > C-h v ediff-highlight-all-diffs > > No doc shown, just an empty "Documentation:". That's because of the ediff-defvar-local macro: (defcustom ediff-highlight-all-diffs t "If nil, only the selected differences are highlighted. Otherwise, all difference regions are highlighted, but the selected region is shown in brighter colors." :type 'boolean :group 'ediff-highlighting) (ediff-defvar-local ediff-highlight-all-diffs t "") It is invoked (here and elsewhere) with an empty string as the doc, so that's what you get. Michael, what's the purpose here? From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 13 16:01:39 2014 Received: (at 16744) by debbugs.gnu.org; 13 Feb 2014 21:01:39 +0000 Received: from localhost ([127.0.0.1]:51254 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE3Pe-0003aI-Ol for submit@debbugs.gnu.org; Thu, 13 Feb 2014 16:01:39 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:32901) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WE3Pc-0003Zr-CD for 16744@debbugs.gnu.org; Thu, 13 Feb 2014 16:01:37 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1DL1KV0007710 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 13 Feb 2014 21:01:21 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1DL1HUq009653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 13 Feb 2014 21:01:18 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1DL1H51002878; Thu, 13 Feb 2014 21:01:17 GMT MIME-Version: 1.0 Message-ID: <5d29cc74-f4db-4961-b111-32b5d8e6477b@default> Date: Thu, 13 Feb 2014 13:01:16 -0800 (PST) From: Drew Adams To: Eli Zaretskii , Drew Adams , Michael Kifer Subject: RE: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <<4d0cbf1a-914e-493c-bb2f-186229902418@default>> <<83txc2dadt.fsf@gnu.org>> In-Reply-To: <<83txc2dadt.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 16744 Cc: 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) > That's because of the ediff-defvar-local macro: >=20 > (defcustom ediff-highlight-all-diffs t > "If nil, only the selected differences are highlighted. > Otherwise, all difference regions are highlighted, but the > selected region is > shown in brighter colors." > :type 'boolean > :group 'ediff-highlighting) > (ediff-defvar-local ediff-highlight-all-diffs t "") >=20 > It is invoked (here and elsewhere) with an empty string as the doc, > so that's what you get. I see. Seems like such a macro, if really needed, should at least reuse the main doc string, in _addition_ to adding any local-binding doc string. Or perhaps allow for either adding or replacing. But it should not require duplicating the literal string as an argument, just to provide doc for the local var. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 02:53:42 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 07:53:42 +0000 Received: from localhost ([127.0.0.1]:51572 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEDaf-0007ka-0F for submit@debbugs.gnu.org; Fri, 14 Feb 2014 02:53:41 -0500 Received: from mail-qc0-f170.google.com ([209.85.216.170]:45659) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEDac-0007kJ-0X for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 02:53:38 -0500 Received: by mail-qc0-f170.google.com with SMTP id e9so19989180qcy.29 for <16744@debbugs.gnu.org>; Thu, 13 Feb 2014 23:53:32 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=SBgTHsctRoxjVUwIK+fRWQzhMWLPyPL16WzCwQ67g8w=; b=UeVgqbgBzn0j9jiLtf3PAJh5AC7pCqw9JCW1LH77xb7ah26UHORfaACAandJcHAyUa r+L3Rn7Gr2kzJSy/anO0yFMuf5jsAVKaLbQpr55shgpY64kUALMHIw63hWfzTlkfJscC +REaHCy5xbQmMxIjYPphNU3hDVWnYrDe0pP93rvlddqoIKCyXs77vsyPC+ttgBNPSXDM G69SNEn/jKbZA82JTq7RuFyOvbmfKbrCTjBaJV/cOSXPlI2IhJPj0dg2BslTBeDgZsPj FJsUKmD0deH2U5hpd139UXoSiVxrpryqAqnjFEMPGnA+mSrMTqcpo9MLdI3SyYas4l0z oUBw== X-Gm-Message-State: ALoCoQmabPpY1AXQ449nOZ6NbkowVX4rh+1hgRQqujV04mRrnSpfMHzihgz4wB54nvh949X6L8aE X-Received: by 10.224.11.136 with SMTP id t8mr10562965qat.26.1392364412459; Thu, 13 Feb 2014 23:53:32 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id 30sm6684034qgt.4.2014.02.13.23.53.31 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 13 Feb 2014 23:53:32 -0800 (PST) Message-ID: <52FDCB7B.8090602@stonybrook.edu> Date: Fri, 14 Feb 2014 02:53:31 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii , Drew Adams Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> In-Reply-To: <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16744 Cc: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Strange. When I run it with .emacs, then M-x describe-variable ediff-highlight-all-diffs returns Documentation: If nil, only the selected differences are highlighted. Otherwise, all difference regions are highlighted, but the selected region is shown in brighter colors. But if it is started with emacs -q then the documentation string is not shown. -- --- michael On 02/13/2014 03:29 PM, Eli Zaretskii wrote: >> Date: Thu, 13 Feb 2014 11:31:58 -0800 (PST) >> From: Drew Adams >> >> emacs -Q >> M-x load-library ediff >> C-h v ediff-highlight-all-diffs >> >> No doc shown, just an empty "Documentation:". > That's because of the ediff-defvar-local macro: > > (defcustom ediff-highlight-all-diffs t > "If nil, only the selected differences are highlighted. > Otherwise, all difference regions are highlighted, but the selected region is > shown in brighter colors." > :type 'boolean > :group 'ediff-highlighting) > (ediff-defvar-local ediff-highlight-all-diffs t "") > > It is invoked (here and elsewhere) with an empty string as the doc, so > that's what you get. > > Michael, what's the purpose here? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 04:22:46 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 09:22:46 +0000 Received: from localhost ([127.0.0.1]:51593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEEyr-0001sx-G4 for submit@debbugs.gnu.org; Fri, 14 Feb 2014 04:22:45 -0500 Received: from mtaout26.012.net.il ([80.179.55.182]:56776) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEEyp-0001sf-3D for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 04:22:44 -0500 Received: from conversion-daemon.mtaout26.012.net.il by mtaout26.012.net.il (HyperSendmail v2007.08) id <0N0Z00G00AUCCH00@mtaout26.012.net.il> for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 11:21:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout26.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0Z00FY3BB8SM20@mtaout26.012.net.il>; Fri, 14 Feb 2014 11:21:08 +0200 (IST) Date: Fri, 14 Feb 2014 11:22:32 +0200 From: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' In-reply-to: <52FDCB7B.8090602@stonybrook.edu> X-012-Sender: halo1@inter.net.il To: Michael Kifer Message-id: <83iosicalj.fsf@gnu.org> References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDCB7B.8090602@stonybrook.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 14 Feb 2014 02:53:31 -0500 > From: Michael Kifer > CC: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org> > > Strange. When I run it with .emacs, then > > M-x describe-variable ediff-highlight-all-diffs > > returns > > Documentation: > If nil, only the selected differences are highlighted. > Otherwise, all difference regions are highlighted, but the selected > region is > shown in brighter colors. > > But if it is started with emacs -q then the documentation string is not > shown. What is in your .emacs? Anyway, can you explain why do we need _both_ defcustom and ediff-defvar-local for the same variable? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 05:21:04 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 10:21:04 +0000 Received: from localhost ([127.0.0.1]:51674 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEFtI-0003d8-AG for submit@debbugs.gnu.org; Fri, 14 Feb 2014 05:21:04 -0500 Received: from mail-qa0-f46.google.com ([209.85.216.46]:40236) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEFtF-0003cT-Hb for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 05:21:02 -0500 Received: by mail-qa0-f46.google.com with SMTP id k15so4556955qaq.5 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 02:20:56 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=rnu0uDj6EhapVBhM6MpYl2EwFSyrcfb4VjQI67H7c88=; b=HWWJ/43WzzbCXuQpLxWo3MMnjUkvox8ercbXwX8VnO1SXpVIEm3k2PEapRTCDfN62Q HFBYEzroUZOquMGIT1pdCYqMCDpYiXUjBCBBfUOObOcsw2/Uz/9xIIw6muEg8su5bNt8 TOcIM4xE2+ndaNODjCgzXES4m4QnHP1LDUx58nUVFe4MaPrKk2L2xWmHpuOGCD5laOIY D/Ohcx49DwZ+nh+3LlFZiBMUgsDa951RWRELiH8oStNt/4q4NZAFRYLJPc5CS3keImpX VLMDa5qJ6NQ9KMOXe+2dfxVty2nmGyflvRh5eNGYuoq9YlU9GeZO8C/99ZpLUb0utSqW w3gw== X-Gm-Message-State: ALoCoQlIuKXItiEj2Sl1ineubojKyZa90C1tAHtGrPCC2l5Bxlxr+2qK1JglEF52j26ur63/+zSf X-Received: by 10.224.45.197 with SMTP id g5mr11491612qaf.52.1392373256121; Fri, 14 Feb 2014 02:20:56 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id r7sm7084194qgr.17.2014.02.14.02.20.55 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 02:20:55 -0800 (PST) Message-ID: <52FDEE06.4080006@stonybrook.edu> Date: Fri, 14 Feb 2014 05:20:54 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDCB7B.8090602@stonybrook.edu> <83iosicalj.fsf@gnu.org> In-Reply-To: <83iosicalj.fsf@gnu.org> Content-Type: text/html; charset=windows-1255 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/14/2014 04:22 AM, Eli Zaretskii wrote:
Date: Fri, 14 Feb 2014 02:53:31 -0500
From: Michael Kifer <michael.kifer@stonybrook.edu>
CC: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org>

Strange. When I run it with .emacs, then

M-x describe-variable ediff-highlight-all-diffs

returns

Documentation:
If nil, only the selected differences are highlighted.
Otherwise, all difference regions are highlighted, but the selected 
region is
shown in brighter colors.

But if it is started with emacs -q then the documentation string is not 
shown.

What is in your .emacs?

Lots of things. I need to see what is making the difference.

Anyway, can you explain why do we need _both_ defcustom and
ediff-defvar-local for the same variable?

ediff-defvar-local makes the var permanent local.
From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 05:43:55 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 10:43:55 +0000 Received: from localhost ([127.0.0.1]:51707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEGFO-0004IQ-FP for submit@debbugs.gnu.org; Fri, 14 Feb 2014 05:43:55 -0500 Received: from mail-qc0-f172.google.com ([209.85.216.172]:38523) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEGFM-0004IA-97 for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 05:43:52 -0500 Received: by mail-qc0-f172.google.com with SMTP id c9so19939627qcz.3 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 02:43:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=87g5HSo6jaNukyyES1d4FyMR/lfaPM+Ob3mo+NrVGhM=; b=WNvymKqb8KoLhRLnGmc2jgQpo1+7Ol7oV2I1x6K8/RYwIYrPnrzOnTTU4Ec9bKmFGO JDVUs0caBS3aMlUpl3jwZuA0OKyS7RjpXwjbeEjK+8iqkzuiAcOMRa8dom4ezMJVfeB0 7c+NGUcdfbzqpTnMCYp3IlAndcvsjoZu7H2hvVG1kCgw47k+qC7+lPvrn+K0ICZ6mA9o Basn21z4dY+9kTZTM9jXVgG6vAHWKiwpciRFBkTqXeLWZCCZXOiooYVZq8h7f4mRu+X2 d5xd8uHuziA1fHppaEhEydYbeftRZWcGEe6yWazFjviFOtoJ0lGjOcTWyn3TQVenQxD/ 40hg== X-Gm-Message-State: ALoCoQlb6FT8yjVYm2U4l074qj/ybjfA9dgZVzgo4ZOh27ct98dbSBX3XgP+3cMTkN9k9m5wkkwV X-Received: by 10.140.44.6 with SMTP id f6mr10937029qga.10.1392374626795; Fri, 14 Feb 2014 02:43:46 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id p8sm7163219qga.9.2014.02.14.02.43.45 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 02:43:46 -0800 (PST) Message-ID: <52FDF361.5060903@stonybrook.edu> Date: Fri, 14 Feb 2014 05:43:45 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii , Drew Adams Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> In-Reply-To: <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/13/2014 03:29 PM, Eli Zaretskii wrote:
Date: Thu, 13 Feb 2014 11:31:58 -0800 (PST)
From: Drew Adams <drew.adams@oracle.com>

emacs -Q
M-x load-library ediff
C-h v ediff-highlight-all-diffs

No doc shown, just an empty "Documentation:".

That's because of the ediff-defvar-local macro:

  (defcustom ediff-highlight-all-diffs t
    "If nil, only the selected differences are highlighted.
  Otherwise, all difference regions are highlighted, but the selected region is
  shown in brighter colors."
    :type 'boolean
    :group 'ediff-highlighting)
  (ediff-defvar-local ediff-highlight-all-diffs t "")

It is invoked (here and elsewhere) with an empty string as the doc, so
that's what you get.

Michael, what's the purpose here?
This problem is caused by some change in the emacs compiler.
The reason I was not seeing it is because I was using .elc files of my development copy of ediff, which were compiled with an older version of emacs. With those .elc's the documentation string was being shown.

Perhaps the empty doc-string in defvar now zaps the doc-string specified in the preceding defcustom while previously it didn't? If so, the previous behavior was smarter.
From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 06:14:19 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 11:14:19 +0000 Received: from localhost ([127.0.0.1]:51742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEGio-0005Cf-Ln for submit@debbugs.gnu.org; Fri, 14 Feb 2014 06:14:18 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:55482) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEGil-0005C5-PH for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 06:14:17 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N0Z00100GC5G700@a-mtaout20.012.net.il> for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 13:14:09 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N0Z001ANGJK6F70@a-mtaout20.012.net.il>; Fri, 14 Feb 2014 13:14:09 +0200 (IST) Date: Fri, 14 Feb 2014 13:14:05 +0200 From: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' In-reply-to: <52FDF361.5060903@stonybrook.edu> X-012-Sender: halo1@inter.net.il To: Michael Kifer Message-id: <83bnyac5fm.fsf@gnu.org> References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 14 Feb 2014 05:43:45 -0500 > From: Michael Kifer > CC: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org> > > This problem is caused by some change in the emacs compiler. > The reason I was not seeing it is because I was using .elc files of > my development copy of ediff, which were compiled with an older > version of emacs. With those .elc's the documentation string was > being shown. > > Perhaps the empty doc-string in defvar now zaps the doc-string > specified in the preceding defcustom while previously it didn't? If > so, the previous behavior was smarter. But why do we need both the defcustom and the defvar in the macro? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 14:14:32 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 19:14:32 +0000 Received: from localhost ([127.0.0.1]:52654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEODX-0007Mh-Sw for submit@debbugs.gnu.org; Fri, 14 Feb 2014 14:14:32 -0500 Received: from mail-qc0-f182.google.com ([209.85.216.182]:41067) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEODV-0007MT-IF for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 14:14:29 -0500 Received: by mail-qc0-f182.google.com with SMTP id c9so20875883qcz.13 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 11:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=AyZpiEo8pMXJD9iQw7bfDLEZ8XNcsA/Ab9kK1QRo9Ek=; b=EHrIxVpT34swpDm8H5+pLktIcojJyqmg+z/qpIL4onSsQ7QP/LSz+v3rbmz6d7Ei+T 7Fyy0FuDV+eUBhGyoWaKOsl6/vbUwX1ZDV92g7Q2k48u1h6KBZONtcxOq9o+I11+pPkP ifykr8LT3JuqfoFNVMbIX3d6h5TG7BYyNJ2NJyJAZZ5eg/UnB/PocgFsOOmC8ukwSTzV Lmz5I87xSe3bu0y8DobMH/zdC6hG/P1T8iIDjUrET1DzHrIsn/u6HUoXalb+Y42EyOAU y/ccN9q18J1eEwmcj88CqyMbs50AoPKIGZI+NjeWx3m8LclKDy4C2ZVQ5P8w2CIfZ3zb qLSw== X-Gm-Message-State: ALoCoQmBV/yg6VHBWqAkT6axTi2iTwNL4JtsuZ+zQwEQB3FWw63jIDNSFpwfWK7lUwb3rep9qgT+ X-Received: by 10.224.131.135 with SMTP id x7mr2716633qas.15.1392405263907; Fri, 14 Feb 2014 11:14:23 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id l40sm9045056qga.13.2014.02.14.11.14.23 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 11:14:23 -0800 (PST) Message-ID: <52FE6B0E.5060203@stonybrook.edu> Date: Fri, 14 Feb 2014 14:14:22 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> In-Reply-To: <83bnyac5fm.fsf@gnu.org> Content-Type: text/html; charset=windows-1255 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/14/2014 06:14 AM, Eli Zaretskii wrote:
Date: Fri, 14 Feb 2014 05:43:45 -0500
From: Michael Kifer <michael.kifer@stonybrook.edu>
CC: "16744@debbugs.gnu.org" <16744@debbugs.gnu.org>

    This problem is caused by some change in the emacs compiler.
    The reason I was not seeing it is because I was using .elc files of
    my development copy of ediff, which were compiled with an older
    version of emacs. With those .elc's the documentation string was
    being shown.

    Perhaps the empty doc-string in defvar now zaps the doc-string
    specified in the preceding defcustom while previously it didn't? If
    so, the previous behavior was smarter.

But why do we need both the defcustom and the defvar in the macro?

First, this was written a few years before defcustom came about. Second, I haven't followed things for a number of years.
Is it possible to define permanent local vars using defcustom now? At the time defcustom was added to ediff, this wasn't possible as far as I remember.
From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 15:58:59 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 20:58:59 +0000 Received: from localhost ([127.0.0.1]:52695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEPqc-00028F-OU for submit@debbugs.gnu.org; Fri, 14 Feb 2014 15:58:59 -0500 Received: from mtaout29.012.net.il ([80.179.55.185]:45399) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEPqa-00027v-JU for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 15:58:57 -0500 Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0N100000070TB600@mtaout29.012.net.il> for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 23:01:08 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N1000PT37PV4630@mtaout29.012.net.il>; Fri, 14 Feb 2014 23:01:08 +0200 (IST) Date: Fri, 14 Feb 2014 22:58:47 +0200 From: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' In-reply-to: <52FE6B0E.5060203@stonybrook.edu> X-012-Sender: halo1@inter.net.il To: Michael Kifer Message-id: <83ppmpbed4.fsf@gnu.org> References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 14 Feb 2014 14:14:22 -0500 > From: Michael Kifer > CC: drew.adams@oracle.com, 16744@debbugs.gnu.org > > But why do we need both the defcustom and the defvar in the macro? > > First, this was written a few years before defcustom came about. > Second, I haven't followed things for a number of years. > Is it possible to define permanent local vars using defcustom now? I don't know. Anyone? From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 16:08:26 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 21:08:27 +0000 Received: from localhost ([127.0.0.1]:52709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEPzm-0002Rj-Hs for submit@debbugs.gnu.org; Fri, 14 Feb 2014 16:08:26 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56835 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEPzk-0002RZ-K3 for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 16:08:25 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WEPzi-0000yg-Uz; Fri, 14 Feb 2014 16:08:22 -0500 From: Glenn Morris To: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> X-Spook: BATF Sears Tower George W. Bush militia Downing Street X-Ran: )Xa\@R/pk.$)2g0oS}:M@;VxsQ1[xw!B3iz&7hL2i:>>:A!n#^n9%sdrhJ#>~VB2}CUs]- X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 14 Feb 2014 16:08:22 -0500 In-Reply-To: <83ppmpbed4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 14 Feb 2014 22:58:47 +0200") Message-ID: <0j7g8xo115.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 16744 Cc: Michael Kifer , 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Eli Zaretskii wrote: >> Is it possible to define permanent local vars using defcustom now? > > I don't know. Anyone? No. (Buffer-local defcustoms generally don't work very well.) http://debbugs.gnu.org/cgi/bugreport.cgi?bug=14591 From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 16:52:37 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 21:52:37 +0000 Received: from localhost ([127.0.0.1]:52715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEQgW-0003mg-34 for submit@debbugs.gnu.org; Fri, 14 Feb 2014 16:52:36 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:56285) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEQgS-0003mL-40 for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 16:52:33 -0500 Received: by mail-qa0-f44.google.com with SMTP id w5so19317099qac.31 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 13:52:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=4eME0tMdsFi0WfbQL85WmZucBtvAS7a1g4fsEGttBTE=; b=T0nPz3WObWT7ar9kdkmY120Fg2ki/gRIEPBAWRxnXa3aHTAGZzxRqsq2Xo/oe+SO/q lQNQdD/R8ef89/+wopJ9VAzZRWY8KC5cPNUEycmbM704rTkRb6GwsTAvi4web3PxM4z6 2oJT9USYdM3HdypovEf2qLV0ZaEaFVtPAPj5aVu1hjVe8S0PmFgfR23eGo8IXdlILgzg orfjMA48zIcrEeZVXsQUdqJw0ngcM8rLSFm/95WyP8hCV0v/TWXsphOrXvfQih8J4SyD Dex7cinknEQyZvDvFKvHo2JIm/djhfg0LOo9AKSD+YhVCAOSyS5l06iG1/1IrnWRfQwg 7/cQ== X-Gm-Message-State: ALoCoQn5sbi9z99PszMBu4lGcC+lb4y6CbEhJjwUSwudU8JZFhzhAYUC3O6wnMPpb5LRAIGjNeQL X-Received: by 10.140.40.5 with SMTP id w5mr16342774qgw.65.1392414746344; Fri, 14 Feb 2014 13:52:26 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id r40sm9685718qga.23.2014.02.14.13.52.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 13:52:25 -0800 (PST) Message-ID: <52FE9019.90604@stonybrook.edu> Date: Fri, 14 Feb 2014 16:52:25 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Eli Zaretskii Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> In-Reply-To: <83ppmpbed4.fsf@gnu.org> Content-Type: text/html; charset=windows-1255 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: drew.adams@oracle.com, 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/14/2014 03:58 PM, Eli Zaretskii wrote:
Date: Fri, 14 Feb 2014 14:14:22 -0500
From: Michael Kifer <michael.kifer@stonybrook.edu>
CC: drew.adams@oracle.com, 16744@debbugs.gnu.org

But why do we need both the defcustom and the defvar in the macro?

    First, this was written a few years before defcustom came about.
    Second, I haven't followed things for a number of years.
    Is it possible to define permanent local vars using defcustom now?

I don't know.  Anyone?
So, Glen's reply confirms it.  Short of fixing defcustom, the right solution would be to tell defvar to not zap defcustom's doc-string with an empty string, as it was before the change.  Not sure when this change in behavior of defvar happened, but probably within the last year or so.
From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 17:22:03 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 22:22:04 +0000 Received: from localhost ([127.0.0.1]:52740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WER91-0004dR-Gi for submit@debbugs.gnu.org; Fri, 14 Feb 2014 17:22:03 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:60092 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WER8z-0004d8-Kb for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 17:22:02 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WER8y-0004V7-Im; Fri, 14 Feb 2014 17:22:00 -0500 From: Glenn Morris To: Michael Kifer Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> <52FE9019.90604@stonybrook.edu> X-Spook: import pipeline strategic Albanian JPL USCODE Elvis X-Ran: X[%Iy*7Nb9A1D3X}bci**=T.gN:V>ZI*4sza2Ei|xZ,qyB(P8:C8z<07e<#=\@*~6U5/Js X-Hue: yellow X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 14 Feb 2014 17:22:00 -0500 In-Reply-To: <52FE9019.90604@stonybrook.edu> (Michael Kifer's message of "Fri, 14 Feb 2014 16:52:25 -0500") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 16744 Cc: Eli Zaretskii , 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Michael Kifer wrote: > Short of fixing defcustom, defcustom does not need fixing IMO. > the right solution would be to tell defvar to not zap defcustom's > doc-string with an empty string, What? Why not just don't use ediff-defvar-local with defcustoms? Just write the two extra lines by hand? AFAICS, it's precisely two variables that seem to be affected: ediff-use-faces, ediff-highlight-all-diffs So this email is longer than the change that will be needed. > as it was before the change.=C2=A0 Not sure when this change in behavior > of defvar happened, but probably within the last year or so. Pretty sure it's this three-year old change: http://debbugs.gnu.org/1821 rather than something to do with the byte-compiler or defcustom or whatever. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 17:35:36 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 22:35:36 +0000 Received: from localhost ([127.0.0.1]:52750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WERM8-00052M-Fg for submit@debbugs.gnu.org; Fri, 14 Feb 2014 17:35:36 -0500 Received: from mail-qc0-f171.google.com ([209.85.216.171]:49942) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WERM4-000523-QP for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 17:35:33 -0500 Received: by mail-qc0-f171.google.com with SMTP id n7so21056530qcx.16 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 14:35:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=LHRLwwkUelMVGfqgqJ2UHcwkx5ye1pXgg1fY/Y3Dhgg=; b=SpJPuG+HWwy4nPfV0MCA1svb8NdNViBMj5ChgPWRsOVyF01/OfHedMUd7QjhZwmYAD areRP7zQReYRz2MouPryTcKcLsxzCXlnmkayXU9zemt1MnAWfoePdyaxR9YqunEdhnUW SIGpryIbqCt65o5TSHI2PCyRCBE+b7Kbe0UIx+kqrXe2Qycm7XEjp53KOKzOUxeI5l3I yKsv9jWd/4oOanPLM2cfrChpyEgKMFI3PMGiFSGjhGl+jkLIs1fSoaOobgQZiLcRQPI/ l5ic25flqLssNSyPYNmst8+yeYFpnmXZk4YXiEFpAMBaJJeCODsOk8kVzRFLReKofByz +poQ== X-Gm-Message-State: ALoCoQkHsBb2RVnDzW34ezNUk9YKw2zAwv3cK0HDYaclmjFiEGbJW5dOvXq05n2nojEgYj/hegRa X-Received: by 10.224.131.72 with SMTP id w8mr469130qas.97.1392417327214; Fri, 14 Feb 2014 14:35:27 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id k95sm9853364qgd.22.2014.02.14.14.35.26 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 14:35:26 -0800 (PST) Message-ID: <52FE9A2E.7020408@stonybrook.edu> Date: Fri, 14 Feb 2014 17:35:26 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> <52FE9019.90604@stonybrook.edu> In-Reply-To: Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: Eli Zaretskii , 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/14/2014 05:22 PM, Glenn Morris wrote:
Michael Kifer wrote:


 Short of fixing defcustom,

defcustom does not need fixing IMO.


the right solution would be to tell defvar to not zap defcustom's
doc-string with an empty string,

What?
Why not just don't use ediff-defvar-local with defcustoms?
Just write the two extra lines by hand?

Which two lines? edif-defvar-local is just a macro, which produces a defvar.
It is this defvar that zaps the doc string.

You may have missed the earlier part of this thread, but this was working fine the previous time I compiled ediff
with emacs 24.3.50. This was in September 2013. So, the bug is not 3 years old.
From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 14 18:24:21 2014 Received: (at 16744) by debbugs.gnu.org; 14 Feb 2014 23:24:21 +0000 Received: from localhost ([127.0.0.1]:52774 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WES7I-0006QO-Ew for submit@debbugs.gnu.org; Fri, 14 Feb 2014 18:24:20 -0500 Received: from mail-qa0-f46.google.com ([209.85.216.46]:54245) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WES7F-0006Q8-To for 16744@debbugs.gnu.org; Fri, 14 Feb 2014 18:24:18 -0500 Received: by mail-qa0-f46.google.com with SMTP id k15so5788804qaq.5 for <16744@debbugs.gnu.org>; Fri, 14 Feb 2014 15:24:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=yqApbIqaFQ4CWrBOoOH5IRV+6xj9u+ZD27VMiNCWIUI=; b=gi/mo9V48ZzwGqdNfESmjI5EyhddzE5SWfOYW3qXGxX+3DzcQq6VhWlJn1710Ol0Io 9psHkdGCsOkoZKRExEGcO963gbuQGgLCl52Ao1SmKYjk3GNPakjP5iIYtzVd0jADmssp qzMyeOhI+p6Qv6/3hBmWrgZt8CFubgafZvXK9nl0MfvWTmZha1nPFNCfC9+Z+3LWNL8e V9Xks/MOwYc8mTCRHA7+eXRRSJOZsKVRhI44qyzYBHBbo0a3NvIWW5Q0TtGs6kPilQCj zyiWPDV9WKiZ9+a+5YEze2zAXh2ZtOq2RnLAhdfllx+i3AyghUbCzK8QoZXA+YOanWng Yk8w== X-Gm-Message-State: ALoCoQnxRHmS3MM8A8VGtWkiwYFf5oGSv3sPPyTVFAHg8S0hCuhJeNMcagbT73Rb68sJx/7/1394 X-Received: by 10.140.89.71 with SMTP id u65mr16900492qgd.93.1392420252328; Fri, 14 Feb 2014 15:24:12 -0800 (PST) Received: from [192.168.1.106] (ool-18bf44a9.dyn.optonline.net. [24.191.68.169]) by mx.google.com with ESMTPSA id q10sm20008974qaj.13.2014.02.14.15.24.11 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 14 Feb 2014 15:24:11 -0800 (PST) Message-ID: <52FEA59A.7090402@stonybrook.edu> Date: Fri, 14 Feb 2014 18:24:10 -0500 From: Michael Kifer User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Glenn Morris Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> <52FE9019.90604@stonybrook.edu> In-Reply-To: Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: 16744 Cc: Eli Zaretskii , 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.4 (/)
On 02/14/2014 05:22 PM, Glenn Morris wrote:
Michael Kifer wrote:


>  Short of fixing defcustom,

defcustom does not need fixing IMO.


> the right solution would be to tell defvar to not zap defcustom's
> doc-string with an empty string,

What?
Why not just don't use ediff-defvar-local with defcustoms?
Just write the two extra lines by hand?

oh, I see what you mean now. Yes, this is simple enough.
From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 05:03:03 2014 Received: (at 16744) by debbugs.gnu.org; 15 Feb 2014 10:03:04 +0000 Received: from localhost ([127.0.0.1]:52945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEc5P-0001Ye-IL for submit@debbugs.gnu.org; Sat, 15 Feb 2014 05:03:03 -0500 Received: from mail-out.m-online.net ([212.18.0.10]:54421) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEc5N-0001YE-CS for 16744@debbugs.gnu.org; Sat, 15 Feb 2014 05:03:02 -0500 Received: from frontend1.mail.m-online.net (frontend1.mail.intern.m-online.net [192.168.8.180]) by mail-out.m-online.net (Postfix) with ESMTP id 3fR6Tb3bxNz3hj1W; Sat, 15 Feb 2014 11:02:59 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.68]) by mail.m-online.net (Postfix) with ESMTP id 3fR6Tb17THzbbgs; Sat, 15 Feb 2014 11:02:59 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.180]) by localhost (dynscan1.mail.m-online.net [192.168.6.68]) (amavisd-new, port 10024) with ESMTP id wB-cIevLhgsE; Sat, 15 Feb 2014 11:02:58 +0100 (CET) X-Auth-Info: iBk2KaQ60qBLu+SgS/qMqQV5omFt/U8PSS4odT0134k= Received: from linux.local (ppp-88-217-51-122.dynamic.mnet-online.de [88.217.51.122]) by mail.mnet-online.de (Postfix) with ESMTPA; Sat, 15 Feb 2014 11:02:58 +0100 (CET) Received: by linux.local (Postfix, from userid 501) id 6389F1E55E2; Sat, 15 Feb 2014 11:02:53 +0100 (CET) From: Andreas Schwab To: Michael Kifer Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> <52FE9019.90604@stonybrook.edu> X-Yow: I don't think you fellows would do so much RAPING and PILLAGING if you played more PINBALL and watched CABLE TELEVISION!! Date: Sat, 15 Feb 2014 11:02:53 +0100 In-Reply-To: <52FE9019.90604@stonybrook.edu> (Michael Kifer's message of "Fri, 14 Feb 2014 16:52:25 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16744 Cc: 16744@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Michael Kifer writes: > Please fix your mailer. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 15 22:34:33 2014 Received: (at 16744-done) by debbugs.gnu.org; 16 Feb 2014 03:34:33 +0000 Received: from localhost ([127.0.0.1]:54108 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEsUz-00012Y-A6 for submit@debbugs.gnu.org; Sat, 15 Feb 2014 22:34:33 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56842 ident=Debian-exim) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WEsUx-00012N-4B for 16744-done@debbugs.gnu.org; Sat, 15 Feb 2014 22:34:31 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WEsUw-0005qr-1q; Sat, 15 Feb 2014 22:34:30 -0500 From: Glenn Morris To: 16744-done@debbugs.gnu.org Subject: Re: bug#16744: 24.3.50; REGRESSION: C-h v does not show doc for `ediff-highlight-all-diffs' References: <4d0cbf1a-914e-493c-bb2f-186229902418@default> <1913911dabee4a1e979c4914631ac676@HUBCAS2.cs.stonybrook.edu> <52FDF361.5060903@stonybrook.edu> <83bnyac5fm.fsf@gnu.org> <52FE6B0E.5060203@stonybrook.edu> <83ppmpbed4.fsf@gnu.org> <52FE9019.90604@stonybrook.edu> X-Spook: e-bomb rs9512c event security anthrax Chobetsu bullion X-Ran: ""0>@;ot5nDw$3WARQ=[rL'/~u-4XZLh?_+:3a)TmK9+(#aR']N0^yamxKx%;Tr|9+SH,x X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Sat, 15 Feb 2014 22:34:29 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.7 (-----) X-Debbugs-Envelope-To: 16744-done Cc: Michael Kifer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.7 (-----) Version: 24.4 Fixed. http://lists.gnu.org/archive/html/emacs-diffs/2014-02/msg00221.html From unknown Sun Sep 07 18:03:29 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 16 Mar 2014 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator