GNU bug report logs - #16729
suggested small refactoring in dfa.c

Previous Next

Full log

View this message in rfc822 format

From: arnold <at> skeeve.com
To: 16729 <at> debbugs.gnu.org
Subject: bug#16729: suggested small refactoring in dfa.c
Date: Wed, 12 Feb 2014 06:58:53 -0700

Hi Jim, Paul.

Here is the small refactoring I suggest for dfa.c

Thanks,

Arnold
--------------------
diff --git a/dfa.c b/dfa.c
index d5e7fdf..dcd28e5 100644
--- a/dfa.c
+++ b/dfa.c
@@ -1767,18 +1767,19 @@ add_utf8_anychar (void)
 static void
 atom (void)
 {
-  if (0)
+  if (MBS_SUPPORT && tok == WCHAR)
     {
-      /* empty */
-    }
-  else if (MBS_SUPPORT && tok == WCHAR)
-    {
-      addtok_wc (case_fold ? towlower (wctok) : wctok);
-      if (case_fold && iswalpha (wctok))
-        {
-          addtok_wc (towupper (wctok));
-          addtok (OR);
-        }
+      if (! case_fold)
+        addtok_wc (wctok);
+      else
+      {
+        addtok_wc (towlower (wctok));
+        if (iswalpha (wctok))
+          {
+            addtok_wc (towupper (wctok));
+            addtok (OR);
+          }
+      }
 
       tok = lex ();
     }

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.