From unknown Wed Aug 20 06:04:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16708: 24.3.50; font-lock nadvice mechanism Resent-From: Nicolas Richard Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2014 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16708@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.139203844417931 (code B ref -1); Mon, 10 Feb 2014 13:21:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Feb 2014 13:20:44 +0000 Received: from localhost ([127.0.0.1]:39321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCqmx-0004f8-HQ for submit@debbugs.gnu.org; Mon, 10 Feb 2014 08:20:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53059) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCqmv-0004es-GT for submit@debbugs.gnu.org; Mon, 10 Feb 2014 08:20:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCqmg-0005TU-GQ for submit@debbugs.gnu.org; Mon, 10 Feb 2014 08:20:35 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34463) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCqmg-0005TQ-DZ for submit@debbugs.gnu.org; Mon, 10 Feb 2014 08:20:26 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54744) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCqmZ-0006w3-3m for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 08:20:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WCqmR-0005Rn-R0 for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 08:20:19 -0500 Received: from mxin.ulb.ac.be ([164.15.128.112]:58850) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WCqmR-0005Rf-KW for bug-gnu-emacs@gnu.org; Mon, 10 Feb 2014 08:20:11 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AhsHAJjR+FKkD4Xx/2dsb2JhbABZrQGCQgGRDoQsdIM9JDQBiFABFJlDj2iWZAGJNIdyhyiEIgSYK4Yxi3CDLjs Received: from mathsrv4.ulb.ac.be (HELO geodiff-mac3) ([164.15.133.241]) by smtp.ulb.ac.be with ESMTP; 10 Feb 2014 14:20:10 +0100 From: Nicolas Richard Date: Mon, 10 Feb 2014 14:20:10 +0100 Message-ID: <87r47b14vp.fsf@yahoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, I suggest to add `add-function' and `advice-add' (which are used instead of defadvice at some places) to the font-lock in lisp mode, just as defadvice is. Perhaps lisp-imenu-generic-expression should be updated too, I don't know what it is exactly. e.g. diff --git a/lisp/emacs-lisp/lisp-mode.el b/lisp/emacs-lisp/lisp-mode.el index db15aea..8fe7095 100644 --- a/lisp/emacs-lisp/lisp-mode.el +++ b/lisp/emacs-lisp/lisp-mode.el @@ -170,7 +170,7 @@ It has `lisp-mode-abbrev-table' as its parent." "ignore-errors" "dotimes" "dolist" "declare")) (lisp-errs '("warn" "error" "signal")) ;; Elisp constructs. FIXME: update dynamically from obarray. - (el-fdefs '("defadvice" "defalias" + (el-fdefs '("defadvice" "add-function" "advice-add" "defalias" "define-derived-mode" "define-minor-mode" "define-generic-mode" "define-global-minor-mode" "define-globalized-minor-mode" "define-skeleton" -- Nico. From unknown Wed Aug 20 06:04:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16708: 24.3.50; font-lock nadvice mechanism Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Feb 2014 16:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Nicolas Richard Cc: 16708@debbugs.gnu.org Received: via spool by 16708-submit@debbugs.gnu.org id=B16708.13920514529195 (code B ref 16708); Mon, 10 Feb 2014 16:58:02 +0000 Received: (at 16708) by debbugs.gnu.org; 10 Feb 2014 16:57:32 +0000 Received: from localhost ([127.0.0.1]:41556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCuAm-0002OF-1Y for submit@debbugs.gnu.org; Mon, 10 Feb 2014 11:57:32 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:55269) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCuAj-0002Nz-RY for 16708@debbugs.gnu.org; Mon, 10 Feb 2014 11:57:30 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFHO+KAF/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFHO+KAF/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgbBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="47206734" Received: from 206-248-160-5.dsl.teksavvy.com (HELO pastel.home) ([206.248.160.5]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 10 Feb 2014 11:57:24 -0500 Received: by pastel.home (Postfix, from userid 20848) id 07AB3616C6; Mon, 10 Feb 2014 11:57:24 -0500 (EST) From: Stefan Monnier Message-ID: References: <87r47b14vp.fsf@yahoo.fr> Date: Mon, 10 Feb 2014 11:57:23 -0500 In-Reply-To: <87r47b14vp.fsf@yahoo.fr> (Nicolas Richard's message of "Mon, 10 Feb 2014 14:20:10 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I suggest to add `add-function' and `advice-add' (which are used instead > of defadvice at some places) to the font-lock in lisp mode, just as > defadvice is. It might be OK for advice-add but I'm not sure it makes sense for add-function. > Perhaps lisp-imenu-generic-expression should be updated too, I don't > know what it is exactly. No, imenu should point to the "definition site", whereas advice-add does not define a function, it merely modifies it. Stefan From unknown Wed Aug 20 06:04:21 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16708: 24.3.50; font-lock nadvice mechanism Resent-From: Noam Postavsky Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 29 Jan 2018 01:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16708 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: Nicolas Richard , 16708@debbugs.gnu.org Received: via spool by 16708-submit@debbugs.gnu.org id=B16708.151718916811604 (code B ref 16708); Mon, 29 Jan 2018 01:27:02 +0000 Received: (at 16708) by debbugs.gnu.org; 29 Jan 2018 01:26:08 +0000 Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efyD2-000311-E5 for submit@debbugs.gnu.org; Sun, 28 Jan 2018 20:26:08 -0500 Received: from mail-it0-f54.google.com ([209.85.214.54]:37897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1efyD0-00030Q-3B; Sun, 28 Jan 2018 20:26:06 -0500 Received: by mail-it0-f54.google.com with SMTP id w14so7451917itc.3; Sun, 28 Jan 2018 17:26:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=SZoP9EAQORhcL5N+P0sPVfX1eucew6HExA8OXBBXYvs=; b=G511F0T3eCuakbr3zHKavPWO3wBFY3Gvcuz5RpKCeTuHJfuVqcSx6qsPfP43Gz+QzJ LKlwzRpn0AJW/WcG0ptSstHrOb/61N5l7dTCDn8WGoEiywBMqYnqwI1zZf9OqeNK/Y6O D/hM3sjssY3d6hldFYWUntIA5/ygHu7Zjj3+Zovnr4Ps2URdx2cKVTqN2vfxJ2yKaxTY UHqavXC4oA036PtuFrtspY6Faa+5E6qB+m+MT1NlZAcdHTPHjHiwB4NuSVBTxULyeJcf Mp4JJOmQgzoMFND+HCYUuyYpogfH5dDTBBaVxWQLUw/oTbPWW6t1zMIt5ksJAtJvK15S OX6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=SZoP9EAQORhcL5N+P0sPVfX1eucew6HExA8OXBBXYvs=; b=U18QYrZRRBvQ3PHMYxr2L4tec+ake+fEuJKBa2J+oBfbW6wCILNxHaC1RiOhNeaBkW 0Ey5F1w4cqGRbsrN9d2BOLy0jPkb1kRWAlhblL8B+KRX2vPk5ITw+UCsNdcPikTZhzQU cgRMPclfv6NFYT3vCevVSWos12F7a358ANlqKQeQGaKBum3aSJjp8B/BsSWydlYfrq5X e700irpNA/3Tjt/F5kcufYQxNpZrA2jiRZ1K+QjOLM/bJl9hN8cuiF68FFsiM0qaPmkp +Xh9YUYgstSEW+JMhu+bpR9eVgGl4a1FOKim4/4d6LWXBWGUU8enUxxYP2HjQB4RPTP/ KtMQ== X-Gm-Message-State: AKwxytdhYe3/3/T6yqLgLSdyhlRH+6v+kVAAaxaUZqrySbZBEmAtUnzs l5IYjzUwXK4A+ILUXEGoLnyvrB4S X-Google-Smtp-Source: AH8x227k69QIb8DlpRqb2L1FZvZtm2ycaDkVjMzs+DYYf/6X+9qBsDmvyjd2IQO31zn0aqW0Le0CJg== X-Received: by 10.36.188.198 with SMTP id n189mr24783450ite.91.1517189160456; Sun, 28 Jan 2018 17:26:00 -0800 (PST) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id u32sm3457134ioi.29.2018.01.28.17.25.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 28 Jan 2018 17:25:59 -0800 (PST) From: Noam Postavsky References: <87r47b14vp.fsf@yahoo.fr> Date: Sun, 28 Jan 2018 20:25:58 -0500 In-Reply-To: (Stefan Monnier's message of "Mon, 10 Feb 2014 11:57:23 -0500") Message-ID: <87372pjw0p.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) close 16708 quit Stefan Monnier writes: >> I suggest to add `add-function' and `advice-add' (which are used instead >> of defadvice at some places) to the font-lock in lisp mode, just as >> defadvice is. > > It might be OK for advice-add but I'm not sure it makes sense for > add-function. Well, since we now highlight all macros, add-function is hightlighted, but advice-add isn't. I don't think it's worth special casing it.