GNU bug report logs - #16694
Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources

Previous Next

Full log

Message #84 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Clemens Schüller <cs.mlists+bug-gnu-emacs <at> mailbox.org>
To: emacs bugs <bug-gnu-emacs <at> gnu.org>
Cc: ml_emacs-lists <at> binary-island.eu, cyd <at> gnu.org, joakim.tjernlund <at> transmode.se,
 16694 <at> debbugs.gnu.org
Subject: Re: bug#16694: Strange background color problem in gentoo Linux
Date: Wed, 26 Mar 2014 16:58:11 +0100

Hello!


> Sounds similar to several other bug reports since the regression was
> introduced in December. Most discussion is at
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16694 .
>
> Chong, it would be nice if you could opine about the problem and
> Matthias's patches. The offending commit was:
>
> 15e14b165dcbc6566a0459b0d5e66f89080f569e is the first bad commit
> commit 15e14b165dcbc6566a0459b0d5e66f89080f569e
> Author: Chong Yidong <cyd <at> gnu.org>
> Date: Sat Dec 21 23:31:09 2013 +0800
>
> Don't make faces when loading Custom themes.
>
> * custom.el (custom-theme-recalc-face): Do nothing if the face is
> undefined. Thus, theme settings for undefined faces do not take
> effect until the faces are defined with defface, the same as with
> theme variables.
>
> * faces.el (face-spec-set): Use face-spec-recalc in all cases.
> (face-spec-reset-face): Don't assign extra properties in temacs.
> (face-spec-recalc): Apply X resources too.

Here is my patch, after I copied the ebuild file in my local overlay:

--- /usr/portage/app-editors/emacs-vcs/emacs-vcs-24.4.9999.ebuild       2014-03-21 15:22:30.000000000 +0100
+++ emacs-vcs-24.4.9999.ebuild  2014-03-24 21:20:49.947795118 +0100
@@ -115,6 +115,9 @@
        fi
 
        epatch_user
+       epatch "${FILESDIR}/0001-lisp-faces.el-Fix-application-of-X-resource-attribut.patch"
+       epatch "${FILESDIR}/0002-lisp-faces.el-Fix-empty-face-handling.patch"
+       epatch "${FILESDIR}/0003-lisp-faces.el-Centralize-no-init-from-x-resources-ch.patch"
 
        # Fix filename reference in redirected man page
        sed -i -e "/^\\.so/s/etags/&-${EMACS_SUFFIX}/" doc/man/ctags.1 \


-- 
Best Regards, Clemens Schüller

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.