GNU bug report logs - #16694
Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources

Previous Next

Full log

View this message in rfc822 format

From: Matthias Dahl <ml_emacs-lists <at> binary-island.eu>
To: Eli Zaretskii <eliz <at> gnu.org>, Barry OReilly <gundaetiapo <at> gmail.com>
Cc: 16694 <at> debbugs.gnu.org
Subject: bug#16694: bugs #16694/#16378: Patches
Date: Sun, 23 Mar 2014 18:04:47 +0100

[Message part 1 (text/plain, inline)]

Hello Eli and Barry,

sorry for my brain fart on this one. It was actually a rather late edit
which, even though I tested it and deemed harmless but useful, slipped
through my fingers.

By the way: no-init-from-resources is a global variable set by Emacs
during startup if (and only if) "-Q" is given, thus X resources should
not be applied. In patch 3 I accounted for that but simply forgot to do
the same in patch 1. Oh well.

Attached are the updated patches which should all work just fine now.
Thanks for the feedback and testing btw. Very much appreciated.

So long,
Matthias

[0001-lisp-faces.el-Fix-application-of-X-resource-attribut.patch (text/x-patch, attachment)]

[0002-lisp-faces.el-Fix-empty-face-handling.patch (text/x-patch, attachment)]

[0003-lisp-faces.el-Centralize-no-init-from-x-resources-ch.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.