GNU bug report logs - #16694
Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources

Previous Next

Full log

View this message in rfc822 format

From: Barry OReilly <gundaetiapo <at> gmail.com>
To: Matthias Dahl <ml_emacs-lists <at> binary-island.eu>
Cc: Clemens Schüller <cs.mlists+bug-gnu-emacs <at> mailbox.org>, 16694 <at> debbugs.gnu.org
Subject: bug#16694: bugs #16694/#16378: Patches
Date: Fri, 28 Mar 2014 10:59:22 -0400

[Message part 1 (text/plain, inline)]

The last patch I indicated is my best guess safe patch that solves the
--reverse-video symptom I care about. To summarize my rationale: an
unconditional call to make-face-x-resource-internal was moved down into
face-spec-recalc, but at least one other caller of face-spec-recalc clearly
doesn't want an unconditional call to make-face-x-resource-internal. Moving
the make-face-x-resource-internal call back up one call level to the caller
which the offending patch touched thus seems right.

Matthias, in your patch, that same make-face-x-resource-internal call was
moved to an earlier line in the same face-spec-recalc function, so it's not
obvious how to reconcile your patch with mine. The concern I raised applies
equally to your patch. Maybe you could give my patch a go to see if it has
any effect on your ill symptom. If not, then perhaps you have an idea about
reconciling the patches?

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.