GNU bug report logs - #16694
Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources

Previous Next

Full log

View this message in rfc822 format

From: Joakim Tjernlund <joakim.tjernlund <at> transmode.se>
To: Clemens Schüller <cs.mlists+bug-gnu-emacs <at> mailbox.org>
Cc: ml_emacs-lists <at> binary-island.eu, 16694 <at> debbugs.gnu.org, cyd <at> gnu.org
Subject: bug#16694: Strange background color problem in gentoo Linux
Date: Wed, 26 Mar 2014 19:18:41 +0100

Clemens Schüller <cs.mlists+bug-gnu-emacs <at> mailbox.org> wrote on 2014/03/26 
16:58:11:
> 
> Hello!
> 
> 
> > Sounds similar to several other bug reports since the regression was
> > introduced in December. Most discussion is at
> > http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16694 .
> >
> > Chong, it would be nice if you could opine about the problem and
> > Matthias's patches. The offending commit was:
> >
> > 15e14b165dcbc6566a0459b0d5e66f89080f569e is the first bad commit
> > commit 15e14b165dcbc6566a0459b0d5e66f89080f569e
> > Author: Chong Yidong <cyd <at> gnu.org>
> > Date: Sat Dec 21 23:31:09 2013 +0800
> >
> > Don't make faces when loading Custom themes.
> >
> > * custom.el (custom-theme-recalc-face): Do nothing if the face is
> > undefined. Thus, theme settings for undefined faces do not take
> > effect until the faces are defined with defface, the same as with
> > theme variables.
> >
> > * faces.el (face-spec-set): Use face-spec-recalc in all cases.
> > (face-spec-reset-face): Don't assign extra properties in temacs.
> > (face-spec-recalc): Apply X resources too.
> 
> Here is my patch, after I copied the ebuild file in my local overlay:
> 
> --- /usr/portage/app-editors/emacs-vcs/emacs-vcs-24.4.9999.ebuild 
2014-03-21 15:22:30.000000000 +0100
> +++ emacs-vcs-24.4.9999.ebuild  2014-03-24 21:20:49.947795118 +0100
> @@ -115,6 +115,9 @@
>         fi
> 
>         epatch_user
> +       epatch 
"${FILESDIR}/0001-lisp-faces.el-Fix-application-of-X-resource-attribut.patch"
> +       epatch 
"${FILESDIR}/0002-lisp-faces.el-Fix-empty-face-handling.patch"
> +       epatch 
"${FILESDIR}/0003-lisp-faces.el-Centralize-no-init-from-x-resources-ch.patch"
> 
>         # Fix filename reference in redirected man page
>         sed -i -e "/^\\.so/s/etags/&-${EMACS_SUFFIX}/" doc/man/ctags.1 \

If this is a local fix you are better off using epatch_user than modifying 
the ebuild.
You could also try the easier:
 (setq initial-frame-alist default-frame-alist)

 Jocke

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.