GNU bug report logs - #16689
24.3.50; Interactivity and nadvice

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16689 in the body.
You can then email your comments to 16689 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Interactivity and nadvice
Date: Sat, 08 Feb 2014 07:46:41 -0500

In replacgin all my `defadvice's with `advice-add's, I noticed the new
section in the manual doesn't go into any detail about how interactivity
(prefix commands, etc.) is maintained through the advice call chain.
Can this be added?

Nathan

Message #8 received at 16689 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
Cc: 16689 <at> debbugs.gnu.org
Subject: Re: bug#16689: 24.3.50; Interactivity and nadvice
Date: Wed, 12 Feb 2014 21:10:19 -0500

Nathan Trapuzzano wrote:

> In replacgin all my `defadvice's with `advice-add's, I noticed the new
> section in the manual doesn't go into any detail about how interactivity
> (prefix commands, etc.) is maintained through the advice call chain.

I'm not sure it is the place of the manual to explain _how_ it works.
Could you say in more detail what you want to see added?

Message #11 received at 16689 <at> debbugs.gnu.org (full text, mbox):

From: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16689 <at> debbugs.gnu.org
Subject: Re: bug#16689: 24.3.50; Interactivity and nadvice
Date: Thu, 13 Feb 2014 20:14:49 -0500

Glenn Morris <rgm <at> gnu.org> writes:

> Nathan Trapuzzano wrote:
>
>> In replacgin all my `defadvice's with `advice-add's, I noticed the new
>> section in the manual doesn't go into any detail about how interactivity
>> (prefix commands, etc.) is maintained through the advice call chain.
>
> I'm not sure it is the place of the manual to explain _how_ it works.
> Could you say in more detail what you want to see added?

I'm talking about the interface.  I believe the manual's old section on
defadvice talked about how to change a command's interactive behavior.
The nadvice section doesn't talk about any of that.

Message #14 received at 16689 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16689 <at> debbugs.gnu.org
Subject: Re: bug#16689: 24.3.50; Interactivity and nadvice
Date: Fri, 14 Feb 2014 11:20:56 +0100

Nathan Trapuzzano <nbtrap <at> nbtrap.com> writes:

> I'm talking about the interface.  I believe the manual's old section on
> defadvice talked about how to change a command's interactive behavior.
> The nadvice section doesn't talk about any of that.

I do think so, too.  What the docstring says:

If one of FUNCTION or OLDFUN is interactive, then the resulting function
is also interactive.  There are 3 cases:
- FUNCTION is not interactive: the interactive spec of OLDFUN is used.
- The interactive spec of FUNCTION is itself a function: it should take one
  argument (the interactive spec of OLDFUN, which it can pass to
  `advice-eval-interactive-spec') and return the list of arguments to use.
- Else, use the interactive spec of FUNCTION and ignore the one of OLDFUN.

is already an exhaustive explanation, it could IMHO be used more or less
as is in the manual.

Michael.

Message #19 received at 16689-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Nathan Trapuzzano <nbtrap <at> nbtrap.com>
Cc: 16689-done <at> debbugs.gnu.org
Subject: Re: bug#16689: 24.3.50; Interactivity and nadvice
Date: Tue, 27 May 2014 20:13:51 -0400

> I'm talking about the interface.  I believe the manual's old section on
> defadvice talked about how to change a command's interactive behavior.
> The nadvice section doesn't talk about any of that.

Closing: I believe the doc now does explain how the functions's
interactive-spec are combined.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.