From debbugs-submit-bounces@debbugs.gnu.org Thu Feb 06 14:56:15 2014 Received: (at submit) by debbugs.gnu.org; 6 Feb 2014 19:56:15 +0000 Received: from localhost ([127.0.0.1]:53719 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBV3V-00075P-87 for submit@debbugs.gnu.org; Thu, 06 Feb 2014 14:56:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37314) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBU9G-0005Y7-Gs for submit@debbugs.gnu.org; Thu, 06 Feb 2014 13:58:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBU9A-0004DH-Ki for submit@debbugs.gnu.org; Thu, 06 Feb 2014 13:58:06 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBU9A-0004DD-HA for submit@debbugs.gnu.org; Thu, 06 Feb 2014 13:58:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39012) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBU99-00057g-Cv for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 13:58:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WBU98-0004Cs-IR for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 13:57:59 -0500 Received: from mail-ve0-x232.google.com ([2607:f8b0:400c:c01::232]:34035) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WBU98-0004CY-Eb for bug-gnu-emacs@gnu.org; Thu, 06 Feb 2014 13:57:58 -0500 Received: by mail-ve0-f178.google.com with SMTP id oy12so1870411veb.37 for ; Thu, 06 Feb 2014 10:57:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=75Kgxdbd1z2T8veHSdjSOKQb/yvwJdFZjIQnWrNJxao=; b=EhCa6Re+2/s/cDs3pSa8Cg6Q/d3dj00smZy+GvdGcudrt93ojOxWyvW4bZA/oUFExK wm++PWe0oHskgkWI4dyfFHXGkRZdtQ9GQMYgiJ30+JK+E/bDyYCGLzIDBSPUB8imValS pKWKMyvyuS6kgCWh8RegZD0U4MuugBLka91VKwP+of1KaOgKZEoekzSttXDxRHwTkGU7 e8zk70eoj2ax1P7h+WGdz2xgNZGrZqRairyX10nhniJ4ieFTdutXmCRcI1Cxe9rJYN84 uQTuGDl+KEDmSvu/2KCxWnTXj65q5KYpgv+AejNo4yujfTJKhjbu4IpeuqKtXnauDo6D YCSA== MIME-Version: 1.0 X-Received: by 10.58.181.71 with SMTP id du7mr2817969vec.25.1391713077409; Thu, 06 Feb 2014 10:57:57 -0800 (PST) Received: by 10.58.46.134 with HTTP; Thu, 6 Feb 2014 10:57:57 -0800 (PST) Date: Thu, 6 Feb 2014 18:57:57 +0000 Message-ID: Subject: [saveplace] toggle-save-place doesn't toggle-save-place From: Andy Sawyer To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 06 Feb 2014 14:56:08 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hi all, I noticed a while back that toggle-save-place doesn't actually toggle save-place. Whilst I mostly run Aquamacs these days, the bug exists in the existing codebase. In particular, in a buffer where save-place is nil, it is unconditionally turned on. I submitted a path for this to the Aquamacs maintainer, and include it here for your attention. (I also took the opportunity to use prefix-numeric-value on the argument, so it plays nice with C-u). Regards, Andy $ git diff saveplace.el diff --git a/lisp/saveplace.el b/lisp/saveplace.el index 91da103..0325475 100644 --- a/lisp/saveplace.el +++ b/lisp/saveplace.el @@ -156,12 +156,12 @@ file: (if (not (or buffer-file-name (and (derived-mode-p 'dired-mode) dired-directory))) (message "Buffer `%s' not visiting a file or directory" (buffer-name)) - (if (and save-place (or (not parg) (<= parg 0))) - (progn - (message "No place will be saved in this file") - (setq save-place nil)) - (message "Place will be saved") - (setq save-place t)))) + (setq save-place (if parg + (> (prefix-numeric-value parg) 0) + (not save-place))) + (message (if save-place + "Place will be saved" + "No place will be saved in this file")))) From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 28 01:45:05 2014 Received: (at 16673-done) by debbugs.gnu.org; 28 Feb 2014 06:45:05 +0000 Received: from localhost ([127.0.0.1]:43421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJHBw-0001pE-5O for submit@debbugs.gnu.org; Fri, 28 Feb 2014 01:45:04 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:53494) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJHBs-0001oW-GK for 16673-done@debbugs.gnu.org; Fri, 28 Feb 2014 01:45:01 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WJHBq-0007YO-QS; Fri, 28 Feb 2014 01:44:58 -0500 From: Glenn Morris To: 16673-done@debbugs.gnu.org Subject: Re: bug#16673: [saveplace] toggle-save-place doesn't toggle-save-place References: X-Spook: Watergate New World Order supercomputer bemd CBNRC secure X-Ran: cA/jo* (Andy Sawyer's message of "Thu, 6 Feb 2014 18:57:57 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16673-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Version: 24.4 Thanks; applied. From unknown Fri Aug 15 15:34:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 28 Mar 2014 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator