From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: "Geoff Gole" , 1662@debbugs.gnu.org Resent-From: "Geoff Gole" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Sun, 21 Dec 2008 21:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.122989581928233 (code B ref -1); Sun, 21 Dec 2008 21:50:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 21 Dec 2008 21:43:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.2 required=4.0 tests=MULTALT,MURPHY_WRONG_WORD2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBLLhUct028227 for ; Sun, 21 Dec 2008 13:43:31 -0800 Received: from mx10.gnu.org ([199.232.76.166]:58476) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LEW4M-0006ZR-Df for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:42:38 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LEW5A-00045d-7K for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:43:28 -0500 Received: from wa-out-1112.google.com ([209.85.146.176]:6082) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LEW59-00045Z-LA for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:43:28 -0500 Received: by wa-out-1112.google.com with SMTP id j32so1114191waf.26 for ; Sun, 21 Dec 2008 13:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=JheWVTrP8L0Ah2hBJDCuervHL5xuvMZpa4lX3Jjnc98=; b=x5eUTirv8GdaVKlHqeehgYmpLmc8whfgbc2JJHvy8HaeS9w6/BBtVDUYc9R9Tb8U+A LGb2kSwG4g0je6yQxdHdb/4BIsT+o/NZL1LgTIkXqlLbfPdKArCzJ5otwhAkkOg0jCHK mPVYqPBGQINmf/HJB1WnCFIVZ0Ur+SepFIiaU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=tdCoD3MPG1mjWlytJcdYDA+6E27BCMSJ/w7XXTbwYOBb9kyUz6+QPnlqkkBfjUbzTl TZebhM75eluUYWttJwQIqxXU/cRL/K4LEEFSDoH7MmjWeAjbyUOpQ897q9xfq3MrGubr PsptM2Zc1QO08rh8sgRPImpksyIveblxVbd2Y= Received: by 10.114.26.18 with SMTP id 18mr3558136waz.159.1229895804511; Sun, 21 Dec 2008 13:43:24 -0800 (PST) Received: by 10.114.56.17 with HTTP; Sun, 21 Dec 2008 13:43:24 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2008 06:43:24 +0900 From: "Geoff Gole" To: emacs-pretest-bug@gnu.org MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_38638_26699807.1229895804507" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) ------=_Part_38638_26699807.1229895804507 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The minibuffer prompt displayed by functions that use (interactive) is usually highlighted with the face `minibuffer-prompt'. However, interactive specs "c", "k" and "K" don't do this. To reproduce: emacs -Q M-z Running this function shows the difference more clearly: (defun example-prompt (&rest args) (interactive "sXXXX: \ncXXXX: \nkXXXX: \nKXXXX: ") (ignore args)) In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian (emacs-snapshot package, version 1:20081121-1) Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Also observed in GNU Emacs 22.2.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-11-10 on raven, modified by Debian ------=_Part_38638_26699807.1229895804507 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The minibuffer prompt displayed by functions that use (interactive) is usually
highlighted with the face `minibuffer-prompt'. However, interactive specs "c",
"k" and "K" don't do this.

To reproduce:

  emacs -Q
  M-z

Running this function shows the difference more clearly:

  (defun example-prompt (&rest args)
    (interactive "sXXXX: \ncXXXX: \nkXXXX: \nKXXXX: ")
    (ignore args))

In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-22 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20081121-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Also observed in GNU Emacs 22.2.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-11-10 on raven, modified by Debian
------=_Part_38638_26699807.1229895804507-- From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: martin rudalics , 1662@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 23 Dec 2008 08:05:06 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.12300192356635 (code B ref 1662); Tue, 23 Dec 2008 08:05:06 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 23 Dec 2008 08:00:35 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mBN80UV3006597 for <1662@emacsbugs.donarmstrong.com>; Tue, 23 Dec 2008 00:00:32 -0800 Received: (qmail invoked by alias); 23 Dec 2008 08:00:25 -0000 Received: from 62-47-41-16.adsl.highway.telekom.at (EHLO [62.47.41.16]) [62.47.41.16] by mail.gmx.net (mp069) with SMTP; 23 Dec 2008 09:00:25 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18+9yYcDNI+q8/jdavv6SFTbspZD5NwTQ63v3PihK e/hoHwmHBqBbkb Message-ID: <49509A5A.5050202@gmx.at> Date: Tue, 23 Dec 2008 08:59:22 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: 1662@debbugs.gnu.org References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.75 > The minibuffer prompt displayed by functions that use (interactive) is > usually > highlighted with the face `minibuffer-prompt'. However, interactive specs > "c", > "k" and "K" don't do this. Strictly spoken, this is not a bug. "c" uses `read-char', "k" and "K" use `read-key-sequence' and, by specification, neither of these use the minibuffer. So `minibuffer-prompt' doesn't apply here. martin From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: Stefan Monnier , 1662@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Tue, 23 Dec 2008 20:50:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.123006513813276 (code B ref 1662); Tue, 23 Dec 2008 20:50:03 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 23 Dec 2008 20:45:38 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from chene.dit.umontreal.ca (chene.dit.umontreal.ca [132.204.246.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBNKjX0v013264 for <1662@emacsbugs.donarmstrong.com>; Tue, 23 Dec 2008 12:45:35 -0800 Received: from alfajor.home (vpn-132-204-232-154.acd.umontreal.ca [132.204.232.154]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id mBNKjWKT018544; Tue, 23 Dec 2008 15:45:32 -0500 Received: by alfajor.home (Postfix, from userid 20848) id 2844A1C175; Tue, 23 Dec 2008 15:45:32 -0500 (EST) From: Stefan Monnier To: martin rudalics Cc: 1662@debbugs.gnu.org Message-ID: References: <49509A5A.5050202@gmx.at> Date: Tue, 23 Dec 2008 15:45:31 -0500 In-Reply-To: <49509A5A.5050202@gmx.at> (martin rudalics's message of "Tue, 23 Dec 2008 08:59:22 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3175=0 >> The minibuffer prompt displayed by functions that use (interactive) >> is usually highlighted with the face `minibuffer-prompt'. However, >> interactive specs "c", "k" and "K" don't do this. > Strictly spoken, this is not a bug. "c" uses `read-char', "k" and "K" > use `read-key-sequence' and, by specification, neither of these use the > minibuffer. So `minibuffer-prompt' doesn't apply here. Yes, strictly speaking, this is true, but this is taking too literal a point of view. I agree with the OP that we should make those operations try to behave similarly to minibuffer ones, wrt to prompt faces. Stefan From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: "Geoff Gole" , 1662@debbugs.gnu.org Resent-From: "Geoff Gole" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 24 Dec 2008 06:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.123009811922862 (code B ref 1662); Wed, 24 Dec 2008 06:00:03 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 24 Dec 2008 05:55:19 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.179]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBO5tFto022794 for <1662@emacsbugs.donarmstrong.com>; Tue, 23 Dec 2008 21:55:16 -0800 Received: by wa-out-1112.google.com with SMTP id j40so1775388wah.1 for <1662@emacsbugs.donarmstrong.com>; Tue, 23 Dec 2008 21:55:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=LmZ2qloIbITCTs4WPHO6o+kCzw8lzKBvwwwke9s+Y+o=; b=FewXsGmIJNCGIgw+BKmUXcBgMmywT7QiqD+14QRSRYe63HiMpweRjUnt+hvqe14xgj /7tj3T8LcYeUooFCdVRVtd9W3b+5LoWOrDWVpNdC3mNrViHvlcywYdGmJzZBHTbI/q7o HEtY5iju62gWn44kFxTtQwO3q9NRumlT4i2zw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=PoajDcYRAVAheUoyNu2qQNiGae4EdGO5bXY+1GJzkbiF8KQ6sJK7DIXpcHKGCrkCAp Mobw7Hfp1uq+I8Ez1ZKOJgngM8SwRc9QH7ZEEmuQTyPOLmM4lhjNkHg3PmixRJpzrupm 8qDfHDF5LsnHNRGSdBuWboYa7FSaBCzcEACcU= Received: by 10.115.18.3 with SMTP id v3mr5295168wai.32.1230098115218; Tue, 23 Dec 2008 21:55:15 -0800 (PST) Received: by 10.114.56.17 with HTTP; Tue, 23 Dec 2008 21:55:15 -0800 (PST) Message-ID: Date: Wed, 24 Dec 2008 14:55:15 +0900 From: "Geoff Gole" To: "martin rudalics" , monnier@iro.umontreal.ca, 1662@debbugs.gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline > Strictly spoken, this is not a bug. "c" uses `read-char', "k" and "K" > use `read-key-sequence' and, by specification, neither of these use the > minibuffer. So `minibuffer-prompt' doesn't apply here. That makes sense. However, I do think that highlighting prompts in the minibuffer is a good idea even in situations where the minibuffer is not used directly. Isearch in emacs 23 seems to do that, so there is some precedent. From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: "Lennart Borgman" , 1662@debbugs.gnu.org Resent-From: "Lennart Borgman" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 24 Dec 2008 10:25:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.12301138211865 (code B ref 1662); Wed, 24 Dec 2008 10:25:03 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 24 Dec 2008 10:17:01 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.0 required=4.0 tests=GMAIL,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.152]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBOAGvbJ001852 for <1662@emacsbugs.donarmstrong.com>; Wed, 24 Dec 2008 02:16:59 -0800 Received: by fg-out-1718.google.com with SMTP id l27so3154621fgb.43 for <1662@emacsbugs.donarmstrong.com>; Wed, 24 Dec 2008 02:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=l2764Bf/LNNUNT1tmqNiNtHga0lZNJLhrg/tG1/gLi0=; b=JbIyIjUBPL5B5LFdrsgCDYA74iif05Sym7NCOd50PEyOGryZJJ3GzEviS9xW9sp+Qs PD0ubIGmZxqsUGKnvXzhRItrEmMjhyNXp5qV7IE70y/tDcLHEHkLL4AzTLy/pYttzro1 BDHntpXNc3s391fWkqfcOCYvpYo2tTlVPZnsg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=p3XOleUfxMcmNCWICBMSM6HBZErAmGVO11YBXihvoJLfCb6Kai1xuPp4mwXPZuot6Q aUx0YdUCGxSDlfkpddMmD7UV0kF4ay7NRpWq5Ar9oG4nTcY8R17wsy/nGRFECUFKYBU2 Ha0jpKX4phwf9cxh92tCzRf/He9z9z0ZAgDe4= Received: by 10.86.60.14 with SMTP id i14mr5031939fga.21.1230113817333; Wed, 24 Dec 2008 02:16:57 -0800 (PST) Received: by 10.86.1.8 with HTTP; Wed, 24 Dec 2008 02:16:57 -0800 (PST) Message-ID: Date: Wed, 24 Dec 2008 11:16:57 +0100 From: "Lennart Borgman" To: "Geoff Gole" , 1662@debbugs.gnu.org Cc: "martin rudalics" , monnier@iro.umontreal.ca In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: On Wed, Dec 24, 2008 at 6:55 AM, Geoff Gole wrote: >> Strictly spoken, this is not a bug. "c" uses `read-char', "k" and "K" >> use `read-key-sequence' and, by specification, neither of these use the >> minibuffer. So `minibuffer-prompt' doesn't apply here. > > That makes sense. However, I do think that highlighting prompts in the > minibuffer is a good idea even in situations where the minibuffer is > not used directly. > > Isearch in emacs 23 seems to do that, so there is some precedent. Yes, the purpose of the special minibuffer-prompt is to make the user aware that input will be treated specially at the moment. From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: martin rudalics , 1662@debbugs.gnu.org Resent-From: martin rudalics Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 24 Dec 2008 10:35:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.12301143684371 (code B ref 1662); Wed, 24 Dec 2008 10:35:03 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 24 Dec 2008 10:26:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.0 required=4.0 tests=HAS_BUG_NUMBER,MIXEDBDN, MURPHY_DRUGS_REL8,RCVD_IN_SBLXBL,RCVD_IN_SBLXBL_CBL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mBOAPw12004364 for <1662@emacsbugs.donarmstrong.com>; Wed, 24 Dec 2008 02:26:00 -0800 Received: (qmail invoked by alias); 24 Dec 2008 10:25:52 -0000 Received: from 62-47-43-147.adsl.highway.telekom.at (EHLO [62.47.43.147]) [62.47.43.147] by mail.gmx.net (mp050) with SMTP; 24 Dec 2008 11:25:52 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/jsSUWz2/jrURaD6sF5EeZKJujTP/xbIKzjQRzih RYkEZlszxhpLVX Message-ID: <49520D58.3070006@gmx.at> Date: Wed, 24 Dec 2008 11:22:16 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 To: Geoff Gole CC: monnier@iro.umontreal.ca, 1662@debbugs.gnu.org References: In-Reply-To: Content-Type: multipart/mixed; boundary="------------030206010500030709070107" X-Y-GMX-Trusted: 0 X-FuHaFi: 0.83,0.53 This is a multi-part message in MIME format. --------------030206010500030709070107 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit > However, I do think that highlighting prompts in the > minibuffer is a good idea even in situations where the minibuffer is > not used directly. Could you try the attached patch? Thanks, martin. --------------030206010500030709070107 Content-Type: text/plain; name="prompt.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="prompt.diff" *** callint.c.~1.167.~ 2008-05-14 09:49:11.000000000 +0200 --- callint.c 2008-12-24 11:09:49.859375000 +0100 *************** *** 45,50 **** --- 45,51 ---- Lisp_Object Vcommand_debug_status, Qcommand_debug_status; Lisp_Object Qenable_recursive_minibuffers; + extern Lisp_Object Qface, Qminibuffer_prompt; /* Non-nil means treat the mark as active even if mark_active is 0. */ *************** *** 541,546 **** --- 542,550 ---- break; case 'c': /* Character */ + Fput_text_property (make_number (0), + make_number (SCHARS (callint_message)), + Qface, Qminibuffer_prompt, callint_message); args[i] = Fread_char (callint_message, Qnil, Qnil); message1_nolog ((char *) 0); /* Passing args[i] directly stimulates compiler bug */ *************** *** 594,599 **** --- 598,606 ---- { int speccount1 = SPECPDL_INDEX (); specbind (Qcursor_in_echo_area, Qt); + Fput_text_property (make_number (0), + make_number (SCHARS (callint_message)), + Qface, Qminibuffer_prompt, callint_message); args[i] = Fread_key_sequence (callint_message, Qnil, Qnil, Qnil, Qnil); unbind_to (speccount1, Qnil); *************** *** 622,627 **** --- 629,637 ---- { int speccount1 = SPECPDL_INDEX (); specbind (Qcursor_in_echo_area, Qt); + Fput_text_property (make_number (0), + make_number (SCHARS (callint_message)), + Qface, Qminibuffer_prompt, callint_message); args[i] = Fread_key_sequence (callint_message, Qnil, Qt, Qnil, Qnil); teml = args[i]; *** textprop.c.~1.163.~ 2008-11-03 18:21:08.015625000 +0100 --- textprop.c 2008-12-24 11:17:14.859375000 +0100 *************** *** 57,62 **** --- 57,63 ---- /* Visual properties text (including strings) may have. */ Lisp_Object Qforeground, Qbackground, Qfont, Qunderline, Qstipple; Lisp_Object Qinvisible, Qread_only, Qintangible, Qmouse_face; + Lisp_Object Qminibuffer_prompt; /* Sticky properties */ Lisp_Object Qfront_sticky, Qrear_nonsticky; *************** *** 2334,2339 **** --- 2335,2342 ---- Qrear_nonsticky = intern ("rear-nonsticky"); staticpro (&Qmouse_face); Qmouse_face = intern ("mouse-face"); + staticpro (&Qminibuffer_prompt); + Qminibuffer_prompt = intern ("minibuffer-prompt"); /* Properties that text might use to specify certain actions */ --------------030206010500030709070107-- From unknown Fri Aug 22 01:33:52 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#1662: 23.0.60; Interactive not using minibuffer prompt face Reply-To: "Geoff Gole" , 1662@debbugs.gnu.org Resent-From: "Geoff Gole" Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs Resent-Date: Wed, 24 Dec 2008 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 1662 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 1662-submit@emacsbugs.donarmstrong.com id=B1662.1230128851958 (code B ref 1662); Wed, 24 Dec 2008 14:35:02 +0000 Received: (at 1662) by emacsbugs.donarmstrong.com; 24 Dec 2008 14:27:31 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from rv-out-0506.google.com (rv-out-0506.google.com [209.85.198.225]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBOERObV000952 for <1662@emacsbugs.donarmstrong.com>; Wed, 24 Dec 2008 06:27:25 -0800 Received: by rv-out-0506.google.com with SMTP id k40so2872212rvb.1 for <1662@emacsbugs.donarmstrong.com>; Wed, 24 Dec 2008 06:27:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type:content-transfer-encoding :content-disposition; bh=sCetNLCdvKpDWTulTZxH6N8yNCyrJp/r3oy58WNGekI=; b=qEk6mM3DSfCpY7HYJYC/3oqRx2ZTW+9Ae3XNUWglROpVRBaJx8SxD+204swCMw/tX8 1qw0j7OUsz+4XY/d1C1Pc7WPztPzLG0tdiJrGuWC9jfKy8JiArXbHISgj1eUDcwnMsez vk87FD8Mn+6n/EtjML0aVE+Vk4uPf7lzcyfnY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type :content-transfer-encoding:content-disposition; b=mV2NdJUiuaO5TTMBPWSnfOC12cMJpeAD5vpDdcBspf82J9wAZNWbQEABnSfQY+KZ7U MSIMGBKOcybC2iPUlOAAGdYwjRcHi6R2+B2mZEYEwM9FPv65E9tC1qlnUbbfa2sIMLDJ 2NPqePOe9K1Uyh9zD4aS8Kn3cuxYZWDRWRDPQ= Received: by 10.114.195.19 with SMTP id s19mr5553584waf.123.1230128844043; Wed, 24 Dec 2008 06:27:24 -0800 (PST) Received: by 10.114.56.17 with HTTP; Wed, 24 Dec 2008 06:27:24 -0800 (PST) Message-ID: Date: Wed, 24 Dec 2008 23:27:24 +0900 From: "Geoff Gole" To: "martin rudalics" , monnier@iro.umontreal.ca, 1662@debbugs.gnu.org MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline > Could you try the attached patch? Thanks, that seems to fix it nicely. From unknown Fri Aug 22 01:33:52 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.420 (Entity 5.420) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: "Geoff Gole" Subject: bug#1662 closed by martin rudalics (Re: bug#1662: 23.0.60; Interactive not using minibuffer prompt face) Message-ID: References: <4954AA17.9080907@gmx.at> X-Emacs-PR-Message: they-closed 1662 X-Emacs-PR-Package: emacs Reply-To: 1662@debbugs.gnu.org Date: Fri, 26 Dec 2008 10:05:08 +0000 Content-Type: multipart/mixed; boundary="----------=_1230285908-10942-1" This is a multi-part message in MIME format... ------------=_1230285908-10942-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #1662: 23.0.60; Interactive not using minibuffer prompt face It has been closed by martin rudalics . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact martin rudalics by replying to this email. --=20 1662: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D1662 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1230285908-10942-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 1662-done) by emacsbugs.donarmstrong.com; 26 Dec 2008 09:57:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-3.0 required=4.0 tests=HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail.gmx.net (mail.gmx.net [213.165.64.20]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with SMTP id mBQ9v8n6008764 for <1662-done@emacsbugs.donarmstrong.com>; Fri, 26 Dec 2008 01:57:10 -0800 Received: (qmail invoked by alias); 26 Dec 2008 09:57:02 -0000 Received: from 88-117-36-184.adsl.highway.telekom.at (EHLO [88.117.36.184]) [88.117.36.184] by mail.gmx.net (mp064) with SMTP; 26 Dec 2008 10:57:02 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+/4O5ApW+/5ElORJgNi9zP/b7s0mBKYDfu+02131 nVkwQzMTnlwQNb Message-ID: <4954AA17.9080907@gmx.at> Date: Fri, 26 Dec 2008 10:55:35 +0100 From: martin rudalics User-Agent: Thunderbird 2.0.0.16 (Windows/20080708) MIME-Version: 1.0 CC: 1662-done@debbugs.gnu.org Subject: Re: bug#1662: 23.0.60; Interactive not using minibuffer prompt face References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Y-GMX-Trusted: 0 X-FuHaFi: 0.71 Fixed as * callint.c (Fcall_interactively): For `c', `k', and `K' prompt in minibuffer-prompt face. (Bug#1662) Thanks for the report, martin. ------------=_1230285908-10942-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 21 Dec 2008 21:43:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: * X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=1.2 required=4.0 tests=MULTALT,MURPHY_WRONG_WORD2 autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id mBLLhUct028227 for ; Sun, 21 Dec 2008 13:43:31 -0800 Received: from mx10.gnu.org ([199.232.76.166]:58476) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LEW4M-0006ZR-Df for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:42:38 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LEW5A-00045d-7K for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:43:28 -0500 Received: from wa-out-1112.google.com ([209.85.146.176]:6082) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LEW59-00045Z-LA for emacs-pretest-bug@gnu.org; Sun, 21 Dec 2008 16:43:28 -0500 Received: by wa-out-1112.google.com with SMTP id j32so1114191waf.26 for ; Sun, 21 Dec 2008 13:43:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:mime-version:content-type; bh=JheWVTrP8L0Ah2hBJDCuervHL5xuvMZpa4lX3Jjnc98=; b=x5eUTirv8GdaVKlHqeehgYmpLmc8whfgbc2JJHvy8HaeS9w6/BBtVDUYc9R9Tb8U+A LGb2kSwG4g0je6yQxdHdb/4BIsT+o/NZL1LgTIkXqlLbfPdKArCzJ5otwhAkkOg0jCHK mPVYqPBGQINmf/HJB1WnCFIVZ0Ur+SepFIiaU= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:mime-version:content-type; b=tdCoD3MPG1mjWlytJcdYDA+6E27BCMSJ/w7XXTbwYOBb9kyUz6+QPnlqkkBfjUbzTl TZebhM75eluUYWttJwQIqxXU/cRL/K4LEEFSDoH7MmjWeAjbyUOpQ897q9xfq3MrGubr PsptM2Zc1QO08rh8sgRPImpksyIveblxVbd2Y= Received: by 10.114.26.18 with SMTP id 18mr3558136waz.159.1229895804511; Sun, 21 Dec 2008 13:43:24 -0800 (PST) Received: by 10.114.56.17 with HTTP; Sun, 21 Dec 2008 13:43:24 -0800 (PST) Message-ID: Date: Mon, 22 Dec 2008 06:43:24 +0900 From: "Geoff Gole" To: emacs-pretest-bug@gnu.org Subject: 23.0.60; Interactive not using minibuffer prompt face MIME-Version: 1.0 Content-Type: multipart/alternative; boundary="----=_Part_38638_26699807.1229895804507" X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) ------=_Part_38638_26699807.1229895804507 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The minibuffer prompt displayed by functions that use (interactive) is usually highlighted with the face `minibuffer-prompt'. However, interactive specs "c", "k" and "K" don't do this. To reproduce: emacs -Q M-z Running this function shows the difference more clearly: (defun example-prompt (&rest args) (interactive "sXXXX: \ncXXXX: \nkXXXX: \nKXXXX: ") (ignore args)) In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11) of 2008-11-22 on elegiac, modified by Debian (emacs-snapshot package, version 1:20081121-1) Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Also observed in GNU Emacs 22.2.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-11-10 on raven, modified by Debian ------=_Part_38638_26699807.1229895804507 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline The minibuffer prompt displayed by functions that use (interactive) is usually
highlighted with the face `minibuffer-prompt'. However, interactive specs "c",
"k" and "K" don't do this.

To reproduce:

  emacs -Q
  M-z

Running this function shows the difference more clearly:

  (defun example-prompt (&rest args)
    (interactive "sXXXX: \ncXXXX: \nkXXXX: \nKXXXX: ")
    (ignore args))

In GNU Emacs 23.0.60.1 (i486-pc-linux-gnu, GTK+ Version 2.12.11)
 of 2008-11-22 on elegiac, modified by Debian
 (emacs-snapshot package, version 1:20081121-1)
Windowing system distributor `The X.Org Foundation', version 11.0.10402000
configured using `configure  '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.60/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.60/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS=''

Also observed in GNU Emacs 22.2.1 (i486-pc-linux-gnu, X toolkit, Xaw3d scroll bars) of 2008-11-10 on raven, modified by Debian
------=_Part_38638_26699807.1229895804507-- ------------=_1230285908-10942-1--