Subject: bug#16607: hippie-expand, a patch

From: [email-masked]
Date: Sun, 02 Jul 2017 15:35:43 -0400

tags 16607 fixed
close 16607 25.1
quit

Lars Ingebrigtsen <[email-masked]> writes:

> Emilio C. Lopes <[email-masked]> writes:
>
>> `hippie-expand' use several methods to expand text in the current buffer.
>> Some of those methods search for possible expansions in multiple Emacs
>> buffers, controlled by the variables `hippie-expand-ignore-buffers' and
>> `hippie-expand-only-buffers'.
>>
>> It would be useful to be able to set these two variables locally in a
>> Buffer (using `make-local-variable').  This would allow for example to
>> set up `hippie-expand' in Lisp buffers to only search for possible
>> expansions in other Lisp buffers.
>>
>> As it is now (Emacs 24.3) the functions in `hippie-expand' using those
>> variables do so in the context of the buffers where potential completions
>> are searched for.  The patch bellow causes the lookup to occur in the
>> buffer where `hippie-expand' was invoked.
>
> I think the patch below looks reasonable, but I've never used
> hippie-expand.  Are there anybody that can weigh in on this?

This was already added in Emacs 25.1.

[1: 8576251878]: 2014-06-12 09:45:52 -0400
  * lisp/hippie-exp.el (try-expand-line-all-buffers) (try-expand-list-all-buffers, try-expand-dabbrev-all-buffers): Read hippie-expand-only-buffers and hippie-expand-ignore-buffers in the original buffer, in case they're buffer-local.
  http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8576251878f59f686b3a14c574a402549eabcbc1