GNU bug report logs - #16599
24.3.50; src/temacs --daemon fails to start

Previous Next

Package: emacs;

Reported by: Alex Bennée <alex.bennee <at> linaro.org>

Date: Thu, 30 Jan 2014 18:36:01 UTC

Severity: minor

Found in version 24.3.50

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Alex Bennée <kernel-hacker <at> bennee.com>
To: Andreas Schwab <schwab <at> linux-m68k.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 16599 <at> debbugs.gnu.org, Alex Bennée <kernel-hacker <at> bennee.com>, emacs-devel <at> gnu.org
Subject: bug#16599: src/temacs --daemon fails
Date: Mon, 17 Feb 2014 07:40:35 +0000
Andreas Schwab <schwab <at> linux-m68k.org> writes:

> Alex Bennée <kernel-hacker <at> bennee.com> writes:
>
>> diff --git a/src/emacs.c b/src/emacs.c
>> index 18f6a08..66f47ef 100644
>> --- a/src/emacs.c
>> +++ b/src/emacs.c
>> @@ -201,7 +201,7 @@ static char *daemon_name;
>>  
>>  /* Pipe used to send exit notification to the daemon parent at
>>     startup.  */
>> -int daemon_pipe[2];
>> +int daemon_pipe[2] = {0, 0};
>
> This is redundant.

Indeed. I wasn't sure if the code I replaced relied on some special
difference between .data and .bss sections. I have to admit I'm
unfamiliar with how the Emacs dumping mechanism works.

Why did the syms_of_emacs() function feel the need to initialise daemon_pipe?

>
> Andreas.

-- 
Alex Bennée





This bug report was last modified 11 years and 101 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.