GNU bug report logs - #16581
suggested code simplification in dfa.c

Previous Next

Package: grep;

Reported by: Aharon Robbins <arnold <at> skeeve.com>

Date: Tue, 28 Jan 2014 20:12:01 UTC

Severity: normal

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #23 received at 16581 <at> debbugs.gnu.org (full text, mbox):

From: arnold <at> skeeve.com
To: eggert <at> cs.ucla.edu
Cc: 16581 <at> debbugs.gnu.org
Subject: Re: bug#16581: suggested code simplification in dfa.c
Date: Wed, 29 Jan 2014 08:29:26 -0700

Aaron Crane <grep <at> aaroncrane.co.uk> wrote:

> I don't think this works for the wide-character case. For example, ....

Maybe just use the xor stuff for the single byte case and the more
straightforward code for the multibyte case?

Otherwise it sounds like we're asking for trouble.

Also, maybe name the routines  ..._other_case instead of just _other ?

Thanks,

Arnold
This bug report was last modified 11 years and 78 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.