GNU bug report logs - #16571
24.3.50; Add :group to `defcustom's in minibuffer.el

Previous Next

Package: emacs;

Reported by: Drew Adams <drew.adams <at> oracle.com>

Date: Mon, 27 Jan 2014 16:57:02 UTC

Severity: minor

Tags: notabug

Found in version 24.3.50

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16571 in the body.
You can then email your comments to 16571 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16571; Package emacs. (Mon, 27 Jan 2014 16:57:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Drew Adams <drew.adams <at> oracle.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 27 Jan 2014 16:57:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Add :group to `defcustom's in minibuffer.el
Date: Mon, 27 Jan 2014 08:55:57 -0800 (PST)

Subject line says it all.  None of the defcustoms in `minibuffer.el'
have a :group.  They all should.

Zero :group entries is not advised.  Adding a :group helps users find
the option.

Presumably, at least group `minibuffer' should apply to the options
defined in `minibuffer.el', which defines that group.  Other groups
might also apply.


In GNU Emacs 24.3.50.1 (i686-pc-mingw32)
 of 2014-01-23 on ODIEONE
Bzr revision: 116129 monnier <at> iro.umontreal.ca-20140123150141-qopqqhpm8jqo8a18
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/binary --enable-checking=yes,glyphs
 'CFLAGS=-O0 -g3' LDFLAGS=-Lc:/Devel/emacs/lib
 CPPFLAGS=-Ic:/Devel/emacs/include'
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Mon, 27 Jan 2014 17:02:03 GMT) Full text and rfc822 format available.
Notification sent to Drew Adams <drew.adams <at> oracle.com>:
bug acknowledged by developer. (Mon, 27 Jan 2014 17:02:04 GMT) Full text and rfc822 format available.

Message #10 received at 16571-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16571-done <at> debbugs.gnu.org
Subject: Re: bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
Date: Mon, 27 Jan 2014 12:01:57 -0500

If you actually test it, you'll find they _are_ all in the minibuffer group.
For some time, defcustom defaults to the last specified defgroup.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16571; Package emacs. (Mon, 27 Jan 2014 17:35:01 GMT) Full text and rfc822 format available.

Message #13 received at 16571-done <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: Glenn Morris <rgm <at> gnu.org>, 16571-done <at> debbugs.gnu.org
Subject: RE: bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
Date: Mon, 27 Jan 2014 09:34:54 -0800 (PST)

> For some time, defcustom defaults to the last specified defgroup.

I see.  I didn't know that.  Sorry for the noise.
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16571; Package emacs. (Tue, 28 Jan 2014 00:18:02 GMT) Full text and rfc822 format available.

Message #16 received at 16571-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: Glenn Morris <rgm <at> gnu.org>, 16571-done <at> debbugs.gnu.org
Subject: Re: bug#16571: 24.3.50; Add :group to `defcustom's in minibuffer.el
Date: Mon, 27 Jan 2014 19:17:36 -0500

>> For some time, defcustom defaults to the last specified defgroup.
> I see.  I didn't know that.  Sorry for the noise.

It's a recent change: it's only been that way since Emacs-21 or
thereabout ;-)


        Stefan
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 25 Feb 2014 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 118 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.