GNU bug report logs - #16544
Optimazation for is_mb_middle

Previous Next

Package: grep;

Reported by: Norihiro Tanaka <noritnk <at> kcn.ne.jp>

Date: Sat, 25 Jan 2014 02:40:02 UTC

Severity: normal

Tags: patch

Done: Jim Meyering <jim <at> meyering.net>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Norihiro Tanaka <noritnk <at> kcn.ne.jp>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: Jim Meyering <jim <at> meyering.net>, 16544 <at> debbugs.gnu.org
Subject: bug#16544: Optimazation for is_mb_middle
Date: Wed, 29 Jan 2014 22:07:22 +0900
[Message part 1 (text/plain, inline)]
Hi Paul,

Thank you for reviewing tha patch.

> Please use something like this instead

All right.

> A minor question about naming: in what sense is mbclen_guess a guess?  

Because mbclen_guess always returns -2 for characters of two or more bytes,
I consider that what isn't mbclen_cache should be used instead of it. But
I don't particularly attach one's mind to the name. Now, I rename it to
mbclen_cache.
[is_mb_middle.txt (application/octet-stream, attachment)]

This bug report was last modified 11 years and 163 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.