GNU bug report logs - #16542
24.3.50; When finding a file via a bookmark, that file is not part of file-name-history

Previous Next

Full log

Message #44 received at 16542 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Bastien Guerry <bzg <at> altern.org>
Cc: 16542 <at> debbugs.gnu.org
Subject: Re: bug#16542: 24.3.50; When finding a file via a bookmark, that
 file is not part of file-name-history
Date: Tue, 25 Aug 2020 12:57:03 +0200

Bastien Guerry <bzg <at> altern.org> writes:

> The subject line says it all.
>
> This trivial patch fixes it.
>
> Comments welcome,
>
> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
> index 5307cad..52697c2 100644
> --- a/lisp/bookmark.el
> +++ b/lisp/bookmark.el

[...]

> +       (add-to-history 'file-name-history file)

I think this would be very surprising -- finding other things in the
minibuffer history than things I've typed in would be pretty odd.

As suggested, having a separate list of all visited files would be nice,
but the UX here would be pretty awkward.  That's discussed in bug#12915,
though, so I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.