From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 13:41:38 2014 Received: (at submit) by debbugs.gnu.org; 23 Jan 2014 18:41:38 +0000 Received: from localhost ([127.0.0.1]:33712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6PDZ-0007yM-UT for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:38 -0500 Received: from eggs.gnu.org ([208.118.235.92]:60628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6PDT-0007y7-6E for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6PDM-0004oi-12 for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:26 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PDL-0004ob-TX for submit@debbugs.gnu.org; Thu, 23 Jan 2014 13:41:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PDF-00057x-7C for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6PD5-0004mp-7N for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:13 -0500 Received: from mail-qc0-x22b.google.com ([2607:f8b0:400d:c01::22b]:50104) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6PD5-0004ml-1r for bug-coreutils@gnu.org; Thu, 23 Jan 2014 13:41:03 -0500 Received: by mail-qc0-f171.google.com with SMTP id n7so2993993qcx.16 for ; Thu, 23 Jan 2014 10:41:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject :content-type:content-transfer-encoding; bh=oYx4EhcI24bmGSeQ5OvcXzI9A18lvB33E8qnXbfQq5M=; b=xJ4J+WnMYShptKF0sVmWT4L298890kDSSjtq/IYhwxxSVKxLaHBChZTnH4DRTIF0zu Wwurd4jLj2GJbPQ4bgyIJOefNSppJWhfROFYwfIlGTugfI+rCQ01clTJrPs7ALWpKDVf 58UaQ4y/mlgr2K9LKlX0ZbLqj8sfFYb0DaGyS8V+8EZvN5JSKKN2jZlw859H+ZCsnm7j PPtBQDuRRWIwYDPVux6O8Ea4T76nASTdLbjj6w+UhgiLDqrpQimJ9x9mU5XV7L8x39oU 9fe/30atgUJhgwFFG/x+Hs3W7IoIDQNFPw6fNJci3KuLvKJIMu2fkygJHrQ34p7DiWxG 2LDg== X-Received: by 10.224.36.195 with SMTP id u3mr13974770qad.59.1390502462639; Thu, 23 Jan 2014 10:41:02 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id k1sm21851810qat.16.2014.01.23.10.41.01 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 10:41:01 -0800 (PST) Message-ID: <52E1625A.7040002@gmail.com> Date: Thu, 23 Jan 2014 13:41:30 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: bug-coreutils@gnu.org Subject: Test Fail: "tests/chown/separator" Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Hello, Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, results in a test failure "tests/chown/separator" (log + strace below). System is: ==== $ uname -a Linux club 2.6.32-24-server #43-Ubuntu SMP Thu Sep 16 16:05:42 UTC 2010 x86_64 GNU/Linux $ cat /etc/issue Ubuntu 10.04.4 LTS \n \l ## Failed on the following file-system $ stat -f /data/gordon/projects/coreutils/ File: "/data/gordon/projects/coreutils/" ID: 83000000000 Namelen: 255 Type: xfs Block size: 4096 Fundamental block size: 4096 Blocks: Total: 1952592384 Free: 86807222 Available: 86807222 Inodes: Total: 1429327392 Free: 1388915606 ==== strace (same command which failed in the log below): ===== $ pwd /data/gordon/projects/coreutils/ $ mkdir foo $ cd foo $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown -- mmap(NULL, 895, PROT_READ, MAP_SHARED, 3, 0) = 0x7fb7ce753000 lseek(3, 895, SEEK_SET) = 895 munmap(0x7fb7ce753000, 895) = 0 close(3) = 0 newfstatat(AT_FDCWD, ".", {st_mode=S_IFDIR|0755, st_size=6, ...}, AT_SYMLINK_NOFOLLOW) = 0 fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) open("/usr/local/share/locale/en_US.UTF-8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en_US.utf8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en_US/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en.UTF-8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) open("/usr/local/share/locale/en.utf8/LC_MESSAGES/coreutils.mo", O_RDONLY) = -1 ENOENT (No such file or directory) -- ===== FAIL: tests/chown/separator =========================== ++ initial_cwd_=/data/gordon/projects/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/gordon/projects/coreutils gt-separator.sh.XXXX +++ case $# in +++ destdir_=/data/gordon/projects/coreutils +++ template_=gt-separator.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/gordon/projects/coreutils/gt-separator.sh.fh9P +++ case $d in +++ test -d /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++++ ls -dgo /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++++ tr S - +++ perms='drwx------ 2 6 Jan 23 13:22 /data/gordon/projects/coreutils/gt-separator.sh.fh9P' +++ case $perms in +++ test 0 = 0 +++ echo /data/gordon/projects/coreutils/gt-separator.sh.fh9P +++ return ++ test_dir_=/data/gordon/projects/coreutils/gt-separator.sh.fh9P ++ cd /data/gordon/projects/coreutils/gt-separator.sh.fh9P ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/gordon/projects/coreutils/./src + case $abs_path_dir_ in + PATH=/data/gordon/projects/coreutils/./src:/data/gordon/projects/coreutils/src:/data/gordon/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games + create_exe_shims_ /data/gordon/projects/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ chown + test yes = yes + local i + for i in '$*' + env chown --version chown (GNU coreutils) 8.22.16-be97f Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie and Jim Meyering. ++ id -u + id_u=34574 + test -n 34574 ++ id -un + id_un=agordon + test -n agordon ++ id -g + id_g=1000 + test -n 1000 ++ id -gn + id_gn=users + test -n users + case $host_triplet in + chown '' . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:1000 . + for sep in '$seps' + case $u$sep$g in + chown 34574.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown 34574.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574: . + for sep in '$seps' + case $u$sep$g in + chown 34574. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:1000 . + for sep in '$seps' + case $u$sep$g in + chown agordon.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown agordon.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon: . + for sep in '$seps' + case $u$sep$g in + chown agordon. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :1000 . + for sep in '$seps' + case $u$sep$g in + chown .1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :users . chown: changing group of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown .users . chown: changing group of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown : . + for sep in '$seps' + case $u$sep$g in + chown . . + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/gordon/projects/coreutils + chmod -R u+rwx /data/gordon/projects/coreutils/gt-separator.sh.fh9P + rm -rf /data/gordon/projects/coreutils/gt-separator.sh.fh9P + exit 1 === From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 18:20:57 2014 Received: (at 16532) by debbugs.gnu.org; 23 Jan 2014 23:20:57 +0000 Received: from localhost ([127.0.0.1]:33861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TZx-000718-1e for submit@debbugs.gnu.org; Thu, 23 Jan 2014 18:20:57 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:61941) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TZu-00070x-FA for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 18:20:55 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu4) with ESMTP (Nemesis) id 0MdAvu-1VpUen2xUY-00IFVZ; Fri, 24 Jan 2014 00:20:51 +0100 Message-ID: <52E1A3D3.2000704@bernhard-voelker.de> Date: Fri, 24 Jan 2014 00:20:51 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Assaf Gordon , 16532@debbugs.gnu.org Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> In-Reply-To: <52E1625A.7040002@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Provags-ID: V02:K0:m0u0tKjnftO3yymCXBgq4hatSOZz2kouXJQluouMbuY q3+2H2bud04NkAArnl7voW5dvAdcp9VNfHgtcLWbLCyDbm36/m DnShf61u6xoL2P/Y20lsLlHhfdXpQR0IAs+hscjnXIYLhqv+Yh hHajQ+o4cCDaG05EEh9TtqiD04GnnEwO9X6VpmWE1u88AFwRRk /o5eKXs58Eb9cXoYT5CrSlL/HFdxh5J3AG5CD1MvW8sG3OxvR1 /tYqywDNwUg/HinDes04AKAdXSJb6y7RcYk/XS4hjyC2HR3yUu SqJlhNRIBAqt5CjqLOAzDEnfSAMzoujWOK7D6d2mmusk9GBk7k 0eBW+87nuzFcAvpJJlRp/Z19l7/nksSBTktS19JQL X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 16532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) tag 16532 + moreinfo thanks On 01/23/2014 07:41 PM, Assaf Gordon wrote: > Hello, welcome back! > Testing the latest coreutils (v8.22.16-be97f) on an old Ubuntu server, > results in a test failure "tests/chown/separator" (log + strace below). > $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown > fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) > ++ id -g > + id_g=1000 > + chown 34574:users . > chown: changing ownership of '.': Operation not permitted > + fail=1 Ooops, something very strange is going on on your system: chown resolves the group 'users' to gid 100 while 'id -g' says 1000. Can you find out why? Are you using some strange Samba/Kerberos authentication against an Active Directory or similar? (I've seen such issues with that combination,) Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 18:41:00 2014 Received: (at 16532) by debbugs.gnu.org; 23 Jan 2014 23:41:00 +0000 Received: from localhost ([127.0.0.1]:33866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TtL-0007ZE-TB for submit@debbugs.gnu.org; Thu, 23 Jan 2014 18:41:00 -0500 Received: from mail-qc0-f170.google.com ([209.85.216.170]:34233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6TtI-0007Z4-6z for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 18:40:56 -0500 Received: by mail-qc0-f170.google.com with SMTP id e9so3515970qcy.15 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 15:40:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=TJtfXzbb6UITsE6gkj0eMTuuJQcJGQA6pcCl0ULfPsc=; b=0V30K/M2yotF6SouroYu+ZuuQkHw5O7gmMBBdRZruUBiBy2taefIKOkpQW794oOel5 mfY09k/TmwUTozxHclqNIS/2aI8OunJJLSrBWVQOOZfa/DVr2U0zt8OOuZrTA2uWWB4u 2Nx3QkpYIrBqjE8NZdJLy7Tje6fwWVpJ7VasJuDjX/zviGyPIMChJ+N9WYADaNZZpjc3 qLYAdj6GHtdsBb68J6Mu8CAWNXV+QkRy8OT6KLtqaAynDJqQwALiopE8MXeqFu9xXqaT koR5oGFTXHE1nHPhGkKbmsJAHKB0KIWfnPrGZrvgieeQSWBwyAWllPiItHcJNXU4vuBw OGHg== X-Received: by 10.224.168.13 with SMTP id s13mr16163724qay.18.1390520455623; Thu, 23 Jan 2014 15:40:55 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id a10sm13464961qew.10.2014.01.23.15.40.53 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 15:40:54 -0800 (PST) Message-ID: <52E1A8A3.6020500@gmail.com> Date: Thu, 23 Jan 2014 18:41:23 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Bernhard Voelker , 16532@debbugs.gnu.org Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> In-Reply-To: <52E1A3D3.2000704@bernhard-voelker.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 01/23/2014 06:20 PM, Bernhard Voelker wrote: > On 01/23/2014 07:41 PM, Assaf Gordon wrote: >> $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown > >> fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) > >> ++ id -g >> + id_g=1000 > >> + chown 34574:users . >> chown: changing ownership of '.': Operation not permitted >> + fail=1 > > Ooops, something very strange is going on on your system: > chown resolves the group 'users' to gid 100 while 'id -g' > says 1000. > > Can you find out why? > Are you using some strange Samba/Kerberos authentication against > an Active Directory or similar? (I've seen such issues with that > combination,) > Thanks for the quick reply - this is a strange old server (not my doing...). Indeed it uses an external authentication, and has conflicting local and global groups named "users". == $ grep users /etc/group users:x:100: $ getent group | grep ^users users:x:100: users:x:1000: $ id -G 1000 1001 3432 == So I guess this is not a bug, and can be closed. I'll just ignore this failure on this system. Thanks, -gordon From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 20:09:26 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 01:09:26 +0000 Received: from localhost ([127.0.0.1]:33911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VGw-0002ba-0n for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:09:26 -0500 Received: from mail5.vodafone.ie ([213.233.128.176]:34627) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VGt-0002bR-Ca for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 20:09:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAPC74VJda5Cx/2dsb2JhbAANTb1IgwWBJoMZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAapaJ0zF45NMweEOAEDk3uLF45W Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 01:09:22 +0000 Message-ID: <52E1BD42.2050101@draigBrady.com> Date: Fri, 24 Jan 2014 01:09:22 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Assaf Gordon Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> In-Reply-To: <52E1A8A3.6020500@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 01/23/2014 11:41 PM, Assaf Gordon wrote: > On 01/23/2014 06:20 PM, Bernhard Voelker wrote: >> On 01/23/2014 07:41 PM, Assaf Gordon wrote: >>> $ strace ../src/chown 34574:users . 2>&1 | grep -A 5 -B 5 chown >> >>> fchownat(AT_FDCWD, ".", 34574, 100, 0) = -1 EPERM (Operation not permitted) >> >>> ++ id -g >>> + id_g=1000 >> >>> + chown 34574:users . >>> chown: changing ownership of '.': Operation not permitted >>> + fail=1 >> >> Ooops, something very strange is going on on your system: >> chown resolves the group 'users' to gid 100 while 'id -g' >> says 1000. >> >> Can you find out why? >> Are you using some strange Samba/Kerberos authentication against >> an Active Directory or similar? (I've seen such issues with that >> combination,) >> > > Thanks for the quick reply - this is a strange old server (not my doing...). > Indeed it uses an external authentication, and has conflicting local and global groups named "users". > > == > $ grep users /etc/group > users:x:100: > $ getent group | grep ^users > users:x:100: > users:x:1000: > $ id -G > 1000 1001 3432 > == > > So I guess this is not a bug, and can be closed. > I'll just ignore this failure on this system. It is a false failure though so would be worth avoiding. It's important to have robust tests we and builders can rely on. Would something along the following be possible? test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" welcome back! Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 20:38:04 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 01:38:04 +0000 Received: from localhost ([127.0.0.1]:33917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Vid-0003Nw-Te for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:38:04 -0500 Received: from mail-qa0-f46.google.com ([209.85.216.46]:49752) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Via-0003NU-E6 for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 20:38:01 -0500 Received: by mail-qa0-f46.google.com with SMTP id ii20so3130818qab.19 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 17:37:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=UzN7ZZKQ7S7NXBIXvc6Ntam+2MQ2bUPcEoAJJQxP30o=; b=TSiaVd4KqUzY46/LorOTCgT5MCGnBJ4vwYHdy/9y+5PiLAFtA9gl4ZcTxeqRf2ysXS VMu6/SK3LP2iVR8bL0bU7Oj4u9yPLVF/tAVkIgYGdymC7OQYT8p5mnF9I0nAVaT7nAil AsX+Kp6IXgNftjEA/Qc8PgUF3S8PwLEA0NXXsRMxxp+h9oAUzdDJyJW/uXLmd5Gedyr7 OmFXkZE6njxjWVktZvX/Kn0KPmq8Ti8E8b6UsZcjE+6mHiFwASYAk4SVQpA4cUW5FbXI ylzd/GwNRinaE44EG9XYzCoNq/uJOI+b9obeEpgeS9UBJRgo3Leb6Xr4UrXsgs3VgpG4 z9cg== X-Received: by 10.224.26.71 with SMTP id d7mr16188443qac.99.1390527479726; Thu, 23 Jan 2014 17:37:59 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id k1sm24078688qat.16.2014.01.23.17.37.57 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 17:37:58 -0800 (PST) Message-ID: <52E1C414.4000300@gmail.com> Date: Thu, 23 Jan 2014 20:38:28 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> In-Reply-To: <52E1BD42.2050101@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This patch makes the test skip on my server (did not test it on other systems). On 01/23/2014 08:09 PM, Pádraig Brady wrote: > On 01/23/2014 11:41 PM, Assaf Gordon wrote: >> So I guess this is not a bug, and can be closed. >> I'll just ignore this failure on this system. > > It is a false failure though so would be worth avoiding. > It's important to have robust tests we and builders can rely on. > > Would something along the following be possible? > > test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" > From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?P=C3=A1draig=20Brady?= Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with duplicated groups * tests/chwon/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..ec33f4a 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +test $(getent group $id_gn | wc -l) != 1 || + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.8.4.3 From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 20:44:01 2014 Received: (at 16532-done) by debbugs.gnu.org; 24 Jan 2014 01:44:02 +0000 Received: from localhost ([127.0.0.1]:33922 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VoP-0003YL-8N for submit@debbugs.gnu.org; Thu, 23 Jan 2014 20:44:01 -0500 Received: from mail3.vodafone.ie ([213.233.128.45]:58765) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6VoM-0003YC-Mb for 16532-done@debbugs.gnu.org; Thu, 23 Jan 2014 20:43:59 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AmQFAEbE4VJda5Cx/2dsb2JhbAANTYNEUKIsAQGaC4EkgxkBAQEDATIBRgULCw0EAwECAQkWDwkDAgECAT0IBg0BBQIBAYd5DQOpc5NviUUXjwAHhDgBA5N7hVqFPYVxiGU Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 01:43:57 +0000 Message-ID: <52E1C55D.2000205@draigBrady.com> Date: Fri, 24 Jan 2014 01:43:57 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Assaf Gordon Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> In-Reply-To: <52E1C414.4000300@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532-done Cc: 16532-done@debbugs.gnu.org, Bernhard Voelker X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 01/24/2014 01:38 AM, Assaf Gordon wrote: > This patch makes the test skip on my server (did not test it on other systems). > > On 01/23/2014 08:09 PM, Pádraig Brady wrote: >> On 01/23/2014 11:41 PM, Assaf Gordon wrote: > >>> So I guess this is not a bug, and can be closed. >>> I'll just ignore this failure on this system. >> >> It is a false failure though so would be worth avoiding. >> It's important to have robust tests we and builders can rely on. >> >> Would something along the following be possible? >> >> test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" >> > > > From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 > From: =?UTF-8?q?P=C3=A1draig=20Brady?= > Date: Thu, 23 Jan 2014 20:34:52 -0500 > Subject: [PATCH] tests: skip chown/separator with duplicated groups > > * tests/chwon/separator.sh: skip test if the user's group has s/chwon/chown/ > multiple entries. > Fixes http://bugs.gnu.org/16532 > --- > tests/chown/separator.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh > index f64b738..ec33f4a 100755 > --- a/tests/chown/separator.sh > +++ b/tests/chown/separator.sh > @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ > id_gn=$(id -gn) || framework_failure_ > test -n "$id_gn" || framework_failure_ > > +test $(getent group $id_gn | wc -l) != 1 || > + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" > + > # FreeBSD 6.x's getgrnam fails to look up a group name containing > # a space. On such a system, skip this test if the group name contains > # a byte not in the portable filename character set. Cool I'll push that in your name since you did the hard work of tracking it down, generating the patch and testing. Marking this as done. cheers, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 21:32:54 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:32:54 +0000 Received: from localhost ([127.0.0.1]:33937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6WZh-0004tS-VN for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:32:54 -0500 Received: from mail4.vodafone.ie ([213.233.128.170]:48753) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6WZf-0004tI-Gu for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:32:52 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqUBAPXP4VJda5Cx/2dsb2JhbAANTYNEULw7gSKDGQEBAQSBCQsNBAMBAgEJDQEGAg8JAwIBAgEPLggHDAYCAQGHbQMWA6lvl1ANhVYXjGyCAxgSAYQlBJA8gz+COwGDHoU9hW4DiGWBagc Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 02:32:50 +0000 Message-ID: <52E1D0D2.4010303@draigBrady.com> Date: Fri, 24 Jan 2014 02:32:50 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: 16532@debbugs.gnu.org, assafgordon@gmail.com Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> In-Reply-To: <52E1C55D.2000205@draigBrady.com> X-Enigmail-Version: 1.6 Content-Type: multipart/mixed; boundary="------------000605050003090404080608" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is a multi-part message in MIME format. --------------000605050003090404080608 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit On 01/24/2014 01:43 AM, Pádraig Brady wrote: > On 01/24/2014 01:38 AM, Assaf Gordon wrote: >> This patch makes the test skip on my server (did not test it on other systems). >> >> On 01/23/2014 08:09 PM, Pádraig Brady wrote: >>> On 01/23/2014 11:41 PM, Assaf Gordon wrote: >> >>>> So I guess this is not a bug, and can be closed. >>>> I'll just ignore this failure on this system. >>> >>> It is a false failure though so would be worth avoiding. >>> It's important to have robust tests we and builders can rely on. >>> >>> Would something along the following be possible? >>> >>> test $(getent group $group | wc -l) != 1 || skip_ "multiple ids for group $group: $(getent group $group)" >>> >> >> >> From 3737105eacbb23cbe453a3d210359fea614b7154 Mon Sep 17 00:00:00 2001 >> From: =?UTF-8?q?P=C3=A1draig=20Brady?= >> Date: Thu, 23 Jan 2014 20:34:52 -0500 >> Subject: [PATCH] tests: skip chown/separator with duplicated groups >> >> * tests/chwon/separator.sh: skip test if the user's group has > > s/chwon/chown/ > >> multiple entries. >> Fixes http://bugs.gnu.org/16532 >> --- >> tests/chown/separator.sh | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh >> index f64b738..ec33f4a 100755 >> --- a/tests/chown/separator.sh >> +++ b/tests/chown/separator.sh >> @@ -31,6 +31,9 @@ test -n "$id_g" || framework_failure_ >> id_gn=$(id -gn) || framework_failure_ >> test -n "$id_gn" || framework_failure_ >> >> +test $(getent group $id_gn | wc -l) != 1 || Actually I messed up the login in the suggestion. I think the above should be s/!=/=/ which I've done in the attached patch. If you could confirm it was skipped on your system it would be great. I'll push soon anyway. >> + skip_ "multiple ids for group $id_gn: $(getent group $id_gn)" I also protected the $id_gn with quotes in case there were spaces in the group name or something. thanks, Pádraig. --------------000605050003090404080608 Content-Type: text/x-patch; name="tests-dupe-groups.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="tests-dupe-groups.patch" >From 9ad5f9f8d8e15c9f47173427714bfd6bcff2730e Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with conflicting group IDs * tests/chown/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..ed3635d 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,11 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +# Systems with both local and external groups with conflicting IDs, +# were seen to fail this test erroneously with EPERM errors. +test $(getent group "$id_gn" | wc -l) = 1 || + skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.7.7.6 --------------000605050003090404080608-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 21:46:35 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:46:35 +0000 Received: from localhost ([127.0.0.1]:33946 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wmw-0005H6-Cy for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:46:35 -0500 Received: from mail-qc0-f181.google.com ([209.85.216.181]:43381) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wmt-0005Gt-TI for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:46:32 -0500 Received: by mail-qc0-f181.google.com with SMTP id e9so3683519qcy.12 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 18:46:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=brlvVse/BT7Vxb5BGxhOu7kXOSQyjE76WM2LLC/vwrQ=; b=b7/Z4Ixl/QqbMLwhsL8qLMl/kzRqZFDPOXM2ei+S3mdQyqGp8lpo1Klvs8GojE8/nm 7uBE3peZxMEQdkkTjJfc7fyrBrKYShHn63p3T5PuDKyBrWmw/M95WjKisQr6Vr7JIG7x zeNR+ETSw4YfmTt8D7MjsuWcoiHF8K3Sw6UWVSLv1FlpOKcpWetN2pK6P4ARCEIbSKIw UuKGNrWIyVB8fbNv0Bi/c9gJwxpcn+QtpD0xPiQeuA+kDhmiWJPJna8/ptyQBCKKyUWd Rm2sUJ7xhfoUJg5yBdzcuq6GvQM00DcGT3xGvRyf6TVANvaOKcxwHdjIhfQCDsUTKION g5vg== X-Received: by 10.224.111.195 with SMTP id t3mr17074492qap.2.1390531591008; Thu, 23 Jan 2014 18:46:31 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id s2sm12371367qat.1.2014.01.23.18.46.29 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 18:46:30 -0800 (PST) Message-ID: <52E1D423.1060605@gmail.com> Date: Thu, 23 Jan 2014 21:46:59 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= , 16532@debbugs.gnu.org Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> In-Reply-To: <52E1D0D2.4010303@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 01/23/2014 09:32 PM, Pádraig Brady wrote: > > Actually I messed up the login in the suggestion. > I think the above should be s/!=/=/ which I've done > in the attached patch. > > If you could confirm it was skipped on your system > it would be great. > > I'll push soon anyway. > Please don't push yet - it doesn't work, but for un-expected reason: my previous patch was incorrect (The "=" vs "!=" as you pointed), but also "getent groups" was incorrect - so two wrongs did make a right :) The test fails, here's why: On my strange system: === $ getent group users users:x:100: === vs. === $ getent group | grep ^users users:x:100: users:x:1000:www-data,XXX,YYY === And so, the skip test didn't actual work to begin with. Should we change it to "getent" + "grep" ? -gordon From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 21:57:53 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 02:57:53 +0000 Received: from localhost ([127.0.0.1]:33951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wxs-0005ZK-8a for submit@debbugs.gnu.org; Thu, 23 Jan 2014 21:57:53 -0500 Received: from mail-qa0-f50.google.com ([209.85.216.50]:42113) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6Wxp-0005Z8-HC for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 21:57:50 -0500 Received: by mail-qa0-f50.google.com with SMTP id cm18so3217723qab.37 for <16532@debbugs.gnu.org>; Thu, 23 Jan 2014 18:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type; bh=wBoajwDF9soksuYYkaabT/hrflMko+4PaYUkxa9q3Eg=; b=iSaQPCH8G6wkFNWnCiqgbiRALnE21d2i/EiAjQHOIrN2+6IYFbypv8fiNjBM9HiDme 9L8eHfGR1UoBXD8G9lOCEGY7q+E/VdFs+v8isjImg6vrJU4YfL/0Y4Zv+O23FKwLIidq efpT9e/B4H8nnyJdomVZjLivnYoEusLQhm0d3BqKyn9OMQsdDXJfoIfN0t7QQXj1Q10M hfc1SV0E2dkZ0LKDOwhFqki5dX5lr6HQBZGfOML+VwjlQfWuhhm6lYtfxXIuvHk1kRuf s1aHmB+E4Fzlxg9sRIxBf42S6EcKSeAgBMLJjOKb3rIBjnWqBkTB2+HTqVnDwpU4EY0o QehA== X-Received: by 10.229.10.197 with SMTP id q5mr16883932qcq.15.1390532268814; Thu, 23 Jan 2014 18:57:48 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id g68sm8375337qge.7.2014.01.23.18.57.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 18:57:47 -0800 (PST) Message-ID: <52E1D6C9.4000204@gmail.com> Date: Thu, 23 Jan 2014 21:58:17 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= , 16532@debbugs.gnu.org Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> In-Reply-To: <52E1D423.1060605@gmail.com> Content-Type: multipart/mixed; boundary="------------040901040607020202020807" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16532 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------040901040607020202020807 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit On 01/23/2014 09:46 PM, Assaf Gordon wrote: > On 01/23/2014 09:32 PM, Pádraig Brady wrote: >> >> If you could confirm it was skipped on your system >> it would be great. >> > > Please don't push yet - it doesn't work, but for un-expected reason: > On my strange system For completeness, attached is the test fail log. Also, similar examples with other groups: === $ getent group | cut -f1 -d: | sort | uniq -d adm bin daemon lp mail root sys tty users uucp $ getent group | grep ^mail: mail:x:8: mail:x:6:root $ getent group mail mail:x:8: $ getent group | grep ^adm: adm:x:4: adm:x:4:root,adm,daemon $ getent group adm adm:x:4: === So yes, this is not an ideally-configured system. -gordon --------------040901040607020202020807 Content-Type: text/x-log; name="chown-group-test-suite.log" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chown-group-test-suite.log" =============================================================== GNU coreutils 8.22.17-ba34a-dirty: ./tests/test-suite.log =============================================================== # TOTAL: 1 # PASS: 0 # SKIP: 0 # XFAIL: 0 # FAIL: 1 # XPASS: 0 # ERROR: 0 .. contents:: :depth: 2 FAIL: ./tests/chown/separator ============================= ++ initial_cwd_=/data/gordon/projects/coreutils ++ fail=0 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /data/gordon/projects/coreutils gt-separator.sh.XXXX +++ case $# in +++ destdir_=/data/gordon/projects/coreutils +++ template_=gt-separator.sh.XXXX +++ MAX_TRIES_=4 +++ case $destdir_ in +++ case $template_ in ++++ unset TMPDIR +++ d=/data/gordon/projects/coreutils/gt-separator.sh.t8dv +++ case $d in +++ test -d /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++++ ls -dgo /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++++ tr S - +++ perms='drwx------ 2 6 Jan 23 21:41 /data/gordon/projects/coreutils/gt-separator.sh.t8dv' +++ case $perms in +++ test 0 = 0 +++ echo /data/gordon/projects/coreutils/gt-separator.sh.t8dv +++ return ++ test_dir_=/data/gordon/projects/coreutils/gt-separator.sh.t8dv ++ cd /data/gordon/projects/coreutils/gt-separator.sh.t8dv ++ gl_init_sh_nl_=' ' ++ IFS=' ' ++ for sig_ in 1 2 3 13 15 +++ expr 1 + 128 ++ eval 'trap '\''Exit 129'\'' 1' +++ trap 'Exit 129' 1 ++ for sig_ in 1 2 3 13 15 +++ expr 2 + 128 ++ eval 'trap '\''Exit 130'\'' 2' +++ trap 'Exit 130' 2 ++ for sig_ in 1 2 3 13 15 +++ expr 3 + 128 ++ eval 'trap '\''Exit 131'\'' 3' +++ trap 'Exit 131' 3 ++ for sig_ in 1 2 3 13 15 +++ expr 13 + 128 ++ eval 'trap '\''Exit 141'\'' 13' +++ trap 'Exit 141' 13 ++ for sig_ in 1 2 3 13 15 +++ expr 15 + 128 ++ eval 'trap '\''Exit 143'\'' 15' +++ trap 'Exit 143' 15 ++ trap remove_tmp_ 0 + path_prepend_ ./src + test 1 '!=' 0 + path_dir_=./src + case $path_dir_ in + abs_path_dir_=/data/gordon/projects/coreutils/./src + case $abs_path_dir_ in + PATH=/data/gordon/projects/coreutils/./src:/data/gordon/projects/coreutils/src:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games + create_exe_shims_ /data/gordon/projects/coreutils/./src + case $EXEEXT in + return 0 + shift + test 0 '!=' 0 + export PATH + print_ver_ chown + test yes = yes + local i + for i in '$*' + env chown --version chown (GNU coreutils) 8.22.17-ba34a-dirty Copyright (C) 2014 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later . This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by David MacKenzie and Jim Meyering. ++ id -u + id_u=34574 + test -n 34574 ++ id -un + id_un=agordon + test -n agordon ++ id -g + id_g=1000 + test -n 1000 ++ id -gn + id_gn=users + test -n users ++ getent group users ++ wc -l + test 1 = 1 + case $host_triplet in + chown '' . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:1000 . + for sep in '$seps' + case $u$sep$g in + chown 34574.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown 34574.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown 34574: . + for sep in '$seps' + case $u$sep$g in + chown 34574. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:1000 . + for sep in '$seps' + case $u$sep$g in + chown agordon.1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon:users . chown: changing ownership of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown agordon.users . chown: changing ownership of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown agordon: . + for sep in '$seps' + case $u$sep$g in + chown agordon. . + for u in '$id_u' '"$id_un"' ''\'''\''' + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :1000 . + for sep in '$seps' + case $u$sep$g in + chown .1000 . + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown :users . chown: changing group of '.': Operation not permitted + fail=1 + for sep in '$seps' + case $u$sep$g in + chown .users . chown: changing group of '.': Operation not permitted + fail=1 + for g in '$id_g' '"$id_gn"' ''\'''\''' + case $u$g in + seps=': .' + for sep in '$seps' + case $u$sep$g in + chown : . + for sep in '$seps' + case $u$sep$g in + chown . . + Exit 1 + set +e + exit 1 + exit 1 + remove_tmp_ + __st=1 + cleanup_ + : + cd /data/gordon/projects/coreutils + chmod -R u+rwx /data/gordon/projects/coreutils/gt-separator.sh.t8dv + rm -rf /data/gordon/projects/coreutils/gt-separator.sh.t8dv + exit 1 --------------040901040607020202020807-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 23 22:09:06 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 03:09:06 +0000 Received: from localhost ([127.0.0.1]:33956 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6X8j-0005sf-Lu for submit@debbugs.gnu.org; Thu, 23 Jan 2014 22:09:06 -0500 Received: from mail5.vodafone.ie ([213.233.128.176]:3676) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6X8h-0005sV-Rt for 16532@debbugs.gnu.org; Thu, 23 Jan 2014 22:09:04 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAFXY4VJda5Cx/2dsb2JhbAANTb1LgwWBIoMZAQEBBDIBRhALDQsJDQEGEQ8CRgYNAQcBAYgGqXedOBeOTTMHEgGEJQEDnxKOVoFqBw Received: from unknown (HELO [192.168.1.79]) ([93.107.144.177]) by mail3.vodafone.ie with ESMTP; 24 Jan 2014 03:09:03 +0000 Message-ID: <52E1D94E.704@draigBrady.com> Date: Fri, 24 Jan 2014 03:09:02 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Assaf Gordon Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> In-Reply-To: <52E1D423.1060605@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 01/24/2014 02:46 AM, Assaf Gordon wrote: > On 01/23/2014 09:32 PM, Pádraig Brady wrote: >> >> Actually I messed up the login in the suggestion. >> I think the above should be s/!=/=/ which I've done >> in the attached patch. >> >> If you could confirm it was skipped on your system >> it would be great. >> >> I'll push soon anyway. >> > > Please don't push yet - it doesn't work, but for un-expected reason: > > my previous patch was incorrect (The "=" vs "!=" as you pointed), but also "getent groups" was incorrect - so two wrongs did make a right :) > > The test fails, here's why: > > On my strange system: > > === > $ getent group users > users:x:100: > === > vs. > === > $ getent group | grep ^users > users:x:100: > users:x:1000:www-data,XXX,YYY > === Oh right, grep ^$id_gn: it is so. Note we can't rely on getent(1) being available (as noted in bug 9987), but the failure in that edge case is still a skip as the count will be 0 then. thanks, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 02:43:22 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 07:43:22 +0000 Received: from localhost ([127.0.0.1]:34069 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6bQ9-0004u0-F2 for submit@debbugs.gnu.org; Fri, 24 Jan 2014 02:43:21 -0500 Received: from moutng.kundenserver.de ([212.227.17.8]:51446) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6bQ1-0004th-Vh for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 02:43:15 -0500 Received: from [192.168.1.11] (p5499CDA4.dip0.t-ipconnect.de [84.153.205.164]) by mrelayeu.kundenserver.de (node=mreu1) with ESMTP (Nemesis) id 0M3OD6-1VG0nY1THs-00rN0Y; Fri, 24 Jan 2014 08:43:12 +0100 Message-ID: <52E2198F.8060600@bernhard-voelker.de> Date: Fri, 24 Jan 2014 08:43:11 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= , Assaf Gordon Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> In-Reply-To: <52E1D94E.704@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:MawoqnBD64tbN3mdxhkK2gSGsXS/VcsMHzA4HwyfZY8 94KFwvheZceLNzI3+1GN9K3jUiHM31NYinj85UqpJy5sHB0/QX QMOaNiL0DR4OW/jN1HS9uDuRn8YDn17ofHXRduBCzmVHIlbcPC lKsYK6gRqOu6C8zqr2Msvoi3/AwFdGKaVpjU5f6gU4/CPnI/S0 VNxGg5dktNoDk6yUnzVDbG853E6Zcin9XNp2GCs+qpIGrzDL9W mdqnpU75HxRnpLHjeP+70maVqW3vsMkHPZvuouw39b8J6Z+9G6 3XIwBRuTy16twnlvJYrT5/2ugZYxXd6YpCiT/BccQTg8bwzo85 F8qxbWQ9rcmnYdSBW+du+8Iyec0Lt1qsZy1+hj1JC X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 01/24/2014 04:09 AM, Pádraig Brady wrote: > On 01/24/2014 02:46 AM, Assaf Gordon wrote: >> $ getent group | grep ^users >> users:x:100: >> users:x:1000:www-data,XXX,YYY >> === > > Oh right, grep ^$id_gn: it is so. > > Note we can't rely on getent(1) being available (as noted in bug 9987), > but the failure in that edge case is still a skip as the count will be 0 then. I'm still not convinced that we should mask this misconfiguration by skipping the test. AFAIK it's totally valid to have several names for a gid, but is it permitted the other way round? I'd bet you run into other trouble on such a system, too. Therefore, I see the failing test more as a heads-up to fix the configuration. Thanks & have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 07:19:49 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 12:19:49 +0000 Received: from localhost ([127.0.0.1]:34202 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6fjh-0003iL-Hv for submit@debbugs.gnu.org; Fri, 24 Jan 2014 07:19:49 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:35505) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6fje-0003iC-Qd for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 07:19:47 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBALdZ4lJtTPUT/2dsb2JhbAANTb1LgwWBIIMZAQEBBDIBRhALDQEKCRYPCQMCAQIBRQYNAQcBAYgGqiSdYxeOTTMHhDgBA58Vjlw Received: from unknown (HELO [192.168.1.79]) ([109.76.245.19]) by mail1.vodafone.ie with ESMTP; 24 Jan 2014 12:19:45 +0000 Message-ID: <52E25A5E.5090609@draigBrady.com> Date: Fri, 24 Jan 2014 12:19:42 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Bernhard Voelker Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> In-Reply-To: <52E2198F.8060600@bernhard-voelker.de> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org, Assaf Gordon X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 01/24/2014 07:43 AM, Bernhard Voelker wrote: > On 01/24/2014 04:09 AM, Pádraig Brady wrote: >> On 01/24/2014 02:46 AM, Assaf Gordon wrote: >>> $ getent group | grep ^users >>> users:x:100: >>> users:x:1000:www-data,XXX,YYY >>> === >> >> Oh right, grep ^$id_gn: it is so. >> >> Note we can't rely on getent(1) being available (as noted in bug 9987), >> but the failure in that edge case is still a skip as the count will be 0 then. > > I'm still not convinced that we should mask this misconfiguration > by skipping the test. > > AFAIK it's totally valid to have several names for a gid, > but is it permitted the other way round? > > I'd bet you run into other trouble on such a system, too. > Therefore, I see the failing test more as a heads-up to > fix the configuration. > > Thanks & have a nice day, > Berny > Since it's an easy enough workaround it's worth adding IMHO. As a general point there should never be any questions about test failures. I've seen some test suites become less than useful through attrition of little issues. For me the tests take more time than the code and are more awkward to write, but that's all fine and good as that's were the real value is. thanks, Pádraig. From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 07:46:24 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 12:46:24 +0000 Received: from localhost ([127.0.0.1]:34206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6g9P-0005Xq-Nk for submit@debbugs.gnu.org; Fri, 24 Jan 2014 07:46:24 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:51456) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6g9M-0005Xf-PZ for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 07:46:22 -0500 Received: from [10.0.2.15] (gw.camline.com [62.153.148.194]) by mrelayeu.kundenserver.de (node=mreu0) with ESMTP (Nemesis) id 0Lgc4H-1VUa7A2S9d-00oEtP; Fri, 24 Jan 2014 13:46:17 +0100 Message-ID: <52E26097.6010205@bernhard-voelker.de> Date: Fri, 24 Jan 2014 13:46:15 +0100 From: Bernhard Voelker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: =?ISO-8859-1?Q?P=E1draig_Brady?= Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> In-Reply-To: <52E25A5E.5090609@draigBrady.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Provags-ID: V02:K0:LoCSDIyTJYIhxvOcL5YfqE/scmG0tZQUSkeIEtHmW88 OwzWqeAaGv1VUPJsYGaLl5WBncNx4IQYI3p531E0Mr04RU+xKw OttlHHqR1wM2qAdRhYWb31N15jbbg1m5OqH4nBE+oVZBXuaG84 t6gw+1vwoJZRZUU16nA3iCoFkQojYt72rcrAOygNM+qyhz1Fvf RAypqW5EyoNiCYymAyUNkvQRHrXtmjoE8n9M2vI1sxA3axq2zp uSma/hgL8xzA/mIOPA3b0C8yWVQRuNcQSg1KhwjMdC7PMvyKke WinHHN15v+mI5GKz81A47M2SFVnnMFTDHwHBp6CU44XmLfzSlU ztln5K5KastnJ4dyoUSi9eQTYhNkhiI00Qyyqqq/f X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org, Assaf Gordon X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On 01/24/2014 01:19 PM, Pádraig Brady wrote: > On 01/24/2014 07:43 AM, Bernhard Voelker wrote: >> On 01/24/2014 04:09 AM, Pádraig Brady wrote: >>> Oh right, grep ^$id_gn: it is so. >>> >>> Note we can't rely on getent(1) being available (as noted in bug 9987), >>> but the failure in that edge case is still a skip as the count will be 0 then. >> >> I'm still not convinced that we should mask this misconfiguration >> by skipping the test. >> >> AFAIK it's totally valid to have several names for a gid, >> but is it permitted the other way round? >> >> I'd bet you run into other trouble on such a system, too. >> Therefore, I see the failing test more as a heads-up to >> fix the configuration. >> >> Thanks & have a nice day, >> Berny >> > > Since it's an easy enough workaround it's worth adding IMHO. > As a general point there should never be any questions > about test failures. I've seen some test suites become > less than useful through attrition of little issues. > For me the tests take more time than the code and are more > awkward to write, but that's all fine and good as that's > were the real value is. Okay, let's go with it then. Thanks. BTW: I'd change the skip_ message to reflect the above mentioned corner case where getent is not available, something like: - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" Have a nice day, Berny From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 11:58:22 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 16:58:22 +0000 Received: from localhost ([127.0.0.1]:34763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6k5F-0003lQ-12 for submit@debbugs.gnu.org; Fri, 24 Jan 2014 11:58:21 -0500 Received: from mail-qc0-f179.google.com ([209.85.216.179]:35388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6k5C-0003lI-Hy for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 11:58:19 -0500 Received: by mail-qc0-f179.google.com with SMTP id e16so4807811qcx.10 for <16532@debbugs.gnu.org>; Fri, 24 Jan 2014 08:58:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type; bh=SRL49HMpWgWsZgQOj/wA01q5x7Y5ahtuUhPKVx3A2hc=; b=Rz93nYgy0uqLbUbXgUF+IUB2I0byssrbqKgIxtskwgve5GDAR3A9916lYLoBlC/aZH LouMj3vP/Cyqubd4uTrMxYN6iS4jdZ8RvorDJeugwpcWDpbxg9l7LogxQp+Qq0p01uRK 04waftqI1FDen9npPNnUYys9LLzDATfl2v+cEa8zk2aH/SexCQUAOiChlzTeFFbWzuEt hcoB/ut0ghIJFimGoW454+XXfqcJ7Dg7M4Ese16wpziJJBhwb+R4m2Wb2knxhGUajXjL eSVyQGYtZhNHZqP2ua1KRWZcFutOAuSmYjEnD269/3ct1ugqKQjyQR3+faiZjZl9j4AC /c/g== X-Received: by 10.224.32.133 with SMTP id c5mr22011349qad.54.1390582697727; Fri, 24 Jan 2014 08:58:17 -0800 (PST) Received: from [10.9.40.29] ([18.4.1.144]) by mx.google.com with ESMTPSA id v92sm1044762qge.6.2014.01.24.08.58.15 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 24 Jan 2014 08:58:15 -0800 (PST) Message-ID: <52E29BC6.20606@gmail.com> Date: Fri, 24 Jan 2014 11:58:46 -0500 From: Assaf Gordon User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Bernhard Voelker , =?ISO-8859-1?Q?P=E1draig?= =?ISO-8859-1?Q?_Brady?= Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> <52E26097.6010205@bernhard-voelker.de> In-Reply-To: <52E26097.6010205@bernhard-voelker.de> Content-Type: multipart/mixed; boundary="------------000706050103080500000305" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------000706050103080500000305 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit On 01/24/2014 07:46 AM, Bernhard Voelker wrote: >>> On 01/24/2014 04:09 AM, Pádraig Brady wrote: >>>> Oh right, grep ^$id_gn: it is so. > > BTW: I'd change the skip_ message to reflect the above mentioned > corner case where getent is not available, something like: > > - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" > + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" > Attached is an updated version, using grep and the suggested error message. On addition is a "tr '\n' ','" - because "skip" only shows the first line of the message, and so multiple groups and not displayed. -gordon --------------000706050103080500000305 Content-Type: text/x-patch; name="chown-dup-group.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="chown-dup-group.patch" >From 5fc10774383928b2fbfde33de3efb314166fe475 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Thu, 23 Jan 2014 20:34:52 -0500 Subject: [PATCH] tests: skip chown/separator with conflicting group IDs * tests/chown/separator.sh: skip test if the user's group has multiple entries. Fixes http://bugs.gnu.org/16532 --- tests/chown/separator.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/chown/separator.sh b/tests/chown/separator.sh index f64b738..f5ecb5b 100755 --- a/tests/chown/separator.sh +++ b/tests/chown/separator.sh @@ -31,6 +31,12 @@ test -n "$id_g" || framework_failure_ id_gn=$(id -gn) || framework_failure_ test -n "$id_gn" || framework_failure_ +# Systems with both local and external groups with conflicting IDs, +# were seen to fail this test erroneously with EPERM errors. +test $(getent group | grep "^$id_gn:" | wc -l) = 1 || + skip_ "group '$id_gn' not biunique: " \ + "$(getent group | grep "^$id_gn:" | tr '\n' ',')" + # FreeBSD 6.x's getgrnam fails to look up a group name containing # a space. On such a system, skip this test if the group name contains # a byte not in the portable filename character set. -- 1.8.4.3 --------------000706050103080500000305-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 24 12:50:34 2014 Received: (at 16532) by debbugs.gnu.org; 24 Jan 2014 17:50:34 +0000 Received: from localhost ([127.0.0.1]:34777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6ktl-00059h-JG for submit@debbugs.gnu.org; Fri, 24 Jan 2014 12:50:33 -0500 Received: from mail1.vodafone.ie ([213.233.128.43]:48445) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W6kti-00059X-V9 for 16532@debbugs.gnu.org; Fri, 24 Jan 2014 12:50:31 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApMBAF6n4lJtTPUT/2dsb2JhbAANTb1KgwWBI4MZAQEBBDIBRhALDQsJFg8JAwIBAgFFBg0BBwEBiAaqYZ1ZF48MB4Q4AQOfFo5c Received: from unknown (HELO [192.168.1.79]) ([109.76.245.19]) by mail1.vodafone.ie with ESMTP; 24 Jan 2014 17:50:28 +0000 Message-ID: <52E2A7E2.5090504@draigBrady.com> Date: Fri, 24 Jan 2014 17:50:26 +0000 From: =?ISO-8859-1?Q?P=E1draig_Brady?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Assaf Gordon Subject: Re: bug#16532: Test Fail: "tests/chown/separator" References: <52E1625A.7040002@gmail.com> <52E1A3D3.2000704@bernhard-voelker.de> <52E1A8A3.6020500@gmail.com> <52E1BD42.2050101@draigBrady.com> <52E1C414.4000300@gmail.com> <52E1C55D.2000205@draigBrady.com> <52E1D0D2.4010303@draigBrady.com> <52E1D423.1060605@gmail.com> <52E1D94E.704@draigBrady.com> <52E2198F.8060600@bernhard-voelker.de> <52E25A5E.5090609@draigBrady.com> <52E26097.6010205@bernhard-voelker.de> <52E29BC6.20606@gmail.com> In-Reply-To: <52E29BC6.20606@gmail.com> X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16532 Cc: 16532@debbugs.gnu.org, Bernhard Voelker X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) On 01/24/2014 04:58 PM, Assaf Gordon wrote: > On 01/24/2014 07:46 AM, Bernhard Voelker wrote: >>>> On 01/24/2014 04:09 AM, Pádraig Brady wrote: >>>>> Oh right, grep ^$id_gn: it is so. >> >> BTW: I'd change the skip_ message to reflect the above mentioned >> corner case where getent is not available, something like: >> >> - skip_ "multiple IDs for group '$id_gn': $(getent group "$id_gn")" >> + skip_ "group '$id_gn' not biunique: $(getent group | grep "^$id_gn:")" >> > > Attached is an updated version, using grep and the suggested error message. > On addition is a "tr '\n' ','" - because "skip" only shows the first line of the message, and so multiple groups and not displayed. If you remove the "" from "$()" the '\n' would be changed to spaces Your changing to ',' is neater though. Note to avoid a trailing ',' one can use ... | paste -s -d, Anyway pushed. thanks! Pádraig. From unknown Sat Sep 20 01:09:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 22 Feb 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator