From unknown Thu Aug 14 22:17:35 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16523: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") Resent-From: Toby Cubitt Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Jan 2014 17:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16523 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Barry OReilly Cc: 16523@debbugs.gnu.org X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Reply-To: Toby Cubitt Received: via spool by submit@debbugs.gnu.org id=B.139041055017603 (code B ref -1); Wed, 22 Jan 2014 17:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jan 2014 17:09:10 +0000 Received: from localhost ([127.0.0.1]:60893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W61Ib-0004Zq-2t for submit@debbugs.gnu.org; Wed, 22 Jan 2014 12:09:09 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35409) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W61IX-0004Zg-Sq for submit@debbugs.gnu.org; Wed, 22 Jan 2014 12:09:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W61IT-0005aq-0x for submit@debbugs.gnu.org; Wed, 22 Jan 2014 12:09:05 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: ** X-Spam-Status: No, score=2.3 required=5.0 tests=BAYES_50,FAKE_REPLY_C autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38986) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W61IS-0005am-UI for submit@debbugs.gnu.org; Wed, 22 Jan 2014 12:09:00 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37066) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W61IO-0002Dz-JN for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2014 12:09:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W61II-0005Yg-IL for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2014 12:08:56 -0500 Received: from starfish.geekisp.com ([216.168.135.166]:28035) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1W61II-0005YR-Eu for bug-gnu-emacs@gnu.org; Wed, 22 Jan 2014 12:08:50 -0500 Received: (qmail 3636 invoked by uid 1003); 22 Jan 2014 17:08:49 -0000 Received: from localhost (localhost.geekisp.com [127.0.0.1]) by localhost.geekisp.com (tmda-ofmipd) with ESMTP; Wed, 22 Jan 2014 12:08:46 -0500 Date: Wed, 22 Jan 2014 17:08:44 +0000 Message-ID: <20140122170844.GA1898@c3po> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-PGP-Key: http://www.dr-qubit.org/gpg-toby-pub.asc User-Agent: Mutt/1.5.22 (2013-10-16) X-Delivery-Agent: TMDA/1.1.11 (Ladyburn) From: Toby Cubitt X-Primary-Address: toby@dr-qubit.org X-detected-operating-system: by eggs.gnu.org: OpenBSD 4.x-5.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) On Tue, Jan 21, 2014 at 10:23:37PM -0500, Barry OReilly wrote: > > * Sometimes the navigate down hangs with backtrace: > > > > Debugger entered--Lisp error: (quit) > > undo-tree-copy-list((nil)) > > undo-tree-redo-1(1) > > undo-tree-visualize-redo(1) > > call-interactively(undo-tree-visualize-redo nil nil) > > command-execute(undo-tree-visualize-redo) > > In a reproduction of this, at the start of undo-tree-copy-list, > undo-list is: > > (nil (undo-tree-id3 . -2)) > > Then in this while loop: > > (while (null copy) > (setq copy > (undo-tree-restore-GC-elts-from-pool (pop undo-list)))) > > undo-tree-restore-GC-elts-from-pool returns nil for both elements, so > the while loop never ends. Perhaps you want instead (ignore-whitespace > diff): Could well be. Thanks a lot for the patch! I need to step through the minimal example and remember what this code is supposed to be doing, and then either apply your patch or figure out what the correct fix is (to this, and the other undo-list-pop-changeset issue you pointed out, which at the moment seem to be separate issues). Cheers, Toby > --- a/emacs/lisp/undo-tree.el Fri Jan 17 19:18:15 2014 -0500 > +++ b/emacs/lisp/undo-tree.el Tue Jan 21 22:17:50 2014 -0500 > @@ -1690,13 +1690,13 @@ > (defun undo-tree-copy-list (undo-list) > ;; Return a deep copy of first changeset in `undo-list'. Object id's are > ;; replaced by corresponding objects from `buffer-undo-tree' object-pool. > - (when undo-list > (let (copy p) > ;; if first element contains an object id, replace it with object > from > ;; pool, discarding element entirely if it's been GC'd > - (while (null copy) > + (while (and undo-list (null copy)) > (setq copy > (undo-tree-restore-GC-elts-from-pool (pop undo-list)))) > + (when copy > (setq copy (list copy) > p copy) > ;; copy remaining elements, replacing object id's with objects from -- Dr T. S. Cubitt Royal Society University Research Fellow and Fellow of Churchill College, Cambridge Centre for Quantum Information DAMTP, University of Cambridge email: tsc25@cantab.net web: www.dr-qubit.org From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 22 13:39:56 2014 Received: (at control) by debbugs.gnu.org; 22 Jan 2014 18:39:56 +0000 Received: from localhost ([127.0.0.1]:60926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W62iR-0006zf-OR for submit@debbugs.gnu.org; Wed, 22 Jan 2014 13:39:55 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56192) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W62iP-0006zX-Gy for control@debbugs.gnu.org; Wed, 22 Jan 2014 13:39:54 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W62iO-0001W4-VH for control@debbugs.gnu.org; Wed, 22 Jan 2014 13:39:53 -0500 Date: Wed, 22 Jan 2014 13:39:52 -0500 Message-Id: Subject: control message for bug 16523 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) forcemerge 16377 16523 From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 05 20:29:12 2017 Received: (at control) by debbugs.gnu.org; 6 Jul 2017 00:29:12 +0000 Received: from localhost ([127.0.0.1]:53905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSufQ-00020z-FT for submit@debbugs.gnu.org; Wed, 05 Jul 2017 20:29:12 -0400 Received: from gateway30.websitewelcome.com ([192.185.152.11]:22692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSufO-00020r-Be for control@debbugs.gnu.org; Wed, 05 Jul 2017 20:29:10 -0400 Received: from cm14.websitewelcome.com (cm14.websitewelcome.com [100.42.49.7]) by gateway30.websitewelcome.com (Postfix) with ESMTP id F19EE2FC1C for ; Wed, 5 Jul 2017 19:29:09 -0500 (CDT) Received: from gator3053.hostgator.com ([50.87.144.69]) by cmsmtp with SMTP id Suf1dR3sAUy7vSuf2dUQ94; Wed, 05 Jul 2017 19:28:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lawlist.com ; s=default; h=Content-Type:MIME-Version:Subject:To:From:Message-ID:Date: Sender:Reply-To:Cc:Content-Transfer-Encoding:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: In-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cgrskv3qI+sQo8e5G+xqb7Hr2WolNqi3Mnk4DJrP/a0=; b=IUodvJdHftpG7LFnG+ijYgZU7L fCBWdvQ0Q9ewiFlwQ3TUsCFX7wnIV7DnAExfBMDaaSJNXloV7ca8NTisgFHk0MWVilFo5zH3sQtBi vV1CdaP1LKzYXPXbwSNJf1FDS5FCAnSbJxUxYs9CsL923kZmovcvEkwpuMFID5FNt1MrENVIjU9j2 hPMelV+gICPt83mnPGaUJN+H3ni8A8B5oMQqhGMy6wFAYeD432qs/kblLabQCQgcS/Vdc7gB3Th8/ KQhTOPxClYKH25UBn170YNOQBtWwZJkQ29Flw3IB3nZLqO0Dz3ZVPtL3F16y198oM7S+JwC33GmOm vuoLpMiw==; Received: from cpe-45-48-239-195.socal.res.rr.com ([45.48.239.195]:56348 helo=server.local) by gator3053.hostgator.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.87) (envelope-from ) id 1dSufN-004Bcf-C5 for control@debbugs.gnu.org; Wed, 05 Jul 2017 19:29:09 -0500 Date: Wed, 05 Jul 2017 17:29:08 -0700 Message-ID: From: Keith David Bershatsky To: control@debbugs.gnu.org Subject: bug#16377: Undo Tree regression: (error "Unrecognized entry in undo list undo-tree-canary") MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator3053.hostgator.com X-AntiAbuse: Original Domain - debbugs.gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - lawlist.com X-BWhitelist: no X-Source-IP: 45.48.239.195 X-Exim-ID: 1dSufN-004Bcf-C5 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: cpe-45-48-239-195.socal.res.rr.com (server.local) [45.48.239.195]:56348 X-Source-Auth: lawlist X-Email-Count: 5 X-Source-Cap: bGF3bGlzdDtsYXdsaXN0O2dhdG9yMzA1My5ob3N0Z2F0b3IuY29t X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) unarchive 16377