GNU bug report logs - #16514
24.3.50; Region overlay looks bad on refined hunks in diff-mode

Previous Next

Full log

View this message in rfc822 format

From: Kévin Le Gouguec <kevin.legouguec <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 16514 <at> debbugs.gnu.org, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: bug#16514: 24.3.50; Region overlay looks bad on refined hunks in diff-mode
Date: Sun, 06 Dec 2020 16:39:04 +0100

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I'm not sure I understand the recipe at all, but what I did was
>
> C-x v =
>
> in a file that had changes, and then created a region with the mouse
> over an arbitrary bit of that buffer:
>
> <screenshot>
>
> And the results don't look obviously wrong to me.  So is this something
> that has been fixed already, or am I reproducing it wrong?

I'm not sure I understand the original recipe either, but the following
steps do show something inconsistent IMO:

1. emacs -Q CONTRIBUTE
2. C-x v g
3. move to "461cb9217d8 CONTRIBUTE (Paul Eggert 2019-05-25 10)"
4. =
5. move to the first removed line ("Briefly, …")
6. C-SPC
7. C-f C-f …

As long as point does not go past the refinement (before the comma), the
region's background has the region face's background.

Once point moves past the refinement, only non-refined parts keep the
region face's background; refined parts keep the refinement background.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.