GNU bug report logs - #16498
24.3.50; Support for custom user agents in url.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16498 in the body.
You can then email your comments to 16498 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vibhav Pant <vibhavp <at> ubuntu.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; Support for custom user agents in url.el
Date: Sun, 19 Jan 2014 21:21:43 +0530

[Message part 1 (text/plain, inline)]

URL currently doesn't support custom user agents. This could be
implemented by adding a defcustom string url-user-agent which could be
changed by the
user.
The default value could be:
(format "User-Agent: %sURL/%s\r\n"
         (if url-package-name
         (concat url-package-name "/" url-package-version " ")
         "") url-version)

I have attached a patch to add support for custom user agents in URL.

-- 
Vibhav Pant
vibhavp <at> gmail.com

[url-custom-user-agent.patch (text/x-patch, attachment)]

Message #8 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Vibhav Pant <vibhavp <at> ubuntu.com>
Cc: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Mon, 20 Jan 2014 11:08:11 -0500

On Sun, 19 Jan 2014 21:21:43 +0530 Vibhav Pant <vibhavp <at> ubuntu.com> wrote: 

VP> URL currently doesn't support custom user agents. This could be
VP> implemented by adding a defcustom string url-user-agent which could be
VP> changed by the
VP> user.
VP> The default value could be:
VP> (format "User-Agent: %sURL/%s\r\n"
VP>          (if url-package-name
VP>          (concat url-package-name "/" url-package-version " ")
VP>          "") url-version)

VP> I have attached a patch to add support for custom user agents in URL.

I think this makes sense, but it has to wait until after the feature
freeze.

Ted

Message #11 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Vibhav Pant <vibhavp <at> ubuntu.com>
Cc: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Tue, 04 Nov 2014 11:50:07 -0500

On Mon, 20 Jan 2014 11:08:11 -0500 Ted Zlatanov <tzz <at> lifelogs.com> wrote: 

TZ> On Sun, 19 Jan 2014 21:21:43 +0530 Vibhav Pant <vibhavp <at> ubuntu.com> wrote: 
VP> URL currently doesn't support custom user agents. This could be
VP> implemented by adding a defcustom string url-user-agent which could be
VP> changed by the
VP> user.
VP> The default value could be:
VP> (format "User-Agent: %sURL/%s\r\n"
VP> (if url-package-name
VP> (concat url-package-name "/" url-package-version " ")
VP> "") url-version)

VP> I have attached a patch to add support for custom user agents in URL.

TZ> I think this makes sense, but it has to wait until after the feature
TZ> freeze.

Stefan, can you please look at this patch? It would also help with
#18812 which requests the ability to specify a more detailed User-Agent
string.

Ted

Message #14 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Vibhav Pant <vibhavp <at> ubuntu.com>
Cc: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 10:27:50 -0500

VP> I have attached a patch to add support for custom user agents in URL.
TZ> I think this makes sense, but it has to wait until after the feature
TZ> freeze.
> Stefan, can you please look at this patch?

I haven't looked in detail, but I'm all in favor of such a feature in trunk.


        Stefan

Message #19 received at 16498-done <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16498-done <at> debbugs.gnu.org, Vibhav Pant <vibhavp <at> ubuntu.com>
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 11:09:06 -0500

On Wed, 05 Nov 2014 10:27:50 -0500 Stefan Monnier <monnier <at> iro.umontreal.ca> wrote: 

VP> I have attached a patch to add support for custom user agents in URL.
TZ> I think this makes sense, but it has to wait until after the feature
TZ> freeze.
>> Stefan, can you please look at this patch?

SM> I haven't looked in detail, but I'm all in favor of such a feature in trunk.

I added it (with an option to use a function call); marking this as
done and I hope you find it useful.

Ted

Message #22 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16498 <at> debbugs.gnu.org
Cc: tzz <at> lifelogs.com
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 11:57:04 -0500

Could you add a :version tag for the defcustom and a NEWS entry please?

Message #25 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 12:04:26 -0500

On Wed, 05 Nov 2014 11:57:04 -0500 Glenn Morris <rgm <at> gnu.org> wrote: 

GM> Could you add a :version tag for the defcustom and a NEWS entry please?

Right, sorry.  Would this be sufficient?

=== modified file 'etc/NEWS'
--- etc/NEWS    2014-11-03 22:27:26 +0000
+++ etc/NEWS    2014-11-05 17:03:40 +0000
@@ -226,6 +226,10 @@
 When `url-handler-mode' is enabled, file operations for these
 protocols as well as for "telnet" and "ftp" are passed to Tramp.
 
+** The URL package allows customizing the `url-user-agent' string.
+The new `url-user-agent' variable can be customized to be a string or
+a function.
+
 ** Tramp
 
 *** New connection method "nc", which allows to access dumb busyboxes.

=== modified file 'lisp/url/url-http.el'
--- lisp/url/url-http.el        2014-11-05 16:06:40 +0000
+++ lisp/url/url-http.el        2014-11-05 17:02:31 +0000
@@ -140,6 +140,7 @@
   "User Agent used by the URL package."
   :type '(choice (string :tag "A static User-Agent string")
                  (function :tag "Call a function to get the User-Agent string"))
+  :version "25.1"
   :group 'url)
 
 ;(eval-when-compile

Message #28 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 12:05:18 -0500

Sure, thanks.

Message #31 received at 16498 <at> debbugs.gnu.org (full text, mbox):

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16498 <at> debbugs.gnu.org
Subject: Re: bug#16498: 24.3.50; Support for custom user agents in url.el
Date: Wed, 05 Nov 2014 12:40:52 -0500

On Wed, 05 Nov 2014 12:05:18 -0500 Glenn Morris <rgm <at> gnu.org> wrote: 

GM> Sure, thanks.

OK, it's done.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.