GNU bug report logs - #16493
24.3.50; (setq search-invisible t) is useless, let's allow to turn visible-mode temporarily on

Previous Next

Full log

Message #44 received at 16493 <at> debbugs.gnu.org (full text, mbox):

From: Bastien <bzg <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 16493 <at> debbugs.gnu.org
Subject: Re: bug#16493: 24.3.50;
 (setq search-invisible t) is useless, let's allow to turn
 visible-mode temporarily on
Date: Sun, 29 Apr 2018 11:50:58 +0200

[Message part 1 (text/plain, inline)]

Hi Stefan,

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

>>> Removing just the text property seems cleaner.
>> I guess this solution, though nice, is tricky to implement.
>
> Why do you think so?

I looked at the way isearch does the temporary opening of overlays,
and it looks complex to add another mechanism to temporarily ignore
the 'invisible text property.  At least I don't know how to do this.

Also, I tried a preliminary patches (attached) which I find quite
convenient and seems to do what I expected first when setting
(setq search-invisible t): turning on visible-mode.

The patch is not fully tested and incomplete, as query-replace is
not handled, but that's a start.

Let me know what you think.

Thanks,

-- 
 Bastien

[isearch.el.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.