From unknown Fri Jun 20 05:34:55 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16477 <16477@debbugs.gnu.org> To: bug#16477 <16477@debbugs.gnu.org> Subject: Status: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Reply-To: bug#16477 <16477@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:34:55 +0000 retitle 16477 24.3.50; [saveplace] symbol's function defn is void: dired-ge= t-filename reassign 16477 emacs submitter 16477 Mark Oteiza severity 16477 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 01:52:05 2014 Received: (at submit) by debbugs.gnu.org; 17 Jan 2014 06:52:05 +0000 Received: from localhost ([127.0.0.1]:54340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W43Hg-0000HD-DZ for submit@debbugs.gnu.org; Fri, 17 Jan 2014 01:52:05 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47829) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W43Hd-0000Gu-MM for submit@debbugs.gnu.org; Fri, 17 Jan 2014 01:52:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W43HW-00040R-0f for submit@debbugs.gnu.org; Fri, 17 Jan 2014 01:52:01 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43555) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W43HV-00040N-T1 for submit@debbugs.gnu.org; Fri, 17 Jan 2014 01:51:53 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W43HP-0004kd-Gz for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2014 01:51:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W43HJ-0003yo-B8 for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2014 01:51:47 -0500 Received: from mail-qe0-f44.google.com ([209.85.128.44]:37086) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W43HJ-0003yh-7P for bug-gnu-emacs@gnu.org; Fri, 17 Jan 2014 01:51:41 -0500 Received: by mail-qe0-f44.google.com with SMTP id 1so3637078qee.31 for ; Thu, 16 Jan 2014 22:51:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-type; bh=Ek9JO/ms0iSOldwSmP6ZJcPu6dRCtn3iHydVtgBbFaY=; b=fUKx/j3TUgY5gmbnTBX21odhX1zzBlYdZXeMO5t72P4yB0+rXwjIDKkoR/Tvomv3uc ixAPnIPDw4Ti7wy9Yas3ZY5kfTYCadRwKFhDONkvDvOXZXuS3Y6XOn7G574ofLhDeWxh NB0F7why4U5ohV5QlwC1nJKv3iQOykN+AWELL58OS+t2FYRkX2yavTE+27CbiGJL/Tb3 XU/wmVE6HRqKzHkryj3hIdlGDFrnuf/boSlG8S03sIkLP8DKR4YwSBbX6d1meQ/kPXHP tLDVw1WUca+ESbUdiXB2XRfIwktjqWsmL6awHeTurg1pQ1SO+5r0ikbeTU0W/ygb4iZI CKcQ== X-Gm-Message-State: ALoCoQnOQxfiQrdkkWdgqgfVu+M+gllTaXLsDryQfR2ThcwxyVkt1cOor1fMLHpYbpo1dyxMpN8a X-Received: by 10.229.194.1 with SMTP id dw1mr480743qcb.20.1389941500378; Thu, 16 Jan 2014 22:51:40 -0800 (PST) Received: from holos.localdomain (c-68-55-201-85.hsd1.md.comcast.net. [68.55.201.85]) by mx.google.com with ESMTPSA id ks9sm15358413qeb.11.2014.01.16.22.51.38 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 Jan 2014 22:51:39 -0800 (PST) From: Mark Oteiza To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Date: Fri, 17 Jan 2014 01:50:45 -0500 Message-ID: <871u07p0e2.fsf@holos.localdomain> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From emacs -Q: (setq-default save-place t) (require 'saveplace) (eshell) (kill-emacs) Debugger entered--Lisp error: (void-function dired-get-filename) dired-get-filename(nil t) save-place-to-alist() save-places-to-alist() save-place-kill-emacs-hook() kill-emacs() eval((kill-emacs) nil) eval-expression((kill-emacs) nil) call-interactively(eval-expression nil nil) command-execute(eval-expression) In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw scroll bars) of 2014-01-17 on holos Repository revision: Windowing system distributor `The X.Org Foundation', version 11.0.11500000 Configured using: `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib --localstatedir=/var --with-x-toolkit=lucid --with-xft 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro' Important settings: value of $LC_COLLATE: C value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: EShell Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-: M-( s e q t q - d e f SPC s a v e - p l a c t SPC t M-: M-( r e q u i SPC ' s a v e p M-x e s h C-x C-c M-x r e p o r Recent messages: Loading em-glob...done Loading em-hist...done Loading em-ls...done Loading em-prompt...done Loading em-script...done Loading em-term...done Loading em-unix...done (No files need saving) save-place-to-alist: Symbol's function definition is void: dired-get-filename Making completion list... Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils help-mode em-unix em-term term disp-table easymenu ehelp em-script em-prompt em-ls cl-loaddefs cl-lib em-hist em-pred em-glob em-dirs em-cmpl em-basic em-banner em-alias pcomplete comint ansi-color ring esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util saveplace eldoc help-fns time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 03:03:36 2014 Received: (at 16477) by debbugs.gnu.org; 17 Jan 2014 08:03:36 +0000 Received: from localhost ([127.0.0.1]:54368 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W44Ot-0002GK-Gr for submit@debbugs.gnu.org; Fri, 17 Jan 2014 03:03:35 -0500 Received: from [69.163.184.122] (port=33097 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W44Oq-0002G8-O4 for 16477@debbugs.gnu.org; Fri, 17 Jan 2014 03:03:33 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 0A9DE301D00931; Fri, 17 Jan 2014 00:03:30 -0800 (PST) From: Juri Linkov To: Mark Oteiza Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Organization: JURTA References: <871u07p0e2.fsf@holos.localdomain> Date: Fri, 17 Jan 2014 10:01:46 +0200 In-Reply-To: <871u07p0e2.fsf@holos.localdomain> (Mark Oteiza's message of "Fri, 17 Jan 2014 01:50:45 -0500") Message-ID: <87mwiv595h.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > (setq-default save-place t) > (require 'saveplace) > (eshell) > (kill-emacs) > Debugger entered--Lisp error: (void-function dired-get-filename) > dired-get-filename(nil t) > save-place-to-alist() > save-places-to-alist() > save-place-kill-emacs-hook() > kill-emacs() > eval((kill-emacs) nil) > eval-expression((kill-emacs) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 16477 Cc: 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > (setq-default save-place t) > (require 'saveplace) > (eshell) > (kill-emacs) > Debugger entered--Lisp error: (void-function dired-get-filename) > dired-get-filename(nil t) > save-place-to-alist() > save-places-to-alist() > save-place-kill-emacs-hook() > kill-emacs() > eval((kill-emacs) nil) > eval-expression((kill-emacs) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS > (setq-default save-place t) > (require 'saveplace) > (eshell) > (kill-emacs) > Debugger entered--Lisp error: (void-function dired-get-filename) > dired-get-filename(nil t) > save-place-to-alist() > save-places-to-alist() > save-place-kill-emacs-hook() > kill-emacs() > eval((kill-emacs) nil) > eval-expression((kill-emacs) nil) > call-interactively(eval-expression nil nil) > command-execute(eval-expression) Thanks for the report. `eshell' sets the variable `dired-directory', so we have to check if we are in dired mode as well: === modified file 'lisp/saveplace.el' --- lisp/saveplace.el 2014-01-01 07:43:34 +0000 +++ lisp/saveplace.el 2014-01-17 08:01:20 +0000 @@ -152,7 +152,8 @@ (defun toggle-save-place (&optional parg \(setq-default save-place t\)" (interactive "P") - (if (not (or buffer-file-name dired-directory)) + (if (not (or buffer-file-name (and (derived-mode-p 'dired-mode) + dired-directory))) (message "Buffer `%s' not visiting a file or directory" (buffer-name)) (if (and save-place (or (not parg) (<= parg 0))) (progn @@ -172,7 +173,8 @@ (defun save-place-to-alist () ;; will be saved again when Emacs is killed. (or save-place-loaded (load-save-place-alist-from-file)) (let ((item (or buffer-file-name - (and dired-directory + (and (derived-mode-p 'dired-mode) + dired-directory (if (consp dired-directory) (expand-file-name (car dired-directory)) (expand-file-name dired-directory)))))) @@ -184,7 +186,8 @@ (defun save-place-to-alist () (position (cond ((eq major-mode 'hexl-mode) (with-no-warnings (1+ (hexl-current-address)))) - (dired-directory + ((and (derived-mode-p 'dired-mode) + dired-directory) (let ((filename (dired-get-filename nil t))) (if filename `((dired-filename . ,filename)) @@ -301,7 +304,8 @@ (defun save-places-to-alist () (with-current-buffer (car buf-list) ;; save-place checks buffer-file-name too, but we can avoid ;; overhead of function call by checking here too. - (and (or buffer-file-name dired-directory) + (and (or buffer-file-name (and (derived-mode-p 'dired-mode) + dired-directory)) (save-place-to-alist)) (setq buf-list (cdr buf-list)))))) @@ -321,9 +325,11 @@ (declare-function dired-goto-file "dired (defun save-place-dired-hook () "Position the point in a dired buffer." (or save-place-loaded (load-save-place-alist-from-file)) - (let ((cell (assoc (if (consp dired-directory) - (expand-file-name (car dired-directory)) - (expand-file-name dired-directory)) + (let ((cell (assoc (and (derived-mode-p 'dired-mode) + dired-directory + (if (consp dired-directory) + (expand-file-name (car dired-directory)) + (expand-file-name dired-directory))) save-place-alist))) (if cell (progn From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 09:38:24 2014 Received: (at 16477) by debbugs.gnu.org; 17 Jan 2014 14:38:24 +0000 Received: from localhost ([127.0.0.1]:54647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4AYx-0008Cf-Jf for submit@debbugs.gnu.org; Fri, 17 Jan 2014 09:38:23 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:46789) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4AYv-0008CX-Jn for 16477@debbugs.gnu.org; Fri, 17 Jan 2014 09:38:22 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh8BBVYjEAs0EhQYDSSIJMEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45183498" Received: from 76-10-140-163.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Jan 2014 09:38:20 -0500 Received: by pastel.home (Postfix, from userid 20848) id 8FB286019C; Fri, 17 Jan 2014 09:38:20 -0500 (EST) From: Stefan Monnier To: Juri Linkov Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Message-ID: References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> Date: Fri, 17 Jan 2014 09:38:20 -0500 In-Reply-To: <87mwiv595h.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 17 Jan 2014 10:01:46 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16477 Cc: Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (if (consp dired-directory) > (expand-file-name (car dired-directory)) > (expand-file-name dired-directory)))))) Unrelated, but couldn't resist: (expand-file-name (if (consp dired-directory) (car dired-directory) dired-directory)))))) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 17 21:20:19 2014 Received: (at 16477) by debbugs.gnu.org; 18 Jan 2014 02:20:19 +0000 Received: from localhost ([127.0.0.1]:55647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4LWF-0003yF-DE for submit@debbugs.gnu.org; Fri, 17 Jan 2014 21:20:19 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:36955) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4LWC-0003y4-Re for 16477@debbugs.gnu.org; Fri, 17 Jan 2014 21:20:17 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W4LWB-0001Pu-T4; Fri, 17 Jan 2014 21:20:15 -0500 From: Glenn Morris To: Juri Linkov Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> X-Spook: CipherTAC-2000 Venezuela Ft. Bragg Craig Livingstone ASIO X-Ran: C)ntbT#g-rXBXjE7q`<$pTS}y~7,6'uD\J[v&@i908Z8;K\yt2s|VR[%&4_Pi-k_M2{;Lq X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Fri, 17 Jan 2014 21:20:15 -0500 In-Reply-To: <87mwiv595h.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 17 Jan 2014 10:01:46 +0200") Message-ID: <0iioti58v4.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.3 (-----) X-Debbugs-Envelope-To: 16477 Cc: Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.3 (-----) Juri Linkov wrote: > `eshell' sets the variable `dired-directory' Why does it do that? From debbugs-submit-bounces@debbugs.gnu.org Sat Jan 18 22:02:51 2014 Received: (at 16477) by debbugs.gnu.org; 19 Jan 2014 03:02:51 +0000 Received: from localhost ([127.0.0.1]:56503 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4iex-0006Ya-CY for submit@debbugs.gnu.org; Sat, 18 Jan 2014 22:02:51 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:7037) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4iev-0006YS-Ay for 16477@debbugs.gnu.org; Sat, 18 Jan 2014 22:02:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCplR/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFMCplR/2dsb2JhbABEuzWDWRdzgh8BBVYjEAsOJhIUGA0kiCTBLZEKA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45288462" Received: from 76-10-153-81.dsl.teksavvy.com (HELO pastel.home) ([76.10.153.81]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 18 Jan 2014 22:02:48 -0500 Received: by pastel.home (Postfix, from userid 20848) id 4B7AB603BA; Sat, 18 Jan 2014 22:02:47 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Message-ID: References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> <0iioti58v4.fsf@fencepost.gnu.org> Date: Sat, 18 Jan 2014 22:02:47 -0500 In-Reply-To: <0iioti58v4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 17 Jan 2014 21:20:15 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16477 Cc: Juri Linkov , Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >> `eshell' sets the variable `dired-directory' > Why does it do that? Maybe it should use list-buffers-directory instead? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 03:56:52 2014 Received: (at 16477) by debbugs.gnu.org; 20 Jan 2014 08:56:52 +0000 Received: from localhost ([127.0.0.1]:57551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Af4-00019O-P8 for submit@debbugs.gnu.org; Mon, 20 Jan 2014 03:56:51 -0500 Received: from [69.163.184.122] (port=60969 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Aez-00018y-US for 16477@debbugs.gnu.org; Mon, 20 Jan 2014 03:56:46 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 21D70301C921AF; Mon, 20 Jan 2014 00:56:44 -0800 (PST) From: Juri Linkov To: Glenn Morris Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Organization: JURTA References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> <0iioti58v4.fsf@fencepost.gnu.org> Date: Mon, 20 Jan 2014 10:52:57 +0200 In-Reply-To: <0iioti58v4.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 17 Jan 2014 21:20:15 -0500") Message-ID: <877g9v6nme.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> `eshell' sets the variable `dired-directory' > > Why does it do that? Maybe some external packages rely on it to implement closer integration with dired? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 16477 Cc: Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> `eshell' sets the variable `dired-directory' > > Why does it do that? Maybe some external packages rely on it to implement closer integration with dired? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS >> `eshell' sets the variable `dired-directory' > > Why does it do that? Maybe some external packages rely on it to implement closer integration with dired? From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 03:56:54 2014 Received: (at 16477-done) by debbugs.gnu.org; 20 Jan 2014 08:56:54 +0000 Received: from localhost ([127.0.0.1]:57553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Af8-00019b-0y for submit@debbugs.gnu.org; Mon, 20 Jan 2014 03:56:54 -0500 Received: from [69.163.184.122] (port=32779 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5Af2-00019F-G3 for 16477-done@debbugs.gnu.org; Mon, 20 Jan 2014 03:56:48 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 714EC301923E79; Mon, 20 Jan 2014 00:56:47 -0800 (PST) From: Juri Linkov To: Stefan Monnier Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Organization: JURTA References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> <0iioti58v4.fsf@fencepost.gnu.org> Date: Mon, 20 Jan 2014 10:55:20 +0200 In-Reply-To: (Stefan Monnier's message of "Sat, 18 Jan 2014 22:02:47 -0500") Message-ID: <87k3dv58xz.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> `eshell' sets the variable `dired-directory' >> Why does it do that? > > Maybe it should use list-buffers-directory instead? Actually I see that eshell-mode sets both dired-directory and list-buffers-directory, so it seems that authors of eshell think both are necessary. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 16477-done Cc: Mark Oteiza , Glenn Morris , 16477-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >>> `eshell' sets the variable `dired-directory' >> Why does it do that? > > Maybe it should use list-buffers-directory instead? Actually I see that eshell-mode sets both dired-directory and list-buffers-directory, so it seems that authors of eshell think both are necessary. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS >>> `eshell' sets the variable `dired-directory' >> Why does it do that? > > Maybe it should use list-buffers-directory instead? Actually I see that eshell-mode sets both dired-directory and list-buffers-directory, so it seems that authors of eshell think both are necessary. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 12:02:11 2014 Received: (at 16477) by debbugs.gnu.org; 20 Jan 2014 17:02:11 +0000 Received: from localhost ([127.0.0.1]:58575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5IEk-0007w3-SL for submit@debbugs.gnu.org; Mon, 20 Jan 2014 12:02:11 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:37696) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5IEi-0007vq-TV for 16477@debbugs.gnu.org; Mon, 20 Jan 2014 12:02:09 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W5IEh-0003Ef-7m; Mon, 20 Jan 2014 12:02:07 -0500 From: Glenn Morris To: Juri Linkov Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> <0iioti58v4.fsf@fencepost.gnu.org> <877g9v6nme.fsf@mail.jurta.org> X-Spook: Semtex nitrate Freeh Exon Shell assassination eternity X-Ran: @4]wdvmruD_ou4o"A$(r*G[5?hi6*n7,&U+x3-[AyxcCZh#H$5GCPIp'rO0E%Z#0"6S#)0 X-Hue: blue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 20 Jan 2014 12:02:07 -0500 In-Reply-To: <877g9v6nme.fsf@mail.jurta.org> (Juri Linkov's message of "Mon, 20 Jan 2014 10:52:57 +0200") Message-ID: <4z38kitwmo.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 16477 Cc: Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Juri Linkov wrote: > Maybe some external packages rely on it to implement closer > integration with dired? Then why does no other part of Emacs set dired-directory, except for dired itself? Eg M-x shell does not. It has no effect on M-x dired. I imagine setting default-directory after cd does all that is necessary. Since this is ancient code from the very first version of eshell, personally I suspect it is simply a mistake. From debbugs-submit-bounces@debbugs.gnu.org Mon Jan 20 13:19:04 2014 Received: (at 16477) by debbugs.gnu.org; 20 Jan 2014 18:19:04 +0000 Received: from localhost ([127.0.0.1]:58653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5JR9-000330-Sd for submit@debbugs.gnu.org; Mon, 20 Jan 2014 13:19:04 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:60322) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W5JR7-00032P-5G for 16477@debbugs.gnu.org; Mon, 20 Jan 2014 13:19:01 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFsoXIQ/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFsoXIQ/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCwsOJhIUGA0kiB4GwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45409646" Received: from 108-161-114-16.dsl.teksavvy.com (HELO pastel.home) ([108.161.114.16]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 20 Jan 2014 13:19:00 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5178D6012D; Mon, 20 Jan 2014 13:19:00 -0500 (EST) From: Stefan Monnier To: Glenn Morris Subject: Re: bug#16477: 24.3.50; [saveplace] symbol's function defn is void: dired-get-filename Message-ID: References: <871u07p0e2.fsf@holos.localdomain> <87mwiv595h.fsf@mail.jurta.org> <0iioti58v4.fsf@fencepost.gnu.org> <877g9v6nme.fsf@mail.jurta.org> <4z38kitwmo.fsf@fencepost.gnu.org> Date: Mon, 20 Jan 2014 13:19:00 -0500 In-Reply-To: <4z38kitwmo.fsf@fencepost.gnu.org> (Glenn Morris's message of "Mon, 20 Jan 2014 12:02:07 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16477 Cc: Juri Linkov , Mark Oteiza , 16477@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > Since this is ancient code from the very first version of eshell, > personally I suspect it is simply a mistake. Agreed, Stefan From unknown Fri Jun 20 05:34:55 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 18 Feb 2014 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator