From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Jan 2014 08:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16438@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138968743717370 (code B ref -1); Tue, 14 Jan 2014 08:18:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Jan 2014 08:17:17 +0000 Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2zBV-0004W5-3q for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2zBS-0004Vw-Kk for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2zBJ-0003Dj-Nh for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zBJ-0003Df-Kc for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zBD-0003ju-KX for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:17:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2zB5-0003C8-Qg for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:16:59 -0500 Received: from [69.163.184.122] (port=45751 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zB5-0003C1-KR for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:16:51 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9BA9033EA3B6C6 for ; Tue, 14 Jan 2014 00:16:49 -0800 (PST) From: Juri Linkov Organization: JURTA Date: Tue, 14 Jan 2014 10:14:07 +0200 Message-ID: <87txd756b4.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) 1. emacs -Q 2. Paste to *scratch*: (custom-set-variables '(mark-even-if-inactive nil)) 3. Eval it. 4. Put point at its opening paren and type: C-M-SPC - selects the whole expression C-x TAB - activates a transient indentation mode right - adjusts indentation 1 position to the right right - fails with the error "The mark is not active now" because the previous `right' key deactivated the region One way to fix this is not to deactivate the mark in this transient mode: === modified file 'lisp/indent.el' --- lisp/indent.el 2014-01-13 05:03:31 +0000 +++ lisp/indent.el 2014-01-14 08:07:55 +0000 @@ -214,7 +214,9 @@ (defun indent-rigidly (start end arg &op (indent-to (max 0 (+ indent (prefix-numeric-value arg))) 0)) (delete-region (point) (progn (skip-chars-forward " \t") (point)))) (forward-line 1)) - (move-marker end nil)))) + (move-marker end nil) + (when (eq overriding-terminal-local-map indent-rigidly-map) + (setq deactivate-mark nil))))) But the condition of checking for the transient mode doesn't work because overriding-terminal-local-map never equals to indent-rigidly-map. indent-rigidly-map: (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) overriding-terminal-local-map: (keymap (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) add-keymap-witness) There is some `add-keymap-witness' at the end of `overriding-terminal-local-map' when the transient indentation mode is active. And I don't know another way to check if `overriding-terminal-local-map' is active. From unknown Sun Jun 22 00:20:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Juri Linkov Subject: bug#16438: closed (Re: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive)) Message-ID: References: <87sisp64cw.fsf@mail.jurta.org> <87txd756b4.fsf@mail.jurta.org> X-Gnu-PR-Message: they-closed 16438 X-Gnu-PR-Package: emacs Reply-To: 16438@debbugs.gnu.org Date: Wed, 15 Jan 2014 08:29:04 +0000 Content-Type: multipart/mixed; boundary="----------=_1389774544-31049-1" This is a multi-part message in MIME format... ------------=_1389774544-31049-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16438@debbugs.gnu.org. --=20 16438: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16438 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1389774544-31049-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16438-done) by debbugs.gnu.org; 15 Jan 2014 08:28:33 +0000 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Lpv-00083y-VW for submit@debbugs.gnu.org; Wed, 15 Jan 2014 03:28:32 -0500 Received: from [69.163.184.122] (port=40758 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3Lps-00083o-PN for 16438-done@debbugs.gnu.org; Wed, 15 Jan 2014 03:28:29 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 4007F303198252 for <16438-done@debbugs.gnu.org>; Wed, 15 Jan 2014 00:28:26 -0800 (PST) From: Juri Linkov To: 16438-done@debbugs.gnu.org Subject: Re: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Organization: JURTA References: <87txd756b4.fsf@mail.jurta.org> Date: Wed, 15 Jan 2014 10:23:11 +0200 In-Reply-To: <87txd756b4.fsf@mail.jurta.org> (Juri Linkov's message of "Tue, 14 Jan 2014 10:14:07 +0200") Message-ID: <87sisp64cw.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But the condition of checking for the transient mode doesn't work > because overriding-terminal-local-map never equals to indent-rigidly-map. > > indent-rigidly-map: > (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > > overriding-terminal-local-map: > (keymap (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > add-keymap-witness) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 16438-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > But the condition of checking for the transient mode doesn't work > because overriding-terminal-local-map never equals to indent-rigidly-map. > > indent-rigidly-map: > (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > > overriding-terminal-local-map: > (keymap (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > add-keymap-witness) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS > But the condition of checking for the transient mode doesn't work > because overriding-terminal-local-map never equals to indent-rigidly-map. > > indent-rigidly-map: > (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > > overriding-terminal-local-map: > (keymap (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) > add-keymap-witness) I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) ------------=_1389774544-31049-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Jan 2014 08:17:17 +0000 Received: from localhost ([127.0.0.1]:49695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2zBV-0004W5-3q for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:17 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W2zBS-0004Vw-Kk for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2zBJ-0003Dj-Nh for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:14 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:46914) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zBJ-0003Df-Kc for submit@debbugs.gnu.org; Tue, 14 Jan 2014 03:17:05 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49478) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zBD-0003ju-KX for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:17:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W2zB5-0003C8-Qg for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:16:59 -0500 Received: from [69.163.184.122] (port=45751 helo=ps18281.dreamhostps.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W2zB5-0003C1-KR for bug-gnu-emacs@gnu.org; Tue, 14 Jan 2014 03:16:51 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 9BA9033EA3B6C6 for ; Tue, 14 Jan 2014 00:16:49 -0800 (PST) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Organization: JURTA Date: Tue, 14 Jan 2014 10:14:07 +0200 Message-ID: <87txd756b4.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no timestamps) [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) 1. emacs -Q 2. Paste to *scratch*: (custom-set-variables '(mark-even-if-inactive nil)) 3. Eval it. 4. Put point at its opening paren and type: C-M-SPC - selects the whole expression C-x TAB - activates a transient indentation mode right - adjusts indentation 1 position to the right right - fails with the error "The mark is not active now" because the previous `right' key deactivated the region One way to fix this is not to deactivate the mark in this transient mode: === modified file 'lisp/indent.el' --- lisp/indent.el 2014-01-13 05:03:31 +0000 +++ lisp/indent.el 2014-01-14 08:07:55 +0000 @@ -214,7 +214,9 @@ (defun indent-rigidly (start end arg &op (indent-to (max 0 (+ indent (prefix-numeric-value arg))) 0)) (delete-region (point) (progn (skip-chars-forward " \t") (point)))) (forward-line 1)) - (move-marker end nil)))) + (move-marker end nil) + (when (eq overriding-terminal-local-map indent-rigidly-map) + (setq deactivate-mark nil))))) But the condition of checking for the transient mode doesn't work because overriding-terminal-local-map never equals to indent-rigidly-map. indent-rigidly-map: (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) overriding-terminal-local-map: (keymap (keymap (S-right . indent-rigidly-right-to-tab-stop) (S-left . indent-rigidly-left-to-tab-stop) (right . indent-rigidly-right) (left . indent-rigidly-left)) add-keymap-witness) There is some `add-keymap-witness' at the end of `overriding-terminal-local-map' when the transient indentation mode is active. And I don't know another way to check if `overriding-terminal-local-map' is active. ------------=_1389774544-31049-1-- From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2014 15:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16438@debbugs.gnu.org Cc: juri@jurta.org Received: via spool by 16438-submit@debbugs.gnu.org id=B16438.138979991017114 (code B ref 16438); Wed, 15 Jan 2014 15:32:01 +0000 Received: (at 16438) by debbugs.gnu.org; 15 Jan 2014 15:31:50 +0000 Received: from localhost ([127.0.0.1]:52189 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3SRa-0004Rv-24 for submit@debbugs.gnu.org; Wed, 15 Jan 2014 10:31:50 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:38613) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3SRY-0004Ro-9C for 16438@debbugs.gnu.org; Wed, 15 Jan 2014 10:31:48 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IPAS-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDYhCBsEtjWGDKQOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45013118" Received: from 76-10-140-163.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 15 Jan 2014 10:31:47 -0500 Received: by pastel.home (Postfix, from userid 20848) id A37796048B; Wed, 15 Jan 2014 10:31:47 -0500 (EST) From: Stefan Monnier Message-ID: References: <87txd756b4.fsf@mail.jurta.org> <87sisp64cw.fsf@mail.jurta.org> Date: Wed, 15 Jan 2014 10:31:47 -0500 In-Reply-To: <87sisp64cw.fsf@mail.jurta.org> (Juri Linkov's message of "Wed, 15 Jan 2014 10:23:11 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) That's hideous, tho :-( Stefan From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2014 08:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 16438@debbugs.gnu.org Received: via spool by 16438-submit@debbugs.gnu.org id=B16438.138985974820372 (code B ref 16438); Thu, 16 Jan 2014 08:10:03 +0000 Received: (at 16438) by debbugs.gnu.org; 16 Jan 2014 08:09:08 +0000 Received: from localhost ([127.0.0.1]:52778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3i0g-0005IU-TK for submit@debbugs.gnu.org; Thu, 16 Jan 2014 03:09:07 -0500 Received: from [69.163.184.122] (port=48122 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3i0d-0005IG-BB for 16438@debbugs.gnu.org; Thu, 16 Jan 2014 03:09:04 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id ABC6E301D89969; Thu, 16 Jan 2014 00:09:01 -0800 (PST) From: Juri Linkov Organization: JURTA References: <87txd756b4.fsf@mail.jurta.org> <87sisp64cw.fsf@mail.jurta.org> Date: Thu, 16 Jan 2014 09:53:12 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 15 Jan 2014 10:31:47 -0500") Message-ID: <87fvopcfdn.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) > > That's hideous, tho :-( I borrowed this condition from (not (eq map (cadr overriding-terminal-local-map))) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: >> I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) > > That's hideous, tho :-( I borrowed this condition from (not (eq map (cadr overriding-terminal-local-map))) [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS >> I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) > > That's hideous, tho :-( I borrowed this condition from (not (eq map (cadr overriding-terminal-local-map))) in `set-transient-map' that checks if the transient map is in effect. Maybe it should be refactored to a separate predicate function. From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 16 Jan 2014 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 16438@debbugs.gnu.org Received: via spool by 16438-submit@debbugs.gnu.org id=B16438.13898808474697 (code B ref 16438); Thu, 16 Jan 2014 14:01:01 +0000 Received: (at 16438) by debbugs.gnu.org; 16 Jan 2014 14:00:47 +0000 Received: from localhost ([127.0.0.1]:53021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3nV0-0001Bw-58 for submit@debbugs.gnu.org; Thu, 16 Jan 2014 09:00:47 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:38129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W3nUw-00018M-R3 for 16438@debbugs.gnu.org; Thu, 16 Jan 2014 09:00:43 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxJJAJkQoDiGGcGYFegxU X-IPAS-Result: Av8EABK/CFFMCoyj/2dsb2JhbABEuzWDWRdzgh4BAQQBViMFCws0EhQYDSSIHgaxJJAJkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45099845" Received: from 76-10-140-163.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 16 Jan 2014 09:00:41 -0500 Received: by pastel.home (Postfix, from userid 20848) id 9D72360073; Thu, 16 Jan 2014 09:00:41 -0500 (EST) From: Stefan Monnier Message-ID: References: <87txd756b4.fsf@mail.jurta.org> <87sisp64cw.fsf@mail.jurta.org> <87fvopcfdn.fsf@mail.jurta.org> Date: Thu, 16 Jan 2014 09:00:41 -0500 In-Reply-To: <87fvopcfdn.fsf@mail.jurta.org> (Juri Linkov's message of "Thu, 16 Jan 2014 09:53:12 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) >>> I fixed this by using (eq (cadr overriding-terminal-local-map) indent-rigidly-map) >> That's hideous, tho :-( > I borrowed this condition from > (not (eq map (cadr overriding-terminal-local-map))) I know. But it has problems: - if there's a nested use of set-transient-map (e.g. C-u), your code will deactivate the mark even tho we're not finished with C-x TAB. - it relies on internal details of implementation of set-transient-map. - now C-x TAB does not deactivate the mark any more :-( > Maybe it should be refactored to a separate predicate function. Could be, tho the two tests need to be different. Another option is to move the deactivation into the exit condition. Yet another option is to change C-x TAB so that it uses (mark t) when called repeatedly. I'm not sure exactly how the deactivation should behave, tho: - The current behavior seems wrong: C-x TAB does use the region, so it should "consume it", so C-x TAB right right right up should end with a deactivated region. - But should the region be highlighted *during* C-x TAB? If yes, then we have a conflict with the previous point, since just before hitting `up' the region would still need to be highlighted, so it'd be counter intuitive to deactivate the region right between when the user hits `up' and when we run the corresponding `previous-line' command. So I think that the region should *not* be highlighted during C-x TAB. Which implies using (mark t). Stefan From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2014 08:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 16438@debbugs.gnu.org Received: via spool by 16438-submit@debbugs.gnu.org id=B16438.13899461499308 (code B ref 16438); Fri, 17 Jan 2014 08:10:02 +0000 Received: (at 16438) by debbugs.gnu.org; 17 Jan 2014 08:09:09 +0000 Received: from localhost ([127.0.0.1]:54377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W44UG-0002Q3-FI for submit@debbugs.gnu.org; Fri, 17 Jan 2014 03:09:08 -0500 Received: from [69.163.184.122] (port=44382 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W44UD-0002Pr-Qx for 16438@debbugs.gnu.org; Fri, 17 Jan 2014 03:09:06 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 05C3B301DB32E6; Fri, 17 Jan 2014 00:09:04 -0800 (PST) From: Juri Linkov Organization: JURTA References: <87txd756b4.fsf@mail.jurta.org> <87sisp64cw.fsf@mail.jurta.org> <87fvopcfdn.fsf@mail.jurta.org> Date: Fri, 17 Jan 2014 10:08:24 +0200 In-Reply-To: (Stefan Monnier's message of "Thu, 16 Jan 2014 09:00:41 -0500") Message-ID: <87a9ev58u6.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > - But should the region be highlighted *during* C-x TAB? When the user selects a region, this indicates the intention to run the next command on the selected region. So when a command is going to operate on the region the user should have the clear indication beforehand to avoid surprises. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > - But should the region be highlighted *during* C-x TAB? When the user selects a region, this indicates the intention to run the next command on the selected region. So when a command is going to operate on the region the user should have the clear indication beforehand to avoid surprises. [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS > - But should the region be highlighted *during* C-x TAB? When the user selects a region, this indicates the intention to run the next command on the selected region. So when a command is going to operate on the region the user should have the clear indication beforehand to avoid surprises. Highlighting the region in transient indentation mode is especially important since this is a new feature, and without highlighting an unsuspecting user don't know that a subsequent `right' will operate on the previously selected region. For the same reason I think the exit condition should not deactivate the active region because the highlighting indicates that the next command is operating on the region. The same problem with exiting the transient indentation mode happens when the user needs to type the `right' key to move point without indentation. Then the user has to exit the sub-mode explicitly by typing e.g. C-g. It will also deselect the region. From unknown Sun Jun 22 00:20:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16438: 24.3.50; `C-x TAB right right' fails with error (mark-inactive) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 17 Jan 2014 14:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16438 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 16438@debbugs.gnu.org Received: via spool by 16438-submit@debbugs.gnu.org id=B16438.138996991732321 (code B ref 16438); Fri, 17 Jan 2014 14:46:01 +0000 Received: (at 16438) by debbugs.gnu.org; 17 Jan 2014 14:45:17 +0000 Received: from localhost ([127.0.0.1]:54663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4Afd-0008PF-3p for submit@debbugs.gnu.org; Fri, 17 Jan 2014 09:45:17 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:23605) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W4Afa-0008P7-VG for 16438@debbugs.gnu.org; Fri, 17 Jan 2014 09:45:15 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av8EABK/CFFMCoyj/2dsb2JhbAA+Brs1g1kXc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2NK4NfA4hhnBmBXoMV X-IPAS-Result: Av8EABK/CFFMCoyj/2dsb2JhbAA+Brs1g1kXc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2NK4NfA4hhnBmBXoMV X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="45184045" Received: from 76-10-140-163.dsl.teksavvy.com (HELO pastel.home) ([76.10.140.163]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 17 Jan 2014 09:45:14 -0500 Received: by pastel.home (Postfix, from userid 20848) id 201B46019C; Fri, 17 Jan 2014 09:45:14 -0500 (EST) From: Stefan Monnier Message-ID: References: <87txd756b4.fsf@mail.jurta.org> <87sisp64cw.fsf@mail.jurta.org> <87fvopcfdn.fsf@mail.jurta.org> <87a9ev58u6.fsf@mail.jurta.org> Date: Fri, 17 Jan 2014 09:45:14 -0500 In-Reply-To: <87a9ev58u6.fsf@mail.jurta.org> (Juri Linkov's message of "Fri, 17 Jan 2014 10:08:24 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > For the same reason I think the exit condition should not > deactivate the active region because the highlighting > indicates that the next command is operating on the region. Indeed, that's the problem with keeping the highlighting, since, this means that C-x TAB will not "consume" the region, which is unusual and inconvenient: after C-x TAB right right right, the user will often have to use C-g to deactivate the region :-( Stefan