GNU bug report logs - #16434
Regression: emacs --reverse-video broken

Previous Next

Full log

Message #95 received at 16434 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Matthias Dahl <matthias.dahl <at> binary-island.eu>
Cc: gundaetiapo <at> gmail.com, monnier <at> IRO.UMontreal.CA, 16434 <at> debbugs.gnu.org
Subject: Re: bug#16694: bugs #16694/#16378: Patches
Date: Mon, 28 Apr 2014 19:38:08 +0300

> Date: Sun, 27 Apr 2014 10:22:27 +0200
> From: Matthias Dahl <matthias.dahl <at> binary-island.eu>
> CC: Eli Zaretskii <eliz <at> gnu.org>, 16434 <at> debbugs.gnu.org, 
>  gundaetiapo <at> gmail.com
> 
> Eli, could you please test the attached patches? Everything is rather
> self-explanatory and the fix as simplistic as possible. I tested it for
> all known possible regressions, but everything works just fine here. It
> looks like it is the right thing to do (tm). Unfortunately, I was not
> able to test it on win32 (yeah, I know, sorry) for obvious reasons :)
> but based on what you said, it should fix the toolbar coloring just fine.

Unfortunately, it doesn't fix the problem.  It looks like the problem
is that when make-face-x-resource-internal is called near the end of
face-spec-recalc, inhibit-x-resources is already set non-nil, and so
make-face-x-resource-internal does nothing.

Don't you see the same problem on X if you set
emacs.tool-bar.attributeBackground in the X resources?  That would
allow you to try the change on your system.

> If there are no regressions reported from other parties and if it fixes
> the issues on win32, from my side just go ahead and apply it to master
> and emacs-24.

Btw, in the future, you don't need to submit 2 identical patches, just
one to the release branch is enough: it will get merged onto the trunk
soon enough after being committed to the branch.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.