GNU bug report logs - #16394
[PATCH] Custom option to turn Flyspell mode on in prog modes

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16394: closed ([PATCH] Custom option to turn Flyspell mode on
 in prog modes)
Date: Fri, 08 Aug 2014 14:11:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 08 Aug 2014 16:10:39 +0200
with message-id <12136348.pe1UfiBOmH <at> descartes>
and subject line Re: bug#16394: [PATCH] Custom option to turn Flyspell mode on in prog modes
has caused the debbugs.gnu.org bug report #16394,
regarding [PATCH] Custom option to turn Flyspell mode on in prog modes
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16394: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16394
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Matthias Meulien <orontee <at> gmail.com>
To: submit <at> debbugs.gnu.org
Subject: Re: [PATCH] Custom option to turn Flyspell mode on in prog modes
Date: Thu, 12 Dec 2013 00:17:25 +0100

[Message part 3 (text/plain, inline)]

Package: emacs
Tags: patch
Severity: wishlist
Version: 24.3

[ resent from
 http://lists.gnu.org/archive/html/emacs-devel/2013-12/msg00353.html ]

> Looks good.  But I don't think `turn-on-flyspell-prog' is needed 
> because  `flyspell-prog-mode' already turns the mode on 
> unconditionally.  (Although  maybe the latter should be 
> reconsidered.) 

You are right. The following works well.

[0001-lisp-progmodes-prog-mode.el-Add-custom-options-to-mo.patch (text/x-diff, inline)]

>From 29893db295fa1d01f9eec0f3f029b33d9a523a49 Mon Sep 17 00:00:00 2001
From: Matthias Meulien <orontee <at> gmail.com>
Date: Thu, 12 Dec 2013 00:09:16 +0100
Subject: [PATCH] lisp/progmodes/prog-mode.el: Add custom options to mode hook

---
 lisp/progmodes/prog-mode.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/lisp/progmodes/prog-mode.el b/lisp/progmodes/prog-mode.el
index b3ed328..f325a67 100644
--- a/lisp/progmodes/prog-mode.el
+++ b/lisp/progmodes/prog-mode.el
@@ -35,6 +35,12 @@
   "Generic programming mode, from which others derive."
   :group 'languages)
 
+(defcustom prog-mode-hook nil
+  "Normal hook run when entering Text mode and many related modes."
+  :type 'hook
+  :options '(flyspell-prog-mode abbrev-mode flymake-mode linum-mode)
+  :group 'prog-mode)
+
 (defvar prog-mode-map
   (let ((map (make-sparse-keymap)))
     (define-key map [?\C-\M-q] 'prog-indent-sexp)
-- 
1.8.5.1

[Message part 5 (text/plain, inline)]

-- 
Matthias

[Message part 6 (message/rfc822, inline)]

From: Rüdiger Sonderfeld <ruediger <at> c-plusplus.de>
To: bug-gnu-emacs <at> gnu.org
Cc: 16394-done <at> debbugs.gnu.org, Matthias Meulien <orontee <at> gmail.com>
Subject: Re: bug#16394: [PATCH] Custom option to turn Flyspell mode on in prog
 modes
Date: Fri, 08 Aug 2014 16:10:39 +0200

close 16394 r117667

Applied in r117667 (ChangeLog fix in r117668).

On Thursday 12 December 2013 00:17:25 Matthias Meulien wrote:
> Package: emacs
> Tags: patch
> Severity: wishlist
> Version: 24.3
> 
> [ resent from
>   http://lists.gnu.org/archive/html/emacs-devel/2013-12/msg00353.html ]
> 
> > Looks good.  But I don't think `turn-on-flyspell-prog' is needed
> > because  `flyspell-prog-mode' already turns the mode on
> > unconditionally.  (Although  maybe the latter should be
> > reconsidered.)
> 
> You are right. The following works well.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.