From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: Empty face settings ignored Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jan 2014 01:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16378@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138905729115885 (code B ref -1); Tue, 07 Jan 2014 01:15:01 +0000 Received: (at submit) by debbugs.gnu.org; 7 Jan 2014 01:14:51 +0000 Received: from localhost ([127.0.0.1]:39698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0LFq-000489-AL for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0LFo-000481-G9 for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0LFf-0003ad-1G for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFe-0003aZ-Ue for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFX-0002pZ-EU for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0LFQ-0003Yv-4x for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:31 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:18561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFQ-0003Yr-0f for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjgIABK/CFFFxKG9/2dsb2JhbABErF0BikSHbBdzgntfEyEBHA2ISKALoSKNYYMpA4hhiGyTLYFegxU X-IPAS-Result: AjgIABK/CFFFxKG9/2dsb2JhbABErF0BikSHbBdzgntfEyEBHA2ISKALoSKNYYMpA4hhiGyTLYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44304865" Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jan 2014 20:14:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5F07762F04; Mon, 6 Jan 2014 20:14:23 -0500 (EST) From: Stefan Monnier Date: Mon, 06 Jan 2014 20:14:23 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: Emacs Version: 24.3.50 Some recent change made Emacs ignore "empty" face settings: src/emacs -Q lisp/minibuffer.el M-x customize-face RET RET click on the "Inherit" button so as to disable inheritance: the result should be a face that does not specify any particular appearance. Middle click "State => Set for current session" and notice that the color is still the same. -- Stefan From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: Empty face settings ignored (was bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources) Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 26 Feb 2014 15:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthias Dahl Cc: 16378@debbugs.gnu.org Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.13934298013425 (code B ref 16378); Wed, 26 Feb 2014 15:50:02 +0000 Received: (at 16378) by debbugs.gnu.org; 26 Feb 2014 15:50:01 +0000 Received: from localhost ([127.0.0.1]:41451 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgkC-0000tA-Q3 for submit@debbugs.gnu.org; Wed, 26 Feb 2014 10:50:01 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:26556) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WIgkB-0000t3-Vc for 16378@debbugs.gnu.org; Wed, 26 Feb 2014 10:50:00 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpaMk/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA4hhiGyTLYFegxU X-IPAS-Result: Av4EABK/CFFFpaMk/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYHCxQYDSSIHgbBLZEKA4hhiGyTLYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="48806335" Received: from 69-165-163-36.dsl.teksavvy.com (HELO pastel.home) ([69.165.163.36]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 26 Feb 2014 10:49:59 -0500 Received: by pastel.home (Postfix, from userid 20848) id CADE7601A0; Wed, 26 Feb 2014 10:49:58 -0500 (EST) From: Stefan Monnier Message-ID: References: <52F601AE.5040309@binary-island.eu> <52FE6BD6.7090607@binary-island.eu> <83txbt4p37.fsf@gnu.org> <83ppmg4yvv.fsf@gnu.org> <530A25EF.6080306@binary-island.eu> <83zjlh21ec.fsf@gnu.org> <530B9D7F.20005@binary-island.eu> Date: Wed, 26 Feb 2014 10:49:58 -0500 In-Reply-To: <530B9D7F.20005@binary-island.eu> (Matthias Dahl's message of "Mon, 24 Feb 2014 20:29:03 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > don't know all of its dark corners and functionality. Thus, when I read > the bug report done by Stefan, I tried to figure out what was the > desired and what was the buggy behavior, all in the context of some > functionality that was rather foggy to me. The desired behavior is that after middle clicking "State => Set for current session", the "sample" (and all code highlighted with that font-lock-comment-delimiter-face) should be displayed with the default color used for all non-highlighted text (i.e. a black foreground, typically), whereas it's still displayed using the reddish color of font-lock-comment-face. IOW, even though I specifically asked to remove the inheritance between font-lock-comment-delimiter-face and font-lock-comment-face, this inheritance is still present. Note that this has nothing to do with inheritance. The same recipe works for other properties: src/emacs -Q lisp/minibuffer.el C-e M-x customize-face RET RET [ So this time we get font-lock-comment-face. ] click on the "Foreground" button so as to disable the reddish color: the result should be a face that does not specify any particular appearance. Middle click "State => Set for current session" and notice that the face is still using the same reddish foreground. -- Stefan From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: Empty face settings ignored (was bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources) Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Feb 2014 19:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 16378@debbugs.gnu.org Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.13935279521019 (code B ref 16378); Thu, 27 Feb 2014 19:06:01 +0000 Received: (at 16378) by debbugs.gnu.org; 27 Feb 2014 19:05:52 +0000 Received: from localhost ([127.0.0.1]:43012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ6HH-0000GM-Vk for submit@debbugs.gnu.org; Thu, 27 Feb 2014 14:05:52 -0500 Received: from hemera.binary-island.eu ([97.107.138.233]:45652) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WJ6HG-0000GE-54 for 16378@debbugs.gnu.org; Thu, 27 Feb 2014 14:05:50 -0500 Received: from [10.0.0.20] (95-90-43-186-dynip.superkabel.de [95.90.43.186]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 3161E3C0D5; Thu, 27 Feb 2014 14:11:26 -0500 (EST) Message-ID: <530F8C8A.90008@binary-island.eu> Date: Thu, 27 Feb 2014 20:05:46 +0100 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <52FE6BD6.7090607@binary-island.eu> <83txbt4p37.fsf@gnu.org> <83ppmg4yvv.fsf@gnu.org> <530A25EF.6080306@binary-island.eu> <83zjlh21ec.fsf@gnu.org> <530B9D7F.20005@binary-island.eu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks Stefan for the explanation, that was quite helpful. I'll have a look and see if I can find the cause. I'll keep you posted. From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: Empty face settings ignored (was bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources) Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Mar 2014 14:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: 16378@debbugs.gnu.org Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.13937703858613 (code B ref 16378); Sun, 02 Mar 2014 14:27:02 +0000 Received: (at 16378) by debbugs.gnu.org; 2 Mar 2014 14:26:25 +0000 Received: from localhost ([127.0.0.1]:47612 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK7LU-0002Er-St for submit@debbugs.gnu.org; Sun, 02 Mar 2014 09:26:25 -0500 Received: from hemera.binary-island.eu ([97.107.138.233]:53566) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK7LQ-0002Eh-TC for 16378@debbugs.gnu.org; Sun, 02 Mar 2014 09:26:21 -0500 Received: from [10.0.0.20] (95-90-43-186-dynip.superkabel.de [95.90.43.186]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 13E003C0D5; Sun, 2 Mar 2014 09:32:01 -0500 (EST) Message-ID: <53133F8A.5000200@binary-island.eu> Date: Sun, 02 Mar 2014 15:26:18 +0100 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <52FE6BD6.7090607@binary-island.eu> <83txbt4p37.fsf@gnu.org> <83ppmg4yvv.fsf@gnu.org> <530A25EF.6080306@binary-island.eu> <83zjlh21ec.fsf@gnu.org> <530B9D7F.20005@binary-island.eu> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) FYI: I found the cause and I've a patch in the pipeline to correct this which needs further work at this point. Since I'm quite pressed for time today, it might take another day or two. From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: Empty face settings ignored (was bug#16694: Regression by commit 115663 (bzr): Theme face attributes no longer take precedence over X resources) Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Mar 2014 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthias Dahl Cc: monnier@iro.umontreal.ca, 16378@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.139377941823724 (code B ref 16378); Sun, 02 Mar 2014 16:57:02 +0000 Received: (at 16378) by debbugs.gnu.org; 2 Mar 2014 16:56:58 +0000 Received: from localhost ([127.0.0.1]:48082 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK9hB-0006AZ-VQ for submit@debbugs.gnu.org; Sun, 02 Mar 2014 11:56:58 -0500 Received: from mtaout22.012.net.il ([80.179.55.172]:38103) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WK9h8-0006AN-OJ for 16378@debbugs.gnu.org; Sun, 02 Mar 2014 11:56:56 -0500 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0N1T00L00IZJDB00@a-mtaout22.012.net.il> for 16378@debbugs.gnu.org; Sun, 02 Mar 2014 18:56:52 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N1T00LZ0J2R2R60@a-mtaout22.012.net.il>; Sun, 02 Mar 2014 18:56:51 +0200 (IST) Date: Sun, 02 Mar 2014 18:56:34 +0200 From: Eli Zaretskii In-reply-to: <53133F8A.5000200@binary-island.eu> X-012-Sender: halo1@inter.net.il Message-id: <83mwh8tu7x.fsf@gnu.org> References: <52F601AE.5040309@binary-island.eu> <52FE6BD6.7090607@binary-island.eu> <83txbt4p37.fsf@gnu.org> <83ppmg4yvv.fsf@gnu.org> <530A25EF.6080306@binary-island.eu> <83zjlh21ec.fsf@gnu.org> <530B9D7F.20005@binary-island.eu> <53133F8A.5000200@binary-island.eu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 02 Mar 2014 15:26:18 +0100 > From: Matthias Dahl > Cc: 16378@debbugs.gnu.org > > FYI: I found the cause and I've a patch in the pipeline to correct this > which needs further work at this point. Since I'm quite pressed for time > today, it might take another day or two. Take your time, and thanks. From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bugs #16694/#16378: Patches References: In-Reply-To: Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Mar 2014 16:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16694@debbugs.gnu.org Cc: Eli Zaretskii , Stefan Monnier , 16378@debbugs.gnu.org Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.139403608510521 (code B ref 16378); Wed, 05 Mar 2014 16:15:02 +0000 Received: (at 16378) by debbugs.gnu.org; 5 Mar 2014 16:14:45 +0000 Received: from localhost ([127.0.0.1]:51872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLESx-0002ja-TS for submit@debbugs.gnu.org; Wed, 05 Mar 2014 11:14:44 -0500 Received: from hemera.binary-island.eu ([97.107.138.233]:34297) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLESr-0002jI-0m; Wed, 05 Mar 2014 11:14:42 -0500 Received: from [10.0.0.20] (95-90-43-186-dynip.superkabel.de [95.90.43.186]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 972253C0D5; Wed, 5 Mar 2014 11:20:21 -0500 (EST) Message-ID: <53174D6A.7010104@binary-island.eu> Date: Wed, 05 Mar 2014 17:14:34 +0100 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080604090709030908070103" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------080604090709030908070103 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hello @all. Since bugs #16694 and #16378 are somewhat loosely connected, I am posting this to both. The attached patches have been tested quite a bit locally and especially the fix for #16378 has gone through several revisions to cover all corner cases and side-effects. The first two patches should be quite safe to apply. Naturally I would appreciate any testing and feedback. :) The last patch is not required to fix any bugs (though it might), it just cleans up a bit but introduces a backwards incompatible change on the way which should (imho) not be a problem. That one is more a RFC but works just fine on my system as well and I think applying it to the tree shouldn't be trouble. If there are any questions or problems, please let me know. So long, Matthias --------------080604090709030908070103 Content-Type: text/x-patch; name="0001-lisp-faces.el-Fix-application-of-X-resource-attribut.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-faces.el-Fix-application-of-X-resource-attribut.pa"; filename*1="tch" >From fc76e8f48a8298c3093df353e048b9a1e996089d Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 5 Mar 2014 10:44:41 +0100 Subject: [PATCH 1/3] lisp/faces.el: Fix application of X resource attributes Attributes from X resources have to applied first after the face spec has been reset, to give Emacs' own face spec theming, customization and defface defaults a higher priority over it. Otherwise those will be overriden and the user sees a broken (= as in unintended and mixed up) user interface. Commit 15e14b165dcbc6566a0459b0d5e66f89080f569e inadvertently changed that priority. This fixes bug #16694. --- lisp/faces.el | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index e008993..145ac39 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1619,11 +1619,19 @@ function for its other effects." (defun face-spec-recalc (face frame) "Reset the face attributes of FACE on FRAME according to its specs. -This applies the defface/custom spec first, then the custom theme specs, -then the override spec." +After the reset, the specs are applied from the following sources in this order: + X resources (if applicable) + | + (theme and user customization) + or, if nonexistent or does not match the current frame, + (defface default spec) + | + defface override spec" (while (get face 'face-alias) (setq face (get face 'face-alias))) (face-spec-reset-face face frame) + (unless no-init-from-resources + (make-face-x-resource-internal face frame)) ;; If FACE is customized or themed, set the custom spec from ;; `theme-face' records. (let ((theme-faces (get face 'theme-face)) @@ -1641,8 +1649,7 @@ then the override spec." (setq spec (face-spec-choose (face-default-spec face) frame)) (face-spec-set-2 face frame spec)) (setq spec (face-spec-choose (get face 'face-override-spec) frame)) - (face-spec-set-2 face frame spec)) - (make-face-x-resource-internal face frame)) + (face-spec-set-2 face frame spec))) (defun face-spec-set-2 (face frame spec) "Set the face attributes of FACE on FRAME according to SPEC." -- 1.9.0 --------------080604090709030908070103 Content-Type: text/x-patch; name="0002-lisp-faces.el-Fix-empty-face-handling.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0002-lisp-faces.el-Fix-empty-face-handling.patch" >From f598a7d85e683c3d99e889bf764435aac3decb80 Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 5 Mar 2014 15:11:32 +0100 Subject: [PATCH 2/3] lisp/faces.el: Fix empty face handling Commit 57becb6238dd612e3bf56bef1608bba9486dcec8 inadvertently broke the handling of empty face specs. If face-spec-choose returned an empty spec (which is valid to do), this was mishandled as a no match found condition and as such, the defface default spec was applied. The bug is twofold: * face-spec-choose maps two valid states onto a single return value (no match and empty face both return as nil). * face-spec-recalc does not differentiate between both cases appropriately. This patch fixes the former by introducing a new optional parameter to face-spec-choose which, if given, is returned if no match was found. Thus the function is completely backwards compatible. The latter is fixed by adapting face-spec-recalc to make use of this new functionality and thus reliably detect if no match was found and only then apply the defface default spec. Fixes bug #16378. --- lisp/faces.el | 30 +++++++++++++++++++++--------- 1 file changed, 21 insertions(+), 9 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 145ac39..8225048 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -1512,13 +1512,15 @@ If FRAME is nil, the current FRAME is used." match)) -(defun face-spec-choose (spec &optional frame) - "Choose the proper attributes for FRAME, out of SPEC. -If SPEC is nil, return nil." +(defun face-spec-choose (spec &optional frame no-match-retval) + "Return the proper attributes for FRAME, out of SPEC. + +If no match is found or SPEC is nil, nil is returned unless NO-MATCH-RETVAL +is given which would then be returned instead." (unless frame (setq frame (selected-frame))) (let ((tail spec) - result defaults) + result defaults match-found) (while tail (let* ((entry (pop tail)) (display (car entry)) @@ -1538,9 +1540,18 @@ If SPEC is nil, return nil." (setq defaults thisval) ;; Otherwise, if it matches, use it. (when (face-spec-set-match-display display frame) - (setq result thisval) - (setq tail nil))))) - (if defaults (append result defaults) result))) + (setq result thisval + tail nil + match-found t))))) + ;; If defaults have been found, it's safe to just append those to the result + ;; list (which at this point will be either nil or contain actual specs) and + ;; return it to the caller. Since there will most definitely be something to + ;; return in this case, there's no need to know/check if a match was found. + (if defaults + (append result defaults) + (if match-found + result + no-match-retval)))) (defun face-spec-reset-face (face &optional frame) @@ -1635,11 +1646,12 @@ After the reset, the specs are applied from the following sources in this order: ;; If FACE is customized or themed, set the custom spec from ;; `theme-face' records. (let ((theme-faces (get face 'theme-face)) + (no-match-found 0) spec theme-face-applied) (if theme-faces (dolist (elt (reverse theme-faces)) - (setq spec (face-spec-choose (cadr elt) frame)) - (when spec + (setq spec (face-spec-choose (cadr elt) frame no-match-found)) + (unless (eq spec no-match-found) (face-spec-set-2 face frame spec) (setq theme-face-applied t)))) ;; If there was a spec applicable to FRAME, that overrides the -- 1.9.0 --------------080604090709030908070103 Content-Type: text/x-patch; name="0003-lisp-faces.el-Centralize-no-init-from-x-resources-ch.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0003-lisp-faces.el-Centralize-no-init-from-x-resources-ch.pa"; filename*1="tch" >From bc9280d9cab6bb59ad79225f729bfd0ef0d394fa Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 5 Mar 2014 15:50:01 +0100 Subject: [PATCH 3/3] lisp/faces.el: Centralize no-init-from-x-resources check logic Centralize the check for no-init-from-x-resources directly in make-face-x-resource-internal and remove all redundant checks. Backwards incompatible change: make-face previously accepted no-init-from-resources as an optional parameter which has now been removed. There were no other users within Emacs itself. And this parameter shouldn't have been there in the first place, imho. --- lisp/faces.el | 28 +++++++++++++--------------- 1 file changed, 13 insertions(+), 15 deletions(-) diff --git a/lisp/faces.el b/lisp/faces.el index 8225048..bcb8665 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -129,13 +129,10 @@ REGISTRY, ALTERNATIVE1, ALTERNATIVE2, and etc." "Return a list of all defined faces." (mapcar #'car face-new-frame-defaults)) -(defun make-face (face &optional no-init-from-resources) +(defun make-face (face) "Define a new face with name FACE, a symbol. Do not call this directly from Lisp code; use `defface' instead. - -If NO-INIT-FROM-RESOURCES is non-nil, don't initialize face -attributes from X resources. If FACE is already known as a face, -leave it unmodified. Return FACE." +If FACE is already known as a face, leave it unmodified. Return FACE." (interactive (list (read-from-minibuffer "Make face: " nil nil t 'face-name-history))) (unless (facep face) @@ -146,8 +143,7 @@ leave it unmodified. Return FACE." (when (fboundp 'facemenu-add-new-face) (facemenu-add-new-face face)) ;; Define frame-local faces for all frames from X resources. - (unless no-init-from-resources - (make-face-x-resource-internal face))) + (make-face-x-resource-internal face)) face) (defun make-empty-face (face) @@ -155,7 +151,7 @@ leave it unmodified. Return FACE." Do not call this directly from Lisp code; use `defface' instead." (interactive (list (read-from-minibuffer "Make empty face: " nil nil t 'face-name-history))) - (make-face face 'no-init-from-resources)) + (make-face face)) (defun copy-face (old-face new-face &optional frame new-frame) "Define a face named NEW-FACE, which is a copy of OLD-FACE. @@ -334,11 +330,14 @@ specifies an invalid attribute." (defun make-face-x-resource-internal (face &optional frame) "Fill frame-local FACE on FRAME from X resources. -FRAME nil or not specified means do it for all frames." - (if (null frame) - (dolist (frame (frame-list)) - (set-face-attributes-from-resources face frame)) - (set-face-attributes-from-resources face frame))) +FRAME nil or not specified means do it for all frames. + +If `no-init-from-resources' is t, this will do nothing." + (unless (and (boundp 'no-init-from-resources) (no-init-from-resources)) + (if (null frame) + (dolist (frame (frame-list)) + (set-face-attributes-from-resources face frame)) + (set-face-attributes-from-resources face frame)))) @@ -1641,8 +1640,7 @@ After the reset, the specs are applied from the following sources in this order: (while (get face 'face-alias) (setq face (get face 'face-alias))) (face-spec-reset-face face frame) - (unless no-init-from-resources - (make-face-x-resource-internal face frame)) + (make-face-x-resource-internal face frame) ;; If FACE is customized or themed, set the custom spec from ;; `theme-face' records. (let ((theme-faces (get face 'theme-face)) -- 1.9.0 --------------080604090709030908070103-- From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bugs #16694/#16378: Patches Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Mar 2014 19:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16694@debbugs.gnu.org Cc: Eli Zaretskii , Stefan Monnier , 16378@debbugs.gnu.org Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.139499723929760 (code B ref 16378); Sun, 16 Mar 2014 19:14:02 +0000 Received: (at 16378) by debbugs.gnu.org; 16 Mar 2014 19:13:59 +0000 Received: from localhost ([127.0.0.1]:38355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPGVS-0007jv-SG for submit@debbugs.gnu.org; Sun, 16 Mar 2014 15:13:59 -0400 Received: from hemera.binary-island.eu ([97.107.138.233]:36114) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPGVQ-0007ji-0X; Sun, 16 Mar 2014 15:13:56 -0400 Received: from [10.0.0.20] (95-90-43-186-dynip.superkabel.de [95.90.43.186]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id EAD943C0D5; Sun, 16 Mar 2014 15:19:55 -0400 (EDT) Message-ID: <5325F7F1.1070209@binary-island.eu> Date: Sun, 16 Mar 2014 20:13:53 +0100 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 References: <53174D6A.7010104@binary-island.eu> In-Reply-To: <53174D6A.7010104@binary-island.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Hello @all. It's been almost two weeks since I sent the patches with absolute and rather discouraging silence in-between. :-) So I quickly wanted to ask if there is any feedback (whether good or very bad) or something that needs improving? And if there is a chance of getting those fixes applied to the tree? Thanks in advance, Matthias From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bugs #16694/#16378: Patches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 17 Mar 2014 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthias Dahl Cc: 16694@debbugs.gnu.org, 16378@debbugs.gnu.org, monnier@IRO.UMontreal.CA Reply-To: Eli Zaretskii Received: via spool by 16378-submit@debbugs.gnu.org id=B16378.13950668198652 (code B ref 16378); Mon, 17 Mar 2014 14:34:02 +0000 Received: (at 16378) by debbugs.gnu.org; 17 Mar 2014 14:33:39 +0000 Received: from localhost ([127.0.0.1]:39056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPYbi-0002FO-Eo for submit@debbugs.gnu.org; Mon, 17 Mar 2014 10:33:39 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:59229) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WPYbf-0002FA-KZ; Mon, 17 Mar 2014 10:33:36 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N2L00D004A7LS00@a-mtaout20.012.net.il>; Mon, 17 Mar 2014 16:33:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N2L00D7Q4FXMO00@a-mtaout20.012.net.il>; Mon, 17 Mar 2014 16:33:33 +0200 (IST) Date: Mon, 17 Mar 2014 16:33:39 +0200 From: Eli Zaretskii In-reply-to: <5325F7F1.1070209@binary-island.eu> X-012-Sender: halo1@inter.net.il Message-id: <83eh20c2t8.fsf@gnu.org> References: <53174D6A.7010104@binary-island.eu> <5325F7F1.1070209@binary-island.eu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sun, 16 Mar 2014 20:13:53 +0100 > From: Matthias Dahl > CC: 16378@debbugs.gnu.org, Stefan Monnier , > Eli Zaretskii > > Hello @all. > > It's been almost two weeks since I sent the patches with absolute and > rather discouraging silence in-between. :-) So I quickly wanted to ask > if there is any feedback (whether good or very bad) or something that > needs improving? And if there is a chance of getting those fixes applied > to the tree? Barring any objections, I will commit this in a few days. Thanks. From unknown Sat Aug 16 16:18:51 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Stefan Monnier Subject: bug#16378: closed (Re: bug#16694: bugs #16694/#16378: Patches) Message-ID: References: <83lhvk8b6x.fsf@gnu.org> X-Gnu-PR-Message: they-closed 16378 X-Gnu-PR-Package: emacs Reply-To: 16378@debbugs.gnu.org Date: Sat, 05 Apr 2014 07:53:05 +0000 Content-Type: multipart/mixed; boundary="----------=_1396684385-30436-1" This is a multi-part message in MIME format... ------------=_1396684385-30436-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16378: Empty face settings ignored which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16378@debbugs.gnu.org. --=20 16378: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16378 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1396684385-30436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16378-done) by debbugs.gnu.org; 5 Apr 2014 07:52:43 +0000 Received: from localhost ([127.0.0.1]:35843 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWLP7-0007u0-Kc for submit@debbugs.gnu.org; Sat, 05 Apr 2014 03:52:42 -0400 Received: from mtaout20.012.net.il ([80.179.55.166]:45778) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWLP3-0007tf-Ga; Sat, 05 Apr 2014 03:52:39 -0400 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0N3J00H00SDBOH00@a-mtaout20.012.net.il>; Sat, 05 Apr 2014 10:52:35 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3J00H6TSJNBX80@a-mtaout20.012.net.il>; Sat, 05 Apr 2014 10:52:35 +0300 (IDT) Date: Sat, 05 Apr 2014 10:52:54 +0300 From: Eli Zaretskii Subject: Re: bug#16694: bugs #16694/#16378: Patches In-reply-to: <533C26F3.4040600@binary-island.eu> X-012-Sender: halo1@inter.net.il To: Matthias Dahl Message-id: <83lhvk8b6x.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=iso-8859-1 Content-transfer-encoding: 8BIT References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16378-done Cc: 16434-done@debbugs.gnu.org, gundaetiapo@gmail.com, monnier@iro.umontreal.ca, 16378-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 02 Apr 2014 17:04:19 +0200 > From: Matthias Dahl > CC: Clemens Schüller > , 16694@debbugs.gnu.org, > Stefan Monnier , > Eli Zaretskii , 16434@debbugs.gnu.org > > Like promised, attached revised versions of my first three patches which > had a nasty and very embarrassing bug/brain-fart as well as a potential > fix for bug #16434. > > I'd appreciate testing and any feedback, so that we (as in who ever is > in charge and can do this) commit this for the pretest. :) Thanks. I applied to the emacs-24 branch the first 2 patches, the part of the 3rd patch that does not introduce backward incompatibilities, and the 4th patch you sent in a later message. Please confirm that the result will DTRT. Meanwhile, I'm marking those bugs as "done". In the future, please also provide ChangeLog entries for the changes that could be dropped into the respective ChangeLog files. TIA. The incompatible part of the 3rd patch, reproduced below, remains uncommitted. I understand the motivation for it, but the emacs-24 branch shouldn't introduce incompatible changes at this time. If Stefan agrees with applying this part to the trunk, I will do that. ============================================================ Backwards incompatible change: make-face previously accepted no-init-from-resources as an optional parameter which has now been removed. There were no other users within Emacs itself. And this parameter shouldn't have been there in the first place, imho. diff --git a/lisp/faces.el b/lisp/faces.el index 8536c08..28205d2 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -149,13 +149,10 @@ REGISTRY, ALTERNATIVE1, ALTERNATIVE2, and etc." "Return a list of all defined faces." (mapcar #'car face-new-frame-defaults)) -(defun make-face (face &optional no-init-from-resources) +(defun make-face (face) "Define a new face with name FACE, a symbol. Do not call this directly from Lisp code; use `defface' instead. - -If NO-INIT-FROM-RESOURCES is non-nil, don't initialize face -attributes from X resources. If FACE is already known as a face, -leave it unmodified. Return FACE." +If FACE is already known as a face, leave it unmodified. Return FACE." (interactive (list (read-from-minibuffer "Make face: " nil nil t 'face-name-history))) (unless (facep face) @@ -166,8 +163,7 @@ leave it unmodified. Return FACE." (when (fboundp 'facemenu-add-new-face) (facemenu-add-new-face face)) ;; Define frame-local faces for all frames from X resources. - (unless no-init-from-resources - (make-face-x-resource-internal face))) + (make-face-x-resource-internal face)) face) (defun make-empty-face (face) @@ -175,7 +171,7 @@ leave it unmodified. Return FACE." Do not call this directly from Lisp code; use `defface' instead." (interactive (list (read-from-minibuffer "Make empty face: " nil nil t 'face-name-history))) - (make-face face 'no-init-from-resources)) + (make-face face)) (defun copy-face (old-face new-face &optional frame new-frame) "Define a face named NEW-FACE, which is a copy of OLD-FACE. ------------=_1396684385-30436-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 7 Jan 2014 01:14:51 +0000 Received: from localhost ([127.0.0.1]:39698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0LFq-000489-AL for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:50 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59439) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0LFo-000481-G9 for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0LFf-0003ad-1G for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:48 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFe-0003aZ-Ue for submit@debbugs.gnu.org; Mon, 06 Jan 2014 20:14:38 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32897) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFX-0002pZ-EU for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0LFQ-0003Yv-4x for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:31 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:18561) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0LFQ-0003Yr-0f for bug-gnu-emacs@gnu.org; Mon, 06 Jan 2014 20:14:24 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjgIABK/CFFFxKG9/2dsb2JhbABErF0BikSHbBdzgntfEyEBHA2ISKALoSKNYYMpA4hhiGyTLYFegxU X-IPAS-Result: AjgIABK/CFFFxKG9/2dsb2JhbABErF0BikSHbBdzgntfEyEBHA2ISKALoSKNYYMpA4hhiGyTLYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44304865" Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 06 Jan 2014 20:14:23 -0500 Received: by pastel.home (Postfix, from userid 20848) id 5F07762F04; Mon, 6 Jan 2014 20:14:23 -0500 (EST) From: Stefan Monnier To: bug-gnu-emacs@gnu.org Subject: Empty face settings ignored Date: Mon, 06 Jan 2014 20:14:23 -0500 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Package: Emacs Version: 24.3.50 Some recent change made Emacs ignore "empty" face settings: src/emacs -Q lisp/minibuffer.el M-x customize-face RET RET click on the "Inherit" button so as to disable inheritance: the result should be a face that does not specify any particular appearance. Middle click "State => Set for current session" and notice that the color is still the same. -- Stefan ------------=_1396684385-30436-1-- From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2014 15:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: Matthias Dahl , 16434-done@debbugs.gnu.org, gundaetiapo@gmail.com, 16378-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139671293924932 (code D ref 16378); Sat, 05 Apr 2014 15:49:02 +0000 Received: (at 16378-done) by debbugs.gnu.org; 5 Apr 2014 15:48:59 +0000 Received: from localhost ([127.0.0.1]:36972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWSq2-0006Tz-UW for submit@debbugs.gnu.org; Sat, 05 Apr 2014 11:48:59 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:35064) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWSq0-0006TZ-1I; Sat, 05 Apr 2014 11:48:56 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s35FmpPN003140; Sat, 5 Apr 2014 11:48:51 -0400 Received: by pastel.home (Postfix, from userid 20848) id DFAAA60125; Sat, 5 Apr 2014 11:48:50 -0400 (EDT) From: Stefan Monnier Message-ID: References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> Date: Sat, 05 Apr 2014 11:48:50 -0400 In-Reply-To: <83lhvk8b6x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Apr 2014 10:52:54 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4903=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4903> : inlines <692> : streams <1152654> : uri <1721263> X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) > Backwards incompatible change: make-face previously accepted > no-init-from-resources as an optional parameter which has now > been removed. There were no other users within Emacs itself. And this > parameter shouldn't have been there in the first place, imho. It's kind of late for 24.4, but it looks like a good API cleanup, so I think it's OK, tho in the 24.4 branch, please keep the optional parameter and use it to signal a warning. Stefan From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Apr 2014 16:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Monnier Cc: ml_emacs-lists@binary-island.eu, 16434-done@debbugs.gnu.org, gundaetiapo@gmail.com, 16378-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139671456232216 (code D ref 16378); Sat, 05 Apr 2014 16:17:01 +0000 Received: (at 16378-done) by debbugs.gnu.org; 5 Apr 2014 16:16:02 +0000 Received: from localhost ([127.0.0.1]:37002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWTGD-0008NG-1T for submit@debbugs.gnu.org; Sat, 05 Apr 2014 12:16:01 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:58470) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WWTG9-0008N0-LW; Sat, 05 Apr 2014 12:15:58 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0N3K00C00FLRBM00@a-mtaout23.012.net.il>; Sat, 05 Apr 2014 19:15:56 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3K00C4YFUJ8D70@a-mtaout23.012.net.il>; Sat, 05 Apr 2014 19:15:56 +0300 (IDT) Date: Sat, 05 Apr 2014 19:15:53 +0300 From: Eli Zaretskii In-reply-to: X-012-Sender: halo1@inter.net.il Message-id: <83a9bz92h2.fsf@gnu.org> References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Cc: Matthias Dahl , gundaetiapo@gmail.com, > cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org, > 16434-done@debbugs.gnu.org, 16378-done@debbugs.gnu.org > Date: Sat, 05 Apr 2014 11:48:50 -0400 > > > Backwards incompatible change: make-face previously accepted > > no-init-from-resources as an optional parameter which has now > > been removed. There were no other users within Emacs itself. And this > > parameter shouldn't have been there in the first place, imho. > > It's kind of late for 24.4, but it looks like a good API cleanup, so > I think it's OK, tho in the 24.4 branch, please keep the optional > parameter and use it to signal a warning. Mathias, could you please prepare 2 patches along these lines, one for the trunk, the other for the emacs-24 branch? Thanks. From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 07 Apr 2014 09:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: gundaetiapo@gmail.com, 16434-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16378-done@debbugs.gnu.org, 16694-done@debbugs.gnu.org Received: via spool by 16378-done@debbugs.gnu.org id=D16378.13968646903462 (code D ref 16378); Mon, 07 Apr 2014 09:59:02 +0000 Received: (at 16378-done) by debbugs.gnu.org; 7 Apr 2014 09:58:10 +0000 Received: from localhost ([127.0.0.1]:38778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WX6Jd-0000tl-AY for submit@debbugs.gnu.org; Mon, 07 Apr 2014 05:58:09 -0400 Received: from hemera.binary-island.eu ([97.107.138.233]:36122) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WX6Ja-0000tN-4w; Mon, 07 Apr 2014 05:58:06 -0400 Received: from [10.0.0.20] (95-90-43-88-dynip.superkabel.de [95.90.43.88]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 779A33C0D5; Mon, 7 Apr 2014 06:04:34 -0400 (EDT) Message-ID: <534276AA.2030203@binary-island.eu> Date: Mon, 07 Apr 2014 11:58:02 +0200 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> In-Reply-To: <83a9bz92h2.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) Hi... > Mathias, could you please prepare 2 patches along these lines, one for > the trunk, the other for the emacs-24 branch? Thanks. > Sure. I'll prepare something tomorrow or Wednesday at the latest. Thanks for applying the patches, btw. :) So long, Matthias From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 09 Apr 2014 09:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: gundaetiapo@gmail.com, 16434-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16378-done@debbugs.gnu.org, 16694-done@debbugs.gnu.org Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139703697813254 (code D ref 16378); Wed, 09 Apr 2014 09:50:02 +0000 Received: (at 16378-done) by debbugs.gnu.org; 9 Apr 2014 09:49:38 +0000 Received: from localhost ([127.0.0.1]:38454 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXp8T-0003Rg-6Q for submit@debbugs.gnu.org; Wed, 09 Apr 2014 05:49:38 -0400 Received: from hemera.binary-island.eu ([97.107.138.233]:34402) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WXp8P-0003RJ-Kk; Wed, 09 Apr 2014 05:49:34 -0400 Received: from [10.0.0.20] (95-90-43-88-dynip.superkabel.de [95.90.43.88]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id D0EAE3C335; Wed, 9 Apr 2014 05:51:00 -0400 (EDT) Message-ID: <534517A5.1070306@binary-island.eu> Date: Wed, 09 Apr 2014 11:49:25 +0200 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> In-Reply-To: <83a9bz92h2.fsf@gnu.org> Content-Type: multipart/mixed; boundary="------------060102080708020807030402" X-Spam-Score: -0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.3 (/) This is a multi-part message in MIME format. --------------060102080708020807030402 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hello... Attached the promised patches. Deprecation goes to emacs-24, removal to master. And the ChangeLog fix, if nobody minds, to both. :) Hope everything is ok. Thanks for the patience. :) If there is anything else, please let me know. So long, Matthias --------------060102080708020807030402 Content-Type: text/x-patch; name="0001-lisp-ChangeLog-Fix-mail-address-for-entry.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-ChangeLog-Fix-mail-address-for-entry.patch" >From 95dd6855bf10edc770a956031c756de4d2aab0e7 Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 9 Apr 2014 11:44:43 +0200 Subject: [PATCH] lisp/ChangeLog: Fix mail address for entry --- lisp/ChangeLog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 5b8e0e9..2dd3e54 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -100,7 +100,7 @@ * help.el (view-lossage): Doc tweak. -2014-04-07 Matthias Dahl +2014-04-07 Matthias Dahl * faces.el (face-spec-recalc): Call make-face-x-resource-internal only when inhibit-x-resources is nil, and do that earlier in the -- 1.9.1 --------------060102080708020807030402 Content-Type: text/x-patch; name="0001-lisp-faces.el-Deprecate-optional-argument-of-make-fa.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-faces.el-Deprecate-optional-argument-of-make-fa.pa"; filename*1="tch" >From 28fd5ca2188a80b18762d4b378e7fef96963615c Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 9 Apr 2014 11:17:37 +0200 Subject: [PATCH] lisp/faces.el: Deprecate optional argument of make-face The conditional application of X resources has been pushed down to make-face-x-resource-internal itself and thus the optional argument is no longer needed nor evaluated. --- lisp/ChangeLog | 7 +++++++ lisp/faces.el | 18 ++++++++++++------ 2 files changed, 19 insertions(+), 6 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 54ac144..58e488c 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,10 @@ +2014-04-09 Matthias Dahl + + * faces.el (make-face): Deprecate optional argument as it is no + longer needed/used since the conditional X resources handling + has been pushed down to make-face-x-resource-internal itself. + (make-empty-face): Don't pass optional argument to make-face. + 2014-04-09 Dmitry Gutov * progmodes/ruby-mode.el (ruby-font-lock-keywords): Highlight more diff --git a/lisp/faces.el b/lisp/faces.el index e4d8a35..cf571af 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -133,9 +133,11 @@ REGISTRY, ALTERNATIVE1, ALTERNATIVE2, and etc." "Define a new face with name FACE, a symbol. Do not call this directly from Lisp code; use `defface' instead. -If NO-INIT-FROM-RESOURCES is non-nil, don't initialize face -attributes from X resources. If FACE is already known as a face, -leave it unmodified. Return FACE." +If FACE is already known as a face, leave it unmodified. Return FACE. + +NO-INIT-FROM-RESOURCES has been deprecated and is no longer used +and will go away. Handling of conditional X resources application +has been pushed down to make-x-resource-internal itself." (interactive (list (read-from-minibuffer "Make face: " nil nil t 'face-name-history))) (unless (facep face) @@ -146,16 +148,20 @@ leave it unmodified. Return FACE." (when (fboundp 'facemenu-add-new-face) (facemenu-add-new-face face)) ;; Define frame-local faces for all frames from X resources. - (unless no-init-from-resources - (make-face-x-resource-internal face))) + (make-face-x-resource-internal face)) face) +;; Handling of whether to apply X resources or not, has been pushed down +;; to make-face-x-resource-internal itself, thus the optional arg is no +;; longer evaluated at all and going away. +(set-advertised-calling-convention 'make-face '(face) "24.4") + (defun make-empty-face (face) "Define a new, empty face with name FACE. Do not call this directly from Lisp code; use `defface' instead." (interactive (list (read-from-minibuffer "Make empty face: " nil nil t 'face-name-history))) - (make-face face 'no-init-from-resources)) + (make-face face)) (defun copy-face (old-face new-face &optional frame new-frame) "Define a face named NEW-FACE, which is a copy of OLD-FACE. -- 1.9.1 --------------060102080708020807030402 Content-Type: text/x-patch; name="0001-lisp-faces.el-Remove-deprecated-optional-argument-of.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-lisp-faces.el-Remove-deprecated-optional-argument-of.pa"; filename*1="tch" >From c8848a3c73f3773bdfcc35d177b0ec0421cfbdfa Mon Sep 17 00:00:00 2001 From: Matthias Dahl Date: Wed, 9 Apr 2014 11:35:22 +0200 Subject: [PATCH] lisp/faces.el: Remove deprecated optional argument of make-face The conditional application of X resources is handled directly by make-face-x-resource-internal since Emacs 24.4 and thus hasn't been evaluated since. Fix make-empty-face to not pass an optional argument to make-face. --- lisp/ChangeLog | 7 +++++++ lisp/faces.el | 11 ++++------- 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/lisp/ChangeLog b/lisp/ChangeLog index 5b8e0e9..f926d30 100644 --- a/lisp/ChangeLog +++ b/lisp/ChangeLog @@ -1,3 +1,10 @@ +2014-04-07 Matthias Dahl + + * faces.el (make-face): Remove deprecated optional argument. The + conditional application of X resources is handled directly by + make-face-x-resource-internal since Emacs 24.4. + (make-empty-face): Don't pass optional argument to make-face. + 2014-04-09 Daniel Colascione * emacs-lisp/cl-indent.el: Add comment claiming diff --git a/lisp/faces.el b/lisp/faces.el index b2f353d..c2ef62f 100644 --- a/lisp/faces.el +++ b/lisp/faces.el @@ -149,13 +149,11 @@ REGISTRY, ALTERNATIVE1, ALTERNATIVE2, and etc." "Return a list of all defined faces." (mapcar #'car face-new-frame-defaults)) -(defun make-face (face &optional no-init-from-resources) +(defun make-face (face) "Define a new face with name FACE, a symbol. Do not call this directly from Lisp code; use `defface' instead. -If NO-INIT-FROM-RESOURCES is non-nil, don't initialize face -attributes from X resources. If FACE is already known as a face, -leave it unmodified. Return FACE." +If FACE is already known as a face, leave it unmodified. Return FACE." (interactive (list (read-from-minibuffer "Make face: " nil nil t 'face-name-history))) (unless (facep face) @@ -166,8 +164,7 @@ leave it unmodified. Return FACE." (when (fboundp 'facemenu-add-new-face) (facemenu-add-new-face face)) ;; Define frame-local faces for all frames from X resources. - (unless no-init-from-resources - (make-face-x-resource-internal face))) + (make-face-x-resource-internal face)) face) (defun make-empty-face (face) @@ -175,7 +172,7 @@ leave it unmodified. Return FACE." Do not call this directly from Lisp code; use `defface' instead." (interactive (list (read-from-minibuffer "Make empty face: " nil nil t 'face-name-history))) - (make-face face 'no-init-from-resources)) + (make-face face) (defun copy-face (old-face new-face &optional frame new-frame) "Define a face named NEW-FACE, which is a copy of OLD-FACE. -- 1.9.1 --------------060102080708020807030402-- From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Apr 2014 14:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Matthias Dahl Cc: 16434-done@debbugs.gnu.org, gundaetiapo@gmail.com, monnier@IRO.UMontreal.CA, 16378-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org Reply-To: Eli Zaretskii Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139731317427727 (code D ref 16378); Sat, 12 Apr 2014 14:33:02 +0000 Received: (at 16378-done) by debbugs.gnu.org; 12 Apr 2014 14:32:54 +0000 Received: from localhost ([127.0.0.1]:46305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYyzF-0007D8-UQ for submit@debbugs.gnu.org; Sat, 12 Apr 2014 10:32:54 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:65442) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYyzD-0007Ch-59; Sat, 12 Apr 2014 10:32:52 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0N3X009009M1ZH00@a-mtaout21.012.net.il>; Sat, 12 Apr 2014 17:32:44 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N3X009MN9QKZ800@a-mtaout21.012.net.il>; Sat, 12 Apr 2014 17:32:44 +0300 (IDT) Date: Sat, 12 Apr 2014 17:32:44 +0300 From: Eli Zaretskii In-reply-to: <53492567.4090303@binary-island.eu> X-012-Sender: halo1@inter.net.il Message-id: <83zjjqsjn7.fsf@gnu.org> References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> <53492567.4090303@binary-island.eu> X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Sat, 12 Apr 2014 13:37:11 +0200 > From: Matthias Dahl > CC: gundaetiapo@gmail.com, cs.mlists+bug-gnu-emacs@mailbox.org, > 16694-done@debbugs.gnu.org, 16434-done@debbugs.gnu.org, > 16378-done@debbugs.gnu.org > > Hello Eli... > > Since the pretest is due today, if you get the time, could you apply > those pending patches? Thanks a lot in advance. Done. (Your changes to the trunk didn't compile, so I fixed them.) From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Apr 2014 18:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , Stefan Monnier Cc: gundaetiapo@gmail.com, 16434-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16378-done@debbugs.gnu.org, 16694-done@debbugs.gnu.org Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139732754022226 (code D ref 16378); Sat, 12 Apr 2014 18:33:02 +0000 Received: (at 16378-done) by debbugs.gnu.org; 12 Apr 2014 18:32:20 +0000 Received: from localhost ([127.0.0.1]:46428 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WZ2ix-0005mO-AK for submit@debbugs.gnu.org; Sat, 12 Apr 2014 14:32:20 -0400 Received: from hemera.binary-island.eu ([97.107.138.233]:42171) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYwFL-0002LH-HI; Sat, 12 Apr 2014 07:37:20 -0400 Received: from [10.0.0.20] (95-90-43-88-dynip.superkabel.de [95.90.43.88]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id 0218C3C335; Sat, 12 Apr 2014 07:38:50 -0400 (EDT) Message-ID: <53492567.4090303@binary-island.eu> Date: Sat, 12 Apr 2014 13:37:11 +0200 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> In-Reply-To: <534517A5.1070306@binary-island.eu> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Mailman-Approved-At: Sat, 12 Apr 2014 14:32:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hello Eli... Since the pretest is due today, if you get the time, could you apply those pending patches? Thanks a lot in advance. Have a nice weekend, Matthias From unknown Sat Aug 16 16:18:51 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16378: bug#16694: bugs #16694/#16378: Patches Resent-From: Matthias Dahl Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 12 Apr 2014 18:33:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16378 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 16434-done@debbugs.gnu.org, gundaetiapo@gmail.com, monnier@IRO.UMontreal.CA, 16378-done@debbugs.gnu.org, cs.mlists+bug-gnu-emacs@mailbox.org, 16694-done@debbugs.gnu.org Received: via spool by 16378-done@debbugs.gnu.org id=D16378.139732754222248 (code D ref 16378); Sat, 12 Apr 2014 18:33:03 +0000 Received: (at 16378-done) by debbugs.gnu.org; 12 Apr 2014 18:32:22 +0000 Received: from localhost ([127.0.0.1]:46434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WZ2iz-0005mg-NE for submit@debbugs.gnu.org; Sat, 12 Apr 2014 14:32:22 -0400 Received: from hemera.binary-island.eu ([97.107.138.233]:42489) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WYzNT-0007wF-7Q; Sat, 12 Apr 2014 10:57:56 -0400 Received: from [10.0.0.20] (95-90-43-88-dynip.superkabel.de [95.90.43.88]) (using TLSv1 with cipher ECDHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by hemera.binary-island.eu (Postfix) with ESMTPSA id AC02D3C335; Sat, 12 Apr 2014 10:59:26 -0400 (EDT) Message-ID: <5349546A.4040500@binary-island.eu> Date: Sat, 12 Apr 2014 16:57:46 +0200 From: Matthias Dahl User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 References: <52F601AE.5040309@binary-island.eu> <87k3bj40nu.fsf@cougar.home.aneadesign.com> <83wqfiz36v.fsf@gnu.org> <5331D45B.7090704@binary-island.eu> <5335920F.4030008@binary-island.eu> <533C26F3.4040600@binary-island.eu> <83lhvk8b6x.fsf@gnu.org> <83a9bz92h2.fsf@gnu.org> <534517A5.1070306@binary-island.eu> <53492567.4090303@binary-island.eu> <83zjjqsjn7.fsf@gnu.org> In-Reply-To: <83zjjqsjn7.fsf@gnu.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.4 (/) X-Mailman-Approved-At: Sat, 12 Apr 2014 14:32:15 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) Hello Eli... > Done. Thanks. > (Your changes to the trunk didn't compile, so I fixed them.) Sorry about that. I missed a parenthesis. I see that now. I should have made the compile test before sending it but it was such a simple patch which was exactly alike what I used locally against 24.4 and I double-checked it... yeah. :( I appreciate it. And sorry for the screw-up. It won't happen again. Have a nice Sunday, Matthias -- Dipl.-Inf. (FH) Matthias Dahl | Software Engineer | binary-island.eu services: custom software [desktop, mobile, web], server administration