GNU bug report logs - #16370
[PATCH] parted: don't reload partition table on every command

Previous Next

Full log

Message #17 received at 16370 <at> debbugs.gnu.org (full text, mbox):

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 16370 <at> debbugs.gnu.org
Subject: Re: [PATCH] parted: don't reload partition table on every command
Date: Thu, 17 Apr 2014 15:13:07 -0700

On Sat, Mar 29, 2014 at 01:50:12PM -0400, Phillip Susi wrote:
> gpt was using a static local variable to suppress repeatedly reporting
> an error if you chose to ignore it.  This is incorrect as the variable is
> global to all disks, and ignoring the error on one should not suppress its
> reporting on another.  Moving the flag to the PedDisk object made it
> effectively useless because parted was destroying the PedDisk and reloading
> the partition table on every command.
> 
> Parted has been reworked to cache the PedDisk once loaded, and only discard
> it when changing disks, or creating a new disklabel.
> ---
>  NEWS                     |   5 +
>  libparted/labels/gpt.c   |   7 +-
>  parted/command.c         |   6 +-
>  parted/command.h         |   6 +-
>  parted/parted.c          | 291 +++++++++++++++++++++++------------------------
>  parted/ui.c              |   8 +-
>  parted/ui.h              |   8 +-
>  tests/t3300-palo-prep.sh |   8 +-
>  8 files changed, 170 insertions(+), 169 deletions(-)

This makes t0283 start failing, it stops showing the error about
overlapping partitions.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.