From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 19:44:45 2014 Received: (at submit) by debbugs.gnu.org; 6 Jan 2014 00:44:45 +0000 Received: from localhost ([127.0.0.1]:37350 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzyJA-0007od-D0 for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:44:45 -0500 Received: from eggs.gnu.org ([208.118.235.92]:58879) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzyB3-0007aC-Lm for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzyAv-0007H2-91 for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:21 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37318) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAv-0007Gv-6b for submit@debbugs.gnu.org; Sun, 05 Jan 2014 19:36:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAm-00029B-P8 for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:36:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VzyAe-00079s-KU for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:36:04 -0500 Received: from relay4-d.mail.gandi.net ([2001:4b98:c:538::196]:51224) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VzyAe-00078G-Ca for bug-gnu-emacs@gnu.org; Sun, 05 Jan 2014 19:35:56 -0500 Received: from mfilter28-d.gandi.net (mfilter28-d.gandi.net [217.70.178.159]) by relay4-d.mail.gandi.net (Postfix) with ESMTP id 5C411172081 for ; Mon, 6 Jan 2014 01:35:51 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mfilter28-d.gandi.net Received: from relay4-d.mail.gandi.net ([217.70.183.196]) by mfilter28-d.gandi.net (mfilter28-d.gandi.net [10.0.15.180]) (amavisd-new, port 10024) with ESMTP id SzCuzUp1EuEB for ; Mon, 6 Jan 2014 01:35:49 +0100 (CET) X-Originating-IP: 109.157.16.36 Received: from andrzej-laptop (host109-157-16-36.range109-157.btcentralplus.com [109.157.16.36]) (Authenticated sender: andrzej@morgangilbert.co.uk) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 87EC5172085 for ; Mon, 6 Jan 2014 01:35:49 +0100 (CET) From: Andrzej P To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [PATCH] GDB Registers buffer - wrong values fontified Date: Mon, 06 Jan 2014 00:35:04 +0000 Message-ID: <87bnzqvtfr.fsf@andrzej-laptop.i-did-not-set--mail-host-address--so-tickle-me> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 05 Jan 2014 19:44:43 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) When stepping through a program with the GDB graphical interface, the values in the Registers buffer are fontified with 'font-lock-warning-face' on the step *after* they have changed. It makes more sense to highlight changed values on each step. I guess that this is a bug. To reproduce: $ emacs -Q M-x gdb gdb -i=mi emacs (or something suitable) M-x gdb-display-registers-buffer In GUD buffer: (gdb) break main (gdb) run Now step by machine instructions (e.g. 'C-x C-a C-i'). The values of registers in the Registers buffer change but are fontified only on the following step. The reason is that in 'gdb-update', 'gdb-changed-registers' is updated *after* the buffers are updated. Switching the order of the two operations as in the following patch solves the problem. === modified file 'lisp/progmodes/gdb-mi.el' --- lisp/progmodes/gdb-mi.el 2014-01-01 07:43:34 +0000 +++ lisp/progmodes/gdb-mi.el 2014-01-05 23:08:27 +0000 @@ -1890,10 +1890,11 @@ ;; gdb-break-list is maintained in breakpoints handler (gdb-get-buffer-create 'gdb-breakpoints-buffer) + (gdb-get-changed-registers) + (unless no-proc (gdb-emit-signal gdb-buf-publisher 'update)) - (gdb-get-changed-registers) (when (and (boundp 'speedbar-frame) (frame-live-p speedbar-frame)) (dolist (var gdb-var-list) (setcar (nthcdr 5 var) nil)) In GNU Emacs 24.3.50.3 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2014-01-05 on andrzej-laptop Bzr revision: 115879 tsdh@gnu.org-20140105201713-769mykhrpcny4oja Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Trisquel 6.0 Important settings: value of $LC_MONETARY: en_GB.UTF-8 value of $LC_NUMERIC: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_GB.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-x r e p o r t SPC e m Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util help-fns mail-prsvr mail-utils time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 10:55:49 2019 Received: (at 16366) by debbugs.gnu.org; 26 Jun 2019 14:55:49 +0000 Received: from localhost ([127.0.0.1]:36761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9Kv-0001Ux-HD for submit@debbugs.gnu.org; Wed, 26 Jun 2019 10:55:49 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hg9Kt-0001Un-NL for 16366@debbugs.gnu.org; Wed, 26 Jun 2019 10:55:48 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=stories) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hg9Kq-000102-38; Wed, 26 Jun 2019 16:55:46 +0200 From: Lars Ingebrigtsen To: Andrzej P Subject: Re: bug#16366: 24.3.50; [PATCH] GDB Registers buffer - wrong values fontified References: <87bnzqvtfr.fsf@andrzej-laptop.i-did-not-set--mail-host-address--so-tickle-me> Date: Wed, 26 Jun 2019 16:55:43 +0200 In-Reply-To: <87bnzqvtfr.fsf@andrzej-laptop.i-did-not-set--mail-host-address--so-tickle-me> (Andrzej P.'s message of "Mon, 06 Jan 2014 00:35:04 +0000") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Andrzej P writes: > When stepping through a program with the GDB graphical interface, the > values in the Registers buffer are fontified with > 'font-lock-warning-face' on the step *after* they have changed. It > makes [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16366 Cc: 16366@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Andrzej P writes: > When stepping through a program with the GDB graphical interface, the > values in the Registers buffer are fontified with > 'font-lock-warning-face' on the step *after* they have changed. It > makes more sense to highlight changed values on each step. I guess > that this is a bug. > > To reproduce: > > $ emacs -Q > > M-x gdb > > gdb -i=mi emacs (or something suitable) > > M-x gdb-display-registers-buffer > > In GUD buffer: > > (gdb) break main > (gdb) run > > Now step by machine instructions (e.g. 'C-x C-a C-i'). The values of > registers in the Registers buffer change but are fontified only on the > following step. I tried to reproduce this, but all I got was a bunch of Breakpoint 3, main (argc=1, argv=0x7fffffffe9e8) at emacs.c:977 977 { (gdb) Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: (gdb) Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: Python Exception name 'long' is not defined: in the *gud-emacs* buffer... -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 26 12:18:30 2019 Received: (at 16366-done) by debbugs.gnu.org; 26 Jun 2019 16:18:30 +0000 Received: from localhost ([127.0.0.1]:36914 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgAcw-0001oq-6y for submit@debbugs.gnu.org; Wed, 26 Jun 2019 12:18:30 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hgAcu-0001oY-AF for 16366-done@debbugs.gnu.org; Wed, 26 Jun 2019 12:18:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55020) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hgAcd-0002aF-5Q; Wed, 26 Jun 2019 12:18:14 -0400 Received: from [176.228.60.248] (port=2521 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hgAcc-0005OQ-Fa; Wed, 26 Jun 2019 12:18:10 -0400 Date: Wed, 26 Jun 2019 19:17:53 +0300 Message-Id: <83lfxojp72.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-reply-to: (message from Lars Ingebrigtsen on Wed, 26 Jun 2019 16:55:43 +0200) Subject: Re: bug#16366: 24.3.50; [PATCH] GDB Registers buffer - wrong values fontified References: <87bnzqvtfr.fsf@andrzej-laptop.i-did-not-set--mail-host-address--so-tickle-me> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16366-done Cc: 16366-done@debbugs.gnu.org, andrzej@morgangilbert.co.uk X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Wed, 26 Jun 2019 16:55:43 +0200 > Cc: 16366@debbugs.gnu.org > > > $ emacs -Q > > > > M-x gdb > > > > gdb -i=mi emacs (or something suitable) > > > > M-x gdb-display-registers-buffer > > > > In GUD buffer: > > > > (gdb) break main > > (gdb) run > > > > Now step by machine instructions (e.g. 'C-x C-a C-i'). The values of > > registers in the Registers buffer change but are fontified only on the > > following step. > > I tried to reproduce this, but all I got was a bunch of > > Breakpoint 3, main (argc=1, argv=0x7fffffffe9e8) at emacs.c:977 > 977 { > (gdb) Python Exception name 'long' is not defined: > Python Exception name 'long' is not defined: > Python Exception name 'long' is not defined: > Python Exception name 'long' is not defined: Your GDB seems to be misconfigured wrt its Python extensions. I've reproduced the problem, verified that the proposed patch fixes it, and installed it on the master branch. Andrzej, apologies for such a long delay in fixing this simple problem, and thanks for the patch. From unknown Fri Aug 08 23:32:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 25 Jul 2019 11:24:11 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator