From debbugs-submit-bounces@debbugs.gnu.org Fri Jan 03 12:19:03 2014 Received: (at submit) by debbugs.gnu.org; 3 Jan 2014 17:19:03 +0000 Received: from localhost ([127.0.0.1]:60232 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8Ok-0003jM-C1 for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:19:02 -0500 Received: from eggs.gnu.org ([208.118.235.92]:51423) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz8Oh-0003iv-EF for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:19:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8OX-0003Rt-4i for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:18:59 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55557) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8OX-0003Ro-1u for submit@debbugs.gnu.org; Fri, 03 Jan 2014 12:18:49 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8OO-00011L-EH for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 12:18:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vz8OF-0003Qd-S9 for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 12:18:40 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:41180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vz8OF-0003QW-Ml for bug-gnu-emacs@gnu.org; Fri, 03 Jan 2014 12:18:31 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id s03HITxe028061 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 3 Jan 2014 17:18:30 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s03HITch003296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 3 Jan 2014 17:18:29 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s03HISi7008394 for ; Fri, 3 Jan 2014 17:18:28 GMT MIME-Version: 1.0 Message-ID: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> Date: Fri, 3 Jan 2014 09:18:28 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `dired-internal-do-deletions': "Deleting..." message X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The message "Trashing..." (which is unclear, BTW) or "Deleting..." appears while the user is being asked whether to delete/trash. So the message is wrong: Emacs is not (yet) deleting files. A better message would be something like "Preparing to delete..." A message such as "Deleting..." can give the impression that the files are already being deleted. If you have 50 marked files, you don't want to see a message saying that they are being deleted before you have had a chance to cancel deletion. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2014-01-01 on ODIEONE Bzr revision: 115827 eggert@cs.ucla.edu-20140101192741-bi5hb4xb4kdi2zpw Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 21:48:49 2014 Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 02:48:49 +0000 Received: from localhost ([127.0.0.1]:55683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBxyK-0002jI-Lc for submit@debbugs.gnu.org; Fri, 07 Feb 2014 21:48:48 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50402) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBxyI-0002j8-6b for 16331@debbugs.gnu.org; Fri, 07 Feb 2014 21:48:46 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WBxy3-0003gZ-L5; Sat, 08 Feb 2014 03:48:32 +0100 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> Date: Fri, 07 Feb 2014 18:47:23 -0800 In-Reply-To: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> (Drew Adams's message of "Fri, 3 Jan 2014 09:18:28 -0800 (PST)") Message-ID: <87mwi2b9s4.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WBxy3-0003gZ-L5 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392432512.3543@W3UcioC80gdEqAFSs7BvhA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > The message "Trashing..." (which is unclear, BTW) or "Deleting..." > appears while the user is being asked whether to delete/trash. > > So the message is wrong: Emacs is not (yet) deleting files. > > A better message would be something like "Preparing to delete..." > > A message such as "Deleting..." can give the impression that the files > are already being deleted. If you have 50 marked files, you don't want > to see a message saying that they are being deleted before you have had > a chance to cancel deletion. As far as I can tell from reading the code, it's not saying "Deleting..." before it's deleting the messages. (Or trashing them.) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 22:18:24 2014 Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 03:18:24 +0000 Received: from localhost ([127.0.0.1]:55773 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByQx-0005ti-Vo for submit@debbugs.gnu.org; Fri, 07 Feb 2014 22:18:24 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:38843) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WByQv-0005tZ-7p for 16331@debbugs.gnu.org; Fri, 07 Feb 2014 22:18:22 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s183IJ9q009515 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 8 Feb 2014 03:18:20 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s183IJw2022834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Feb 2014 03:18:19 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s183IIlD022822; Sat, 8 Feb 2014 03:18:18 GMT MIME-Version: 1.0 Message-ID: <9d2961a4-ff90-4a14-8582-c5934adc5558@default> Date: Fri, 7 Feb 2014 19:18:17 -0800 (PST) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> In-Reply-To: <87mwi2b9s4.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > The message "Trashing..." (which is unclear, BTW) or "Deleting..." > > appears while the user is being asked whether to delete/trash. > > > > So the message is wrong: Emacs is not (yet) deleting files. > > > > A better message would be something like "Preparing to delete..." > > > > A message such as "Deleting..." can give the impression that the > > files are already being deleted. If you have 50 marked files, > > you don't want to see a message saying that they are being > > deleted before you have had a chance to cancel deletion. >=20 > As far as I can tell from reading the code, it's not saying > "Deleting..." before it's deleting the messages. (Or trashing > them.) I see the message when the pending-deletion file list is popped and you are asked for confirmation. Emacs is not deleting anything at that point. It does not start deleting the files until you confirm that you want to delete them. Whether the message appears at all depends on the timing done in `progress-reporter-do-update'. That is the code that shows the message. You may or may not see the message at all, depending on your context. From debbugs-submit-bounces@debbugs.gnu.org Fri Feb 07 22:34:08 2014 Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 03:34:09 +0000 Received: from localhost ([127.0.0.1]:55801 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBygC-0007UT-Hf for submit@debbugs.gnu.org; Fri, 07 Feb 2014 22:34:08 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:57169) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WBygA-0007UI-55 for 16331@debbugs.gnu.org; Fri, 07 Feb 2014 22:34:06 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WByfu-0004Gc-Sk; Sat, 08 Feb 2014 04:33:51 +0100 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> <9d2961a4-ff90-4a14-8582-c5934adc5558@default> Date: Fri, 07 Feb 2014 19:32:42 -0800 In-Reply-To: <9d2961a4-ff90-4a14-8582-c5934adc5558@default> (Drew Adams's message of "Fri, 7 Feb 2014 19:18:17 -0800 (PST)") Message-ID: <87y51m8ejp.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WByfu-0004Gc-Sk X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392435232.50755@nTWc9ekW4Fsq6jD+ZbhnmA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > I see the message when the pending-deletion file list is popped > and you are asked for confirmation. Emacs is not deleting > anything at that point. It does not start deleting the files > until you confirm that you want to delete them. > > Whether the message appears at all depends on the timing done > in `progress-reporter-do-update'. That is the code that shows > the message. You may or may not see the message at all, > depending on your context. I tried edebugging through the function. It asked me first whether to delete the files in question, and then it used the (progress-reporter (make-progress-reporter (if trashing "Trashing..." "Deleting...") succ count))) to display "Deleting... [33%]". But that was when it's actually deleting something. I can't see the progress reported being used before that, but I may be misreading the code. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 10:06:45 2014 Received: (at 16331) by debbugs.gnu.org; 8 Feb 2014 15:06:45 +0000 Received: from localhost ([127.0.0.1]:58031 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC9US-0008B6-4M for submit@debbugs.gnu.org; Sat, 08 Feb 2014 10:06:44 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48647) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WC9UO-0008Ax-Ng for 16331@debbugs.gnu.org; Sat, 08 Feb 2014 10:06:41 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s18F6a69029132 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 8 Feb 2014 15:06:37 GMT Received: from userz7022.oracle.com (userz7022.oracle.com [156.151.31.86]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s18F6ZX0017771 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 8 Feb 2014 15:06:36 GMT Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by userz7022.oracle.com (8.14.5+Sun/8.14.4) with ESMTP id s18F6Y98009841; Sat, 8 Feb 2014 15:06:34 GMT MIME-Version: 1.0 Message-ID: <839a6591-081d-4a2f-869c-26a4b73f2899@default> Date: Sat, 8 Feb 2014 07:06:33 -0800 (PST) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> <9d2961a4-ff90-4a14-8582-c5934adc5558@default> <87y51m8ejp.fsf@building.gnus.org> In-Reply-To: <87y51m8ejp.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > I tried edebugging through the function. It asked me first whether > to delete the files in question, and then it used the >=20 > =09 (progress-reporter > =09 (make-progress-reporter > =09 (if trashing "Trashing..." "Deleting...") > =09 succ count))) >=20 > to display "Deleting... [33%]". But that was when it's actually > deleting something. >=20 > I can't see the progress reported being used before that, but I may > be misreading the code. Yes, I believe you are. And apparently you are also mis-seeing what you see (not noticing the "Deleting..." message appear first). Not only do I see what I said, but this is what debug shows the progress reporter doing: Debugger entered--entering a function: * message("%s" "Deleting...") * progress-reporter-do-update((1 . [1391871442.1130002 0 5 "Deleting..." 1 0.2]) 0) * make-progress-reporter("Deleting..." 0 5) * (let* ((files (mapcar (function car) l)) ... And if you `M-x debug-on-entry RET dired-internal-do-flagged-delete' then you will see that it immediately calls `dired-internal-do-deletions'. `dired-internal-do-deletions' _first_, in its `let*'-form, calls `make-progress-reporter', which shows the message "Deleting...". Only _after_ that, in the `let*'-body, does it call `dired-mark-pop-up', which pops up the list of files and asks for confirmation. From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 21:17:39 2014 Received: (at 16331) by debbugs.gnu.org; 9 Feb 2014 02:17:39 +0000 Received: from localhost ([127.0.0.1]:58494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCJxi-0005IH-8r for submit@debbugs.gnu.org; Sat, 08 Feb 2014 21:17:38 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:37502) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCJxg-0005I7-9l for 16331@debbugs.gnu.org; Sat, 08 Feb 2014 21:17:36 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCJxS-0003kF-Ai; Sun, 09 Feb 2014 03:17:22 +0100 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> <9d2961a4-ff90-4a14-8582-c5934adc5558@default> <87y51m8ejp.fsf@building.gnus.org> <839a6591-081d-4a2f-869c-26a4b73f2899@default> Date: Sat, 08 Feb 2014 18:16:11 -0800 In-Reply-To: <839a6591-081d-4a2f-869c-26a4b73f2899@default> (Drew Adams's message of "Sat, 8 Feb 2014 07:06:33 -0800 (PST)") Message-ID: <87lhxlkp3o.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WCJxS-0003kF-Ai X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392517042.90509@lAq7VcWY1D3U9HdYzJlcNA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Drew Adams writes: > `dired-internal-do-deletions' _first_, in its `let*'-form, calls > `make-progress-reporter', which shows the message "Deleting...". > > Only _after_ that, in the `let*'-body, does it call `dired-mark-pop-up', > which pops up the list of files and asks for confirmation. Oh, I see. I didn't know that `make-progress-reporter' itself messaged. Then the solution seems to be to move that call closer to when it's actually deleting stuff. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sat Feb 08 21:20:57 2014 Received: (at control) by debbugs.gnu.org; 9 Feb 2014 02:20:57 +0000 Received: from localhost ([127.0.0.1]:58500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCK0u-0005NY-Dw for submit@debbugs.gnu.org; Sat, 08 Feb 2014 21:20:56 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:46479) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCK0s-0005NR-NZ for control@debbugs.gnu.org; Sat, 08 Feb 2014 21:20:55 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WCK0e-0003mI-P5 for control@debbugs.gnu.org; Sun, 09 Feb 2014 03:20:41 +0100 Date: Sat, 08 Feb 2014 18:19:30 -0800 Message-Id: <87k3d5koy5.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #16331 X-MailScanner-ID: 1WCK0e-0003mI-P5 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392517241.67451@J3N8eTuqi1AxrAVoOmH3hQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) close 16331 24.4 From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 19:39:16 2014 Received: (at 16331) by debbugs.gnu.org; 10 Feb 2014 00:39:16 +0000 Received: from localhost ([127.0.0.1]:32833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCeu4-0005nI-A4 for submit@debbugs.gnu.org; Sun, 09 Feb 2014 19:39:16 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:24385) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WCeu1-0005n7-7c for 16331@debbugs.gnu.org; Sun, 09 Feb 2014 19:39:14 -0500 Received: from ucsinet22.oracle.com (ucsinet22.oracle.com [156.151.31.94]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id s1A0dBcl018165 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 10 Feb 2014 00:39:12 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by ucsinet22.oracle.com (8.14.5+Sun/8.14.5) with ESMTP id s1A0dAJt010977 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 10 Feb 2014 00:39:11 GMT Received: from abhmp0005.oracle.com (abhmp0005.oracle.com [141.146.116.11]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id s1A0dArh003371; Mon, 10 Feb 2014 00:39:10 GMT MIME-Version: 1.0 Message-ID: <3e1e5a10-15fa-42ac-96e5-a2bff21be96f@default> Date: Sun, 9 Feb 2014 16:39:06 -0800 (PST) From: Drew Adams To: Lars Ingebrigtsen Subject: RE: bug#16331: 24.3.50; `dired-internal-do-deletions': "Deleting..." message References: <8a572886-e141-4cad-a9db-9acbc3daaa5f@default> <87mwi2b9s4.fsf@building.gnus.org> <9d2961a4-ff90-4a14-8582-c5934adc5558@default> <87y51m8ejp.fsf@building.gnus.org> <839a6591-081d-4a2f-869c-26a4b73f2899@default> <87lhxlkp3o.fsf@building.gnus.org> In-Reply-To: <87lhxlkp3o.fsf@building.gnus.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet22.oracle.com [156.151.31.94] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16331 Cc: 16331@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > `dired-internal-do-deletions' _first_, in its `let*'-form, calls > > `make-progress-reporter', which shows the message "Deleting...". > > > > Only _after_ that, in the `let*'-body, does it call `dired-mark- > > pop-up', which pops up the list of files and asks for confirmation. >=20 > Oh, I see. I didn't know that `make-progress-reporter' itself > messaged. Then the solution seems to be to move that call closer to > when it's actually deleting stuff. I guess so, but you would need to test that that in fact DTRT. I see that you closed the bug in the same breath. Is this fixed then? From unknown Sun Jun 22 17:10:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 10 Mar 2014 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator