GNU bug report logs - #16329
`head --lines=-0' prints nothing if no newline at the EOF

Previous Next

Package: coreutils;

Reported by: Алексей Шилин <rootlexx <at> mail.ru>

Date: Fri, 3 Jan 2014 16:31:01 UTC

Severity: normal

Merged with 16559, 16560, 16561

Done: Pádraig Brady <P <at> draigBrady.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Алексей Шилин <rootlexx <at> mail.ru>
To: 16329 <at> debbugs.gnu.org
Subject: bug#16329: Acknowledgement (`head --lines=-0' prints nothing if no newline at the EOF)
Date: Sat, 04 Jan 2014 00:40:27 +0400

[Message part 1 (text/plain, inline)]
Looks like I was overly cautious about decrementing an unsigned...

size_t n = bytes_read;
while (n)
  {
    if (all_lines)
      n -= n ? 1 : 0;        // ...here.
    else

As it is under `while (n)' statement, n is always true here, and thus the ternary operator, though makes no
harm, is needless, and the whole line can be replaced with just `n--;'. Sorry for that.

The fixed version of the original patch is attached.

-- 
Алексей Шилин

[head_nlines_fix2.patch (application/x-patch, attachment)]
This bug report was last modified 11 years and 118 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.